dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add tests for internal name conflicts in extension methods

Browse Source 
Change-Id: I7c2bed173f4d945ab83ab9157fcf650ddd4990ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112645
Reviewed-by: Bob Nystrom <rnystrom@google.com>
This commit is contained in:
Leaf Petersen
2019-08-14 02:24:44 +00:00
parent 6c46a93361
commit 76c99bcd01
2 changed files with 271 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/language_2/extension_methods/static_extension_internal_name_conflict_error_test.dart
+242
View File
@@ -0,0 +1,242 @@
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// SharedOptions=--enable-experiment=extension-methods
// Tests that errors are given for internal name conflicts in extension methods.
// It is an error to have duplicate type parameter names.
extension E1<T, T> on int {
// ^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
extension E2 on int {}
// It is an error to have duplicate extension names.
extension E2 on int {}
// ^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
class E2 {}
// ^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
typedef E2 = int Function(int);
// ^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
void E2(int x) {}
// ^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
int E2 = 3;
// ^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
////////////////////////////////////////////////////////////////////
// It is an error to have two static members with the same base name
// unless one is a setter and one is a getter.
//
// The next set of tests check various combinations of member name
// conflicts: first testing that members of the same kind (e.g.
// method/method) induce conflicts for the various combinations of
// static/instance; and then testing that members of different kind (e.g.
// method/getter) induce conflicts for the various combinations of
// static/instance.
////////////////////////////////////////////////////////////////////
// Check static members colliding with static members (of the same kind)
extension E3 on int {
static int method() => 0;
static int get property => 1;
static void set property(int value) {}
static int field = 3;
static int field2 = 4;
static int method() => 0;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
static int get property => 1;
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
static void set property(int value) {}
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
static int field = 3;
// ^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
static int get field2 => 1;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
static void set field2(int value) {}
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check instance members colliding with instance members (of the same kind).
extension E4 on int {
int method() => 0;
int get property => 1;
void set property(int value) {}
int method() => 0;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
int get property => 1;
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
void set property(int value) {}
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check static members colliding with static members (of the same kind).
extension E5 on int {
static int method() => 0;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static int get property => 1;
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static void set property(int value) {}
// ^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static int get property2 => 1;
// ^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static void set property3(int x) {}
// ^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static int field = 3;
// ^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
static int field2 = 3;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
int method() => 0;
int get property => 1;
void set property(int value) {}
void set property2(int value) {}
int get property3 => 1;
void set field(int value) {}
int get field2 => 1;
}
// Check a static method colliding with a static getter.
extension E6 on int {
static int method() => 0;
static int get method => 1;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check a static method colliding with a static setter.
extension E7 on int {
static int method() => 0;
static void set method(int value) {}
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check a static method colliding with a static field.
extension E8 on int {
static int method() => 0;
static int method = 3;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check an instance method colliding with an instance getter.
extension E9 on int {
int method() => 0;
int get method => 1;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check an instance method colliding with an instance setter.
extension E10 on int {
int method() => 0;
void set method(int value) {}
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.DUPLICATE_DEFINITION
// [cfe] unspecified
}
// Check a static method colliding with an instance getter.
extension E11 on int {
static int method() => 0;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
int get method => 1;
}
// Check a static method colliding with an instance setter.
extension E12 on int {
static int method() => 0;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
void set method(int value) {}
}
// Check an instance method colliding with a static getter.
extension E13 on int {
int method() => 0;
static int get method => 1;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
}
// Check an instance method colliding with a static setter.
extension E14 on int {
int method() => 0;
static void set method(int value) {}
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
}
// Check an instance method colliding with a static field.
extension E15 on int {
int method() => 0;
static int method = 3;
// ^^^^^^
// [analyzer] COMPILE_TIME_ERROR.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE
// [cfe] unspecified
}
void main() {}
tests/language_2/extension_methods/static_extension_setter_getter_assignability_error_test.dart
+29
View File
@@ -0,0 +1,29 @@
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// SharedOptions=--enable-experiment=extension-methods
// It is an error to have a setter and a getter in an extension where
// the argument type of the setter is not assignable to the return type
// of the getter
extension E1 on int {
static int get property => 1;
// ^^
// [analyzer] unspecified
// [cfe] unspecified
static void set property(String value) {}
// ^^
// [analyzer] unspecified
// [cfe] unspecified
int get property2 => 1;
// ^^
// [analyzer] unspecified
// [cfe] unspecified
void set property2(String x) {}
// ^^
// [analyzer] unspecified
// [cfe] unspecified
}
void main() {}