dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Kallen Tu b3df8aaa12 Change subtype checking with variance for assignments and methods. 
Change-Id: I2594c8749ee445a02e06f82c65cd34a62fc77a29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120744
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-10-11 19:44:05 +00:00
Aart Bik 9515301418 [vm/compiler] fix bug on need for check 
Rationale:
When the static class type does not match information found
in ICData, we require a check on a mismatch. However,
unused data should not be considered

https://github.com/dart-lang/sdk/issues/38741

Change-Id: If7717bfbce2f2a09014ce3e7cdcbf34816102b9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121141
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-10-11 16:45:52 +00:00
Kallen Tu 5098e90de5 Change subtype check for overrides to handle variance. 
Part of variance subtyping changes, variance handled in
overriden methods.

Change-Id: I23db9c9f8b91bb2ac5634a909da9cf47416f94cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120625
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-10 20:04:47 +00:00
Johnni Winther 72bae7be70 [cfe] Handle all bounds checks on extension methods. 
Closes #38755

Change-Id: I3d5449950ecb3268436a3033ae16bac590a1e4b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120790
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-09 19:50:02 +00:00
Martin Kustermann 55d1c95e08 [vm] Fix instruction deduplication for bare-AOT mode 
Though we disable deduplication for instance methods because switchable
calls rely on a unique PC -> Code mapping atm.

Change-Id: I80915e97f5e06c3f1251ea3176d5c4f8413a81ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120041
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-10-09 19:45:42 +00:00
Kallen Tu e3ca5ee6ba Check variance of type-parameter use in supertypes. 
Tests have both correct and erroneous implementations
of variance.

Change-Id: I49dd76f42399015dd6e3f9688e598c271ce7ab1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119722
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-08 21:33:40 +00:00
Leaf Petersen bb04f145b2 Update CFE expectations for extension method tests. 
Change-Id: I04662433cb031043714d5ad0a1050a5398b1cf95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120740
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-10-08 20:16:39 +00:00
Kallen Tu 9461df2084 Language tests for variance modifiers. 
These test basic correct usages of variance modifiers in fields
and methods.

Erroneous usages will come in a future CL, as well as more complex
examples + subclassing.


Change-Id: I05d547ac1db9e22235a0bf64b05fcb3e119e3157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119169
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-10-05 01:18:42 +00:00
Leaf Petersen 7486512634 Update CFE expectations for extension method tests. 
Change-Id: I673f5187d74cddfe2f2e54774a713713a137b081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120025
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-04 17:55:26 +00:00
Karl Klose 16bb96aa25 [infra] Remove non-essential test expectations with comments from general status files 
Change-Id: I8aa918b4065eaa9ae8e4501c6a77328659784f9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114848
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-10-01 06:18:59 +00:00
Ryan Macnak 8a5e2a688b [vm, compiler] Consistently produce OutOfMemoryErrors for large variable-length object allocations. 
Bug: https://github.com/dart-lang/sdk/issues/38575
Change-Id: I3f93488511519ac1dca04f91465efad3d2a0c66d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118886
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-09-30 20:19:03 +00:00
Aart Bik 5f32afdd4c [vm/compiler] patch up push arguments in environment 
Rationale:
My great friends PushArguments again! During OSR, the replacement
of a lost PushArgument (due to having this on the expression stack
while OSRing) must also be reflected in the environment. Why? This
is used for the stack depth bookkeeping. Note that I added some logic
for this less-than-obvious assumption in the flow graph checker to
make sure we don't fall into this trap again (currently only for
instance methods, since the IR is not clean for the others, that
is yet TBD). With regression test!

https://github.com/dart-lang/sdk/issues/38412
https://github.com/dart-lang/sdk/issues/38577
https://github.com/dart-lang/sdk/issues/38602

Change-Id: I8e4ff67e3e0926ff3ee6b6ac0af05f7ea0dc5ea1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118913
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-30 20:05:53 +00:00
Johnni Winther 05fb7d80dc [cfe] Update test expectations in static_extension_internal_name_conflict_error_test 
Change-Id: Iab47b7aa3a493f5aeeed9c58c6b7067ebcdcf068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119141
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-27 18:30:24 +00:00
Johnni Winther ee7aae43c0 [cfe] Handle explicit extension index access 
+ avoid implicit extension for [] or []= when the other is defined on
the receiver.

Change-Id: I99c76a66bfb4f72c396097b2f347aad9f0a42f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118940
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-26 10:36:51 +00:00
Kallen Tu c3bbd6a247 Added parser recovery for multiple variance modifiers. 
New error message for multiple variances and will handle recovery from
more than one variance modifier before a parameter.

Change-Id: I63ed8a7f04dd664e20d72b632b40f723aa43020f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118621
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-25 17:12:06 +00:00
Johnni Winther f2743fceee Fix language_2/extension_methods/basic_static_extension_test 
Change-Id: Idd586013ac8bf0a09209bce738f290c03df806b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118560
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-25 07:30:17 +00:00
Aart Bik 78bd9f17a1 [vm/compiler] keep stack depth per block in stack IR 
Rationale:
This simplifies finding the proper stack depth while
traversing the entries in the DOM tree during OSR.
Also enables asserting stack integrity on all paths
(OSR and non-OSR) more rigidly.

https://github.com/dart-lang/sdk/issues/38459
https://github.com/dart-lang/sdk/issues/38436
https://github.com/dart-lang/sdk/issues/38434

Change-Id: I3bc43def081013357e9a765e9e03fffe4c72dc6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118473
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-24 21:33:01 +00:00
Kallen Tu 89220fd812 Variance Parsing and Syntax Support 
With the experiment flag on, will properly parse the `in`/`out`/`inout`
keywords. Without it, will issue an error regarding the flag. First CL
for parsing, syntax support, no AST work yet.

Keywords only parse correctly for classes and mixins.
See test `variance_disabled_syntax_test.dart`.


Change-Id: I37d765804fa0752512abf52fa44456a173087ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117929
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-09-24 17:21:39 +00:00
Leaf Petersen c2e0f7ee06 Update analyzer expectations from undefined in two tests. 
Change-Id: I097c8ab98986d518e97169a159ceccd0fb7826a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118367
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-24 17:16:29 +00:00
Karl Klose 9203453183 [infra] Remove non-essential test expectations with comments from dart2js status files 
Change-Id: I55d13632e701f8c5627e418faaee71a09e48fe57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114851
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-09-24 06:44:11 +00:00
Leaf Petersen d53d355c6c Add subscript operator to extension method setter/getter tests. 
Change-Id: I09d97d291231eaf81b76c8156e1b3f25b7ab222e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118366
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-09-24 00:04:08 +00:00
Vijay Menon a6cc7b94c7 Reland "[dartdevc] fix for const / overridden fields" 
This reverts commit 43cacafb51.

Patchset 1 is the original CL.  Compare PS 1 to 4 to see additional fix.

It undoes an optimization that assumes private fields
are not overridden in the SDK.  This patterns happens in dart:ui
and would be difficult to enforce now that flutter web also adds to
the SDK.  As a result, all private SDK fields are virtualized, adding 0.7% to the size of
dart_sdk.js.

Fixes https://github.com/dart-lang/sdk/issues/38455

Change-Id: If969dddcb7143316ac8c771df1ed83def21412b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118362
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-09-23 21:31:49 +00:00
Vijay Menon 43cacafb51 Revert "[dartdevc] fix for const / overridden fields" 
This is breaking Flutter Web - see:

https://github.com/flutter/flutter/issues/40876

Will need to reopen: https://github.com/dart-lang/sdk/issues/38455

Change-Id: I6942cdc136533286c3a5eee93439d4f0f9beb28b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118261
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-09-20 20:09:08 +00:00
Lasse R.H. Nielsen 469863ded7 Fix bug in static extension member test. 
Change-Id: I525b1ce349b04ddc1aac83c57c2a58a976ae512a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118282
Auto-Submit: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-20 12:01:45 +00:00
Johnni Winther 70a1e8e090 [cfe] Fix handling of access on type variables with dynamic bound 
Change-Id: Ibff097e5f18bee169191b94633455547460debb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118280
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-20 10:48:14 +00:00
Aske Simon Christensen 6e4794a584 [kernel] Clone all co-defined type parameters before visiting them. 
Fixes https://github.com/dart-lang/sdk/issues/38384

Change-Id: I8292e91549c14e1ebac4ea4ab497ff16e6a8a81f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118047
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-19 15:19:06 +00:00
Kallen Tu 678f561ea6 Syntax tests for disabled variance flag. 
Change-Id: I796db1ce44b37e65bd4633abb962004a6e079041
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117288
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-09-18 16:13:53 +00:00
Johnni Winther 0c948521ca Update expectations in static_extesion_operators_test 
Change-Id: I9f4ebdc9488adb86106df4fe72234ece634924cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117722
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-09-18 13:34:46 +00:00
Vijay Menon ce6f40bccc [dartdevc] fix for const / overridden fields 
Fixes https://github.com/dart-lang/sdk/issues/37839

Change-Id: Ibe7b151e8e5fdd4d83cf5b69d49c7b3d17a1cefe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113136
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
 2019-09-18 13:19:05 +00:00
Mayank Patke 9385a879e5 Status file cleanup. 
Change-Id: Icd0ee8b790ca2f94a47190765f9d6d8da9e0039e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117216
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-16 23:32:56 +00:00
Mayank Patke 035c428b31 Delete language_2/config_import_test. 
Change-Id: I346b98a07379250342be889b023c6511543d83cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117215
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-16 22:40:51 +00:00
Mayank Patke 87ba885a45 Delete language_2/call_method_implicit_tear_off_implements_function_test. 
`implements Function` has no effect anymore, so this test is obsolete.
language_2/call_method_implicit_tear_off_test is basically the fixed
version of this test, so we can just delete this one.

Change-Id: I4b17130506bc6e590a7cb4ac19e9dd1feffa5c5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117240
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-16 18:49:29 +00:00
Mayank Patke a554c8be6b Fix language_2/flatten_test. 
Change-Id: I1cba1d84737d5b42d3d8670568e249de9790cfba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117064
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-13 01:05:24 +00:00
Aart Bik 95d7749f48 [vm/compiler] OSR on non-empty stack integrity 
Rationale:
Leaving a push argument on the stack in slightly more
complex flow graphs (try-catch, loop back, conditinals)
required a bit more bookkeeping. This CL also introduces
more integrity checks to make sure the stack is as
expected at each block and instruction.

Note:
Fuzzer is regression test for new feature.

https://github.com/dart-lang/sdk/issues/38231

Change-Id: I8f7e605937d76c1a429df601e69380111737dd94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116545
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-09-13 00:58:24 +00:00
Mayank Patke 9f778d69f4 Fix language_2/external_test. 
Change-Id: Ie54433c28619a4786ae0d67b1358cdbc91f8ffab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116890
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-12 23:51:57 +00:00
Kallen Tu 83930fdc75 Reformatted extension method tests. 
Removed unnecessary semicolon.

Change-Id: Ic5b2ff93b2a8904f377e14b19439a046d8fc2a1d

Reformat tests using dart_style.

Change-Id: I4d50f441fb7fa9d5d934ba6c9f3691ddd87a5cc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116551
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-09-12 17:39:46 +00:00
Kallen Tu 4331e7e5fa Fix bad tests setter_no_getter_test and syntax_test. 
Changed void test expectation to ok. Using void as such is now valid.

Change-Id: I2ea0208a182eb0f20eb9e1b79c938df899f96319

Change setter_no_getter_test to a static error test - compile-time error.

Change-Id: I232e4460397f88e4f9806adf73622903fd76d000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116825
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-09-12 17:16:08 +00:00
Mayank Patke 531cb02331 Fix language_2/mixin_constructor_forwarding/* tests. 
Change-Id: I9d6cf8236d3549a799ee2b499cafd4ad40f445a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116720
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-12 00:43:19 +00:00
Mayank Patke 24f45d64c7 Delete language_2/generic_no_such_method_dispatcher_simple_test. 
language_2/generic_no_such_method_dispatcher_test works after
https://dart-review.googlesource.com/c/sdk/+/115901, so we can delete this test
now.

Change-Id: Ifb0b32f9afb0d93de3db75f2293f60a1ce485c13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116751
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-12 00:41:39 +00:00
Mayank Patke d18bfb409f Fix language_2/super_call4_test. 
Change-Id: I1173d7121e7f557f93ec1f61341b627f141e6802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-11 22:26:29 +00:00
Konstantin Shcheglov 3d1712c822 Remove tests for unqualified identifiers from static_extension_getter_setter_conflicts_test 
R=brianwilkerson@google.com

Change-Id: I98f11b85ca480b6012e1286a707010ced4305571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 19:37:36 +00:00
Lasse R.H. Nielsen 4d5e15abde Fix broken static_extension_getter_setter_test. 
Change-Id: Ie8cfc07df8507862c1d534421a1bd9a60fac580c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116500
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-09-11 07:44:56 +00:00
Aart Bik 2305d9f3a6 [vm/compiler] Better be ready for OSR in field init 
Rationale:
OSR was happening in a field initializer, but the kernel
binary flow graph builder assumed this never happened.
With regression test.

https://github.com/dart-lang/sdk/issues/38248

Change-Id: I91243b4422cac76ec7ee2460d466bd0e1cf608ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116558
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-09-10 22:17:22 +00:00
Mayank Patke 81dc269a71 Status file cleanup. 
Change-Id: Ifeb56e7ec7319ec9834b1888f09f0726c1b5a6e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116486
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-10 21:26:46 +00:00
Mayank Patke 13fc090e85 Fix language_2/map_literal3_test/03. 
Change-Id: I2d3dd6857ce3c2a4594f53de71d03b42668731c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116487
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-10 20:17:27 +00:00
Konstantin Shcheglov fa099eb717 Look for both getter and setter in the hierarchy before looking for extension. 
Change-Id: I7080f5ffb307b9deb9bba453e1d1c1aa253b7cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 16:39:09 +00:00
Mayank Patke 78bf8f08b9 Fix language_2/deferred_load_library_wrong_args_test. 
Change-Id: I83f31b84a2128f01056bca21c2dce1b1dde57567
Bug: https://github.com/dart-lang/sdk/issues/38281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116480
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-10 02:10:38 +00:00
Mayank Patke b4724c1d78 Fix language_2/regress_23408_test. 
Change-Id: I9ab03ffd07738d6c936052d104e8d68716835815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116440
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-10 00:58:49 +00:00
Mayank Patke 601d8934f4 Fix issue31596 tests 
Change-Id: I02d56402aa09c1c9563929ab3792743b8fe7e97d
Bug: https://github.com/dart-lang/sdk/issues/31596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116085
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
 2019-09-09 23:16:03 +00:00
Mayank Patke 4e7b77e428 Fix language_2/super_bound_closure_test 
Change-Id: Ib297bfb5350d97a30c3a2f737d9c2dad75ef88ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116087
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-09-09 19:54:41 +00:00