dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Leaf Petersen 6d9c651fdd Fix typos in static_extension_internal_resolution tests. 
Fix #37791
Fix #37792

Change-Id: Id00f7e3eacb6c44ed1914ad0a5748bc800a80af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-08 22:11:00 +00:00
Nicholas Shahan 8c834efae9 [dartdevc] Skip all tests on DDC for extension methods 
We expect to turn down DDC in favor of DDK before shipping extension methods so
they will never be implemented.

Change-Id: I4f4ddfbf37ccec965d53b21eac9223e75b87d93c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112420
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-08-08 22:00:22 +00:00
Leaf Petersen d2048763d4 Add tests of internal extension method resolution. 
This adds tests verifying expected error and non-error cases for
resolution of symbols referenced from inside of the definition of an
extension method or a class, which have overlapping definitions in
various different scoping levels.

Change-Id: I753cc80c0dfdefb3e44429e8bb085c8af3ceb685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111882
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-08-07 23:20:56 +00:00
Leaf Petersen 7b46191f45 Remove incorrect super bounded test, and add tests for bounds 
violations in extension method applications.

Fix #37765

Change-Id: I26d286251b0e832577dc170b9a41594c52e25377
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112149
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-07 19:36:24 +00:00
Leaf Petersen 1aa98e5dc6 Fix incorrect getter names in basic_static_extension_test and 
static_extension_inference_test .

Fix #37763
Fix #37764

Change-Id: Ibf25b55ba9357c6b0de33e8c20af3f9e1f2e45d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2019-08-06 21:46:17 +00:00
Aart Bik 193985777d [vm/compiler] Propagate call type to load indexed 
Rationale:
AOT's TFA sometimes knows a bit more about the result
type of a call that is later recognized as an indexed
load. This CL preserves that type for later use, improving
decision on operations that consume this load.

https://github.com/dart-lang/sdk/issues/37719

Change-Id: I5f88e03b68b4f7aec6e39a8ca94f243c2796730d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112028
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-08-06 19:28:29 +00:00
Leaf Petersen 6f551f040b Fix a few extension method test bugs. 
Fixes https://github.com/dart-lang/sdk/issues/37749 .
Fixes https://github.com/dart-lang/sdk/issues/37748 .

Change-Id: I31f32964b33679e09d5a71ac39cc51343c0384d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112030
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2019-08-05 23:14:07 +00:00
Sam Rawlins 2bf13fd058 Add a language test for Object().runtimeType. 
Fixes #15917

Change-Id: I4dd00385ba84f4c65ec0c0e2a9b0a4f6748d1396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111963
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-05 17:27:57 +00:00
Stephen Adams 5456641022 More canonicalization_hashing tests 
These behave poorly on dart2js.

Change-Id: I15f73dce79912151e172038932dbedf5dd725530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110640
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-08-01 18:03:56 +00:00
Aart Bik 361d27e20b [dart/vm] Fix bug in parallel move/register allocator 
Rationale:
Another one bites the dust due to fuzzing! The attached
small reproducer assert failed in debug and crashed
in release due to "any" allocation in the parallel move.

https://github.com/dart-lang/sdk/issues/37633

Change-Id: Ie9044cb7fa86dfdb1ba312599f57db76bec47611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110540
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-07-30 20:42:05 +00:00
Teagan Strickland f822dfa3ea Reland "[vm/compiler] Implement new inlining pragmas." 
This change introduces two new pragmas:

* `@pragma('vm:never-inline')`
* `@pragma('vm:prefer-inline')`

These replaces the old way of specifying AlwaysInline or NeverInline
annotations when the (now removed) --enable-inlining-annotations flag
was used.

Bug: https://github.com/dart-lang/sdk/issues/36571
Change-Id: Iee152c1d67abde8d58c58fa967449d36e77c8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110440
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-07-30 12:01:06 +00:00
Mike Fairhurst 2f96be9ee3 [analyzer] Allow references of 'this' in late field initializers 
Change-Id: Ic464a1d8402404ca79f2281780bf3d408bbb948a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110550
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-29 20:23:03 +00:00
Brian Wilkerson 1d14f239b0 Fix one of the language tests 
The identifier `in` is a reserved word and hence cannot be used as a variable name.

Change-Id: I557430e1f87573d19bfb22d7c09120139baa3731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110581
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-26 17:59:43 +00:00
Nicholas Shahan 0ca1582afd Revert "[dartdevc] Temporarily skip const stress tests in DDK" 
This reverts commit 8fb4240bcb.

Reason for revert: Fix has been merged.
https://dart-review.googlesource.com/c/sdk/+/109640/16

Original change's description:
> [dartdevc] Temporarily skip const stress tests in DDK
> 
> Revert this change once fixes have landed for DDK.
> 
> Issue: #37523
> Change-Id: I2855c647ceb5b9831466d8da458e6e7bcd810ee9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110543
> Auto-Submit: Nicholas Shahan <nshahan@google.com>
> Commit-Queue: Nicholas Shahan <nshahan@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=vsm@google.com,nshahan@google.com

Change-Id: Iace2084460eb42b0ebe05f72b8511c16fc1b28a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Issue: #37523
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110600
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-25 23:50:46 +00:00
Mike Fairhurst db25ef8a9c Report unnecessary ! 
Change-Id: Ie5fbe1e7697c2911eb9ff931bcf5d2e1cef9d171
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108944
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-25 21:45:09 +00:00
Paul Berry 8b24e21980 Rename extension methods syntax test so that it actually runs. 
The test infrastructure only runs tests whose name ends in "_test.dart".

Change-Id: I42bde31cf49318b87c270b4df9cc71fd9b89999c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110460
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-25 20:23:10 +00:00
Nicholas Shahan 8fb4240bcb [dartdevc] Temporarily skip const stress tests in DDK 
Revert this change once fixes have landed for DDK.

Issue: #37523
Change-Id: I2855c647ceb5b9831466d8da458e6e7bcd810ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110543
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-25 19:01:37 +00:00
William Hesse f771a1f978 Skip deep constant nesting test on Windows dart2js. It crashes infrastructure. 
Bug: https://github.com/dart-lang/sdk/issues/37631

These tests cause the dart2js batch mode compiler process
to resist termination somehow on Windows, which locks the dart.exe executable
and prevents sharding task cleanup.

Change-Id: Ica19e9d262f0b5b97c263205ba6fac030a3bedb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110444
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-07-25 17:17:45 +00:00
Leaf Petersen b74ae33406 Fix various issues with a generic method test 
Fix various issues with language_2/generic_function_bounds_tests,

including:
  - Overly specific expectations on print formats of types
  - Outdated expectation of contra-variance for generic method bounds
Change-Id: I5135a743cc58773af144b2d9e6685667c9be7d41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109726
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-25 16:43:52 +00:00
Aart Bik 1ac0a36fcb [dart/vm] Fix division-by-zero bug in range analysis 
Rationale:
The attached test, a simplified version from a case found
by fuzzing, yielded the range [4,4] for the left hand side
of the division but [25,0] (sic!) for the right hand side.
This reverse range caused the logic in the TRUNC evaluation
to pass the >= 1 test but introduce the division by zero
in the compiler code. The true culprit, however, was
the reason for [25,0] which was due to a difference
in C++ and Dart shift right semantics. This CL fixes
the bug and adds some sanity assert to find more of
such cases.

https://github.com/dart-lang/sdk/issues/37622

Change-Id: I60e07428435d99589e1177c113ef5e24e1611d0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110420
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-07-25 00:00:39 +00:00
Leaf Petersen 9e4cf6af14 Add tests for static extension methods. 
Change-Id: I385db23248d266ae69882f7fb13f1a1e8d7ed5d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106908
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-24 21:55:02 +00:00
Konstantin Shcheglov 48662bdb94 Report not initialized potentially non-nullable instance fields. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id762e0cf651b2f2d7199f3447b5bf305b1a584c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107567
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-23 23:17:32 +00:00
Stephen Adams 262e4c4b09 Remove canonicalization_hashing entries from language_2_dart2js.status 
We only add new entries for Skip and Slow tests.

TBR=rmacnak@google.com

Change-Id: I83fe176ee6ff0e9624cf1092aed9a45f41b970d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110124
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-23 18:23:26 +00:00
Ryan Macnak 60a952e261 [vm] Avoid superlinear time canonicalizing deep constants. 
Bug: https://github.com/dart-lang/sdk/issues/37523
Change-Id: Ia3c2514891e2e3f07d1b3266b019b142413918d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109318
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-22 22:20:33 +00:00
Aart Bik ebc180be95 [dart/vm] Fix bug on missed exception in AOT 
Rationale:
The regression test in this CL should throw
with a NoSuchMethod on null. However, before
the fix, AOT did not throw at all.

https://github.com/dart-lang/sdk/issues/37408

Change-Id: I4037b163092caf78d313815624fd3b20c20f88ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109550
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-19 22:43:31 +00:00
Siva Annamalai 27001fb289 Revert "[vm/compiler] Implement new inlining pragmas." 
This reverts commit 629f38cf87.

Reason for revert: This CL seems to depend on constant_update_2018 flag being turned on by default. The CL that turns on constant_update_2018 has been reverted, so this CL is also being reverted.

Original change's description:
> [vm/compiler] Implement new inlining pragmas.
> 
> This change introduces two new pragmas:
> 
> * `@pragma('vm:never-inline')`
> * `@pragma('vm:prefer-inline')`
> 
> These replaces the old way of specifying AlwaysInline or NeverInline
> annotations when the (now removed) --enable-inlining-annotations flag
> was used.
> 
> Bug: https://github.com/dart-lang/sdk/issues/36571
> Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
> Commit-Queue: Teagan Strickland <sstrickl@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>

TBR=sjindel@google.com,sstrickl@google.com

Change-Id: Idc8e8344adb026a308af20c8b0d0224edb891d9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109320
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-07-16 22:33:00 +00:00
Teagan Strickland 629f38cf87 [vm/compiler] Implement new inlining pragmas. 
This change introduces two new pragmas:

* `@pragma('vm:never-inline')`
* `@pragma('vm:prefer-inline')`

These replaces the old way of specifying AlwaysInline or NeverInline
annotations when the (now removed) --enable-inlining-annotations flag
was used.

Bug: https://github.com/dart-lang/sdk/issues/36571
Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-07-16 09:41:12 +00:00
Stephen Adams fab9b9f71f [gardening] Move language_2/conditional_rewrite_test 
Change-Id: I878230e5ed311d5d51b15c48c9fb5dca447e0ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108905
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-15 22:04:16 +00:00
Stephen Adams e4eea58ac9 [gardening] Update language_2/constructor12_test for strong checking 
Change-Id: I1f0f121af9d22ccb2345c8da9070d352ade742f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108907
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-12 14:46:13 +00:00
Lasse R.H. Nielsen e7fab5eacc Fix bugs in >>> test now that it has been implemented. 
Change-Id: Iafdf3e56a3e69b4d945799c541795e1fd6901178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108806
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-12 12:57:14 +00:00
Stephen Adams 7cadd70696 Fix language_2/ct_const_test 
Change-Id: Iebb3e40b8835ae5f24afe7ae31117ff24c18aa5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108370
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-11 20:51:04 +00:00
Mike Fairhurst 3c3dc09d47 Test that ! on void is a compile time error 
Change-Id: Ia2a43dca23df6d332bd5baa63af7cb68c94ac612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108762
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 18:48:53 +00:00
Stephen Adams d1bd3a2f43 [gardening] Fix language_2/generic_instanceof2_test 
Change-Id: Ida4afe8488a6c58ebfedde901ae293465a320714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108741
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-11 18:40:48 +00:00
Mike Fairhurst e95b1f7bf0 Make UNNECESSARY_NULL_AWARE_CALL a warning 
Change-Id: I0cbe9522dcddb4c664ae5679e521191d0c91d777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-07-11 17:59:58 +00:00
Stephen Adams ed764e5688 [gardening] Delete legacy parser_quirks_test 
This is a test of keep-on-truckin' behaviour that is now a static
error.

Should we delete it?

Change-Id: Ia8702f46d8d343941ed002f42e0a217485e53fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108761
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-11 17:45:48 +00:00
Nicholas Shahan 25bac04503 [tests] Delete temporary const tests 
These tests acted as a guard to make sure we didn't unintentionally enable control flow and spread
in const collections when we initially shipped the features. Now that we are getting close to
enabling them for const they no longer valid.

Added a few more compile-time errors to the const spread error suite.

Change-Id: I52e215d4c1c4394f1a1b868c05241277b0d58d2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108680
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-07-11 16:29:28 +00:00
Lasse R.H. Nielsen ac41a20081 Update language_2/nested_generic_closure_test.dart. 
No longer depends on the unspecified `Type.toString`.

Bug: http://dartbug.com/37452
Change-Id: Ie7eeeecdc8970831082e763edc46f195a8bfc7e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108275
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-07-10 09:46:41 +00:00
Mike Fairhurst 449b799c21 Test that null cannot be used because its potentially nullable 
Change-Id: I344157c31225f92f1a8a931b9ffe23feebcb15de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102500
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-07-09 22:05:15 +00:00
Vyacheslav Egorov 5479175012 Remove incorrect test. 
Symbol constructor can't be used to create symbols for private names.

Closes https://github.com/dart-lang/sdk/issues/34377
Closes https://github.com/dart-lang/sdk/issues/30848
https://github.com/dart-lang/sdk/issues/36433
https://github.com/dart-lang/sdk/issues/34904

Change-Id: Ibe551c43a9209e1f483cea8178665890d52799aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108416
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-07-09 17:32:29 +00:00
Lasse R.H. Nielsen aee65636ba Add constructors to Stream which creates single data or error event streams. 
Change-Id: I3f570b15d29601a488dc634ab3cc563783868ac2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108102
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-08 13:38:54 +00:00
Stephen Adams f0d6f119de Make nested_generic_closure_test work for dart2js 
Change-Id: I07fa89b184cd542ebd028dbf70279ee6d64cd1cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107834
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-05 21:05:07 +00:00
Stephen Adams 0272c1d863 Split language_2/truncdiv_test 
Move zero case out to increase coverage of non-zero cases.

Change-Id: Iaa3a1dbe1fc952bcccb16dca2f6543a9d367d61c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107826
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Auto-Submit: Stephen Adams <sra@google.com>
 2019-07-04 07:58:05 +00:00
Stephen Adams 738d9f9666 Avoid non-web integer literal in language2/list_test 
Change-Id: I926dc7b9e9eabd098c4561ea95e1e3568522902f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107922
Commit-Queue: Stephen Adams <sra@google.com>
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-07-04 01:01:26 +00:00
Konstantin Shcheglov 2ea7e5513b Perform type promotion when NNBD, using flow analysis. 
Mostly just implementing existing interface LocalVariableTypeProvider,
and moving type promotion tests into a separate file.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If864cb2c300f01a152f40c51cffa7f17028ad200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-03 20:33:08 +00:00
Stephen Adams 1f02c10b9a Update language_2/const_map4_test for type inference 
Change-Id: Id81d974b0889e7c469ed40c85955f9b18265c634
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107927
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-07-02 19:23:18 +00:00
Stephen Adams 822de210b5 fix branch_canonicalization_test 
Change-Id: Icd26e9edf3dbf513c614743a97c696ed88df00db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107570
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-07-02 06:15:02 +00:00
Lorenz Nickel 79e478e50e Fixed some links 
**I fixed some links and some other minor flaws.**

I also found the following outdated links, which I didn't fix:

- [This link](https://github.com/dart-lang/pool/tree/zone.strong) in [this file](https://github.com/dart-lang/sdk/blob/master/docs/newsletter/20170728.md) (didn't fix because don't know new location and this is some sort of archive so the link should probably stay the original)
- [This link](https://www.dartlang.org/tools/analyzer) in [this file](https://github.com/dart-lang/sdk/blob/master/pkg/analyzer_cli/lib/src/options.dart) (didn't fix since the link is still working, it just gets redirected and the link is part of the programm, I don't want to break anything by changing it, all other links are in comments)
- [This link](https://github.com/domokit/mojo/issues/728) in [this file](https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn) (didn't fix since probably has no new location and is part of TODO, which I don't want to change)

While doing all this I also noticed that [these tests](https://github.com/dart-lang/sdk/tree/master/tests/compiler/dart2js_extra) contain a lot of other inconsistencies in their comments and the location of the import-statements (I only fixed one which was not link-related), could be target of another PR.

Closes #36927
https://github.com/dart-lang/sdk/pull/36927

GitOrigin-RevId: 71d05d0b52d8ec5b92d077a070e066d1fdd4bbfa
Change-Id: Ide4b2424fccad8ae2e06c788efd4443dc0de997b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102222
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-07-01 16:21:41 +00:00
Stephen Adams 000cf0560c clean up type_literal_test 
TBR=leafp@google.com

Change-Id: Id8eebf4893103b187e981ccaf6c671ccdf659824
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107690
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-06-29 14:44:21 +00:00
Stephen Adams 0f20911022 Improve type_literal_test 
- Fix expectations for dart2js generic function types
- Split out Type canonicalization tests
- Do some partial checking for dart2js minification

Change-Id: Ifb6e38c1138311baf1a9852286e208c59aaa03fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107686
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-06-29 06:36:36 +00:00
Robert Nystrom 13b470ac46 Parse error expectations in tests. 
They don't do anything yet, but the syntax is supported and tested.

Change-Id: I67e3c72babd8e272b28b434dfb0cf6028f472676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107568
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-06-29 00:54:11 +00:00