75bc44734f
Fix comments of previous commit.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200793006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33802 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 12:54:20 +00:00
23aea27441
Prefix io part uri's with 'dart:io/'.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17083
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//203073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33799 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 11:29:06 +00:00
2493b45413
Make http-imports faster to load, by hinting persistent connection on request.
...
Also avoids a BytesBuilder, if only one chunk is received. This speeds
up e.g. 'pub build' notably (4x speedup).
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//203213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33798 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 08:57:00 +00:00
7fbb7cd5dc
Rework library and class view pages.
...
Add expression evaluation support for libraries and classes.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//199363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33755 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:43:07 +00:00
5790e70744
Visualize heap fragmentation in Observatory.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//197923005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33754 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:16:53 +00:00
0c157cd31e
Move signal_blocker to platform and use it by default in TEMP_FAILURE_RETRY.
...
BUG=http://code.google.com/p/dart/issues/detail?id=16927
R=johnmccutchan@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//165723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33745 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:51:11 +00:00
09a4f24413
Add exitCode getter counterpart to the existing setter in dart:io.
...
BUG=https://code.google.com/p/dart/issues/detail?id=16217
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33737 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 10:40:19 +00:00
f99c83e54a
Show object pool on code page
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//197853005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33702 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 17:03:38 +00:00
0c885fde33
Use mutex around getaddrinfo on windows, as it's not thread-safe.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17237
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33690 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 10:25:16 +00:00
6ea46abd34
Create a shadow table to track CodeRegions of reused code address space.
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//197803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33665 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 21:00:44 +00:00
3b29063492
Don't act on return-token commands on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//199063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33653 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 15:23:08 +00:00
9a71498127
Make the event-handler handle backpreasure.
...
We now limit the number of active events per fd to 8.
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org//198743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33649 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 12:02:47 +00:00
a08b282ee8
Use a sync-writing StreamConsumer for stdout/stderr.
...
This makes stdout.write and stderr.write block, until the write is done.
BUG=https://code.google.com/p/dart/issues/detail?id=17020
R=whesse@google.com
Review URL: https://codereview.chromium.org//195893012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33645 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 11:20:34 +00:00
9b25d2f09b
Make service-view programmatically switch views
...
This has the side effect of fixing most of the Polymer exceptions when switching views.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//195763005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33630 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 23:32:19 +00:00
6ceb9ad3ce
Correct capacity reporting for new space; show external size in Observatory.
...
Before, the reported capacity included *both* semi-spaces, which seems wrong.
Also exclude external size from capacity, to be consistent with old space and
the comment on Heap::CapacityInWords.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//196603009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33625 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 23:12:48 +00:00
a73703b08a
Improve the instance-view page in observatory.
...
Add an eval-box element which is used to evaluate expressions.
Support expression evaluation for instances in the vm service.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//194623006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33592 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 17:18:14 +00:00
453361e443
Code view tweaks and crasher fix
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//194503006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33548 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 19:27:52 +00:00
6edd276df8
Switch Observatory to use only ServiceObject instances.
...
All fetched objects are upgraded to a ServiceObject.
ServiceObjectCache.
Uniform updating / refreshing.
Fix UTF8 string escaping in TextBuffer (should fix invalid character bug https://code.google.com/p/dart/issues/detail?id=16590 )
R=turnidge@google.com
Review URL: https://codereview.chromium.org//192443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33541 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 17:48:09 +00:00
9609621c4f
Fix type error in implementation of dart:io Directory.existsSync.
...
Add checked-in binary for mips architecture to tools/testing.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//190723008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33483 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 12:00:36 +00:00
a69d028eb3
Track external allocated memory for weak persistent handles.
...
The amount of external allocation is tracked per generation
and informs GC policy.
BUG=dart:11471
R=asiva@google.com
Review URL: https://codereview.chromium.org//187113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33467 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:32 +00:00
058510ebd0
Handle collected objects and expired handles more gracefully.
...
Prints <collected> or <expired>.
Added tooltips to explain these to users.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//177473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33386 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 17:38:16 +00:00
97fe225e63
Display sample count and refresh time.
...
Fix some uninitialized variables.
Don't send disassembly by default.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//185563013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33380 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 16:48:49 +00:00
1e3e88769f
Socket I/O statistics for Observatory
...
This is the first part of adding I/O statistics to the observatory.
R=ajohnsen@google.com , johnmccutchan@google.com
Review URL: https://codereview.chromium.org//163903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33366 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 11:12:08 +00:00
b688a44e7f
Fix Dartium Observatory
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//187923009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33356 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 23:35:31 +00:00
6ee2ccc7dd
Refactor Observatory
...
Introduce a VM class responsible for communicating with a VM and the isolates collection
Add two new base elements: IsolateElement and VMElement which are peered to an isolate or VM respectively.
Remove request manager (functionally replaced by VM)
Remove isolate manager (functionally replaced by VM)
Link creation and network requests delegated through Isolate class.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//184233007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33347 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 21:59:48 +00:00
7bf90e6205
Remove broken flags --all and --tests.
...
BUG=dart:17257
R=iposva@google.com
Review URL: https://codereview.chromium.org//187853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33343 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 21:06:45 +00:00
b86941da52
Remove faulty function return type in builtin.dart
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//183803021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33322 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 09:26:15 +00:00
905e20ffd1
Add new <curly-block> element.
...
This is an expandable curly-brace block.
- Show pointer cursor when over link instead of text input.
- Make the link easier to click with inline-block,  .
- Show a busy cursor and hide the link when an expand is pending.
- Use boxed +/- for expand/contract icons. (We can change these later).
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//182413007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33297 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:26:30 +00:00
9d11ac7a94
Update the navbar in the observatory
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//185413015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33292 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 19:10:52 +00:00
e380b175f8
Pass in the isolate parameter to the weak persistent callback handler so that
...
there is no need to access the current isolate in the callback and delete
path (this code is run while a GC is in progress).
See https://codereview.chromium.org/185643003/ for corresponding changes
in dartium
R=iposva@google.com
Review URL: https://codereview.chromium.org//186003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33282 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 18:11:19 +00:00
1ab4461654
Refactor native extension shared library lookup.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//186473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33275 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 14:39:12 +00:00
ce266f9435
Merge all http-outgoing transfomers into _HttpOutgoing, including simpler(better) buffering.
...
This speeds up the system by:
- Using a simpler buffering mechanism, where we fill up a 8kb buffer, pass it on, and allocating a new.
- Avoiding up to 4 streams for each stream added to the http-outgoing. We now only create one extra stream.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//185543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33272 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 13:58:46 +00:00
9d3f2b4ce9
Handle NUL bytes in builtin print.
...
BUG=dart:16761
R=asiva@google.com
Review URL: https://codereview.chromium.org//186103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33247 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 21:21:06 +00:00
fc5af7b7b4
Add InternetAddress:rawAddress, to return the raw address as a list of bytes.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17137
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//180163005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33235 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 18:33:56 +00:00
0f79171efb
Add user resetable accumulator to allocation profiler.
...
Display aggregate of new and old space in a separate table.
Speed up display of tables by 10x.
Fix heap display bug (heap stats were always for new space).
Keep sort across refreshes.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//173013004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33220 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 15:39:06 +00:00
36ba03fd0c
Use signal-block around fork() to avoid we block it.
...
This issue is seen on a single-core VM.
BUG=https://code.google.com/p/dart/issues/detail?id=17217
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//176933006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33219 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 15:38:22 +00:00
c1ea75d3c5
Fix typo in r33216
...
BUG=
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//184823007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33217 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 15:04:04 +00:00
32b2fd3cf1
Change handling of dart-ext: URIs for native extensions.
...
With this change, a dart-ext: URI is now an opaque URI consisting of
the scheme dart-ext: followed by an actual URI, either relative, or
with a scheme like file:, http:, or package:. Existing users are mostly
or all using relative URIs, so this change should not affect them.
This is a step toward allowing native extensions in packages to be served
over http, and also cleans up the code, and would help a future change
that replaces "dart-ext:" with metadata or an annotation.
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//180783008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33216 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 14:51:44 +00:00
3f135836fe
Use actual length of dictionary, and not size of a pointer, in zlib.
...
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org//185773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33213 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 13:12:23 +00:00
a22e98f539
[ZLIB] Add support for windowBits, memLevel, raw
...
BUG=159367
**BC breaks:**
All public (API) classes that used to be const are not const any more. This allow checking the validity of input parameters in the constructor body.
- ZLibCodec,
- GZipCodec,
- ZLibEncoder,
- ZLibDecoder
The globals codecs GZIP and ZLIB are now final we should be ok (the class contain only final properties, ie no state).
What should be done:
(- finer grained exceptions, -> later change)
(- Handle the flush modes but probably in an other patch as the updates might be more complex.)
Done:
Patch Set #1
- add some more docs,
- support for memLevel.
Patch Set #2 :
- implement dictionaries (todo: fix mem management),
- integrate review feedback,
- fix CC,
- rebased on master
Patch Set #4 :
- support for strategy,
- add some checks (ie checking the level, memLevel, ...) this could imply adding a constructor body (Codecs, Coders) but this would force making the const non const and break BC, thoughts ?
- Add ZLIB constants Dart side.
- Refactor the tests and test only some levels rather all which was unit testing rather more than the extension. It saves some test time.
Patch Set #8 :
- fix mem management for dictionaries,
R=ajohnsen@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//130513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33206 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 11:43:09 +00:00
1481635fca
Don't report hasTerminal, if term-size is (0,0).
...
BUG=http://code.google.com/p/dart/issues/detail?id=17070
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//177863010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33202 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 10:17:04 +00:00
e9e54f6af6
Cleanup native, collected, and stub code handling in profiler
...
R=iposva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//182703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33177 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 22:55:53 +00:00
983c99305c
Remove rum_vm_tests.host target.
...
It should not be needed to compile it. If one wants to test the host,
one should compile with toolchains; 'target' == 'host'.
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org//179423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33150 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 08:55:04 +00:00
ab402c8190
Code regions now have list of callers and callees.
...
Address ticks track exclusive / inclusive separately.
Code regions only receive one inclusive tick per sample regardless of how many times they appear in the sample's stack trace.
Provide useful name for most stub functions.
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//168833005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33036 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 21:41:57 +00:00
8c96505b32
Add hide/show for stack frame variables.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//172913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33031 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 19:08:24 +00:00
c32aa7737c
Make run_vm_tests on host depend on libdart_io again.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//179713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33012 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 11:40:05 +00:00
b052d69661
Don't depend on libdart_io in run_vm_tests and gen_snapshot.
...
This fixes an issue where we would compile the eventhandler and
file-system-watcher for the host toolchain.
BUG=https://code.google.com/p/dart/issues/detail?id=17002
R=iposva@google.com
Review URL: https://codereview.chromium.org//169753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33010 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 09:59:18 +00:00
a5d145b1ca
Remove non-fatal prints from windows eventhandler.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//177803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32964 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 14:31:39 +00:00
aaa07ed2d5
Define EPOLLRDHUP in eventhandler_android if missing.
...
BUG=http://code.google.com/p/dart/issues/detail?id=17038
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//177753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32963 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 14:29:54 +00:00
e87d3883b9
Fix error-checking when calling timerfd_create.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17051
R=kasperl@google.com
Review URL: https://codereview.chromium.org//177643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32960 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 12:45:16 +00:00
ajohnsen@google.com