8f41c24471
Make server-sockets level triggered.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//234843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35302 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 06:05:46 +00:00
1e72c0f6c4
Disable applyAuthorStyles
...
This allows us to remove the dependency on bootstrap.css (removal of bootstrap.css from third_party will happen in follow up CL).
As a side effect of this, the following changes have occurred:
- Removed Google Charts Table from allocation profile pane.
- Add a SortedTable view-model (used in allocation profile).
- Changes to CPU profile tree view.
- Consolidate string formatting utility functions.
There is some UI regression (font size is one size too small) that will have to be addressed in follow up CLs.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//237683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35266 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 16:01:14 +00:00
fffd6da770
Use AI_ADDRCONFIG on Windows as well.
...
BUG=http://code.google.com/p/dart/issues/detail?id=16742
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//246843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35251 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 10:46:47 +00:00
ea84b80f47
Add class id to debugger stack trace
...
Add the class id of the origin class of each activation frame’s function.
Top-level functions have no class id. The wire protocol for an activation
frame now looks like this:
CallFrame = “{“ functionName “:” String “,”
[ location “:” Location “,” ]
[ classId “:” Integer “,” ]
locals “:” NamedObjList “}“
R=devoncarew@google.com
Review URL: https://codereview.chromium.org//242453011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35232 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 23:16:41 +00:00
c3a88f02c0
Register existing isolates when service isolate is started
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//242493007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35227 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 22:16:34 +00:00
fdaf1b59bf
Undo r35207
...
Review URL: https://codereview.chromium.org//243583008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35208 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 16:03:52 +00:00
1606fce42f
Add TraceBuffer log to all Functions (plus small tweaks to function-view)
...
BUG=
R=srdjan@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//227423005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35207 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 15:57:09 +00:00
94f53d4d2b
Fix *ServerSocket's handling of zones.
...
A stream's zone is the one it has when listening to. Use that, and not
the one active when creating the socket.
BUG=https://code.google.com/p/dart/issues/detail?id=17468
R=floitsch@google.com
Review URL: https://codereview.chromium.org//239613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35071 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 18:44:14 +00:00
febba444a4
Fix heap report bug and add checked mode display to VM page
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//233523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35060 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 14:16:15 +00:00
82f487f92f
Fix File:copy FD leak, and add file-closes to some tests.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//233053004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34961 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 07:48:49 +00:00
ef666553a1
Add runtime and native entry tags
...
- Split runtime and native entry tags.
- Set runtime / native entry address as vm tag in stubs.
- Add reverse native entry resolver (pc to name) to public API (breaking change).
- Hookup reverse resolver for standalone VM (io + bootstrap + builtin natives).
- Runtime entries are registered with tags.
- Profiler queries for tag names via the reverse native entry resolver.
- Profiler outputs named entry tags as children under parent tag (runtime or native).
R=asiva@google.com
Review URL: https://codereview.chromium.org//227433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34941 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 20:26:45 +00:00
090e15d537
Do not try to move lines around after test!
...
- Fix typo in field name.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//233313005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34935 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 17:58:47 +00:00
9adfe60489
- Apply review comments from https://codereview.chromium.org/232223004/
...
- Use isWindows where appropriate.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//233093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34934 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 17:49:31 +00:00
5aa521fa7b
Report the correct error, when recursive delete fails on Windows.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//227913007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34933 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 17:13:02 +00:00
566ec5d5b9
- Do not keep the environment alive past the process spawn.
...
- Avoid creation of many temp objects while creating the process
environment.
- "if (identical(true, value))" makes no sense.
R=asiva@google.com
Review URL: https://codereview.chromium.org//232223004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34907 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 00:15:47 +00:00
431761e878
Miscellaneous Observatory UI improvements
...
Update cursor over expander in profiler
Ressurect json-view
Show arrow in profiler tree
Clicking on <code-ref> link in profiler doesn't expand tree
<code-ref> only shows a link for Dart code
Port script-view to use script-inset
Add function source to function view
Add counters to isolate view
Add counters to isolate summary
R=turnidge@google.com
Review URL: https://codereview.chromium.org//221263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34661 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 18:30:01 +00:00
2fe51715e5
Begins work on ARM64, first assembler test.
...
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}
The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.
R=regis@google.com
Review URL: https://codereview.chromium.org//221133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
ab19ef4f31
Redo allocationprofile options
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//217323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34620 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 22:05:39 +00:00
cc82321046
Add <eval-link> - a custom element for evaluating an expression.
...
Use <eval-link> to add a convenience toString() link for instances.
In the future I plan to use <eval-link> to provide easy access to getters.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//213853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34616 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 20:18:17 +00:00
b373e6c423
Change how we provide value previews in the vm service.
...
Rename the 'preview' property to 'valueAsString'.
Rework printing so that we only add 'valueAsString' when we need it
(num, String, etc.).
Change ToUserCString to be a String-only method. Drop ToUserCString
for lists -- it was hokey and unused. Max string length is now 1024
instead of 40.
Update tests.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//219333011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34612 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 19:45:57 +00:00
59fcec073c
Don't make the signal-pipe non-blocking.
...
This is an attempt to make it run on MIPS. The non-blocking is not
needed here.
BUG=https://code.google.com/p/dart/issues/detail?id=17826
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//220863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34594 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 12:15:21 +00:00
45d35b1588
Make non-copying version of BytesBuidler and make file-reads faster.
...
The non-copying version is internally, as this is always the behaviour
we want, when receiving data from the system.
File-reads are also further improved, by only reading data in chunks, if
initial length is 0. This is a special case where the file can be a
character device. Overall improvement is around a factor of 6.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//218493012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34589 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 10:56:19 +00:00
e78cc1544d
- Make ports be less predictable.
...
- Limit the range of port numbers to 30-bits.
- Parse the ports as 64-bit values when reading from the wire in the debugger protocol.
R=hausner@google.com
Review URL: https://codereview.chromium.org//217693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34542 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 23:39:36 +00:00
9b814028a3
Minor fix in isolate-view.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//217473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34530 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:09:53 +00:00
3e86631f02
Use tokenPos instead of line/col in the vm service.
...
Add line number information to the Script response.
Parse line number information in the observatory.
Update <script-ref> to take a pos argument
Add a new <script-inset> element which shows a code snippet.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//216883008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34528 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 21:24:24 +00:00
3adcbe1071
Rework the <field-view> page.
...
Give fields/functions a consistent notion of ownership.
Add field's script to the JSON.
Make page reload work again.
Fixup closure printing a bit.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//215213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34520 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 20:21:09 +00:00
99fca31c02
Support Types in instance-ref/instance-view.
...
Refactor JSON printing for all instances to share more code. This allows Types to act like Instances in Observatory.
Update the look and feel for the function-view page.
Add script info for functions.
Update tests.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//211283004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34435 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:13:03 +00:00
862687a1ad
Don't use ThreadSignalBlocker in mac eventhandler.
...
Turns out kevent can modify the current sigmask.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//212193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34408 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 06:21:38 +00:00
182fcd0921
Add isolate tag-profile model and UI.
...
Distinction between a Dart Error and a ServiceError/ServiceException.
Better Observatory behaviour when a ServiceError/ServiceExceptions occurs.
Display isolate's sticky error.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//205713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34377 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 18:09:02 +00:00
644e1f50aa
Fix mac part of previous commit.
...
BUG=
Review URL: https://codereview.chromium.org//207553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34362 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 14:20:45 +00:00
1a8f76beb3
Only return eventhandler tokens in stacks of 8, to avoid runtime calls.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//208653012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34359 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 13:44:01 +00:00
4f613457d6
Speed up GetRandomBytes by only entering signal-blocking scope once.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//209333014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34356 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 13:06:37 +00:00
ffdca5647a
Fix PrintToJSONStream for oddball functions
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//196173022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34338 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:58:45 +00:00
23d06d9db0
Rework how ServiceObjects are created and cached in Observatory.
...
We now use a single cache, rather than per-type caches which simplifies the get() logic and makes it easier to add more model-types in the future.
Rework how isolates are created/stored/retrieved. IsolateList is gone.
Add canCache and immutable to ServiceObjects and use them to inform when an object should be cached or reloaded.
Remove cache.dart, service.dart.
Add a notion of a ServiceObjectOwner.
Cleanups.
Etc.
Etc.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//204983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34333 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:42:26 +00:00
f79179cbdb
Be sure we to read all bytes requested, in GetRandomBytes.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17723
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//209983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34305 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 13:40:29 +00:00
f13a5b700f
Allow built in Observatory to work on any port
...
https://code.google.com/p/dart/issues/detail?id=17537
R=turnidge@google.com
Review URL: https://codereview.chromium.org//208243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34267 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 20:06:24 +00:00
8516b12799
Switch to using pub build instead of custom build_.dart script
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//199633007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34263 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 18:24:07 +00:00
3529ba0a7e
Modify secure_socket.cc to use new NSS memio api.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//207413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34236 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:25:36 +00:00
bfe05a3ca8
Update NSS to NSS 3.16 RTM
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//201853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34235 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:17:08 +00:00
d302dc431a
Auto delete persistent weak handles during finalization after invoking the callback associated with the weak handle.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//205153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34208 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 21:45:43 +00:00
9c5c7040dc
Add a VM page to the observatory.
...
Make the VM a ServiceObject. Some refactoring in the ServiceObject
implementation.
IsolateList is no longer a ServiceObject. It should eventually become more like our caches.
Support the /vm request in the vm. Remove isolate list request.
Improvements to Isolate::PrintToJSONStream: always provide a
reasonable name. Use the same code to produce isolate refs and
non-refs.
Improve isolate status message when the isolate is paused at
start/exit. Add a resume link to the isolate view.
Add a navbar to the error page so that dartium users are less likely
to get stuck.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//206213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34204 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 21:00:10 +00:00
9a8671276b
Add class and address information to heap map; display on hover.
...
Display a string like "String @ 0xe97c3328" while hovering over the map.
Also add page separators (black).
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//204103009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34195 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 18:56:45 +00:00
e93dd02838
Support doubles in observatory.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//199443008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34190 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 18:17:16 +00:00
9079108be8
Remove previous debug printing.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//206333005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34175 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 15:34:03 +00:00
0244fa2a77
Add debug-printing to file, and remove from test.
...
Adding the debug print made the test stop failing.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//206263005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34168 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 14:24:20 +00:00
4cf3726fe6
Close(destroy) Socket on user-generated write error.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//204343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34109 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 09:23:17 +00:00
8d5461c2e7
Regenerate Observatory js
...
Review URL: https://codereview.chromium.org//204013004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34075 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:35:59 +00:00
6952f5ddfe
Use VM tag in profile and add stack trace trie
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//201213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34064 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 21:20:41 +00:00
157bc5719c
Move all service objects to one file ahead of refactor.
...
Review URL: https://codereview.chromium.org//203243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34051 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 19:14:26 +00:00
e9eb700bfa
Implement isolate view page.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//197873028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33812 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 16:24:00 +00:00
ajohnsen@google.com