00f01663f3
Add dart:io view to the observatory.
...
The dart:io view contains HttpServerList and HttpServer for now.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//286903010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36559 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 10:09:54 +00:00
2516c34023
Fix bin.gypi and all the bots!
...
BUG=
Review URL: https://codereview.chromium.org//288983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36545 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 07:22:00 +00:00
dc7d4ce90a
Upgrade Observatory to Polymer 0.10.x
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//299823004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36544 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 07:10:12 +00:00
61bde80790
Retaining path in Observatory.
...
Add retaining_path instance command to VM service, exposed in the Observatory
with a [find] eval-link in instance view. By default shows up to 10 elements,
possibly followed by [find more] which doubles the number of elements shown.
Change RetainingPath to include the object itself.
Always include an id in Object::PrintJSONImpl, to avoid instance-ref crashing on
internal objects.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//292663012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36516 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 17:31:47 +00:00
6e6ead2faf
Fix crash when no package root argument is specified. (Issue 18935).
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//293983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36438 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 16:46:19 +00:00
968fb8ee31
Add missing files.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//293013008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36420 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 11:27:47 +00:00
198b11bd9b
Add IO service object handler, with initial implementation for HTTP server.
...
This is tempoary disabling the Socket service handler.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//284313011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36417 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 11:12:49 +00:00
78f3f14635
Add pause/resume for isolates in vmservice/observatory.
...
Improve the isolate view and isolate summary.
Details:
- Rig DbgMsgQueueList so it can run even when the debugger hasn't started.
- Add <action-link> element for pause/resume actions.
- Introduce new flex-percentile css classes.
- Add <isolate-run-state>, <isolate-location>, <isolate-shared-summary>, and <isolate-counter-chart> elements. Counters are now displayed as a pie chart instead of as text.
- Reorg <isolate-view> and <isolate-summary> substantially.
- Add shared style sheet to <script-view>.
- Combine pause-on-start/pause-on-exit with other debugger pause events and present a consistent representation for these in the vm service. Reorg how pause events are shown in <isolate-run-state>.
- Give the user a nicer message when an isolate is still loading.
- Move the /resume command to /debug/resume. Implement this with a bool in the Isolate class which is used to smuggle resume requests from the vm service to the dart embedding api.
- Add the /debug/pause command to the vm service
- Break the DebuggerEvent struct out into its own top-level class. Add JSON printing.
etc.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//271153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36366 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 17:09:08 +00:00
a0682663e0
Fix Android build warnings
...
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org//287933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36183 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 18:32:11 +00:00
525291c698
Remove default value for argument (was missing from previous commit)
...
BUG=
Review URL: https://codereview.chromium.org//281133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36160 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 12:02:29 +00:00
6906b3ba5f
Fix listening for multiple signals.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18793
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//285023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36153 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 09:36:03 +00:00
12c56b29c7
Eliminate unused url mapping parameter in dartutils
...
Change the LibraryTagHandler used in unit tests to match
the real tag handler better, eliminating special treatment
of url canonicalization. This required changing the library
url of tests so tests don’t get loaded using dart scheme urls,
since builtin.dart doesn’t handle dart: urls.
R=iposva@google.com
Review URL: https://codereview.chromium.org//270503007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35987 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-09 18:25:41 +00:00
9b385ee2d2
Add trace_service_pause_events flag and paused at exit tracing
...
R=keertip@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//271893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35944 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 22:02:38 +00:00
13efa12329
Clean up recursive deletion on windows.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//276593005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35900 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 10:31:33 +00:00
30f6999668
Don't try to send messages, when the port is not set.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18402
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//273833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35898 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 10:28:31 +00:00
7256650645
- Change when the library being loaded is registered. Now
...
we register it before calling the tag handler so that the
VM can keep track of which libraries have outstanding
requests.
R=hausner@google.com
Review URL: https://codereview.chromium.org//267353005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35870 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 21:46:05 +00:00
3a1defc2c8
Potential workaround for JSON decode errors
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//274603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35852 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 16:26:50 +00:00
ead1047e0a
Show new and old space separately in allocation profile
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//269813011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35824 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 20:07:24 +00:00
9ceffffb39
Display an informative message when we hit the JSON decode bug.
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//265853011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35820 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 19:28:07 +00:00
c7a15b7c2b
Add support for cloning server-sockets.
...
BUG=
R=lrn@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//250513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35818 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 19:09:44 +00:00
bee90bf298
Suppress some polymer runtime warnings.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//261853011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35808 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 16:47:01 +00:00
6e3d6bbd78
Small cleanup to Code and Profiler
...
- Profiler doesn't show expander when node has no children.
- Code name is not prefixed with * on VM side.
- <code-ref> prefixes code name with * if referenced code is optimized.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//266043004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35807 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 16:37:08 +00:00
47890400ac
Observatory grab-bag for 1.4 release.
...
- Make nav bar stick to the top
- Classes, functions, libraries are not immutable
- Expand some short lists by default
- Use uri to make a name for unnamed libraries
- Add Library class
- Fix z-index for navbar relative to heap map status pane
- Make NetworkError look nicer
- Dispatch known instance types to <instance-view>
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//262303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35785 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 04:04:10 +00:00
66369faf9c
Class view: Retained size of all instances.
...
Uses eval-link to compute retained size on request.
Does not round to MB or other human-friendly units.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//266323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35773 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 22:10:35 +00:00
1c3a41ad13
Retained size for instance in Observatory.
...
Add objects/$id/retained message that uses ObjectGraph to compute retained size for an instance.
In the instance view, the user can request the size to be calculated.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//263803009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35757 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 19:41:12 +00:00
c5527ac2aa
Various vmservice/observatory fixes:
...
- get rid of double lines on vm view page
- show eval errors in monospace font
- make eval highlight color consistent
- fix broken navbar on script view page
- show list of all libs for an isolate
- use two-column view to save space on isolate view page
- give the dart:nativewrappers library a name
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//262823012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35745 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 16:54:59 +00:00
3e1058fdfd
Clean up windows eventhandler.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//265273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35737 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 11:08:03 +00:00
82d1382faa
Fix crash in raw_secure_server_socket_test.
...
We had a scenario where read&write events were requested after the socket was closed, leading to a use-after-free.
This also fixes a scenario where we didn't delete client sockets, when accepted sockets are ignored when closing a listening socket.
BUG=https://code.google.com/p/dart/issues/detail?id=18610
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//269003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35732 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 09:17:26 +00:00
f5b0a17b19
Use ConnectEx on Windows, to do async connect of sockets.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18154
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//264613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35622 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 10:48:43 +00:00
deccfaf042
Make Socket::connect try all addresses given.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//259353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35619 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 08:42:57 +00:00
7d9d46dc4b
Remove the getaddrinfo mutex, but put mutex around winsock initialization.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//269623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35617 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 08:32:51 +00:00
03429c2ee6
Allow internal usage of SIGQUIT signal listening.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//262463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35616 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 08:01:09 +00:00
19244f5dac
Don't use AI_V4MAPPED.
...
AI_V4MAPPED only effects when we are restricted to IPv6. That can only
happen if the user requests _only_ IPv6. Thus, don't map IPv4 addrs into
IPv6.
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org//257243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35538 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 19:40:49 +00:00
b8668cd8bc
Revert to using second-precision on file timestamps on Android.
...
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org//254043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35535 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 18:32:02 +00:00
9243ffc4ff
Always use the same json for null in the vm service.
...
PrintToJSONStream -> PrintJSON.
ALSO:
Fix <em> tags in the Observatory.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//257053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35532 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 18:10:02 +00:00
bc35c1752e
Display PC descriptors with disassembling in Observatory
...
Couple other fixes:
- Fix path to shared css
- Fix crash when printing null AbstractType.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//251043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35529 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 16:40:42 +00:00
84bc2d6409
Remove accidental code.
...
BUG=
Review URL: https://codereview.chromium.org//257063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35521 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 11:49:20 +00:00
3265fb5d09
Make FileStat have millisecond precisions, for linux, mac and android.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18442
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//252123005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35520 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 11:38:50 +00:00
2151658634
Use accept and not accept4.
...
BUG=https://code.google.com/p/dart/issues/detail?id=18446
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//257153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35515 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 07:40:05 +00:00
47d03a04a0
Adds AI_ADDRCONFIG back to address lookup on Android.
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//257613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35425 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 14:45:34 +00:00
ca58691974
Mark pipe as close-on-exec.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//251403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35354 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 07:34:07 +00:00
df14081452
Make opendir test for EINTR again and make NO_RETRY_EXPECTED check in release mode.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//253413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35352 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 06:38:16 +00:00
e1ec7a2c5f
- Update status file to mark crashing test while investigating.
...
- Remove unused fields from socket code.
R=asiva@google.com
Review URL: https://codereview.chromium.org//257433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35346 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 00:37:55 +00:00
37baacb116
Small fixes for Android.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//254383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35342 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 23:20:24 +00:00
3f40651e3a
Support evaluation of expressions in context of a stack frame
...
This change adds a debugger API function to evaluate an expression
in the context of a particular stack frame. The expression can
refer to local variables accessible in the frame, but it cannot
alter the variables.
R=regis@google.com
Review URL: https://codereview.chromium.org//249533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35340 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 22:56:23 +00:00
fd8565b071
- Add a minimal implementation of Capability.
...
- Make RawReceivePort and SendPort VM internal objects.
- Rationalize the creation of ports and their handling within the VM.
R=asiva@google.com
Review URL: https://codereview.chromium.org//243973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:44:03 +00:00
f394f4b7dc
Object size on heap map hover.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//247713006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35324 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:41:08 +00:00
a36796b587
Connect heap map to instance view.
...
Clicking anywhere on the heap map sends an 'address' message to look up the object spanning the corresponding address.
Also fix issue with free list elements (which cannot be wrapped in handles).
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//249553003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35315 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 17:00:01 +00:00
ebd8317290
Extract common code, add host IP to --debug and --enable-vm-service options
...
R=hausner@google.com , johnmccutchan@google.com
Review URL: https://codereview.chromium.org//239303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35312 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 13:09:10 +00:00
ab53006509
Fix recursive directory deletion, to not leak file descriptors (and pointers).
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//249233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35310 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 12:09:12 +00:00
ajohnsen@google.com