dddc13ae1f
Fix quotes to satisfy build bot.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//451653003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38988 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 15:00:56 +00:00
66eecefc43
Remove prematurely added test.
...
TBR=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//452483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38986 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 13:32:17 +00:00
e2546942c3
Move service library test into observatory package.
...
This depends on https://codereview.chromium.org/434883002/
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//445023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38985 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 13:24:55 +00:00
7ea3f05253
Clean up socket:connect change.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//441903003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38918 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 05:10:44 +00:00
e803f27641
Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript.
...
BUG=http://dartbug.com/13460
R=hausner@google.com
Review URL: https://codereview.chromium.org//429013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38801 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 21:25:23 +00:00
4258c115b4
Handle load errors in deferred code
...
IO errors on the URL of a deferred library are forwarded to the Future
that handles the deferred load. Syntax errors and finalization errors
are lethal, killing the isolate.
Review URL: https://codereview.chromium.org//419103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38800 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 21:09:33 +00:00
57a043903c
Remove stray debug output.
...
R=koda@google.com
Review URL: https://codereview.chromium.org//426993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38682 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 17:33:21 +00:00
d3e183b91a
Be sure we don't delete a ClientSocket, until 'connect' is completed.
...
BUG=
Review URL: https://codereview.chromium.org//426923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38671 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 13:40:51 +00:00
1984326985
In Socket:connect, start connecting to next address, after 250 (25 for loopback).
...
BUG=https://code.google.com/p/dart/issues/detail?id=19871
R=whesse@google.com
Review URL: https://codereview.chromium.org//429543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38662 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 11:26:49 +00:00
343ee141f2
Don't print errors to stderr in socket_*.
...
BUG=https://code.google.com/p/dart/issues/detail?id=20070
R=ricow@google.com
Review URL: https://codereview.chromium.org//426833004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38660 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 07:13:58 +00:00
1efe114f05
Enable using the service library from dart:io applications.
...
Handle WebSocket differences between dart:html and dart:io.
Create simple command-line shell as an example.
This will enable standalone unit tests that use the service library.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//428613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38655 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 00:44:28 +00:00
7595f9e69e
Add breakpoints and single-stepping to Observatory.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//381383010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38654 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 23:08:47 +00:00
f560436366
Fix two other issues, with my previous commit.
...
BUG=
Review URL: https://codereview.chromium.org//425733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38619 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 13:12:22 +00:00
d56b11bf59
Compute absolute script path at isolate startup.
...
BUG=https://code.google.com/p/dart/issues/detail?id=20119
R=whesse@google.com
Review URL: https://codereview.chromium.org//423843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38616 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 12:31:29 +00:00
d481c8b61c
Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSocket.bind'.
...
Note that I have not been able to reproduce the error, thus no test is added for this case.
BUG=http://code.google.com/p/dart/issues/detail?id=19815
R=whesse@google.com
Review URL: https://codereview.chromium.org//426613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38606 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 11:36:35 +00:00
bba79810d5
Fix for the load error that is happening with dart_no_snapshot.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//411793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38519 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 20:31:23 +00:00
28c8553cb6
- Fix a lot of warnings generated by -Wshorten-64-to-32
...
when compiling for ia32 on Mac.
R=vegorov@google.com
Review URL: https://codereview.chromium.org//415513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38499 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 14:10:13 +00:00
e921f8c416
Fix dartium build break.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//407073005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38479 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-22 22:45:38 +00:00
97b903c665
Fix for issue 19817
...
- do not try to finalize classes on every Dart API call which could
potentially result in calls to dart code
- Invoke Dart_FinalizeLoading after all loads are done to ensure that
classes are finalized
R=hausner@google.com
Review URL: https://codereview.chromium.org//411633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38471 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-22 20:08:15 +00:00
a8195aeb5c
Change the Dart API call Dart_FInalizeLoading to accept an additional argument
...
which makes completion of deferred library futures optional.
R=hausner@google.com
Review URL: https://codereview.chromium.org//407143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38463 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-22 16:56:14 +00:00
a97bafab93
vm/observatory: Clean up script access
...
Addresses issues from https://codereview.chromium.org/346003003/
BUG=
R=hausner@google.com , johnmccutchan@google.com
Review URL: https://codereview.chromium.org//392933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38264 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 22:55:19 +00:00
e0d40e8d3b
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//376333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38165 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 18:39:09 +00:00
207292adb1
Report stack overflow to debugger after stack is unwound
...
Notify the debugger of stack overflow errors after the stack has
been unwound. No location information is sent with the pause event.
R=devoncarew@google.com
Review URL: https://codereview.chromium.org//382653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38125 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 17:44:33 +00:00
4544fe683b
Observatory: Promote function to ServiceObject
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//376293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38105 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 21:32:09 +00:00
b430288791
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//379223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38099 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 20:05:58 +00:00
0add94dd7e
Improve script display in the observatory.
...
- <script-inset> now supports scrolling
- <script-inset> can now highlight and scroll to the current line
- 'args' (#pos=55) are now passed to Panes (and some ObservatoryElements).
- <script-view> now scrolls to the current line.
- coverage data (red/green) is now shown as the background of the line #.
Saves space. Reworked the colors a bit to make black text visible.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//378113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38092 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 17:37:35 +00:00
92277cd0e6
Minor cleanup in use of intptr_t vs int
...
Fixes remaining issues from issue 19812.
Review URL: https://codereview.chromium.org//371123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38067 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-08 17:14:52 +00:00
8e4610a96c
Fix debugging module(replace int with intptr_t) so it works on Windows x64.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//369023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37996 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 23:25:58 +00:00
f7e931bb7d
observatory: add class view based on end token position
...
vm: add method to compute end token positions
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//361743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37964 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:22:50 +00:00
655b16b2d6
Include parent field/list index in retaining path.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//350403005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37956 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 20:37:56 +00:00
37903fc1b5
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//359833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37922 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 23:06:04 +00:00
adb4d1c185
[WIP]
...
Allow Observatory to run as a hosted web service
- Add vm-connect pane for connecting to a different VM.
- Can connect with Dartium VMs
- Can connect with content_shell VMs.
- Can connect with standalone VMs.
- Remember previously connected to standalone VMs.
- Auto refresh list available Dartium VMs.
- Provide simple server to tunnel Dartium / Content shell Chrome Remote Debugging Protocol requests.
- Improved WebSocket VM.
- Removed support for HTTP VM.
- Add support for polling updates to ObservatoryElement.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//335463008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37910 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 21:53:31 +00:00
f849afc751
Add support for asynchronous event notification to the observatory.
...
Implement "isolate pause" notifications.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//340443006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37841 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-30 22:46:27 +00:00
a2d7a425c9
- Remove Dart_ReceivePortGetId, Dart_GetReceivePort and Dart_PostMessage.
...
- Change _EventHandler._sendData to use a sendport object instead of a
receiveport object.
R=iposva@google.com
Review URL: https://codereview.chromium.org//359673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37827 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-30 17:46:26 +00:00
19c1502e11
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//348043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37801 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-27 23:06:29 +00:00
58933a1006
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//357763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37794 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-27 18:12:34 +00:00
9b8828d91c
BUG=
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//352063006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37755 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 20:07:52 +00:00
5fab97a6e7
Display average time between collections
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//353003005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37749 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 19:53:29 +00:00
bdab04234a
Class view: list all/sample instances on request.
...
The returned list can be filtered, etc., using its eval box.
Change VM code to only get reachable instances, using ObjectGraph.
BUG=dart:
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//351703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37661 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 16:14:37 +00:00
dc9f902fb1
Fix code coverage (again!)
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//346763007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37617 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 21:05:15 +00:00
d3c0913a3d
Make retained size human-readable.
...
BUG=dart:19444
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//350573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37614 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 19:47:07 +00:00
bd979f84d5
Send allocation stats with each class and show in class view.
...
For each class, if there are any allocations, shows current number of instances, shallow size, and the already existing link for retained size.
Also refactor code in ClassTable to reduce duplication.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//345543003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37566 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 20:17:42 +00:00
9aeb79505a
Fix Observatory code coverage
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//345113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37555 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 16:06:30 +00:00
857304304f
Do not add '-p' and 'c' options to VM options, the VM flag processing
...
functionality only accepts flags with the '--' prefix. It silently
ignores all following options if an invalid option is specified.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//348653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37517 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:00:50 +00:00
452545ddcd
Visual refresh of allocation profile page
...
- Redo layout of page.
- Show human readable strings for used, free, and external memory for each space.
- Track time of last forced GC/accumulator reset in isolate and display them in allocation profile page.
- Track allocation statistics on Class object itself.
- Make isolate's heap reporting use heap's PrintToJSON.
- Manually insert allocation profile table rows into dom (removes usage of template repeat).
- Add some timing information to allocation profile page update (to help diagnose slow downs).
Other changes:
- Upgrade to Polymer 0.11-dev (finally ends erroneous console spam).
- Replace enteredView/leftView with attached/detached (polymer change).
- Add <link> tag to polymer.html for each element (polymer change).
- Move <script> tag outside of element (uniformity, clarity).
- Remove unused collapsible-content element.
R=koda@google.com
Review URL: https://codereview.chromium.org//342513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37456 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 17:39:37 +00:00
6cc8cbc53b
Adding embedder API function Dart_FinalizeLoading
...
Embedder must call Dart_FinalizeLoading when all outstanding
load requests are satisfied, to complete the deferred loading
futures.
R=asiva@google.com
Review URL: https://codereview.chromium.org//341543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37423 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 21:05:30 +00:00
1833604ae6
Show pid on Observatory VM page
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//331323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37415 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 20:15:49 +00:00
c3211b9608
Avoid calling anything related to signals on Windows
...
BUG=
Review URL: https://codereview.chromium.org//339193003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37402 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 15:58:05 +00:00
7a761048f3
Wrap signal listening with try catch to fix Windows
...
BUG=
Review URL: https://codereview.chromium.org//343433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37398 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:46:47 +00:00
164a3500ef
SIGQUIT toggles VM service HTTP server
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//237113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37396 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:26:38 +00:00
koda@google.com