46043093af
Move js library back into compiler directory.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//538513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39870 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 13:49:30 +00:00
b01818d7be
Don't use async loading in gen_snapshot.
...
This fixes the dartium builds.
BUG=
Review URL: https://codereview.chromium.org//543623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39855 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 09:42:22 +00:00
a1f884b9b7
Mark observatory tests as failing on the analyzer
...
Filed issue 20805
Review URL: https://codereview.chromium.org//537853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39850 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 07:48:24 +00:00
e8946947aa
Fix handling of Windows paths after cleanup.
...
BUG=
Review URL: https://codereview.chromium.org//539863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39849 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 07:03:04 +00:00
ad4d4af975
Reuse HttpClient in the built-in resource loader.
...
BUG=
Review URL: https://codereview.chromium.org//539473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39848 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 06:53:41 +00:00
8c633a390e
Cleanup resource loading of the VM.
...
There is not only one path for loading resources, and it's async.
BUG=
Review URL: https://codereview.chromium.org//529203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39847 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 06:42:01 +00:00
117f18b8a4
Teach the Observatory about Contexts. Factor out object graph information from the instance view.
...
Address various issues with mismatched tags and type errors.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//532063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39845 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 00:27:49 +00:00
ec1140b188
Adds support for building arm64 Android.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//539573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39844 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 23:31:51 +00:00
0f0b5d00e5
Reapply "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref."
...
Update inbound_references_test
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//524433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39758 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 17:47:14 +00:00
da871c0b45
Allow observatory to distinguish between user-level and vm-level types.
...
Currently the 'type' property always encodes a vm-specific type. In
the future 'type' will specify a user-level (Dart-ish) type and
'vmType' will (optionally) specify a vm-specific type if it is
different. This will allow an application like a debugger (for
example) to ignore the specifics of the vm-internal Instance hierarchy
while still providing this information for applications like
Observatory, which want to know everything.
So, in this change, we prepare Observatory to receive both 'type' and
'vmType' properties.
Specifics:
- replace 'serviceType' on ServiceObject with 'type' and 'vmType'.
- replace uses of serviceType with type or vmType as appropriate.
- fix a couple of stray bugs I found ('user_name', etc.)
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//515303005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39705 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-29 17:17:43 +00:00
62a0ab203b
Revert "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref."
...
Review URL: https://codereview.chromium.org//511413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39686 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 23:05:11 +00:00
b418a04289
Give instances their own model class; move DartErrors out of instance-ref into their own error-ref.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//509563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39682 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 21:56:20 +00:00
40dd4b7607
Fix type in vm_metrics_test
...
BUG=
Review URL: https://codereview.chromium.org//520443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39681 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 21:52:15 +00:00
47060ce13e
Initial UI for Metrics in Observatory
...
- s/href/_href to silence new polymer warnings.
- Add fixed pollers that metrics can be registered with.
- UI to control sample buffer size
- UI to control refresh rate
- UI to see registered counters
R=koda@google.com
Review URL: https://codereview.chromium.org//457803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39679 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 21:16:51 +00:00
8a3c490f6b
Add a new Sentinel type for sentinel responses. (They are not Null).
...
Fix some stray problems.
Silence warnings about stray GC events.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//514833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39663 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 16:52:01 +00:00
2396c11a3c
Treat null like the object it is in the Observatory and Service.
...
BUG=http://dartbug.com/20649
R=turnidge@google.com
Review URL: https://codereview.chromium.org//501583007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39616 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 19:36:29 +00:00
beebba4624
More service api cleanup.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//488233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39609 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 17:13:31 +00:00
2d4250d852
Defer execution of the main isolate's entry point until the message loop.
...
This allows us to know more accurately the stack limit while running main.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//503363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39558 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-26 17:21:20 +00:00
bd4263bff2
Incoming references service request and UI.
...
Misses references from stack frames and embedder handles.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//483103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39534 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 22:31:45 +00:00
912741174f
Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view.
...
Fix spelling of superclass and subclass. Remove redudant null check in JSONifying classes.
BUG=http://dartbug.com/20554
R=johnmccutchan@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//500093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39532 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 21:31:58 +00:00
4d5f3ba638
vmservice protocol cleanup
...
user_name -> name
name -> vmName
Also, vmName is now only provided when it differs from name.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//487023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39525 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 18:53:43 +00:00
c48496b873
Refactor isolate startup code in preparation for making isolate spawning more truly non-blocking.
...
Instead of passing a startup message to the new isolate, pass all
necessary information in to _startIsolate directly. The new isolate
sends its control port and capabilities back to the parent.
R=iposva@google.com
Review URL: https://codereview.chromium.org//456983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39423 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 19:57:09 +00:00
015211b474
Track per-class promotion stats.
...
This will be useful for allocation policy and heap growth policy.
Also include these stats in the VM service.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//487973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39415 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 17:57:12 +00:00
5d5deec4e6
Optional binary payloads in VM service events.
...
Allow an event to send a binary blob in addition to its JSON message.
For testing, add _Echo event type that is triggered by an _echo/event request.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//474633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39332 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 15:35:03 +00:00
3299ed4a81
- Add VMMetric and some sample metrics
...
- Per isolate:
* heap.old.used
* heap.old.capacity
* heap.old.external
* heap.new.used
* heap.new.capacity
* heap.new.external
- VM:
* vm.isolate.count
- New metrics service namespace: /metrics/vm/...
R=koda@google.com
Review URL: https://codereview.chromium.org//464953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39305 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 17:35:00 +00:00
1fdd5af122
Update path to Observatory in HACKING.txt
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//474083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39273 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 22:42:52 +00:00
2a15350ce5
- Fix Windows standalone build again.
...
Review URL: https://codereview.chromium.org//473783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39239 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 05:13:55 +00:00
e57e60c300
Fix Windows Dartium build:
...
- Cannot access dart::bin::* from Dartium build.
Review URL: https://codereview.chromium.org//473763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39238 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 05:00:37 +00:00
5a383e7add
- Make sure that the threads for dart::bin are in the correct namespace.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//471743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39233 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 00:06:04 +00:00
cc2b9ab0c4
Use function names as service IDs, rather than indices.
...
This gives more descriptive ids and removes dependency on implementation details of Class.
Special kinds of functions still use indices and oddballs still fall back to the object ring.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//466183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39217 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 19:59:15 +00:00
13f2772897
Remove unintentionally added symlink.
...
BUG=dart:20489
Review URL: https://codereview.chromium.org//468263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39209 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 17:40:24 +00:00
5ca1d8a984
Skip Observatory tests on dart2dart.
...
BUG=dart:20487
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//468143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39205 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 16:57:04 +00:00
ef0247b0b0
Mark vmservice/observatory/test/allocations_test as failing on dart2dart
...
Filed issue 20487 to track this
Review URL: https://codereview.chromium.org//465243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39189 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 06:24:19 +00:00
58cf8abfd3
- MutexLocker needed by eventhandler_win.cc.
...
Review URL: https://codereview.chromium.org//467953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39181 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 00:08:50 +00:00
4884b3124c
- More missing headers on Windows.
...
Review URL: https://codereview.chromium.org//463373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39180 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 00:03:46 +00:00
22851d18da
- Fix vm/thread.h and bin/thread.h confusion.
...
Review URL: https://codereview.chromium.org//465133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39179 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 23:55:23 +00:00
ea4e984b66
- Do not use platform/thread.h
...
Review URL: https://codereview.chromium.org//462353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39177 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 23:43:45 +00:00
14ecdbd66a
- Separate the thread implementation used in bin/ and vm/
...
to allow us to make VM specific changes.
R=asiva@google.com
Review URL: https://codereview.chromium.org//463993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39172 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 23:19:53 +00:00
b03ea55ba3
Attempt to fix build bot by including Dart VM flags when invoking testee.
...
R=johnmccutchan@google.com
TBR=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//464873004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39154 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:28:05 +00:00
48e8e8dd1e
Even easier observatory testing.
...
Tester/testee code in single file.
Less boilerplate: shared setup and future chaining.
Also supports concurrent testee (see gc_test).
Simplify all exisiting tests to use new style.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//460523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39151 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 17:55:21 +00:00
265da3c18d
Adding missing dependencies for dart executable on OSX
...
The dart build target was picking these dependencies up via nss.gyp:nspr, but when IO is not enabled then it hits a link error on some CoreFoundation APIs.
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//465683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39113 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 23:31:55 +00:00
7f03df2239
Exclude *all* observatory unit tests from browser.
...
For now, they are all expected to use dart:io.
Review URL: https://codereview.chromium.org//459453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39053 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 21:32:36 +00:00
5a3ac3215b
Port metrics test to new framework.
...
Also extend it to actually check the values, rather than just types.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//453943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39049 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 20:59:24 +00:00
101c2ad4fa
Update testing instructions in HACKING.txt.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//452933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39044 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 17:37:01 +00:00
dc65a5b72f
Don't run observatory tests on the browser, they are using dart:io
...
Review URL: https://codereview.chromium.org//455673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39025 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 08:45:46 +00:00
418a550d1c
Add package links for the observatory and enable testing
...
This will make them run on the vm bots, not the pkg bots (I can move them if need be by changing the exclude filter, but I assume you want full vm coverage for this? )
Review URL: https://codereview.chromium.org//455693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39021 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 07:47:44 +00:00
6312736130
Add a new event family for GC-related events, and generate an event after each garbage collection with basic stats.
...
One reason for this is to provide a structured alternative to the ad hoc logging format of --verbose_gc, and to move some functionality currently provided by standalone one-off scripts into the observatory.
Add first unit test for events.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//434763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39014 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 23:52:18 +00:00
3912c841e2
Add request tracing to Observatory:
...
URL---trace=on turns tracing on
URL---trace=off turns tracing off
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//429293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39011 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 22:34:54 +00:00
bcd5aa0942
client -> observatory
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//454533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39009 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 21:46:29 +00:00
d1fe01a657
Rename vmservice/client to vmservice/observatory to match package name.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//443713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38991 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 15:56:27 +00:00
floitsch@google.com