3a896318b6
Revert "Add lock to a file handle in windows event handler."
...
This reverts commit r32901. The lock causes a deadlock, and timeouts in tests.
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//175223004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32906 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 17:00:41 +00:00
cad945de00
Add lock to a file handle in windows event handler.
...
BUG=
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//174013012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32901 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 15:29:09 +00:00
37913b1e00
Add missing mutex protection for timeout queue with mutex
...
Holding the timer_mutex_ is required to access the timeout_queue_ data
structure. This was missing for epoll events.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//174033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32856 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 17:21:27 +00:00
53c6b88abb
Don't leak file names in Windows File::Stat().
...
BUG=https://code.google.com/p/dart/issues/detail?id=13848
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//172153007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32854 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 17:06:13 +00:00
9635777fe0
Don't try to call read, if len i 0.
...
Also fix a Socket_Read to handle -1 from read.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//173633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32849 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 12:23:20 +00:00
e3372e72e9
Remove SocketData and now only pass the dart port to epoll.
...
This avoids keeping extra data alive.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//171503009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32846 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 08:56:54 +00:00
f2a6f1b4b6
Another round of cleanups for http://www.dartbug.com/15922
...
- Address warnings about 64-bit to 32-bit conversions.
R=ajohnsen@google.com , asiva@google.com
Review URL: https://codereview.chromium.org//169893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32831 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 23:35:55 +00:00
8f83775ead
Fix build by removing unused class member.
...
BUG=
Review URL: https://codereview.chromium.org//172103005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32797 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 16:49:27 +00:00
cabe710753
Remove 'mask' from SocketData, as it's not required.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//167193004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32794 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 16:15:00 +00:00
6bbd44db73
Also make eventhandler on Android edge-triggered.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//172133004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32791 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:29:13 +00:00
2cf11a443f
Fix Windows event-handler, where write can 'complete' with 0 bytes written.
...
To match our design, we now treat this as a success write, as we expect the error to come on next issued write (which is exactly what happens).
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//172363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32788 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:22:46 +00:00
140fddd06e
Make event-handlers edge-triggered and move socket-state to Dart.
...
This eliminates to pause/resume calls made in the previous one-shot based model.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//169383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32780 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 09:44:26 +00:00
a848bfdd89
Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the anchor text - keep long script url in hover text
...
The links for script-ref's now have a ?line=### url parameter which is
currently ignored in the script view page.
Added an optional 'isolate' parameter for all service-ref's. This
allows us to explicitly specify our "current" isolate.
Redo function/script reference in the isolate summary page to use
<function-ref> and <service-ref> now that we can specify an isolate.
Add a missing comma in observatory_element.dart.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//165643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32772 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 00:37:18 +00:00
2820a12766
Allow for embedder provided service request handlers
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//170943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32769 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 22:38:11 +00:00
7d4b415fe3
Improved how closures are displayed by <instance-ref>.
...
Make <optimized out> look a bit nicer.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//167713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32760 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 19:45:36 +00:00
d40db9d4b6
Add refresh button to stack trace page.
...
Remove stray debugging output.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//167363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32757 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 19:37:58 +00:00
1baf2b8e16
Trace VM service requests
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//164503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32751 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 17:50:26 +00:00
4b35c1e387
Fix host lookup on linux, to skip IPv6 if there are no global IPv6 addresses.
...
BUG=https://code.google.com/p/dart/issues/detail?id=16742
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//168943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32716 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 10:08:34 +00:00
0f52be7f63
Make std* blocking file-descriptors.
...
This will most likely be a performance regression when piping, that
we'll have to look into in the future (copying data through
message-passing).
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//154273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32715 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 10:06:35 +00:00
174bc974bd
Add expandable instances and lists to the vm service.
...
Review URL: https://codereview.chromium.org//164183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32707 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 17:48:25 +00:00
e6813f42e4
observatory indent code
...
BUG= https://code.google.com/p/dart/issues/detail?id=16751
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//159903003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32602 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 14:59:54 +00:00
76368bfa29
Really really fix the build...
...
BUG=
Review URL: https://codereview.chromium.org//144283010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32598 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 09:28:55 +00:00
9afc9cac70
Fix mac os x build.t
...
BUG=
Review URL: https://codereview.chromium.org//159723010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32597 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 09:16:30 +00:00
d00f632847
Use Thread::Compare instead of ==.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//157813011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32596 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 08:47:01 +00:00
7e49953c19
Avoid over-use of futures in socket.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//159663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32571 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 19:14:05 +00:00
c93bb293c5
Fix signal handler in checked mode..
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//130893010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32424 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 13:19:23 +00:00
9c08471e3a
Remove DEBUG ifdefs.
...
BUG=
Review URL: https://codereview.chromium.org//152883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32423 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 13:18:05 +00:00
d074156ac9
Move all run-loop calls into the run-loop thread, and use correct memory handling (retain/release).
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//140183004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32421 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 12:49:33 +00:00
2f60129fb0
Document ProcessSignal::watch.
...
We now also allow watching for SIGTERM.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//149253013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32416 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 09:41:38 +00:00
05d70400d6
Send error-event if socket is marked for error.
...
BUG=http://code.google.com/p/dart/issues/detail?id=16544
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//143473006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32358 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 14:37:21 +00:00
b88a51bd99
Fix file-watcher on mac by always starting/stopping through the run-loop thread.
...
This also fixes some system error-printing and maybe also early events.
BUG=https://code.google.com/p/dart/issues/detail?id=16216
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//147083015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32355 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 13:16:13 +00:00
06a79acbf6
Remove wrong type in file_system_entity
...
R=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//145643010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32354 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 12:50:49 +00:00
5e7886f1b7
Short-cut the call to Timer.run, to not go through standalone.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//150563005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32310 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 07:44:08 +00:00
eba430a424
Allow paths up to 32767 characters on Windows (so '\\?\' can be used).
...
BUG=https://code.google.com/p/dart/issues/detail?id=16264
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//145623011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32308 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 07:28:02 +00:00
8c7020e422
Add Google Charts to Observatory and use it in allocation profiler
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//148153007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32142 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 21:51:25 +00:00
b891e78325
Post-meetup feature extravaganza.
...
Remodel the top-level isolate summary page.
Add variables to stack frames in the stack trace.
Stop putting small integers and bools in the object id ring.
Rework how we pass down null references (and null-like references like
uninitialized values).
Collect all isolate timers by default.
Change the lifetime of IsolateSpawnState so that we can refer to it
later to know how an isolate started up. Stop pretending that
IsolateSpawnState is a void*. Clean up vestigial IsolateStartData.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//145323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32128 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 18:40:12 +00:00
64600f4e8e
Fix native extensions located in packages on Windows.
...
BUG=dartbug.com/16205
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//135403007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32102 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 05:07:29 +00:00
04d76d43cc
Fix error in processing dart-ext urls with a relative path.
...
BUG=dartbug.com/16205
R=sgjesse@google.com
Committed: https://code.google.com/p/dart/source/detail?r=32031
Review URL: https://codereview.chromium.org//134753005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32046 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 00:33:14 +00:00
ea1f835463
Fix error in processing dart-ext urls with a relative path.
...
BUG=dartbug.com/16205
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//134753005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32031 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 21:58:19 +00:00
dff049ab71
Don’t call toString from debugger
...
Debugger no longer calls toString on objects. It continues to do so
on known basic types like numbers, booleans, strings. This is necessary
because toString() may have side effects. See issue 16229 for example.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//146833007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32003 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-24 23:14:15 +00:00
9ca09b50e7
Track live instance and allocation counts for classes.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//51653006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31978 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 19:21:22 +00:00
a6399981e6
Code coverage in Observatory
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//143973005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31970 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 00:46:30 +00:00
d41a2106c2
Change Code object serialization format to use 50% less space.
...
Update observatory to support new format
Cache code objects inside observatory isolate
Profiler updates cache of code objects
Profiler can display annotated disassembly objects
Code objects now display sample ticks
Fix error viewer
Start using the logging package.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//135843006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31931 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:16:44 +00:00
3b3e87cabc
Revert "Rename internal library dart:_collection-dev to dart:_internal."
...
Dartium needs updating too.
Committed: https://code.google.com/p/dart/source/detail?r=31827
R=floitsch@google.com
Review URL: https://codereview.chromium.org//133273011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
781f737c6a
First round of http://dartbug.com/15922 :
...
- Address warnings about 64-bit to 32-bit conversions.
- Remove heap profiler.
R=asiva@google.com
Review URL: https://codereview.chromium.org//139043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31867 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:05:35 +00:00
12f8555b19
Allow root level requests in the vm service.
...
Move /cpu to the root level.
Move PostReply to the command handlers. This will allow command
handlers to reply asynchronously (by delegating elsewhere) if they
need to.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//131973007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31849 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 20:45:39 +00:00
ead87f47e9
Revert "Rename internal library dart:_collection-dev to dart:_internal."
...
Dartium needs updating too.
Review URL: https://codereview.chromium.org//133273011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
0098710559
Rename internal library dart:_collection-dev to dart:_internal.
...
BUG= http://dartbug.com/14140
R=floitsch@google.com
Review URL: https://codereview.chromium.org//133893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
ab3b253830
remove resource.h from bin.gypi file (should fix windows build break)
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//137783007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31816 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 00:16:45 +00:00
c76b6eb1c2
Split service into VM and embedder specific bits.
...
Move most service sources into the VM.
R=asiva@google.com
Review URL: https://codereview.chromium.org//125103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31809 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 22:34:43 +00:00
whesse@google.com