f772b572c8
Fix curly_braces_in_flow_control_structures lint.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I63cb372bf04f80182f873e2143971cb3cf1392fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-05 23:46:13 +00:00
845fccc337
Issue 35818. Use getDisplayString() in _ElementWriter.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/35818
Change-Id: I9a86729ba48cf599c45afee2c7ba83f32ba3c30b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-05 22:21:55 +00:00
47383da053
Update LUB for Null vs star.
...
As specified in https://github.com/dart-lang/language/pull/700
Change-Id: I324841799a485600bf1ebfd54cd852465efac715
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-05 03:55:48 +00:00
48573044b3
Replace helper methods in AbstractTypeSystemTest with ElementsTypesMixin.
...
Change-Id: Ibb50a5ca9365212af6e1ed024d213cb06d6856da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-04 00:37:18 +00:00
9c220059a1
Implement DOWN for FunctionType(s) with NNBD rules.
...
Change-Id: Icd21f17522a54f6d6545aa13406bbbac6cfb0233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127060
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-03 20:41:38 +00:00
1ebf5cfb39
Fix false positive UNUSED_FIELD on extensions
...
Also add tests for extensions, and for mixins.
Fixes #39618
Change-Id: I9f6ab723c72d5297c91e360f3531da374a53f0ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-03 18:45:38 +00:00
9719f75ef3
Add InvalidLanguageVersionOverride Hint; fixes #37504
...
Change-Id: Iea0687266b748a94218191f0ebdf7032715bf96a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125522
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-03 13:19:15 +00:00
2de9b45c8f
Update isFunctionSubtypeOf() to NNBD spec.
...
There is no functional changes, just rewriting this to the rules
as they are in the NNBD spec, and iterating over parameters in parallel
without building additional lists and maps.
Change-Id: I5d30cc3b7e1debf45486166aa5a8d1ccc20d5adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-03 03:14:20 +00:00
980b7ace7d
Implement DOWN with NNBD rules.
...
https://github.com/dart-lang/language/blob/master/resources/type-system/upper-lower-bounds.md#lower-bounds
Presubmit is green.
https://test.corp.google.com/ui#id=OCL:283239993:BASE:283239999:1575237950656:febb4697
Change-Id: I50ed1fc8ec589a545f41c2360f7d841a1b11f6fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-12-03 03:04:10 +00:00
4fe27fd444
Report an error when 'await' is used in the initializer of a late local variable.
...
Change-Id: I4c610dd37e4c7ca653d250d4e0522536a70a6ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-02 18:00:48 +00:00
e4344a568f
Report INVALID_OPTIONAL_PARAMETER_TYPE when default values are not allowed.
...
Change-Id: I8145bde238c092a50ddbc053100891737b74feb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-02 16:54:47 +00:00
3de7487a2c
Report an error for 'late final' fields in classes with const constructors.
...
Change-Id: I6843191a2f7a0bdd856549177468ff87eec949f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-01 01:48:20 +00:00
0a575d8681
Unify two diagnostics into instantiate_abstract_class
...
Change-Id: I0d9b97b26173ec789a7937337b8ff015edd283b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-01 00:58:00 +00:00
7707c2a84c
Issue 39563. Expression body always exists.
...
Bug: https://github.com/dart-lang/sdk/issues/39563
Change-Id: Ie1db0b78d39e5023662eb192fe59aab8a5b870d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-30 18:08:21 +00:00
c6326de855
Improve the highlight region for variable_type_mismatch diagnostic
...
Change-Id: I8fd2b17c93f2247603a8caacce58cd4abcfb651d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-30 16:09:50 +00:00
5b31b1e26d
Improve the selection range when reporting that an invoked constructor is not marked as const
...
Change-Id: Ibb49050394abe2ca1b7d5badf10227a970f15411
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-29 16:09:06 +00:00
98d1e99986
Relax UP for required named parameters.
...
According to https://github.com/dart-lang/language/pull/707
Change-Id: I7c469a204213968acb76ae6c797189aa3d394154
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126461
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-27 20:49:51 +00:00
0bbcf079f3
Issue 39532. Support for question mark in typedef generic function type.
...
Bug: https://github.com/dart-lang/sdk/issues/39532
Change-Id: Iea900717e8f60bc6c3216fc18cb59c8f921c996f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-27 20:25:21 +00:00
eddfaff322
Issue 39509. Support for configurable imports in AnalysisDriver.
...
Bug: https://github.com/dart-lang/sdk/issues/39509
Change-Id: I87cbc20c38ed93e46ae0b646ddad4d9fc28eca8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-27 18:58:02 +00:00
abeebc04e0
Compute LUB for FunctionType(s) in one pass over parameters.
...
Support for required named parameters.
Change-Id: Ic9dd286779ade8f9cceb5231f68b606148b295ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126180
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-26 23:09:15 +00:00
1a6b76a8a0
Update DeprecatedMemberUseTest from ResolverTestCase to DriverResolutionTest.
...
Change-Id: Ic6e0f593213e69c9524eb9e0909ad71f72700b49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-26 23:01:10 +00:00
58e9aeafdb
Deprecate AnalysisSession.typeProvider and typeSystem.
...
Change-Id: I33132bed9fd950030746adbd8951506a81912c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-26 01:30:33 +00:00
273ca5858b
Deprecate AnalysisContext.typeProvider/typeSystem
...
Change-Id: I5235aa38bcde93618a10b88da9ad6a8c3e5dc29c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-25 22:00:47 +00:00
6294c73f3e
Deprecate 'typeSystem' parameter for InheritanceManager3.
...
Change-Id: If14eb8900b0fb5cac5e49cf865f2e6e3a0a0263d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-22 23:08:41 +00:00
72f461b116
Update FunctionExpression return type inference to NNBD.
...
This reverts some changes I did in LUB update CL.
https://dart-review.googlesource.com/c/sdk/+/125761
Change-Id: I29e8896f6007ecb643c30ad98f2055fb917eeacc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125999
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-22 20:03:27 +00:00
63e8213721
Expose 'typeProvider' and 'typeSystem' from LibraryElement.
...
Change-Id: I547f60ff11c03d6d90385b3257cd3b4244b77490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125995
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-22 01:53:04 +00:00
029e06b8d9
[analyzer] Allow downwards inference and upper bound heuristic wrt variance.
...
variance_downwards_inference_test now passes.
The other part of this CL addresses https://github.com/dart-lang/language/issues/658
The code has similar logic to https://dart-review.googlesource.com/c/sdk/+/125552 .
Change-Id: Ib2bc7e9c11574ccd9b16fe66472bba8c16dabd29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125486
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2019-11-22 01:31:03 +00:00
3931d43d42
Issue 39407. Test for ListLiteral inference in presence of null(s).
...
There are no implementation changes, because LUB change did it.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39407
Change-Id: I932ef14ddf2ed4e640cf93e5a817c5325c87f6e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 23:08:48 +00:00
28d272b3dd
Move more types access / creation helpers into ElementsTypesMixin.
...
R=brianwilkerson@google.com
Change-Id: Icbadc6c52fee636e851632dcd3b90818bf3264bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125989
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 22:43:28 +00:00
aff0915ead
Fix BazelWorkspaces in which multiple 'bin' directories exist, e.g. on distributed build systems
...
Change-Id: If619bdd64b1a00be41026643d7c84b8bd9d9dcc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125723
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-21 22:43:18 +00:00
f979bd9899
Merge RestrictedAnalysisContext into AnalysisContextImpl.
...
We don't have any useful / old API(s) in AnalysisContextImpl,
so the distinction between these two does not exist.
Change-Id: I87ef84bc728cc1c2c0e269c695419c425afb6559
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:58:16 +00:00
f3455278ff
Use 'isNonNullableByDefault' flag in TypeProviderImpl.
...
Instead of giving it the NullabilitySuffix, for consistency with
TypeSystemImpl.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I16d1ca32071b8a28a31e207afed604f8d4b24a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:43:56 +00:00
6646412705
Rewrite DEFERRED_IMPORT_OF_EXTENSION check to using ImportElement namespace.
...
I think we thought about doing this, but probably forgot to do.
Also, we got NPE during google3 rool, 'importedLibrary' might be null.
R=brianwilkerson@google.com
Change-Id: Id321f18c97df06f543d619cf1913551535634d0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:32:37 +00:00
03676ad489
Remove AnalysisEngine.createAnalysisContext()
...
In order to remove a way to create AnalysisContextImpl at all.
This method is not API, and is not used internally.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ie36c1cc9e414310a9e3ee08a9ac26da9191b1ef7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125983
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:13:50 +00:00
6444fba9c7
Implement upper bound computation with NNBD rules.
...
https://github.com/dart-lang/language/blob/master/resources/type-system/upper-lower-bounds.md
Limitations:
1. Only UP is implemented, not DOWN.
So, handling formal parameters in incomplete.
2. Handling required named parameters is not implemented yet.
Change-Id: I4ddebeeaad21d41e0cbecfbc08aee82ec9752bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-11-21 17:24:46 +00:00
6dc3762b99
Stop producing a diagnostic for an error that was removed from the spec (issue 39476)
...
Change-Id: I811356f737ea27bad804729c0ee518701a08dd8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125927
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 17:18:01 +00:00
821b3c44ff
Add evaluateConstant() to LinterContext.
...
R=brianwilkerson@google.com
Change-Id: I497f1eccf48d3bd9d425cc47fbca769b27cab119
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125922
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-21 16:29:36 +00:00
b370346d60
Add 'isNonNullableByDefault' flag to TypeSystemImpl, make all parameters named required.
...
R=brianwilkerson@google.com
Change-Id: I262f86ba964f4970ec570dc9fa4c1a802556fa63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 15:37:46 +00:00
ad021d02d4
Integrate the latest batch of reviewed diagnostic docs
...
This includes a small improvement to the validation tests, but there is
also one code whose docs can't be verified without additional work that
I will do in a follow-on CL.
It also includes splitting one code into two to improve the messages.
Change-Id: I52989ca336e42822327e3ac3805b1654d20a479c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 15:21:55 +00:00
615928c514
Stop referencing non-API TypeSystem in analyzer.
...
Replace it with TypeSystem from lib/dart/element/type_system.dart,
or (internally) with TypeSystemImpl.
We keep the old TypeSystem where its is exposed from API:
- ResolveResult.typeSystem
- AnalysisSession.typeSystem
- AnalysisContext.typeSystem
We will make changes to these as a breaking change later.
Change-Id: I40ca53ea77e440457c6d0f3832ec3b6286bacdf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 01:09:24 +00:00
8d328738b8
[analyzer] Add variance to analyzer summaries.
...
Change-Id: Ia1a527eff5a784b2cb6d169c76108c16e6ccfe1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125554
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-20 23:01:02 +00:00
be519e83b1
Remove XyzElementImpl.forNode() constructors.
...
R=brianwilkerson@google.com
Change-Id: I39332a153b6d13be7b33d3980263eb3c3e952c65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125802
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-20 22:48:43 +00:00
f414465c45
Analyzer refactoring Workspace.isBazelWorkspace() to a getter: get isBazel, this is follow up on https://dart-review.googlesource.com/c/sdk/+/125564
...
Change-Id: I7e1dbc6b695b04a65bbb17761162daece797f238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125470
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-19 19:05:59 +00:00
1f933abcee
Convert a compile time error into a parse error (issue 39389)
...
Change-Id: I115c7bb4ab05f8c6e9ddc566985126a1b9a09842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125621
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-19 18:25:29 +00:00
db166e423e
Fix unused elements when setter used
...
Fixes #35677
Change-Id: I2daf8b4e2cc8e1a11ed0dde730d4126154b60910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125620
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-19 17:44:19 +00:00
0a98a7a153
Add helper predicates for upper/lower bounds.
...
Change-Id: Icec2315e4a65539861d99c8e10e254d11454cba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-11-19 02:48:23 +00:00
239e2eb4ed
Issue 38813. If in a legacy library, use legacy interface types for CONFLICTING_GENERIC_INTERFACES.
...
Bug: https://github.com/dart-lang/sdk/issues/38813
Change-Id: I950bf7bf492e80bc8f12c94252af360158dcb7b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125549
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-19 02:46:23 +00:00
2416116208
[analyzer] Support AST variance in visitors and cloning methods.
...
Most of the visitor, clone and constructor methods support variance
in the AST. Some methods for summary work are missing from this CL,
but I have taken note and will change those in an analyzer summary CL
in the future.
Change-Id: I54a39b9ec44ced26d2bc55966d5938a91ab6a76c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125007
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 23:20:53 +00:00
a8bf0dc2e5
Move type parameter variance tests for LUB to LeastUpperBoundTest.
...
Change-Id: Ia1eda9f0be073043399488af43f9d0485656ceb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-18 22:25:00 +00:00
8dd2e8e693
Modify DeclarationsContext.getLibraries to consider the entire context if it is a BazelWorkspace
...
Change-Id: I3d06e46505741f9166acf66f68a9ee1654ac37d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-11-18 20:57:35 +00:00
Konstantin Shcheglov