dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Danny Tuppeny 2678ee01ac Don't include end of comment markers in TODO range 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2181.

Bug: https://github.com/Dart-Code/Dart-Code/issues/2181
Change-Id: I670f8f46ef60d09ec3f1fd743084734048f3cfc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-03 15:48:09 +00:00
Johnni Winther e3a20bf361 [analyzer,cfe,dart2js] Support annotated code generation 
Add support for generating annotations from actual data using
option -g

Change-Id: I88d9cdb62a38d579234b15097c9e9bb3d81ebe8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129708
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-03 13:57:39 +00:00
pq d35e94c8ae Validate incompatible lint rules 
Change-Id: Ic57cdf7c7264c7d4da266f73a63b0b47e4a1d65a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130007
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 22:07:56 +00:00
Konstantin Shcheglov df98317c42 Report unchecked nullable for explicit / implicit 'this' in extensions. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39875
Change-Id: Ia0e5b9ea736428cd40d8898e48e0db605deebacd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-02 20:17:07 +00:00
Konstantin Shcheglov ed4c692620 Remove ResolutionTest.assertErrorsWithCodes(). 
R=brianwilkerson@google.com

Change-Id: I2673465848ec9ce8f4a737f8c4291414f6809bd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-02 17:42:06 +00:00
Konstantin Shcheglov 8a4404e64b Remove assertTestErrorsWithCodes() and assertNoTestErrors(). 
R=brianwilkerson@google.com

Change-Id: Ia5e64bfe318a11a87ee24aafca94fad7c7c8beb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-02 15:32:56 +00:00
Konstantin Shcheglov c7f3020fc6 Extract error reporting from TypeNameResolver. 
The extracted code mostly chooses which ErrorCode to report, and
does not do resolution logic itself. So, I think it will make the
resolver itself cleaner to keep it separately.

R=brianwilkerson@google.com

Change-Id: Idc6b652028ddb11913d5cd5c8273299ed94e7079
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129987
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 22:29:05 +00:00
Konstantin Shcheglov dce4de0b47 Deprecate assertNoTestErrors() and replace with assertNoErrorsInCode(). 
Change-Id: I3176e50d6cd86fa0863da5252ce52211a63f50b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129960
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-01 20:40:05 +00:00
Konstantin Shcheglov 99a39abe98 Stop using Identifier in several Scope.lookup() methods. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I400f7c5b14f44fb1e2a8b3d5e52016dcc4924961
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129832
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-01 19:55:55 +00:00
Konstantin Shcheglov 850ca2d410 Add Element.getDisplayString(withNullability), use it in analyzer. 
R=brianwilkerson@google.com

Change-Id: Ic4924e19612f2a7713f9a3f2059a880ebff9d2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-01 19:01:14 +00:00
Konstantin Shcheglov 7b7d8789ca Use WRONG_NUMBER_OF_TYPE_ARGUMENTS instead of two other equivalent error codes. 
R=brianwilkerson@google.com

Change-Id: Ibb5ea7d65df75655eaf2d43fba1110740be39912
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129833
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-31 20:27:03 +00:00
Konstantin Shcheglov 73389e6af0 Remove almost all uses of assertTestErrorsWithCodes(). 
The only use is assertNoTestErrors(), it cannot be replaced with not
ExpectedError(s) at all, we have 209 tests failing with UNUSED_LOCAL_VARIABLE

R=brianwilkerson@google.com

Change-Id: I19b6e0785e7553c00b130f827b4bb35b0742507f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129831
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-31 19:19:03 +00:00
Konstantin Shcheglov 4e38c9012a Remove 'isNonNullableByDefault' from TypeSystem.inferGenericFunctionOrType 
R=brianwilkerson@google.com

Change-Id: Ibdca2d8c762d723ad5847ad99605618db19ad5f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-31 18:28:13 +00:00
Sam Rawlins f1084cdf0b analyzer: move tests for 10 error codes to separate files 
Change-Id: I708b0ae276d7da7247d10b854eeedc52fb69e68e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129829
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-30 04:31:08 +00:00
Sam Rawlins 566f173f0c analyzer: Fix duplicate error-reporting with duplicate field formals 
Change-Id: I80e158b33e7ea6ae4769b37f1a3448ebf6e061a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129824
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-30 04:29:18 +00:00
Sam Rawlins 282dcb6f44 analyzer: move 'non-error' tests for 12 codes to separate files 
Change-Id: I30e8442f48afd018467239d6c9d966d25c087284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129704
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-30 03:40:38 +00:00
Konstantin Shcheglov 0c7048be74 Remove reporting duplicate CompileTimeErrorCode.CONST_NOT_INITIALIZED from ConstructorFieldsVerifier. 
R=brianwilkerson@google.com

Change-Id: I1566c0d4f955846671823fd3736f71f08281d5c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-30 01:24:38 +00:00
Konstantin Shcheglov 90c5eb0603 Remove 'referencingLibrary' from several Scope.lookupX() methods. 
We don't use them, instead corresponding import namespaces don't
include private declarations.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I727ed92a643412a90f691c6966efb90121b079d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-30 00:48:18 +00:00
Konstantin Shcheglov 45b780e04c Add canReferenceElementWithoutThisPrefix() to LinterContext. 
With this approach, UnnecessaryThis is a bit more complicated than
the one outlined in the previous message:

  @override
  void visitThisExpression(ThisExpression node) {
    final parent = node.parent;

    Element element;
    if (parent is PropertyAccess) {
      element = parent.propertyName.staticElement;
    } else if (parent is MethodInvocation) {
      element = parent.methodName.staticElement;
    } else {
      return;
    }

    if (_canReferenceElementWithoutThisPrefix(element, node)) {
      rule.reportLint(parent);
    }
  }

  bool _canReferenceElementWithoutThisPrefix(Element element, AstNode node) {
    if (element == null) {
      return false;
    }

    var id = element.displayName;
    var isSetter = element is PropertyAccessorElement && element.isSetter;
    var result = context.resolveNameInScope(id, isSetter, node);

    // No result, definitely no shadowing.
    // The requested element is inherited, or from an extension.
    if (result.isNone) {
      return true;
    }

    // The result has the matching name, might be shadowing.
    // Check that the element is the same.
    if (result.isRequestedName) {
      return result.element == element;
    }

    // The result has the same basename, but not the same name.
    // Must be an instance member, so that:
    //  - not shadowed by a local declaration;
    //  - prevents us from going up to the library scope;
    //  - the requested element must be inherited, or from an extension.
    if (result.isDifferentName) {
      var enclosing = result.element.enclosingElement;
      return enclosing is ClassElement;
    }

    // Should not happen.
    return false;
  }

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I83e2a3a67f3db43caeb8157116e823268c9bfec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129819
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-29 22:31:37 +00:00
Sam Rawlins b6e0845a81 analyzer: move 31 'non-error' tests to separate files 
Change-Id: Ibeebeff73a656c5659b9dfd85d7a104ae6ae92fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129805
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-27 20:08:05 +00:00
Konstantin Shcheglov 890905371c Move getElementDeclaration() tests, prepare for adding new tests. 
R=brianwilkerson@google.com

Change-Id: Id7b3d73782410aa7a814a570557f61b32edb0c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-27 18:38:57 +00:00
Sam Rawlins d9bf32513d analyzer: Move tests for 7 more codes to separate files 
Change-Id: I59fcf1cc3c7e00f34f1fbd122af250948bfa2a97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-27 14:47:15 +00:00
Konstantin Shcheglov f979338aab Extract TypedLiteralResolver. 
Almost purely moving classes and methods, without desirable additional
refactorings yet.

Change-Id: I7927a432b208747addf4a561d54078da553b339b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 07:56:04 +00:00
Sam Rawlins 7737f8b948 analyzer: Move tests for 9 more codes to separate files 
Change-Id: Id9a8fc2cda5bafeb40b8dc335e884ae57ad790fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129564
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-27 05:59:14 +00:00
Konstantin Shcheglov e2795c41ee Move ResolverErrorCode codes into CompileTimeErrorCode. 
Change-Id: Ie8a1422c86da5c4f04fbd4422a758289bf9e078c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 22:12:44 +00:00
Konstantin Shcheglov 2fb3f09948 Extract TypeProvider class into lib/dart/element/type_provider.dart file 
Change-Id: I96cdfccc33e35a9625c14a89a08826758eac0f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 21:31:04 +00:00
Sam Rawlins 232a171a0b analyzer: Move tests for 8 codes to separate files 
Change-Id: I3092a13ecdcde820b2a35c07ddb78df08f23ae75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129560
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-24 19:21:41 +00:00
Sam Rawlins 4eb896b9e4 analyzer: Move tests for 8 more error codes into separate files 
Change-Id: I59ee527c0ff68ff7c77c7a52483ba23355dfe3ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129423
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-24 16:02:56 +00:00
Sam Rawlins de6faade0f analyzer: Move 9 more code tests to separate files 
Change-Id: I77f4d5b50459a2cb066c90b3278c155041b5c9f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129542
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-24 15:55:41 +00:00
Sam Rawlins b5e1aeb4d0 analyzer: Move two tests into separate files 
Change-Id: I5f0a3eb9a26940ab2a77580b5d139bc44e20d86c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129543
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-24 15:54:51 +00:00
Konstantin Shcheglov 48e42598df Remove special support for dart:_foreign_helper 
Change-Id: I5678d208a98dd2a6dce51305ea07df76ca935e53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-23 18:40:00 +00:00
Konstantin Shcheglov 8a0d30d4e2 Fix annotate-overrides in analyzer. 
R=brianwilkerson@google.com

Change-Id: I7a587daf9715ded6450b28ecf3892ce4181aeb37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-23 00:02:37 +00:00
Konstantin Shcheglov e11077da83 Don't special case null literal, it has Null type. 
Bug: https://github.com/dart-lang/sdk/issues/39880
Change-Id: Ic03da57425327b151d86ca1f2d3abf1bc85bf18c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129330
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-21 20:47:08 +00:00
Konstantin Shcheglov 6aa995d579 Issue 39880. Resolve extension method invocations on null literals. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/39880
Change-Id: Ia37c31b03858c8b1d6bd4bcd6fcbc300bb20aead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-21 01:46:15 +00:00
Konstantin Shcheglov 36ded5cdd9 Issue 39875. Don't report unchecked nullable when resovled to an extension with nullable extended type. 
Bug: https://github.com/dart-lang/sdk/issues/39875
Change-Id: I8beff226da4b301b0d2903788b44705985c89823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-12-20 23:39:44 +00:00
Konstantin Shcheglov b21be1a177 Run all extension tests in NNBD mode too. 
Change-Id: I91b997602e50d42a0f022d0e96ee9c788d1f6853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129320
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 21:32:19 +00:00
Konstantin Shcheglov 9555c0a7d8 GenericInferrer gets all information from TypeSystem. 
Change-Id: I1d3a5626a7ffda33ea7708b6d9f3b9a3b4f1a4f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129308
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 20:25:04 +00:00
Konstantin Shcheglov 8299e0693f Fix PackageBuildPackageUriResolver.restoreAbsolute() 
Bug: https://github.com/dart-lang/sdk/issues/39848
Change-Id: I0a8ee0e96e0035e33370dc6c5d65e499f639d8d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129305
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 19:07:44 +00:00
Konstantin Shcheglov 912e0e4085 Issue 39849. Support for null-aware invocations and extensions. 
Bug: https://github.com/dart-lang/sdk/issues/39849
Change-Id: I71a16699ccb28e0d06b83b32ddf927a24984f870
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129241
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 16:57:30 +00:00
Konstantin Shcheglov cf2a35f661 Use DartType.getDisplayString() in as many places as possible. 
We fail to do this now in Element.toString(), which also should be
converted into something like getDisplayString(withNullability), so
that we used the appropriate presentation in DAS.

I noticed some duplication for type assertions in tests, and would
like to use more shared utilities for validating types.

Change-Id: I28af74a2c96916e868887df6422ccfb640a9c01b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 01:11:49 +00:00
Konstantin Shcheglov 21354dccc9 Remove SdkExtUriResolver. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820

R=brianwilkerson@google.com

Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 01:08:49 +00:00
Konstantin Shcheglov d321f6e452 Issue 39773. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER when no default value is allowed. 
This partially reverts https://dart-review.googlesource.com/c/sdk/+/126801

Bug: https://github.com/dart-lang/sdk/issues/39773
Change-Id: Ib147ed770d9bf328dd7792a37a72291070411964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129142
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 23:35:13 +00:00
Konstantin Shcheglov 5c6d95d067 Implement NNBD_TOP_MERGE. 
https://github.com/dart-lang/language/blob/master/accepted/future-releases/nnbd/feature-specification.md#classes-defined-in-opted-in-libraries

Change-Id: I48a67410d0e065349348f2590b2d69546054aec3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-12-18 22:04:11 +00:00
Konstantin Shcheglov 82f1f2f1b0 Remove AnalysisOptionsImpl.strongModeHints 
Change-Id: I61b8aefb4935160bec20e52fb9c9482079387c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 20:11:16 +00:00
Konstantin Shcheglov 78c2a6a101 Remove StrongModeCode.DYNAMIC_INVOKE 
Change-Id: I99c158823bf9c30e6950619548f09eb7070607ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 17:37:31 +00:00
Konstantin Shcheglov a3ea61c3d0 Remove StrongModeCode.IMPLICIT_DYNAMIC codes. 
Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:286100469:BASE:286100526:1576636805426:a3f44b2a

Change-Id: I6a239a39c5b71418d5bdd4f152b60fea9322099b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 07:02:15 +00:00
Konstantin Shcheglov b6e051e2c8 Use StaticWarningCode.DEAD_NULL_COALESCE instead of hint, use isStrictlyNonNullable(). 
Change-Id: I626745a7114b9403419d62307b79282f46fff985
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128803
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 01:55:05 +00:00
Konstantin Shcheglov becb0c0b85 Revert "Remove SdkExtUriResolver." 
This reverts commit 7ef8822c2a.

Reason for revert: breaks Flutter build because dartdoc is not updated there yet.

Original change's description:
> Remove SdkExtUriResolver.
> 
> R=​brianwilkerson@google.com
> 
> Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I0c9a26662a6fe6abac558313c14949886364d28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 01:07:34 +00:00
Konstantin Shcheglov 7ef8822c2a Remove SdkExtUriResolver. 
R=brianwilkerson@google.com

Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 00:22:15 +00:00
Konstantin Shcheglov 630bdfbc38 Fix typos in diagnostics/test_all 
R=brianwilkerson@google.com

Change-Id: I59e176082a12a1da56c47f740fd53641934d6f0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 23:15:04 +00:00