dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov 8b204d477d Remove StringUtilities.startsWithChar() 
R=brianwilkerson@google.com

Change-Id: If05d2fcf0f60c3bd2b2319cf38cf463dcdc0e336
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128768
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 23:14:00 +00:00
Konstantin Shcheglov 2655f82326 Report UNNECESSARY_NULL_AWARE_CALL for IndexExpression and cascades. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iea413e69fd9f92f99bb8a3f9f1f9c399fa61e719
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 23:05:54 +00:00
Konstantin Shcheglov 96eff3cc82 Remove unnecessary @pragma('analyzer:non-nullable') from tests. 
R=brianwilkerson@google.com

Change-Id: I483ab1b232e0f3c1ad852a3ed62226ee7028548f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 21:21:14 +00:00
Konstantin Shcheglov f3ffe7d3fd Use isStrictlyNonNullable() to report UNNECESSARY_NULL_AWARE. 
R=brianwilkerson@google.com

Change-Id: I993b18135c12187708c26dc10d3d2fd6ba61077c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 20:58:55 +00:00
Konstantin Shcheglov 0b7b2295e3 Rename test file name typo for ExportDuplicatedLibraryNamedTest. 
R=brianwilkerson@google.com

Change-Id: I5945d454cb167fd7146a9d757740afe12993a822
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 20:17:09 +00:00
Konstantin Shcheglov d940075e6c When building interfaces in legacy libraries, convert signatures from superinterfaces to legacy. 
Change-Id: Ibcaea82b2825d37a5dc98ca1757af99e70e5b8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128578
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 18:42:26 +00:00
Konstantin Shcheglov f25368bd82 Implement strictly non-nullable predicate. 
Change-Id: I4b3e20b76b582d04ef206fce37351358c33b02f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128722
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 17:53:36 +00:00
Konstantin Shcheglov b89eb6cf16 Stop reporting INFERRED_TYPE codes. 
Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:285886840:BASE:285910812:1576561195953:c64215aa

Change-Id: I6616a8ce0fd5188ae9405cdc4b82a2006fee675d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128571
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 17:01:56 +00:00
Sam Rawlins 2d332ee1d3 Make private fields final where possible 
Change-Id: I16ee52f1b23e8d708e40cb482c5150f1e04d2417
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128524
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-17 06:12:39 +00:00
Konstantin Shcheglov fe36f5db02 Remove reporting NON_GROUND_TYPE_CHECK_INFO. 
Change-Id: If7303fd2f24a233122cc354ad11eeedd1225c800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128568
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 00:32:40 +00:00
Sam Rawlins 5dfa750393 Convert all function parameters and typedefs to generic syntax 
Change-Id: I18f8644ecbe61555b2929ed09d446733d33ec2a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128521
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-12-16 23:36:38 +00:00
Konstantin Shcheglov d32e56f51c Fix BazelWorkspacePackageTest on Windows. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ie0be91f58bf6f3e0fed1410b6761d16ff07cb327
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-16 18:40:38 +00:00
Konstantin Shcheglov 383e6a7e8b Fix packages tests on Windows. 
Change-Id: Iaa06928d6d279459aa7a6e0d8f3d8da113c4fdd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-16 18:06:13 +00:00
Konstantin Shcheglov c5c4690886 Stop reporting several StrongModeCode(s). 
Change-Id: I8d2f165a6fb570f82b8d2506dfa5602f8e89bba1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-16 00:58:06 +00:00
Konstantin Shcheglov 99ba43c413 Look up concrete members when checking for PRIVATE_COLLISION_IN_MIXIN_APPLICATION. 
Originally specified in https://github.com/dart-lang/sdk/issues/28809
There was a couple of holes in our unit tests, so we missed a
rare situation when the issue should not be reported.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iaf35a7755c4ac4fc69bd86c56f18dc0a952bf7fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-16 00:36:36 +00:00
Konstantin Shcheglov ae3973da40 Use FeatureSetProvider in AnalysisDriver. 
So that package_config.json can be used to opt-out from context
specified features / experiments.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I5e62d733eda6939d66d942eb3d690583f6091a57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128369
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-14 21:06:04 +00:00
Paul Berry 09a0b040dd Deprecate InterfaceType.lookupXyz, add new InheritanceManager based implementations. 
With proposed changes to nullability suffixes and inheritance, we
better consolidate lookups in one place.

Change-Id: Id02fd9a470ea83e83af061b1d92fdbc90092a1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127721
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-12-14 14:22:26 +00:00
Konstantin Shcheglov 6c99171686 Report CompileTimeErrorCode.EXPORT_LEGACY_SYMBOL 
Change-Id: Icd43121a4d7f20fdecc1bff8ced6b9378ce94149
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128377
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-14 01:14:55 +00:00
Sam Rawlins 40718899fe Fix pedantic 0.9 lints around collection literals and spreads 
Change-Id: I64277c36fbeb4ea7a1bb429a8e0a40203520c883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128380
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-14 00:15:41 +00:00
Konstantin Shcheglov 92f3447eb1 Replace using \n with multiline strings. 
R=brianwilkerson@google.com

Change-Id: Iae3f4c3eef3e944e32515a8c029ddc60a01d47ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128375
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-13 22:00:59 +00:00
Konstantin Shcheglov 0fbce8238d Remove NameFilter. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I684bda477d35b40fc812113e126d1f4ad70302b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128371
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-13 20:33:11 +00:00
Brian Wilkerson 43066c9911 Add newly reviewed diagnostic docs 
Change-Id: I1a090ebd0129040a5fcbf2fca3919c6e22cf1daa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-13 17:55:29 +00:00
Konstantin Shcheglov f14301b0df Stop supporting _sdkext, look for _embedder.yaml only in sky_engine package. 
Change-Id: I20d30ef0e07ec617d5d8b9fb2e5fb97a7fc9930f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-13 02:15:28 +00:00
Konstantin Shcheglov b3c2eb9f69 Stop setting AST properties for DDC. 
Change-Id: Ia3fd639497b65844d386e06131dd729aa76c6a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128111
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-12 23:54:41 +00:00
Konstantin Shcheglov e51702a7a1 Issue 39752. Fix for promoting TypeParameterType twice. 
Bug: https://github.com/dart-lang/sdk/issues/39752
Change-Id: Idbb1a3b11d8eb6bdb05a2916d224a4d3e08a5b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128240
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 21:35:29 +00:00
Konstantin Shcheglov 3389b3bd32 Remove Packages from SourceFactory. 
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.

Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 17:10:00 +00:00
Konstantin Shcheglov dfc268671f Packages configuration abstraction on top of .packages or package_config.json files. 
I plan replacing all references to package:package_config with this
new abstraction in future CLs.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ifbe2c6a16f12cbf32f895505b16857a790610f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128102
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-11 20:52:38 +00:00
Konstantin Shcheglov 191df1ff71 Implement NORM. 
https://github.com/dart-lang/language/blob/master/resources/type-system/normalization.md

Change-Id: I51d74045a7c50e546427767fcfbc7a28c1986ecc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-12-11 17:47:17 +00:00
Konstantin Shcheglov b305a5cef1 Implement parsing for package_config.json files in analyzer. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Idb1ae19327df2bb2388fb585aecc7269edfdf66e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-11 17:01:27 +00:00
Konstantin Shcheglov 7e6c130ed6 Extract nullability TypeSystem tests. 
R=brianwilkerson@google.com

Change-Id: I6dbfa4f92f83d7a595d979e614c33f62233df5be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128012
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-11 16:53:49 +00:00
Sam Rawlins c01b52cb0f Remove duplicate 'DEFAULT_VALUE_IN_FUNCTION_TYPE_ALIAS' already reported by fasta 
Fixes #39524

Change-Id: Iaf1c095a9f80809cb8b7e0edd966ab1b22c89abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-11 16:22:48 +00:00
Sam Rawlins bd008dd1e4 Allow empty URI strings in library directives 
Fixes #38859

Change-Id: I1698b09bfee367634782f6f7c61f1dbda22edc0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127600
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-12-11 02:20:16 +00:00
Konstantin Shcheglov e22ddd1372 Update TypeSystemTest to reuse more ElementsTypesMixin. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1ceb8a7fe429f194e7ff418105517b96917ce6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-10 19:10:45 +00:00
Konstantin Shcheglov 1cc5d6927a Deprecate ErrorReporter.reportTypeErrorForNode() 
We always want to convert DartType(s) to their String presentations
using getDisplayString(), never using toString(). Also it is OK  to do
some processing during error reporting, it should be rare operation.

R=brianwilkerson@google.com

Change-Id: I57b80cdd7e91de2eb0d06aa84e15ffc0f577090b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-10 18:41:35 +00:00
Konstantin Shcheglov 9456316b51 ErrorReporter should know isNonNullableByDefault. 
So, when we call DartType.getDisplayString() we know if the type
presentation should include nullability suffixes.

This fixes many, but not all places where we need to present types.
There are places where we don't go through ErrorReporter, but call
ErrorListener directly. I plan to replace all these with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/39651
Change-Id: Ic77a556e7834d8f757c8b13eed37ed1d34f47348
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-10 01:31:22 +00:00
Konstantin Shcheglov b296d55c55 Issue 39709. Disable implicit 'call' tear-off for nullable objects. 
Bug: https://github.com/dart-lang/sdk/issues/39709
Change-Id: I5dcb139f99d3d1e7ef43c6e463e01b665e655b77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-09 22:22:44 +00:00
Konstantin Shcheglov bafd4e8dc6 Issue 39668. Use 'read type' to check dead '??='. 
Bug: https://github.com/dart-lang/sdk/issues/39668
Change-Id: I20bd3ae7806b409d6c4b9b72b4968651db207ea4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-09 18:19:29 +00:00
Sam Rawlins 9f2be5cadf Move tests for 6 more diagnostic codes to the diagnostics/ directory 
Change-Id: I291754287ff01baf86031960a3c4f260a9fc5df9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127541
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-07 17:31:45 +00:00
Sam Rawlins 159c6da02a Add test for a @required field formal 
Related to #37266, but doesn't address it.

Change-Id: I51114c2b67dcd6f62b5b237998eafab49d2fc369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-07 17:18:05 +00:00
Konstantin Shcheglov c17aff87e1 Restore skipping all dynamic type arguments in DartType.displayName 
There is one internal client that currently depends on such presentation.
This will unblock rolling analyzer, then we will fix the client, and
remove this skipping code in analyzer.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0d6387892d12326d658800069dd8a60faa589405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127488
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-07 02:24:34 +00:00
Konstantin Shcheglov f024d9dcce NullabilityEliminator - Never to Null*, remove required from formal parameters. 
Change-Id: I3ad2cf15c2ed1e8eb347ac84c9dc401e807e2e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127203
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 23:28:09 +00:00
Konstantin Shcheglov b92cd2cb95 Deprecate DartType.displayName, use getDisplayString() instead. 
We call it with `withNullability: false` almost everywhere.
My attempt to update all places turned out to be a long chain of
changes. So, instead I will make decisions and updates in separate
CLs, starting with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9d72475577ba2934bed1c06a4808ab620e92a20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127441
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 22:43:59 +00:00
Sam Rawlins 0939101320 When reporting unused elements, do not count a CommentReference as usage 
Fixes #37116

Change-Id: I9ac563036a367a5e5da4fbba8ab521f174062570
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127223
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 22:36:54 +00:00
Sam Rawlins 3281a4ab7f Move tests for 10 diagnostic codes to diagnostics/ files 
Change-Id: Ic5e4f344c17b2c18c134b816a771fb61732dd934
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127452
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-06 16:00:10 +00:00
Konstantin Shcheglov 4b21941d33 Fix prefer_iterable_wheretype in analyzer. 
R=brianwilkerson@google.com

Change-Id: Id683ec62a7bdfddb5b2662afbcf57d884767a736
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127454
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 15:54:10 +00:00
Konstantin Shcheglov 54e1c16c1c Fix empty_catches in analyzer. 
R=brianwilkerson@google.com

Change-Id: I6abc5acbd93aa12df8ff6226c49f9b72c0313c92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127426
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 15:03:30 +00:00
Konstantin Shcheglov 54b7543c55 Fix unnecessary_const in analyzer. 
The only non-mechanical change is update for tool/diagnostics/generate.dart
to handle MethodInvocation, because without resolution and without
explicit `new` and `const` we get MethodInvocation(s).

R=brianwilkerson@google.com

Change-Id: Ib89ce9c37066e9b27ad03aed96b349ef36f11d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 15:03:00 +00:00
Konstantin Shcheglov 0bca6aaf10 Fix avoid_return_types_on_setters in analyzer. 
R=brianwilkerson@google.com

Change-Id: If7132980451d76c777d3734abbb89ece5ad3e3d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127425
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 01:48:48 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer. 
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 01:11:30 +00:00
Konstantin Shcheglov eee20b4e60 Fix prefer_equal_for_default_values in analyzer. 
Change-Id: Ia72a2ac31d6cf6329c78baad6954ac9595a6c45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 00:00:30 +00:00