dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov 860132c9e0 Fix using interfaceType() without nullability, remove unused class. 
R=brianwilkerson@google.com

Change-Id: I8c8ab46dc629e9a6895fdd37abc98d86e01590cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 19:10:01 +00:00
Konstantin Shcheglov 7df44023f4 Issue 38878. Update SuperContext for annotations. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38878
Change-Id: Ib2944fd60062fca0ec2899d83656cdc02b0a4a87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125529
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 19:06:48 +00:00
Konstantin Shcheglov b5b45ffe4b Issue 38953. Exit the unit element walker on enter into a directive. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38953
Change-Id: I54e84e28f5d576bcd50c8bb10e99aefdae725c25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125528
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 18:11:53 +00:00
Konstantin Shcheglov 2a5d00bcd2 Issue 38992. Build annotation elements for type parameter elements on their creation. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38992
Change-Id: I98f7690914ce2acb7074a8333b9a482605bb9afb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125527
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:36:08 +00:00
Konstantin Shcheglov aa0cf44b05 Issue 38506. Don't attempt to use LibraryElement.metadata for not the first LibraryDirective. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38506
Change-Id: Ib76b1e81554f061622ec98fae21b4dd9a1280c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:28:45 +00:00
Konstantin Shcheglov 6df2491743 Issue 38551. Fix for reading references to PropertyAccessorElement(s) defined in extensions. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38551
Change-Id: Id93714a2db97ff1ab448fe408f4e86df9988a147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:28:03 +00:00
Kallen Tu 6ec813e07a [analyzer] Modified type inference constraints wrt variance. 
Change-Id: I0502bad1c57af358453c78d27fe738880beb7b4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125021
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-15 22:02:36 +00:00
Sam Rawlins fea5e1b741 Fix UNUSED_MEMBER check for cross-class private class members 
Overhauled how UNUSED_MEMBER and UNUSED_FIELD work, by using
Elements instead of names. This requires careful extra logic for:

* implicit getters
* overridden members
* parameterized members
* unresolved members: when _x is called on a dynamic
  expression, we must declare that all members named _x on all
  classes are used.

Fixes https://github.com/dart-lang/sdk/issues/35677

Change-Id: Id097350499b34b33239e82e391af0b7ea9580cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124521
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-15 03:42:55 +00:00
Konstantin Shcheglov c98a775436 Remove deprecated classes and fields from IDL. 
This patch should be landed atomically into both internal copies
of analyzer, and there should not be any pending roll into either copy.

Change-Id: Iae405b6c8292fb33ef5cf99332acec9d85257748
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125281
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-15 00:14:43 +00:00
Konstantin Shcheglov 385cfb61c6 Add nullability variants to create InterfaceType(s) to ElementsTypesMixin. 
R=brianwilkerson@google.com

Change-Id: I6ec6f6f1d533de4ec46e569c0b7becc9dd19b33b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125225
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-14 20:36:29 +00:00
Konstantin Shcheglov 81da345035 Use ElementsTypesMixin.mixin_ in analyzer tests. 
R=brianwilkerson@google.com

Change-Id: I2e7dfc608db1f8fe66c48b94b4faf73be5344cb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-14 18:23:31 +00:00
Konstantin Shcheglov fac27eae0a Use Member(s) as legacy views on elements. 
Change-Id: I3e8a603a50ecc04b217311bfc34f66e3dd924247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124593
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-14 16:41:51 +00:00
Konstantin Shcheglov bd2163f122 Issue 39380. Fix for null loopVariable. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39380
Change-Id: I1d631d89f4c8cc72f8d76c3f62334d570c92aff2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-14 16:36:20 +00:00
Konstantin Shcheglov 2928b6179c Test interfaces of opt-in and opt-out mixes. 
Change-Id: I0a3433216b9e8b3b1a2df03c3823697c1e8ae017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-13 23:31:18 +00:00
Konstantin Shcheglov a8e48405dd Share search methods in FindElement and ImportFindElement. 
Change-Id: I511c23440fbd95b3a27a50d7b80c66c9a8a7f558
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-13 22:22:25 +00:00
Kallen Tu df2093362d [analyzer] Clean up casting for variance and related tests. 
Change-Id: Ieb73919e41ee500c29c17d64f6b4525978378a00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-13 19:26:41 +00:00
Konstantin Shcheglov c9ef7cc5e3 Deprecate Member.baseElement, use Element.declaration in analyzer. 
Change-Id: I91d23558c7d0bd8ffa2e251e5d615d4e026923b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124940
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 22:35:07 +00:00
Kallen Tu d5d889668b [analyzer] Added variance support for upper/lower bounds. 
Change-Id: I64f44a7068c6caa222787ccb7dfbb3ed8b5fd0fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124420
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-11-12 22:10:56 +00:00
Kallen Tu a65aff122d [analyzer] Changed subtype checking for variance modifiers. 
Change-Id: I9fa65e13d2f8611acc50fd133029c76666b8f452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123559
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 22:09:56 +00:00
Konstantin Shcheglov a520e771f6 More subtyping tests. 
R=brianwilkerson@google.com

Change-Id: I078639191f3574cba7baaa49bfb4330f0b35c206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-12 22:00:49 +00:00
Sam Rawlins 0b210e5e81 strict inference should not complain about top-level setter return types 
Fixes https://github.com/dart-lang/sdk/issues/39250

Change-Id: I9f9ddc7ce484cc4ee0e9bbf2a7b2c673f6ad4e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124520
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 21:25:43 +00:00
Konstantin Shcheglov ab7bceb622 Ensure that Member(s) are not created around Member(s). 
Change-Id: I11505dcfcbaa51488d4bb2f8ab541b5599d36edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-12 21:00:14 +00:00
Konstantin Shcheglov 6cde7ce224 Deprecate synthetic FunctionTypeImpl constructor. 
Change-Id: I7c2f834d7e9e532709b3d43b348e7588be659af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124595
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-11 19:38:53 +00:00
Brian Wilkerson e39b0f8d99 Disallow a deferred import of a library with extensions if any extensions are visible 
Change-Id: I37f08e56cfbbdd5147abd28ae40f2358cd7d1382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124584
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-08 19:55:47 +00:00
Konstantin Shcheglov 5f5ce5d119 Include type parameter bounds into string expections for subtyping. 
R=brianwilkerson@google.com

Change-Id: Id2ef295a1eb77221199ed2f098961990b249e8b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124585
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-08 19:47:38 +00:00
Konstantin Shcheglov dc69edcdb3 NullabilityEliminator for removing nullabilities in legacy libraries. 
Change-Id: I3202ef39954e27b26a5851f449903fa1fac1eb63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-08 19:10:09 +00:00
Brian Wilkerson 7ad7e6202d Allow extensions imported with a prefix to be accessible 
Change-Id: Iccc4a0c1ad50e13f5034fb1214d549a29e8a3e7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-08 18:52:48 +00:00
Konstantin Shcheglov e3aac9e25d Check more in LegacyTypeAsserter. 
Change-Id: Ie90ff509dd4327ef33a1ce7fb81657ff8c2f1412
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-08 17:00:07 +00:00
Paul Berry 6317779f9b Simplify TestTypeProvider constructor. 
The only optional parameter that was actually used was
nullabilitySuffix, so eliminate the others, and make it a named
parameter for easier future expansion.

Change-Id: Iee05e955a1c996b4e1dd9bbec3db7fd1588ebe04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-08 13:53:17 +00:00
Konstantin Shcheglov 7a45228584 Use ElementsTypesMixin in TypeSystem tests. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If7195af4f5e90e6acce60912f1c66c5cf956865c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-08 04:00:06 +00:00
Paul Berry 395373a90c Further improvement to ID testing error output. 
We now print the error code as well as the message, which makes it
easier to locate the analyzer code related to the error.

Change-Id: I9e18744ce8e58efe6a5ecb7e7a98035777982836
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124381
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-07 22:06:17 +00:00
Konstantin Shcheglov 1ab6ba98d3 Test GLB and LUB symmetry for FunctionType(s). 
https://github.com/dart-lang/sdk/issues/26126 was fixed,
so we can do this properly now.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I938df344a96470f461f8d7f4cf530bc0b290453c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-07 21:51:17 +00:00
Konstantin Shcheglov cb0e5c5a3e Set operator== parameter type to dynamic if directly from Object. 
See https://github.com/dart-lang/language/issues/569

See https://github.com/dart-lang/sdk/issues/38339

Change-Id: I8d42135985aa4d55ffcc65cdf849572736cb9198
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124284
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-07 20:07:29 +00:00
Konstantin Shcheglov 548d078115 Sort named parameters in FunctionTypeImpl, fix equality. 
Change-Id: I90fdf768f291161a598bb5a6c072ac8fd31f73c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-07 19:20:59 +00:00
Kallen Tu 126297befd [analyzer] Add variance modifier values to the AST. 
Change-Id: Ic8b4291941d7b11672783a5e11a741c90fb12394
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123548
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-07 01:33:53 +00:00
Konstantin Shcheglov 3dacbae99e Use 'isRequiredNamed' for FunctionType subtyping. 
Change-Id: I3d8ca70be7f782e1574535e463f9049ddd0e28a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124285
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-07 00:17:53 +00:00
pq d76b2ccc16 rename tests 
Follow-up from: https://dart-review.googlesource.com/c/sdk/+/124260/2/pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart#521

Change-Id: Iaa714754eed38bf9f5a32e147f4506a00a2cc8a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124281
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-11-06 23:17:43 +00:00
Paul Berry 1994c5c323 Improve error reporting in ID tests 
Change-Id: I3a1da7cef955cdef62d4fea3a98f5949309695be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-06 21:57:41 +00:00
pq e93bf30171 fix deprecated messages for implicit getters/setters 
Fixes: https://github.com/dart-lang/sdk/issues/39267

Change-Id: Iad0f22f4da8239a0d802d7b3d951afb42a5c8965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-11-06 21:43:51 +00:00
Konstantin Shcheglov 3e3a926690 Fix spread and Set/Map literal disambiguation when NNBD. 
Fixes https://github.com/dart-lang/sdk/issues/39120
Fixes https://github.com/dart-lang/sdk/issues/39117
Fixes https://github.com/dart-lang/sdk/issues/39115

Change-Id: Ice9c525b2584940b66e9afe2c593bd41852026c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124207
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-06 19:20:44 +00:00
Brian Wilkerson c6919a6653 Add a test for issue 39254 
Change-Id: I49a4192296f014633baa45e358a0cd7e6283d411
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124208
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-06 18:46:43 +00:00
Konstantin Shcheglov 89dd099cad Update TypeParameterElement.== as discussed, add tests. 
Change-Id: I53e0f36bb3f11875a220f457f4c2205eae8ef2ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-06 18:32:13 +00:00
Sam Rawlins d3f19cf7ae Reland "Enable visibleForTesting on unnamed constructors" 
This is a reland of de7ad46797

Original change's description:
> Enable visibleForTesting on unnamed constructors
> 
> Fixes #37936
> 
> Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: I1ac1dad28dab1b35dcc0a1cd69e64076b758c6a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122591
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-05 19:20:43 +00:00
Mike Fairhurst 7ba5584c2e [analysis_server] Fix outdated desin Service->Server, use Service->Logger. 
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.

Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 21:31:26 +00:00
Konstantin Shcheglov 8119253f64 Include space after comma in FunctionType.toString(). 
R=brianwilkerson@google.com

Change-Id: I6a30f98c11bc85d2c1afb0d86ba40160e11e85e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 19:00:26 +00:00
Konstantin Shcheglov c38dafec6b Issue 39051. Implement isAbstract for ConstructorElement. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39051
Change-Id: I1ed42bd7c95fc3b7a359d9125c4c1eb3ce9f594c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 18:18:56 +00:00
Konstantin Shcheglov abb1a17c89 Include FeatureSet into unlinked API signature. 
R=brianwilkerson@google.com

Change-Id: I3c5898e1500b6a70689ef7068de2b88bae69b90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 18:06:16 +00:00
Sam Rawlins 48d44af154 Report error if inheriting from FutureOr. Fixes #33745 
Change-Id: Ia78892e48c6268d944cfb8f5b4afd25f37c95b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123883
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 16:32:26 +00:00
Konstantin Shcheglov 5a3c4002b8 Replace 'bottom' with 'Never' in subtyping tests. 
Change-Id: I592b2c9ca50d4c320adcc337b667aef4d1ccf644
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 15:08:18 +00:00
Konstantin Shcheglov 2438fe10cb Rename BottomTypeImpl to NeverTypeImpl. 
The corresponding element is Never, and the spec says "the type Never".

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Icb6427ef13fa6ee74bd07d5345e68402a1b90b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-03 19:03:02 +00:00