dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov d74aadd647 Reuse checkGetter() in checkExtension(). 
Change-Id: I356fdc7bc16d0abaaa890e46bb9cce0ae548df16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-30 01:28:10 +00:00
Konstantin Shcheglov f6c7fe278f Implement NullShortableExpressionImpl in MethodInvocationImpl. 
Change-Id: Ifc6eba086fcf3a49aa1d3458d568bfd62a54a94f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133761
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 20:26:10 +00:00
Konstantin Shcheglov b4698ffe72 Issue 39976. Treat UnknownInferredType as top. 
Bug: https://github.com/dart-lang/sdk/issues/39976
Change-Id: Ie14f279323282e3143d5d936e3edc953cebd9ff2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 18:06:26 +00:00
Konstantin Shcheglov e98085fdd8 Issue 40333. Verify types of static getters / setters. 
Bug: https://github.com/dart-lang/sdk/issues/40333
Change-Id: I10f366d4f451a94f8afa7b30cd6daa99073d7eda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 18:05:36 +00:00
Konstantin Shcheglov 4b79594ab4 Update AnalysisDriverResolutionTest for compatibility with unforked SDK. 
Change-Id: I0aca71fae01594d3fba053bff9d53e739c2b65e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 02:37:22 +00:00
Konstantin Shcheglov b3a1f053a3 Issue 40333. Extract GetterSetterTypesVerifier, report GETTER_NOT_SUBTYPE_SETTER_TYPES for NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/40333
Change-Id: I265d535956204644859b05d02dd39a0bfdc8c19a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 02:37:14 +00:00
Konstantin Shcheglov 2bde0e119e Support for searching references to imports when opt-in from opt-out. 
Change-Id: I4b558296cfd1ef17ca7fa03d1551658d2ae6d578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133546
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 21:08:20 +00:00
Konstantin Shcheglov 209e70b2a7 Convert loadLibrary() to legacy when opt-in from opt-out. 
Change-Id: I2834eac5522da3d5e20f54682fe1b7f0c78ea434
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133482
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 21:08:00 +00:00
Konstantin Shcheglov efdd38b0eb Move tests for MISMATCHED_GETTER_AND_SETTER_TYPES. 
Change-Id: I49f0ea4d30fb50be4ecb6b4226081470397d098d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 19:12:08 +00:00
Konstantin Shcheglov 44dff4e24b Issue 40221. NNBD_TOP_MERGE super-interfaces when checking for implementing the same generic class more than once. 
Bug: https://github.com/dart-lang/sdk/issues/40221
Change-Id: I776ee76ced12ec9ab0838f9bac76a3ec9fdb71b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-27 17:12:06 +00:00
Paul Berry 0399fcf6fa Flow analysis: fix shared tests to consider potential nullability instead of nullability. 
No change in functionality.  Just changing the analyzer's
nullability_test.dart so that it generates the `nonNullable`
annotation for a promotion from type parameter `E` to `E&Object`.
This makes it consistent with the front end test runner behavior.

Change-Id: I9b74222257b432e361fbe46aa7d4d7070225a5e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133322
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-01-27 12:43:06 +00:00
Konstantin Shcheglov b6fdba235e Update NORM and type parameters handling to new understanding. 
Change-Id: I5df83667b4016651a15182c22a621eb59c387feb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133410
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-27 00:32:54 +00:00
Brian Wilkerson 7d7643c2ad Add newly reviewed docs and change section header everywhere 
Change-Id: I337fe5764b9167240b42cf75f908a3d36ef08cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133407
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-26 22:56:45 +00:00
Konstantin Shcheglov 21ab021637 Use test Matcher for checking Element(s). 
We have more elements that might be Member(s) because of isLegacy.
So, we need something more sophisticated for checking elements.

Change-Id: Ibbf661571bf56cd4e9bc067adf57e881619ff92a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133325
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 22:21:14 +00:00
Konstantin Shcheglov 318e8556e0 Issue 39917. Test that Never is resolved as Never* in legacy. 
Bug: https://github.com/dart-lang/sdk/issues/39917
Change-Id: Iaa236377b777f25b13fe3072a9b3f3dee4b8f436
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 21:33:34 +00:00
Konstantin Shcheglov 3f12134e60 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for external and native methods. 
Bug: https://github.com/dart-lang/sdk/issues/40287
Change-Id: I3ad4268321c2355573a058ad00c11276bff83796
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133283
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 21:00:44 +00:00
Konstantin Shcheglov ae372d68ee Move old AnalysisDriverResolutionTest to DriverResolutionTest. 
R=brianwilkerson@google.com

Change-Id: I6561c214850a8bdcad282dfec0676f61bea52c8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133321
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-01-24 20:57:43 +00:00
Konstantin Shcheglov 691df73a15 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for abstract methods. 
Opens new issue: https://github.com/dart-lang/co19/issues/516

Bug: https://github.com/dart-lang/sdk/issues/40287
Change-Id: Ifd05e570b8411369cec296db52746ce4f144bbac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 20:19:28 +00:00
pq 8ebe354ecc fix diagnostic messages for named constructors 
Fixes: https://github.com/dart-lang/linter/issues/1986

Change-Id: I67ba3393be48dc39d3bbaaa922542f11b138afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-24 18:50:13 +00:00
Konstantin Shcheglov 3962edccf1 Convert opt-in elements to legacy when resolving annotations. 
Change-Id: Ifc32ec66e9e45dcaa206c662785bb7d4c054b701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133166
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 01:34:11 +00:00
Konstantin Shcheglov c92b3e6f86 Fixes for NORM and FunctionType(s) - type parameters, and covariant formal parameters. 
I think this will fix the issue that required revert of:
https://dart-review.googlesource.com/c/sdk/+/133041

Change-Id: Ib25ea9c9ac9743dee560fb688cd026fa3b3fe6bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 22:44:43 +00:00
Konstantin Shcheglov fb667d2ae4 Revert "Use NNBD_TOP_MERGE to combine signatures of the inherited members." 
This reverts commit 0391d1fc7f.

Reason for revert: Breaks the build: https://ci.chromium.org/p/dart/builders/ci.sandbox/analyzer-nnbd-linux-release/1045

Original change's description:
> Use NNBD_TOP_MERGE to combine signatures of the inherited members.
> 
> Change-Id: I314eac1b9175409e6b2b05afd3b97d44c1156cf8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133041
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I15f73853b39a93fa2038aefea95aa1b364ca3d5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133086
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 18:59:48 +00:00
Konstantin Shcheglov 0391d1fc7f Use NNBD_TOP_MERGE to combine signatures of the inherited members. 
Change-Id: I314eac1b9175409e6b2b05afd3b97d44c1156cf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 17:25:07 +00:00
Konstantin Shcheglov eb271d997f Update NNBD_TOP_MERGE for pending updates to the spec. 
These changes are not yet in the spec, but it seems that we want
them before we can start using NNBD_TOP_MERGE for merging interfaces.

Change-Id: I4ba0f95b169febd05a2cbc1a50edf342227ee217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132971
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 03:35:11 +00:00
Konstantin Shcheglov 582727a4ec Tests for TypeName resolution, fixes for NNBD opt-in/out mixes. 
Change-Id: Ifb119a266306dbdf8a712d3110038179ee3cd7f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132965
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 01:01:00 +00:00
Konstantin Shcheglov 7f2a5b54a4 Support for instantiating opt-in classes from legacy libraries. 
Change-Id: I3cafd51936a4af97d63424d6c8612570d27ac031
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-22 19:58:08 +00:00
Konstantin Shcheglov 02f1244921 Fix reporting of uninitialized field errors after a redirecting constructor. 
Change-Id: I868cec4a09ebdfce271d861b714c2100e812c5c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132808
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
 2020-01-22 19:53:48 +00:00
Sam Rawlins e685ff5131 Move UNDEFINED_{GETTER,METHOD,OPERATOR,SETTER} tests to their own files 
Change-Id: Iaf5049efdbf887f84d7db1444d5ea7d835a2c967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132806
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-22 16:32:08 +00:00
Konstantin Shcheglov 1c56176084 Parse --packages file as package_config.json or .packages, depending on the content. 
Bug: https://github.com/dart-lang/sdk/issues/38554
Bug: https://github.com/dart-lang/sdk/issues/39762
Change-Id: Ibce0cabd75ecbfd3aa4e573418c2127ff7f9687e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-21 23:07:59 +00:00
Konstantin Shcheglov 1478e48ea5 Issue 39833. Report an error when a function typed formal parameter has question and the experiment is not enabled. 
Bug: https://github.com/dart-lang/sdk/issues/39833
Change-Id: I742396890692cef6a5befa58f7717b3971c82257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-21 21:30:19 +00:00
Konstantin Shcheglov 7e0726e077 Fix for asking constant value from a VariableMember. 
Change-Id: If67b0922010b730e887a764383889f0ee3e790c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-18 01:11:47 +00:00
Konstantin Shcheglov 72193714ed Fix await(ing) tests for List/MapLiteral inference. 
R=brianwilkerson@google.com

Change-Id: I13c69d9e3ea3309be9eb266bc6882f05cfa1e17d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 22:28:08 +00:00
Konstantin Shcheglov 58a65fe4ba Issue 40110. Update switchStatement_end() to 'isExhaustive', use for switch on enum in analyzer. 
Bug: https://github.com/dart-lang/sdk/issues/40110
Change-Id: Ic17ab4562f518b7e69b78c3285b577ea3b8d1223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131712
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 22:07:16 +00:00
Konstantin Shcheglov 03432747b9 Fix resolveNameInScope() for import scope. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/linter/issues/1970
Change-Id: I6f3798950d6d20f444e731aea22b2e41516e1081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 20:00:36 +00:00
Konstantin Shcheglov 2d33d4eec9 Re-read condition after resolution, it might be rewritten. 
Bug: https://buganizer.corp.google.com/issues/147866900
Change-Id: I1f18c52a569a813b454893ad02d3263897d4679b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132304
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 18:42:04 +00:00
Konstantin Shcheglov d19b2b0349 Use NullableDereferenceVerifier in resolver instead of ErrorVerifier. 
Change-Id: Ib360bd9091656e04820879052a04e6ee23c495d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132161
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-01-16 22:55:49 +00:00
Konstantin Shcheglov 356fa11349 Extract BoolExpressionVerifier. 
Mostly because it also reports UNCHECKED_USE_OF_NULLABLE_VALUE, and
we want to report it during resolution, to use for migration.

Change-Id: I89f988d9be34a70dfe0e590a5fede2696423c89c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132029
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-16 22:30:18 +00:00
Konstantin Shcheglov 445c0842c7 Use nullable context type for operand of null-check operator. (2) 
Initial: https://dart-review.googlesource.com/c/sdk/+/131343
Reverted: https://dart-review.googlesource.com/c/sdk/+/131461

Bug: https://github.com/dart-lang/sdk/issues/39694
Change-Id: I6287338ce347ddc45d6cc1f3cb16fdccbc75c891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-16 22:30:09 +00:00
Konstantin Shcheglov b94a12b60b Don't flag Never as not available when the non-nullable feature is enabled for the library. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39597
Change-Id: I5865f467a3b5097fb863d172321f60cbe1f5fd44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132023
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-16 18:49:27 +00:00
Konstantin Shcheglov 8c82979b76 Revert "Remove StrongModeCode.IMPLICIT_DYNAMIC codes." 
This reverts commit a3ea61c3d0.

We decided that analyzer should continue to provide this
functionality, at least until we have a better replacement.

Bug: https://github.com/dart-lang/sdk/issues/40129
Change-Id: Idd5ae37a6b8f8d39d374df2b0aaa04d7ee8bf3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131723
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-16 17:37:57 +00:00
Konstantin Shcheglov c0a501ba8d Report LATE_FINAL_LOCAL_ALREADY_ASSIGNED also for prefix / postfix expressions. 
Change-Id: I9c47e0a992b807c18a26af885902d4196fe64772
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131907
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-16 17:28:47 +00:00
Konstantin Shcheglov 6525fc9057 Fix for crash: type 'DefaultParameterElementImpl' is not a subtype of type 'FieldFormalParameterElementImpl' 
#0      ResolutionVisitor.visitFieldFormalParameter (package:analyzer/src/dart/resolver/resolution_visitor.dart:458:7)
#1      FieldFormalParameterImpl.accept (package:analyzer/src/dart/ast/ast.dart:4123:49)
#2      ResolutionVisitor.visitDefaultFormalParameter (package:analyzer/src/dart/resolver/resolution_visitor.dart:370:21)
#3      DefaultFormalParameterImpl.accept (package:analyzer/src/dart/ast/ast.dart:2999:15)
#4      NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7520:20)
#5      FormalParameterListImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:4451:17)
#6      RecursiveAstVisitor.visitFormalParameterList (package:analyzer/dart/ast/visitor.dart:887:10)
#7      FormalParameterListImpl.accept (package:analyzer/src/dart/ast/ast.dart:4447:49)
#8      ResolutionVisitor.visitFunctionExpression.<anonymous closure>.<anonymous closure> (package:analyzer/src/dart/resolver/resolution_visitor.dart:596:25)
#9      ResolutionVisitor._withNameScope (package:analyzer/src/dart/resolver/resolution_visitor.dart:1275:8)
#10     ResolutionVisitor.visitFunctionExpression.<anonymous closure> (package:analyzer/src/dart/resolver/resolution_visitor.dart:591:7)
#11     ResolutionVisitor._withElementHolder (package:analyzer/src/dart/resolver/resolution_visitor.dart:1253:8)
#12     ResolutionVisitor.visitFunctionExpression (package:analyzer/src/dart/resolver/resolution_visitor.dart:590:5)
#13     FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:4969:49)
#14     ResolutionVisitor.visitVariableDeclaration.<anonymous closure>.<anonymous closure> (package:analyzer/src/dart/resolver/resolution_visitor.dart:980:27)
#15     ResolutionVisitor._withElementHolder (package:analyzer/src/dart/resolver/resolution_visitor.dart:1253:8)
#16     ResolutionVisitor.visitVariableDeclaration.<anonymous closure> (package:analyzer/src/dart/resolver/resolution_visitor.dart:979:9)
#17     ResolutionVisitor._withElementWalker (package:analyzer/src/dart/resolver/resolution_visitor.dart:1264:8)
#18     ResolutionVisitor.visitVariableDeclaration (package:analyzer/src/dart/resolver/resolution_visitor.dart:971:7)
#19     VariableDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:10408:49)
#20     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7520:20)
#21     VariableDeclarationListImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:10512:16)
#22     ResolutionVisitor.visitVariableDeclarationList (package:analyzer/src/dart/resolver/resolution_visitor.dart:995:10)
#23     VariableDeclarationListImpl.accept (package:analyzer/src/dart/ast/ast.dart:10506:15)
#24     FieldDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:3993:17)
#25     RecursiveAstVisitor.visitFieldDeclaration (package:analyzer/dart/ast/visitor.dart:857:10)
#26     ResolutionVisitor.visitFieldDeclaration (package:analyzer/src/dart/resolver/resolution_visitor.dart:449:11)
#27     FieldDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:3988:49)
#28     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7520:20)
#29     ResolutionVisitor.visitClassDeclaration.<anonymous closure>.<anonymous closure> (package:analyzer/src/dart/resolver/resolution_visitor.dart:245:22)


Change-Id: I2402751a3b88e9df934a2f6660813826244f827a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-15 21:10:47 +00:00
Konstantin Shcheglov 9ae4849386 Report LATE_FINAL_LOCAL_ALREADY_ASSIGNED. 
Change-Id: Ifa1706b6aecf53ec15578b13a4cc5931fbba3b2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-15 19:28:56 +00:00
Johnni Winther 862d5012ae [cfe] Handle explicit opt-out in nnbd-not-enabled message 
Closes #39835

Change-Id: I4ffa3377289f45b7ea909b5477ba53508040b9d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131076
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-01-15 10:30:43 +00:00
Konstantin Shcheglov c3a2ed9555 Fix failing tests on unittest-asserts-release-win after analyzer Packages change. 
Change-Id: Iec83b5d02d10e3b93f2e1e734bd155189f9ef2d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131780
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-15 03:10:24 +00:00
Konstantin Shcheglov 924f4e0549 Downgrade receiver of type Never to hint. 
Bug: https://github.com/dart-lang/sdk/issues/40057
Change-Id: I49f56b7efa4c88a86fda071c6063b308062784bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-15 01:33:24 +00:00
Konstantin Shcheglov b68f844570 Issue 40057. Fix for Never as setter receiver. 
Bug: https://github.com/dart-lang/sdk/issues/40057
Change-Id: Ia53e01b7aa5e41a80e88b14aabdffc31cbc683b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131706
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-14 21:33:23 +00:00
Konstantin Shcheglov 96cbfb4a2c Issue 39059. Check for minor / major version overflow. 
Bug: https://github.com/dart-lang/sdk/issues/39059
Change-Id: I78a5598b2433d772409a41f7c6e87b32f859c6be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131705
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-14 20:08:13 +00:00
Konstantin Shcheglov d44d7d4573 Extract AssignmentExpressionResolver. 
Change-Id: I9a019ba499a12431955bf9ee45bfe0ae375a52f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131488
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-14 18:08:15 +00:00
Sam Rawlins fe666ce592 Report unused public static members of private classes 
Also of private mixins, enums, and extensions.

Fixes #39988

Change-Id: I646205cba64da1a9837585a5af2c4c2b8d41824c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129860
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-14 06:09:04 +00:00