dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Brian Wilkerson 60a81b0f51 Add hints to find equal elements in literal sets and maps 
Change-Id: Ib930b49b338d7cb088b17909991934b16c4f1538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-06 14:22:44 +00:00
Konstantin Shcheglov ce7fcff2ea Resolve type parameters to bounds when checking for implementing Iterable / Map. 
R=brianwilkerson@google.com

Change-Id: Ifdb8fe73cbe731bfe5e3ea130f846fabfc1ce07f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-06 02:36:21 +00:00
Brian Wilkerson ced0ceddd3 Rename an incorrectly named test class 
Change-Id: I40cdb290cea7beaffa68d5f21f1e340e7086a857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138603
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-05 20:06:29 +00:00
Konstantin Shcheglov 5e66618175 Issue 40316. Verify only language version override locations at line starts. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I932fd9aa5a516096c11b605b16c9f674098cdc21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 19:18:29 +00:00
Konstantin Shcheglov 110a29c9b3 Issue 40704. Support for ?[ in resolution. 
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Iaa4680e65a44c83bdc6a3ae826cc510b685a7ccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 18:59:34 +00:00
Konstantin Shcheglov 72acbc18e6 Issue 40316. Report hint if @dart language version override is not before any declartion. 
Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I787df83020835f930e21dd772faa848d375a8a78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138388
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 23:32:13 +00:00
Konstantin Shcheglov 285cce47e1 When implicit casts are disabled, report it also for for-each. 
Internal presubmit looks green.
https://test.corp.google.com/ui#id=OCL:298910526:BASE:298911322:1583359564045:f2c3047c

Change-Id: I548b1d439ecc9cbb7f0924087fa9cab158022bb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 22:43:33 +00:00
Konstantin Shcheglov d3fd44182d Fix crash in declaredParameterElement(). 
R=brianwilkerson@google.com

Bug: b/150742402
Change-Id: Ia72179f934579f1eb6861bf8b6cc955168e10136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 19:42:16 +00:00
Konstantin Shcheglov f67cc65ecb Update tests and error code for void with type arguments. 
R=brianwilkerson@google.com

Change-Id: I82c8c61bce2d841e06724d1d41dc10cac6f0c304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 18:53:37 +00:00
Konstantin Shcheglov 27c50aeb86 Implement factor() operation from flow analysis. 
Change-Id: If2e23c3b850974d9190b90b287b811baf3121739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 17:01:55 +00:00
Konstantin Shcheglov 81bc629582 Use packageDefaultFeatureSet when the language version is the same as the current version. 
Change-Id: I14862603d4204b879cd2b0f950d75a98dd347419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 17:01:35 +00:00
Konstantin Shcheglov 1f92f1d903 Issue 40865. Fix for parsing documentation comment of an annotatied EnumConstantDeclaration. 
Bug: https://github.com/dart-lang/sdk/issues/40865
Change-Id: Ida37b7140d8f2366d0f8c6d7e073f0ef92d95369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138246
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 16:18:15 +00:00
Jens Johansen f828f00b59 [parser] Error recovery of type parameters on void 
Fixes #39958.

Change-Id: I851bef762776f4b68f0fcb645d634019b8b32e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-04 14:02:35 +00:00
Paul Berry 794f70a044 Add currentVersion to experiments.g.dart code generated output. 
Change-Id: I0ea91aaeb34068d25c07b61b0a432d24af0dd59a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138104
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-03 19:25:44 +00:00
Brian Wilkerson 131502d752 Unify two error codes and improve the messages 
Change-Id: Ic3be0dfeadce045c051304be5331a1828202d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-03 17:53:11 +00:00
Johnni Winther 101588f0f4 [cfe] Implement legacy top merge functionality 
+ fix getter/setter type inference

Change-Id: I9a4bed2b6a53131cbc9946bac0a01a4b15a63a91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137922
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-03 12:19:09 +00:00
Jens Johansen 47d462e8b1 [parser] Better handling of nullable types vs conditional expressions 
Fixes #40834

Change-Id: I2fdad5a383c1873b1dd782b70e2f1e3ab8664b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137960
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-03-03 09:49:57 +00:00
Sam Rawlins e687b62ffe Improve recovery on yield not-in generator; Improves #32967 
Fix is inspired by very similar recover for `await` in synchronous
function, like `looksLikeAwaitExpression` and `endInvalidAwaitExpression`.

Change-Id: I50bf0c1e73c31551b94de29d78fd3d449c30fd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136920
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-03-02 17:29:22 +00:00
Konstantin Shcheglov 860dca93ea Fix crash when reporting REDIRECT_TO_NON_CONST_CONSTRUCTOR for unnamed constructor. 
Another crash from internal crash logs.

R=brianwilkerson@google.com

Change-Id: I91cce6c968ba9641b55a4e77f63f34ad70cdca4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-01 21:42:02 +00:00
Konstantin Shcheglov 7f483c067c Set TypeName type of unresolved class with prefixed identifier in instance creation. 
It was crashing prefer_void_to_null lint.

R=brianwilkerson@google.com

Change-Id: Ie9301d53267f264907ecc9e84d0c9252532172e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-29 00:24:50 +00:00
Konstantin Shcheglov 34fcc56458 Fix for renaming named formal parameters from invocations, when synthetic. 
R=brianwilkerson@google.com

Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 23:11:00 +00:00
Brian Wilkerson 831ebedecf Unify the two variants of the unnecessary-type-check hint 
Change-Id: I2c1f1f6c3a1ea4828e951bee6f4d34a14ccf0e29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137733
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 19:41:24 +00:00
Konstantin Shcheglov 6a9987838f Issue 38990. Fix for function typed formal parameters, trailing question, endToken. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/38990
Change-Id: Iaf58a6588f5098168f59edba1c82397dcf7077ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137736
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 19:10:06 +00:00
Brian Wilkerson 4dad6d77ba Minor test cleanup 
I'd like the diagnostic tests to be organized by "name" rather than by
"unique id" because I think it will make it easier to find the tests
when we get reports from users (who only see the name, not the unique id).

Change-Id: Ia5878f499d789c085d406c8ada5f7022da5bde7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137732
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-28 17:26:49 +00:00
Konstantin Shcheglov ced8d66d25 Report HintCode.DEAD_NULL_CONDITION_FALSE/TRUE for non-nullable compared with null literal. 
Change-Id: Iac41f17e6e41f5e99e2291889456db64f6f2c7ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-28 01:58:33 +00:00
Konstantin Shcheglov fabe842b8d Issue 39939. Fix for-in when iterable is Never. 
Bug: https://github.com/dart-lang/sdk/issues/39939
Change-Id: I83a0c8a0d3b2bed1859f064d71c9c70a19497919
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-27 21:37:43 +00:00
Konstantin Shcheglov c9884ccf52 Analyze SDK with non-nullable experiment enabled, update MockSdk. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/134401
Reverted: https://dart-review.googlesource.com/c/sdk/+/134802

Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:294345942:BASE:297377939:1582738004318:fb4ae9fe

Change-Id: I25e6445bd0241a89850dff3d88ece0edd768053a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 21:08:21 +00:00
Konstantin Shcheglov 118d220bfa Remove unused SdkPatcher. 
Change-Id: I9ce49a8713e528b3376fc447d3b053c8e2b1087d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 20:20:31 +00:00
Konstantin Shcheglov 0c7b9cf470 Issue 40764. Use Never instead of Null when converting super-bounded to regular-bounded. 
Bug: https://github.com/dart-lang/sdk/issues/40764
Change-Id: I58f0e9860dd000aa2d8e416c5fce7e8964db0ef8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-26 20:12:51 +00:00
Devon Carew 9eeecae3e4 address a few static analysis nits 
Change-Id: I461c71550e320ed9f520169bcdbd4083f58b3db3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137323
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-02-26 20:04:51 +00:00
Konstantin Shcheglov 5940821f4e Issue 37487. Add CompilationUnit.languageVersion override. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/136802
Reverted: https://dart-review.googlesource.com/c/sdk/+/136851

Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: Ida3bf049840e7bda32ecdd54309ea0b141aa6800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 18:08:07 +00:00
Konstantin Shcheglov 8010b7d4c7 Issue 40677. Report NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD when no generative constructors. 
Bug: https://github.com/dart-lang/sdk/issues/40677
Change-Id: Ibea667e5bc70de32e464c74f04995d01aa4821f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 17:20:16 +00:00
Jens Johansen 3660b9ecc7 [parser] New syntax for null aware index (2nd try) 
This reverts commit bc4893a3b3.

The previous attempt failed because when we check if something is a
conditional expression we used a rewriter that didn't actually rewrite.
This further down the line (still checking if we can parse the expression)
results in errors occurring (that wouldn't have occurred if the rewrite
had happened) and the conclusion was thus that it wasn't a conditional
expression and we parsed it as a null-aware index operator (which gave
errors because it wasn't).

This 2nd try solves it by having a rewriter that actually rewrites,
but then allows to undo the rewrites after we're done parsing.

Change-Id: Ide3c0d6a870d4dc18b6d9475b0227d93c733dc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136624
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 13:31:52 +00:00
Konstantin Shcheglov 8726b35711 Issue 40413. Don't infer promoted TypeParameterType(s) for locals. 
Internal presubmit looks green.
https://test.corp.google.com/ui#id=OCL:295832949:BASE:295984425:1582132722046:8eaca57b

Bug: https://github.com/dart-lang/sdk/issues/40413
Change-Id: I8514f6e1a99c4b02098cc649607cf31c5daf350f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 01:10:14 +00:00
Paul Berry b0b06bff31 Revert "Issue 37487. Add CompilationUnit.languageVersion override." 
Reason for revert: it was a breaking change to the analyzer public API.

There were two breakages:

- A @required `languageVersion` parameter was added to
  AstFactory.compilationUnit, which is part of the officially
  supported analyzer public API.

- A @required `languageVersion` parameter was added to the Parser
  constructor, which is not part of the officially supported analyzer
  public API, but is part of its de facto public API due to the fact
  that it is used by dart_style.

This reverts commit ce26dfda7d.

Change-Id: I507103ea6f6ffabf915d6f56e9f24454725c3930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136851
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-25 04:39:10 +00:00
Konstantin Shcheglov 07144ef876 Fix top-level inference with ForElement and NNBD. 
Change-Id: I7b656ad4af600a82ec13f007dbad3465cd502a3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137020
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-25 04:29:00 +00:00
Konstantin Shcheglov a473c22755 Fix driver_test on Windows. 
TBR

R=brianwilkerson@google.com

Change-Id: Id4fc4c4eba69c16759475e1ee64ab5c8cc3c2460
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136847
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-25 01:06:54 +00:00
Johnni Winther a9162bd599 [analyzer,cfe] Implement mixed inheritance id test for analyzer 
Change-Id: Ie4ce09b83c2a96a5ad16c60d2924f18cd90a4089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136633
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-24 13:28:26 +00:00
Konstantin Shcheglov ce5fb94014 Issue 40538. Revert YieldStatement changes after reverting language spec decision. 
Bug: https://github.com/dart-lang/sdk/issues/40538
Change-Id: Idd563a15dc1e17e1271f823c33d015c73f720874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136814
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-23 21:32:44 +00:00
Brian Wilkerson cc45c9358b Rename another diagnostic code 
The diagnostic applies to both the if-null expression ('??') and the
compound assignment expression ('??='), so it seems like the name should
be more general.

Change-Id: I004cc2924ef97fcbd2168f070380ff17152cbb0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-23 17:11:24 +00:00
Konstantin Shcheglov 732cd81f05 Move expectedErrorsByNullability / typeStringByNullability to ResolutionTest mixin. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9ee6cf8ab8d06bc02ee4a52a6d7e5b63d277e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136810
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 21:59:35 +00:00
Konstantin Shcheglov bc2c4181c1 Issue 40734. Allow multi-digit major / minor language version components. 
Bug: https://github.com/dart-lang/sdk/issues/40734
Change-Id: Ic88082ba0ee86986e92c0944a93c0b299a1c825f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 21:38:40 +00:00
Konstantin Shcheglov ce26dfda7d Issue 37487. Add CompilationUnit.languageVersion override. 
Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: I57fbcdd6771d9004ba1fc43902c19514dab2a23d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 20:19:43 +00:00
Konstantin Shcheglov c09e6c18b7 Issue 40538. Verify yield statements using new element type based rules. 
Bug: https://github.com/dart-lang/sdk/issues/40538
Change-Id: I9feaca0484f7a5c779068e823bbd765f5c06fe59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136712
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 19:26:27 +00:00
Brian Wilkerson 33e6f4af33 Rename a diagnostic code 
Change-Id: I0b712af35d4a904bd0507b63ca52595cfcc7de2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136728
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 18:34:20 +00:00
Johnni Winther 5829fc7829 [analyzer,cfe,dart2js] Add marker.options files to automate running id tests on all configurations 
Change-Id: Ib5eb7f3967634721047f8dcc57b9e6c350b91a41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136226
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-02-21 08:34:26 +00:00
Konstantin Shcheglov a248f88e8e Extract YieldStatementResolver. 
Change-Id: I1e7c60dac6d97152fc8e3a463bc2f66274ed4f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-20 19:53:45 +00:00
Konstantin Shcheglov 561039dd9e Extract YIELD_OF_INVALID_TYPE tests. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3f57f8d64e08312006ba3cdb81166453d91c867e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136704
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-20 19:02:10 +00:00
Keerti Parthasarathy 67e42b611c Add a resolver for resolution of a single file. 
Change-Id: Ibe7062942db8d921c8305a5ab7fd5bd0f9667773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136409
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-20 16:06:39 +00:00
Jens Johansen bc4893a3b3 Revert "[parser] New syntax for null aware index" 
This reverts commit cf4e044e07.

Reason for revert: Breaks internal customer.

Original change's description:
> [parser] New syntax for null aware index
> 
> Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903
> Commit-Queue: Jens Johansen <jensj@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,jensj@google.com,johnniwinther@google.com

Change-Id: Ic0ff607c944e489f29bda7da37afd63c62d368eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136600
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-02-20 14:11:08 +00:00