dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8489 Commits

Author SHA1 Message Date
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 23a8788f6a Issue 41378. Update on-catch and throw for the spec changes. 
Now it is not an error to use a potentially nullable type in on-catch.

But it is an error for throw an expression of type that is not
assignable to Object.

Bug: https://github.com/dart-lang/sdk/issues/41378
Change-Id: If0a198ae618cd01d03f45a46aa1efa6179df76ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-11 20:08:03 +00:00
Konstantin Shcheglov 89b0f67261 Implement InterfaceType.asInstanceOf() using allSupertypes. 
Change-Id: I2e67f68dd924d1abc9718f5e822980692ce47408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-11 18:39:53 +00:00
Sam Rawlins 5ddea4b8f6 analyzer: Fix analyzer crash when spreading a mixin 
Fixes #41424

Change-Id: I2093b02d325f1593f36c4752dd665601d6d0422c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-10 23:50:12 +00:00
Sam Rawlins 2c420267b7 analyzer: Do not allow errors to be ignored inline. Fixes #27218 
Change-Id: If37dabba3ec18a9f79f44c4ea38d6920a4013019
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-04-10 17:16:24 +00:00
Konstantin Shcheglov 450ae848f6 Applying a mixin replaces corresponding names in the interface. 
Change-Id: I5e2ada71af50aa580f5d236773ccb122fca5591c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:57:44 +00:00
Konstantin Shcheglov 516f297d87 Generator function bodies don't need a return. 
This should fix:
language/async_star/yield_expressions_test

Change-Id: Ifa1dc86f442ca36b292a587d67a208fc15d370dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143011
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:07:34 +00:00
Konstantin Shcheglov fa3a4eb956 Update TOP_MERGE according to the spec change. 
Bug: https://github.com/dart-lang/sdk/issues/41412
Change-Id: If61638188e594cb1b4272e0011ff0ebd5dbb2772
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-09 16:28:09 +00:00
Sam Rawlins 38be00f971 analyzer: Do not mark any enum values as unused if the values accessor is accessed 
Fixes #41377

Change-Id: I8c3c03c033a18c6770ab7fbe00435eccb747fb49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-09 15:51:49 +00:00
Konstantin Shcheglov f557fbd943 Support for TypedLiteral in LinterContext.canBeConst(). 
Bug: https://github.com/dart-lang/linter/issues/2058
Change-Id: I8a037cec8d0b3488733f8cb34eddb3ff2cce5600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142907
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 22:04:15 +00:00
Konstantin Shcheglov bcdfdeb280 Issue 41399. Check for 'dynamic' and 'Never' when verifying EXPORT_LEGACY_SYMBOL. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/41399
Change-Id: I7d36c16085bed80460269f477dcb13fdddfd8603
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 17:18:53 +00:00
Konstantin Shcheglov 4d8a98d18c Make all named parameters of BestPracticesVerifier required. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/153520946
Change-Id: I67c7554944283d8626b05f911b96b51fc4ea8cc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 17:00:45 +00:00
Konstantin Shcheglov d43eb2b368 Support for analysis options in FileResolver. 
Change-Id: Ifaebeaf87abdac0260c0084090c39d64c699585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142821
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-08 16:19:15 +00:00
Konstantin Shcheglov 842d1ceff0 Remove the special case for getGreatestLowerBound() in inference. 
Change-Id: Iac50b8eede9b66bf329680aa2891816f4fb76cef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142807
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 15:54:03 +00:00
Konstantin Shcheglov ed38c78397 Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETE for external factory constructors. 
See https://dart-review.googlesource.com/c/sdk/+/142555 for the context.

Change-Id: I0d20c7ef40f6e59e184a2891b061d82492329545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 15:53:24 +00:00
Konstantin Shcheglov 2d47db7424 Improve DOWN for FutureOr vs. FutureOr or Future. 
https://github.com/dart-lang/language/pull/903
https://github.com/dart-lang/sdk/issues/41363

Change-Id: Ieedd4468bbf44b2fec9abba22955eac9b8905a24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:35:21 +00:00
Konstantin Shcheglov fa66c73fea Implement hasTypeParameterReference using RecursiveTypeVisitor. 
Change-Id: I351f2b03e1866a15528ed781689e2c894a20d466
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:27:36 +00:00
Konstantin Shcheglov 696c655140 Remove disableConflictingGenericsCheck flag. 
Change-Id: I994b59131e362c55e388e75a5f5cef04ec1b5cd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:27:16 +00:00
Sam Rawlins 8886230803 Format analyzer's mock SDK code 
Change-Id: Id7e4d84414a85e3d5301453456bb4b90d192508c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142563
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-07 18:00:56 +00:00
Sam Rawlins a31781f737 Add Window and DocumentFragment to analyzer's mock SDK. 
These are required for upcoming changes to the unsafe_html lint.

Change-Id: I71018e3702b4c1e88b4b5071a150ad5b8ed99304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142560
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 17:29:06 +00:00
Konstantin Shcheglov 91b581fb2c Fix LinterContext().canBeConst() - compute dependencies. 
Change-Id: Ibcf08f79a9990ca714dd69a0dd0cc856e99335c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 16:38:34 +00:00
Konstantin Shcheglov dcdc71d763 Report CONFLICTING_GENERIC_INTERFACES using ClassHierarchy. 
Change-Id: Ib5d79403358efffd5365ac4931c3163d746d933a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142567
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 15:50:28 +00:00
Konstantin Shcheglov 8a8c2e74d2 Update constants_2018/constant_types_test to allow type parameters in 'as'. 
Change-Id: I37b0413914d6677e2be53fb0ce98c51f81694edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142568
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-07 06:50:28 +00:00
Konstantin Shcheglov 92f6b03513 Update ClassHierarchy for legacy support, record errors. 
Change-Id: I6a07a750293fa0a16c5b101142e023c8105a85aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-06 23:07:37 +00:00
Konstantin Shcheglov 0bb6143f17 Clear class hierarchies to reduce memory consumption. 
Hopefully this will improve the memory usage benchmark.

Change-Id: I7d79153a77a03926f850ca7130ecbcfa24277f4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 19:23:34 +00:00
Konstantin Shcheglov e5e9bc74db Allow potentially constant type expression in 'as'. 
Change-Id: I6790816daa0c02dd3d12ffd4aba00f514bf03922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 17:06:14 +00:00
Konstantin Shcheglov bac08fb339 Implement interfaces subtyping check using allSupertypes. 
Change-Id: I43a4b98bae913895c7e176dd24a17fc5df7666e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 00:20:10 +00:00
Konstantin Shcheglov 806ff47b0f Match InterfaceType(s) using allSupertypes. 
Change-Id: I6694f4c4c0df74dd1d7c1bc9f00792bc419c83bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-04 00:06:27 +00:00
Konstantin Shcheglov be76b03b1a Update MockSdkElements to create only migrated SDK. 
Also update TestAnalysisContext to set AnalysisSessionImpl.

R=brianwilkerson@google.com

Change-Id: I21aafdc602ab049280c199b990ec9df5563fa494
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-03 17:08:07 +00:00
Jens Johansen b93f3dd3a7 [analyzer] Fix crash with _OperatorName in Constructor 
Parser recovery was recently changed so the name in a Constructor can
(again --- this was a bug that was previously semi-fixed) be
_OperatorName because everything with initializers gets recovered as a
constructor.
This fixes the analyzer crash caused by that.

Change-Id: Idc62d1a6f17b671476df051a0b5f3c2d1246c920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-03 06:32:31 +00:00
Konstantin Shcheglov 1ad0ee1444 Infer when nullable type parameter type. 
R=brianwilkerson@google.com

Change-Id: Ifd59905c25cbe979d1c7090e92159124c9fa2ef4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142207
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 21:11:19 +00:00
Konstantin Shcheglov afab7d6652 Remove unused TypeComparison. 
R=brianwilkerson@google.com

Change-Id: I02941aa828feb2c7748a29057e01b8df6e5b496f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142091
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 15:46:05 +00:00
Johnni Winther fae35fca47 [cfe] Handle potentially constant type expressions in CFE 
Closes #41305

Change-Id: Ibb839c5b6619ae2f7e90cc956c7de20d8c76ae3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142120
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-02 13:23:04 +00:00
Konstantin Shcheglov 191be51124 Extract GenericInferrer and type schema. 
Change-Id: Ic306342609911e3e232dbf95f30b60cff94c34be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 20:54:48 +00:00
Konstantin Shcheglov 43115b0f75 Extract SubtypeHelper. 
Change-Id: I6534e68e71108db2dbdca36897694179ec218cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141902
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-01 18:46:38 +00:00
Konstantin Shcheglov cf5620fa9e Use the deep-most packages. 
Change-Id: I8c03e67d16a58f48e0ac334c216b21dcf2e532c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:42:52 +00:00
Konstantin Shcheglov 0e5b596e0d Extract GreatestLowerBoundHelper and LeastUpperBoundHelper. 
Change-Id: I1e10798d2dfe231ab5e6fb87a5eed42e81e43998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:41:42 +00:00
Johnni Winther d68f552e70 [analyzer,cfe] Handle (un)assigned state in try-statement 
This handles (un)assigned state in try-statement that do not
complete normally. In this case we could create a variable model
for an unreachable state that would be both assigned and unassigned
leading to an assertion failure.

Closes #41284

Change-Id: Id4c7689bc7c614338af3542eb342c964696fca1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141981
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:46:15 +00:00
Konstantin Shcheglov 37773d39be Make 'covariant' parameter required in tryMatchSubtypeOf(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7a30e886c8fe2abdc5402d0d9da283cdd8f32c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:36:45 +00:00
Mike Fairhurst 5999b6bad5 Reland "[analyzer] Remove deprecated language version API" 
This is a reland of 65a377b967

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I1c5180fcc40b14b4bcc209e0b6b9bc053814047d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141720
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-03-31 18:41:50 +00:00
Konstantin Shcheglov e8c4aed700 Remove implementedForMixing from inheritance manager. 
Change-Id: I4f698e1210d86e7c3d168e99b69aea0c075cc10e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-31 15:59:55 +00:00
Konstantin Shcheglov fb4b59e043 Deprecate isProxy / isOrInheritsProxy in ClassElement. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ied4011961d4dece33d527888d274893985d85f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141767
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:27:39 +00:00
Konstantin Shcheglov 9864a9532a Set dynamic resolution for super MethodInvocation in invalid context. 
Every MethodInvocation should be resolved, even if to dynamic.
Leaving it undersolved caused NPEs later.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I43ad2889639684ecaecf3810127213f69765a271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:25:49 +00:00
Konstantin Shcheglov 44b6f02985 Revert "Fix the result type of binary expression with the left TypeParameter extends num type." 
This reverts commit 35ebf66c6a.

Reason for revert: This change is not supported by the specification.

Original change's description:
> Fix the result type of binary expression with the left TypeParameter extends num type.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I84e90001d97f95dc729072d4dfa54a9bb53ab002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 16:35:56 +00:00
Keerti Parthasarathy 1364488dce Add guard code for exceptions from ResourceProvider when reading contents. 
Change-Id: I5deb050874c0f0c665777b365cfac59425fb1e76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141440
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 02:32:54 +00:00
Konstantin Shcheglov 35ebf66c6a Fix the result type of binary expression with the left TypeParameter extends num type. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-29 04:09:23 +00:00
Brian Wilkerson 9d5fcfc7e7 Remove an unused variable in AstBuilder 
Change-Id: I3497a21b78797abcebc03a59a44176a5fd78588b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141469
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:23 +00:00
Konstantin Shcheglov 1807cf2030 Add LibraryElement.languageVersionMajor/Minor 
Change-Id: I33d2acb269381abf4f26aad0abe4e1feb2435931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141464
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:01:08 +00:00
Konstantin Shcheglov 9ba1dc4e56 Report exceptions with the file content for getResult(). 
We report the exception to the caller via Future, but it is still
useful to report it into the exceptions stream with additional data.

R=brianwilkerson@google.com

Change-Id: I89bce59986b5df35072460e2bc36eaefc170fa98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 16:53:25 +00:00
Konstantin Shcheglov ea9df6827e Fix crash in index when the invoked element is multiply defined. 
Saw this in crash reports.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib2052c8d17abcd0194d75eae43f9f0df37d123db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 16:53:03 +00:00