dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8489 Commits

Author SHA1 Message Date
Konstantin Shcheglov f5a6554635 Move 'thisType' to ResolverVisitor. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/40932
Change-Id: Ie0fd3554fcb1f8baa3944bd6805ac72f0b76da61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-10 15:50:20 +00:00
Konstantin Shcheglov 83378633e1 Add the attachment with the content of the file being analyzed. 
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 04:57:20 +00:00
Konstantin Shcheglov bbb449dfa4 Issue 40931. Update inference constraint for T? to be non-nullable. 
Bug: https://github.com/dart-lang/sdk/issues/40931
Change-Id: I483c3febad236b366f911f38339c712dd928cfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-10 02:19:50 +00:00
Keerti Parthasarathy 8329bd7ca8 Do not check for '.analysis_options' for default options file in builder. 
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-09 19:31:24 +00:00
Konstantin Shcheglov 24c8021f03 Replace initialize() with declare(). 
Fixes https://github.com/dart-lang/sdk/issues/38791

Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-09 18:24:51 +00:00
Brian Wilkerson a629dbf073 Add a fix to inline a typedef 
I needed to fix AST nodes for parameters to know about the required
token when computing the beginning token and child entities.

Change-Id: Icb0fc27bc1e9f6650376f5870944fb8f592a5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138744
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-09 14:17:07 +00:00
Brian Wilkerson e79f50098e Unify two error codes into one 
Change-Id: I955298756a7e8aa7094cc36e7b2846aac3d785db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138323
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-06 17:25:10 +00:00
Brian Wilkerson 60a81b0f51 Add hints to find equal elements in literal sets and maps 
Change-Id: Ib930b49b338d7cb088b17909991934b16c4f1538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-06 14:22:44 +00:00
Konstantin Shcheglov ce7fcff2ea Resolve type parameters to bounds when checking for implementing Iterable / Map. 
R=brianwilkerson@google.com

Change-Id: Ifdb8fe73cbe731bfe5e3ea130f846fabfc1ce07f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-06 02:36:21 +00:00
Konstantin Shcheglov 5e66618175 Issue 40316. Verify only language version override locations at line starts. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I932fd9aa5a516096c11b605b16c9f674098cdc21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 19:18:29 +00:00
Konstantin Shcheglov 110a29c9b3 Issue 40704. Support for ?[ in resolution. 
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Iaa4680e65a44c83bdc6a3ae826cc510b685a7ccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 18:59:34 +00:00
Konstantin Shcheglov 0649115b06 Rename VoidWithTypeParameters to VoidWithTypeArguments. 
Change-Id: I5df6a49f0b27b6edfe2ce0f677d5f898900d8384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 17:31:34 +00:00
Konstantin Shcheglov 72acbc18e6 Issue 40316. Report hint if @dart language version override is not before any declartion. 
Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I787df83020835f930e21dd772faa848d375a8a78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138388
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 23:32:13 +00:00
Konstantin Shcheglov 285cce47e1 When implicit casts are disabled, report it also for for-each. 
Internal presubmit looks green.
https://test.corp.google.com/ui#id=OCL:298910526:BASE:298911322:1583359564045:f2c3047c

Change-Id: I548b1d439ecc9cbb7f0924087fa9cab158022bb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 22:43:33 +00:00
Konstantin Shcheglov d3fd44182d Fix crash in declaredParameterElement(). 
R=brianwilkerson@google.com

Bug: b/150742402
Change-Id: Ia72179f934579f1eb6861bf8b6cc955168e10136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 19:42:16 +00:00
Konstantin Shcheglov f67cc65ecb Update tests and error code for void with type arguments. 
R=brianwilkerson@google.com

Change-Id: I82c8c61bce2d841e06724d1d41dc10cac6f0c304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 18:53:37 +00:00
Konstantin Shcheglov 27c50aeb86 Implement factor() operation from flow analysis. 
Change-Id: If2e23c3b850974d9190b90b287b811baf3121739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 17:01:55 +00:00
Konstantin Shcheglov 81bc629582 Use packageDefaultFeatureSet when the language version is the same as the current version. 
Change-Id: I14862603d4204b879cd2b0f950d75a98dd347419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 17:01:35 +00:00
Konstantin Shcheglov 1f92f1d903 Issue 40865. Fix for parsing documentation comment of an annotatied EnumConstantDeclaration. 
Bug: https://github.com/dart-lang/sdk/issues/40865
Change-Id: Ida37b7140d8f2366d0f8c6d7e073f0ef92d95369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138246
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 16:18:15 +00:00
Konstantin Shcheglov fb547fcb28 Log data to debug crash in declaredParameterElement(). 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I7f0ed393177adc9711560d8ea9ecfd2f57bd1217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 15:38:00 +00:00
Jens Johansen f828f00b59 [parser] Error recovery of type parameters on void 
Fixes #39958.

Change-Id: I851bef762776f4b68f0fcb645d634019b8b32e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-04 14:02:35 +00:00
Paul Berry 794f70a044 Add currentVersion to experiments.g.dart code generated output. 
Change-Id: I0ea91aaeb34068d25c07b61b0a432d24af0dd59a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138104
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-03 19:25:44 +00:00
Brian Wilkerson 131502d752 Unify two error codes and improve the messages 
Change-Id: Ic3be0dfeadce045c051304be5331a1828202d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-03 17:53:11 +00:00
Sam Rawlins e687b62ffe Improve recovery on yield not-in generator; Improves #32967 
Fix is inspired by very similar recover for `await` in synchronous
function, like `looksLikeAwaitExpression` and `endInvalidAwaitExpression`.

Change-Id: I50bf0c1e73c31551b94de29d78fd3d449c30fd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136920
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-03-02 17:29:22 +00:00
Konstantin Shcheglov 860dca93ea Fix crash when reporting REDIRECT_TO_NON_CONST_CONSTRUCTOR for unnamed constructor. 
Another crash from internal crash logs.

R=brianwilkerson@google.com

Change-Id: I91cce6c968ba9641b55a4e77f63f34ad70cdca4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-01 21:42:02 +00:00
Konstantin Shcheglov 7f483c067c Set TypeName type of unresolved class with prefixed identifier in instance creation. 
It was crashing prefer_void_to_null lint.

R=brianwilkerson@google.com

Change-Id: Ie9301d53267f264907ecc9e84d0c9252532172e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-29 00:24:50 +00:00
Konstantin Shcheglov 34fcc56458 Fix for renaming named formal parameters from invocations, when synthetic. 
R=brianwilkerson@google.com

Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 23:11:00 +00:00
Brian Wilkerson 831ebedecf Unify the two variants of the unnecessary-type-check hint 
Change-Id: I2c1f1f6c3a1ea4828e951bee6f4d34a14ccf0e29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137733
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 19:41:24 +00:00
Konstantin Shcheglov 6a9987838f Issue 38990. Fix for function typed formal parameters, trailing question, endToken. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/38990
Change-Id: Iaf58a6588f5098168f59edba1c82397dcf7077ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137736
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 19:10:06 +00:00
Brian Wilkerson 4dad6d77ba Minor test cleanup 
I'd like the diagnostic tests to be organized by "name" rather than by
"unique id" because I think it will make it easier to find the tests
when we get reports from users (who only see the name, not the unique id).

Change-Id: Ia5878f499d789c085d406c8ada5f7022da5bde7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137732
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-28 17:26:49 +00:00
Konstantin Shcheglov 001db5d669 Extract shared code for resolving ForEachParts and ForParts. 
Change-Id: I3b38174aab90faaf3a563567e6e862dd38a3d186
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137729
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 15:30:12 +00:00
Konstantin Shcheglov c790e0c401 Extract ForResolver. 
Change-Id: I633b58d4dc73ccddce43bb13dfabde166b0f7189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137656
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 02:49:04 +00:00
Konstantin Shcheglov ced8d66d25 Report HintCode.DEAD_NULL_CONDITION_FALSE/TRUE for non-nullable compared with null literal. 
Change-Id: Iac41f17e6e41f5e99e2291889456db64f6f2c7ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-28 01:58:33 +00:00
Konstantin Shcheglov fabe842b8d Issue 39939. Fix for-in when iterable is Never. 
Bug: https://github.com/dart-lang/sdk/issues/39939
Change-Id: I83a0c8a0d3b2bed1859f064d71c9c70a19497919
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-27 21:37:43 +00:00
Konstantin Shcheglov 9e4000e44b Issue 40603. Update MockSdk to stop returning null from factories. 
Bug: https://github.com/dart-lang/sdk/issues/40603
Change-Id: Id1060773d303527424bde02785a5c21651df4c85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-27 00:47:06 +00:00
Konstantin Shcheglov 5540c9551e Use parseString() in analyzer. 
R=brianwilkerson@google.com

Change-Id: I1f78cf994d71acf810c9e8fc1682628a8366da22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 23:00:27 +00:00
Konstantin Shcheglov c9884ccf52 Analyze SDK with non-nullable experiment enabled, update MockSdk. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/134401
Reverted: https://dart-review.googlesource.com/c/sdk/+/134802

Internal presubmit is green.
https://test.corp.google.com/ui#id=OCL:294345942:BASE:297377939:1582738004318:fb4ae9fe

Change-Id: I25e6445bd0241a89850dff3d88ece0edd768053a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 21:08:21 +00:00
Konstantin Shcheglov 118d220bfa Remove unused SdkPatcher. 
Change-Id: I9ce49a8713e528b3376fc447d3b053c8e2b1087d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 20:20:31 +00:00
Konstantin Shcheglov 0c7b9cf470 Issue 40764. Use Never instead of Null when converting super-bounded to regular-bounded. 
Bug: https://github.com/dart-lang/sdk/issues/40764
Change-Id: I58f0e9860dd000aa2d8e416c5fce7e8964db0ef8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-26 20:12:51 +00:00
Brian Wilkerson 6ed6a11f9b AST support for the null aware index operator 
I think this also includes the necessary changes to the summary format.

Change-Id: I12bb28d5579f05d7026d0778e847380425e90b3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137252
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 19:30:11 +00:00
Konstantin Shcheglov 5940821f4e Issue 37487. Add CompilationUnit.languageVersion override. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/136802
Reverted: https://dart-review.googlesource.com/c/sdk/+/136851

Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: Ida3bf049840e7bda32ecdd54309ea0b141aa6800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 18:08:07 +00:00
Konstantin Shcheglov 8010b7d4c7 Issue 40677. Report NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD when no generative constructors. 
Bug: https://github.com/dart-lang/sdk/issues/40677
Change-Id: Ibea667e5bc70de32e464c74f04995d01aa4821f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 17:20:16 +00:00
Jens Johansen 3660b9ecc7 [parser] New syntax for null aware index (2nd try) 
This reverts commit bc4893a3b3.

The previous attempt failed because when we check if something is a
conditional expression we used a rewriter that didn't actually rewrite.
This further down the line (still checking if we can parse the expression)
results in errors occurring (that wouldn't have occurred if the rewrite
had happened) and the conclusion was thus that it wasn't a conditional
expression and we parsed it as a null-aware index operator (which gave
errors because it wasn't).

This 2nd try solves it by having a rewriter that actually rewrites,
but then allows to undo the rewrites after we're done parsing.

Change-Id: Ide3c0d6a870d4dc18b6d9475b0227d93c733dc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136624
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 13:31:52 +00:00
Konstantin Shcheglov 8726b35711 Issue 40413. Don't infer promoted TypeParameterType(s) for locals. 
Internal presubmit looks green.
https://test.corp.google.com/ui#id=OCL:295832949:BASE:295984425:1582132722046:8eaca57b

Bug: https://github.com/dart-lang/sdk/issues/40413
Change-Id: I8514f6e1a99c4b02098cc649607cf31c5daf350f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 01:10:14 +00:00
Keerti Parthasarathy da8e160a0f Add an interface for a workspace with a default analysis options file 
Change-Id: I2ffacd2bdb05d5f93ac871cc4dd84dc19e9704f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-02-25 21:44:19 +00:00
Konstantin Shcheglov ddd0e5d598 Update String.splitMapJoin() in MockSdk to the style in unforked SDK, fail a test. 
R=brianwilkerson@google.com

Change-Id: I3ece2a7aec27500eaff30bd40249b37977f78dcc
Bug: https://github.com/dart-lang/sdk/issues/40578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136856
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-25 20:45:29 +00:00
Paul Berry b0b06bff31 Revert "Issue 37487. Add CompilationUnit.languageVersion override." 
Reason for revert: it was a breaking change to the analyzer public API.

There were two breakages:

- A @required `languageVersion` parameter was added to
  AstFactory.compilationUnit, which is part of the officially
  supported analyzer public API.

- A @required `languageVersion` parameter was added to the Parser
  constructor, which is not part of the officially supported analyzer
  public API, but is part of its de facto public API due to the fact
  that it is used by dart_style.

This reverts commit ce26dfda7d.

Change-Id: I507103ea6f6ffabf915d6f56e9f24454725c3930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136851
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-25 04:39:10 +00:00
Konstantin Shcheglov 07144ef876 Fix top-level inference with ForElement and NNBD. 
Change-Id: I7b656ad4af600a82ec13f007dbad3465cd502a3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137020
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-25 04:29:00 +00:00
Brian Wilkerson 0dca599153 Unify diagnostic names for uninitialized non-nullable fields 
Change-Id: I1aa63cbb6f8aa8f3496df348dc1bc415ae8b1373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-24 17:59:56 +00:00
Johnni Winther a9162bd599 [analyzer,cfe] Implement mixed inheritance id test for analyzer 
Change-Id: Ie4ce09b83c2a96a5ad16c60d2924f18cd90a4089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136633
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-24 13:28:26 +00:00