dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8489 Commits

Author SHA1 Message Date
Alexander Markov a32dc76b86 Revert "[analyzer] Remove deprecated language version API" 
This reverts commit 65a377b967.

Reason for revert: this change broke Flutter HHH and Flutter Golem build:

third_party/dart/third_party/pkg/pub/lib/src/validator/language_version.dart:57:40: Error: The getter 'languageVersion' isn't defined for the class 'CompilationUnit'.
 - 'CompilationUnit' is from 'package:analyzer/dart/ast/ast.dart'

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,mfairhurst@google.com

Change-Id: I979fa6201f03e1957bb2557d507b5090c303c82c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141521
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-03-28 00:35:21 +00:00
Mike Fairhurst 65a377b967 [analyzer] Remove deprecated language version API 
Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 18:54:47 +00:00
Mike Fairhurst 2753365946 Revert "[analyzer] Copy result of allSupertypes for now." 
This reverts commit 8f492da139.

Reason for revert: ACX has been updated to not rely on this.

Original change's description:
> [analyzer] Copy result of allSupertypes for now.
> 
> Change-Id: I7713c439872734c94681fa1826e443a33fbec14f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141030
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

TBR=scheglov@google.com,mfairhurst@google.com

Change-Id: I59b24b1f7ece65975ca3a8c0016389d85cfafff7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141282
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-27 16:36:37 +00:00
Konstantin Shcheglov 8120ee57d2 Merge types during instance member inference. 
Change-Id: If3f252d1c031fcb5219e485ac7a053186e6b950c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141207
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 16:22:26 +00:00
Konstantin Shcheglov 126ee948c8 Catch linking exceptions and include the cycle file contents. 
I hope that this will help us to find and fix crashes that we see
during linking.

R=brianwilkerson@google.com

Change-Id: I2e269763395b68fa7bb1a4169b2d681a6834b8eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 16:21:58 +00:00
Jens Johansen 4ab3bda5db [parser] Change recovery for constructor; report errors in bad constructors 
Change-Id: I3d656afce4a3ec14c7c099893a434abba3945ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-27 11:57:56 +00:00
Konstantin Shcheglov 216d98ad2c Use NNBD_TOP_MERGE to combine signatures of the inherited members. 
Initial: https://dart-review.googlesource.com/c/sdk/+/133041
Reverted: https://dart-review.googlesource.com/c/sdk/+/133086

Instance inference is not supported yet in this CL, will continue
in following CLs.

Change-Id: I72de01180b0624eeafc03bfe415ed3d928f1110f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 21:13:12 +00:00
Konstantin Shcheglov 1089356a21 Update checkForWrongTypeParameterVarianceInMethod(), fix NPE. 
Saw in crash logs:

NoSuchMethodError: NoSuchMethodError: The getter 'type' was called on null.
Receiver: null
Tried calling: type
at Object.noSuchMethod	(dart:core )
at ErrorVerifier._checkForWrongTypeParameterVarianceInMethod	(error_verifier.dart:5002 )
at ErrorVerifier.visitMethodDeclaration	(error_verifier.dart:973 )
at MethodDeclarationImpl.accept	(ast.dart:6978 )
Change-Id: I17b3db0d537827e34c4cc63a9ebdf1ecbda455f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 17:15:48 +00:00
Mike Fairhurst 8f492da139 [analyzer] Copy result of allSupertypes for now. 
Change-Id: I7713c439872734c94681fa1826e443a33fbec14f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141030
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-26 17:15:09 +00:00
Konstantin Shcheglov 81a6ffae13 Add more data to debug crash in buildExportNamespace(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/41212
Change-Id: Iaf52b17cc39529362bd1932484a7fa69cdd95a7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 17:07:46 +00:00
Konstantin Shcheglov fc91636703 Fix for crash when FieldFormalParameter in a local function has annotations. 
Saw this in the crash reports.

R=brianwilkerson@google.com

Change-Id: I890592b264a3c33df80d89b45ad55ebe3fdf0c09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 17:07:03 +00:00
Jens Johansen 137aeeb8a1 [analyzer] Sort entries in error.dart and syntactic_errors.dart 
Change-Id: I1913b0dedc7a0100911c4cab3aeba5a30031bbbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-26 14:03:18 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Konstantin Shcheglov 2dfb90618c Return null from getErrors() if the path does not own the URI. 
b/152322246

R=brianwilkerson@google.com

Change-Id: I4cdd0b310dd183118e68c3bd97f6e136e44491a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-25 16:07:16 +00:00
Konstantin Shcheglov b344a111dc Remove extra await null in analyzer. 
R=brianwilkerson@google.com

Change-Id: Idcc04115f618ae7dfcb58a2ab93df538d2b65873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140887
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-25 15:59:12 +00:00
Konstantin Shcheglov 70567aa8df Report an error when a null-aware index expression in legacy library. 
Change-Id: I931445a748d88bf7a1416b880de3299b4a3e19bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140774
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-24 20:55:47 +00:00
Konstantin Shcheglov 5e4f28b900 Use ClassHierarchy for computing implemented interfaces. 
Change-Id: Ie7acf61f9a29d59cc1416dea85a6adb7c534b8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 22:00:37 +00:00
Konstantin Shcheglov 6b7d7aa2c1 Type Function should be excluded from extended / implemented / mixed types. 
Change-Id: If225400a976657f042856bfdaf95b285f98cebb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 20:35:37 +00:00
Konstantin Shcheglov e696554526 Add more libraries and classes to MockSdk. 
https://critique-ng.corp.google.com/cl/301928602

Change-Id: I74353eee3b09ee0b03706a1fa274649a4bb04b81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 16:10:43 +00:00
Konstantin Shcheglov 1dc03cc80c Fix for resolving MethodInvocation(s) with the synthetic method name. 
I saw crashes because of this internally, mostly around ListLiteral
resolution (which were arguments of method invocations), and left
unresolved.

Change-Id: I814a7ac6cb4bfdffff701a8ed51b80849cedb82c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-22 21:19:39 +00:00
Konstantin Shcheglov bdf1454357 Consider FunctionType(s) with required named parameters as subtypes of legacy FunctionType(s) with named parameters. 
Change-Id: Ic2f6b0226ec7885e45ef54053b95b84d3bbf8201
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-21 21:51:36 +00:00
Konstantin Shcheglov 3586f4ccde Issue 41130. Report an error for any default List constructor invocation. 
Bug: https://github.com/dart-lang/sdk/issues/41130
Change-Id: Ib9f440773f7a2ac68b9bcba8a5b380541298434b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140363
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-21 18:39:16 +00:00
Konstantin Shcheglov 0100a5e7f9 Issue 41095. Update flatten() to null safety. 
Bug: https://github.com/dart-lang/sdk/issues/41095
Change-Id: Id72bbe6f51657c474f70eca35677225ba40a5569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-20 16:18:39 +00:00
Konstantin Shcheglov 532f43dcb2 Stop clearing evaluationResult for ConstVariableElement(s). 
This was causing constant errors in _fe_analyzer_shared

With summary2, after https://dart-review.googlesource.com/c/sdk/+/109460
we infer types of fields and field formal parameters together, so
https://github.com/dart-lang/sdk/issues/35940 does not happen.

Change-Id: I3d8532fa938f4942d971d8f9055c8f0f50f482df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140001
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 23:04:19 +00:00
Konstantin Shcheglov 4844fa9622 Issue 40959. Support null-shorting for cascades. 
Bug: https://github.com/dart-lang/sdk/issues/40959
Change-Id: Ia7fd153debafd13ab469bbfcc3a2d1ef3feaa5f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139865
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-18 07:36:36 +00:00
Konstantin Shcheglov f4592159d6 Issue 41050. Support for evaluating bool.hasEnvironment(). 
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I806c201dde6e4692a3252fef5aec2fbcbd663147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139823
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-18 02:53:05 +00:00
Sam Rawlins 3fc075d397 Do not report on collision of private _static_ members 
Fixes #29751; related to #27218

Change-Id: I8adcc5dcc7a97ec3e8237506af84aff2667aff6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139866
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-18 01:05:25 +00:00
Sam Rawlins 9dfd0127da Do not report super-constructor errors on external constructors 
Bug: https://github.com/dart-lang/sdk/issues/27218
Change-Id: I1772cc850b21e97694eaa1852893993f6d4037b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-17 18:34:04 +00:00
Konstantin Shcheglov faae2ec2c5 Issue 41019. Fix for readType of IndexExpression. 
Bug: https://github.com/dart-lang/sdk/issues/41019
Change-Id: I861b355c14c6bb30e570bb0c0101871db423ffb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 17:16:56 +00:00
pq 3e970c4215 fix lint code urls 
Change-Id: I54c7fa05ea8d3c4dfee6d468ae5f99b3bb34c2c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-17 14:23:32 +00:00
Konstantin Shcheglov db5dc11b9b Issue 41050. Get default values for fromEnvironment() from element model. 
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I8fee34a6b5816a725df4e4886fc85061ac4ec9b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 02:05:41 +00:00
Konstantin Shcheglov fbd232dbe6 Issue 40958. Fix null shorting for MethodInvocation. 
Bug: https://github.com/dart-lang/sdk/issues/40958
Change-Id: Ic96b54feeeced5adb3b4271180636b493f951976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 00:29:51 +00:00
Konstantin Shcheglov efdbd86647 Issue 40704. Fix AstTextPrinter for '?[' support. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Icc800f8d5244030170b414c4f8c4d95cefab09a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 22:15:51 +00:00
Konstantin Shcheglov 0f8238efe9 Issue 41036. Add null-shorting for prefix/postfix expressions. 
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 20:23:16 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00
Konstantin Shcheglov 7079c49b05 Check for importedLibrary is null in importLibraryElement(). 
I see it in crashes sometimes.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I734d78f0e71c5985c7833fcf6e439fd4c48a5899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139601
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-15 21:22:37 +00:00
Konstantin Shcheglov 7c5059f528 Issue 40704. Report INVALID_NULL_AWARE_OPERATOR for unnecessary '?['. 
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: I67b45a4b5c6afba38141b33b44e2fc28726dffd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 20:42:56 +00:00
Konstantin Shcheglov 29fe8b85c2 Issue 2025. Report an error when evaluating Set/Map literal and ForElement. 
Bug: https://github.com/dart-lang/linter/issues/2025
Change-Id: Ifa61299ed69e029a51f3f05fa11583e7abd5a2f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 16:50:32 +00:00
Konstantin Shcheglov 668c81ffbf Don't report FINAL_NOT_INITIALIZED_CONSTRUCTOR for mixins. 
We already report MIXIN_DECLARES_CONSTRUCTOR, and there was a crash
in quick fixes when we attempted to fix it for a mixin.

R=brianwilkerson@google.com

Change-Id: I453d1de0702e36978c3972fd586494d2cd92aa40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139316
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-12 22:49:46 +00:00
Konstantin Shcheglov aef2012b3a Add more data to debug FunctionTypeAlias linking crash. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/41023
Change-Id: Ica2aa7ec72992b9fe1b5a374b6f3546e7e297c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139318
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:46:31 +00:00
Keerti Parthasarathy cd3a13e3f6 Add an option to allow for prefecthing of directly referenced files when building unlined summaries. 
Change-Id: I20869dd6aee3ab5f4fc0bf99eab05c08173cb782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139320
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:28:46 +00:00
Konstantin Shcheglov ef6c7efc9f Issue 40941. Report FINAL_AND_COVARIANT_LATE_WITH_INITIALIZER. 
Bug: https://github.com/dart-lang/sdk/issues/40941
Change-Id: Ica0bbbdeee447c410cbfd64aea1a643711d21655
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139322
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-12 21:04:06 +00:00
Konstantin Shcheglov e9e1d5a7f1 Issue 40956. Legacy view on required named parameters is not required. 
Bug: https://github.com/dart-lang/sdk/issues/40956
Change-Id: Ib4be27f084f7c88ccc4dab92aa557eab85eda166
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 20:39:46 +00:00
Konstantin Shcheglov 3da03a648a Issue 40955. Late final variables without initializers have setters. 
Bug: https://github.com/dart-lang/sdk/issues/40955
Change-Id: I7cdccbf7f16e3a070b79f05062e6b5692a9f0051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 19:02:06 +00:00
Konstantin Shcheglov ad4762343b Issue 39876. Report DEFINITELY_UNASSIGNED_LATE_LOCAL_VARIABLE. 
Bug: https://github.com/dart-lang/sdk/issues/39876
Change-Id: I855579c47ab8f932bb3977eb44d0c17d0ce5987a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:41:07 +00:00
Konstantin Shcheglov cdac6f614c Issue 40837. Fix for invalid function expression flow analysis. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40837
Change-Id: Id7021aa6b54fede6af2d03f51fd1d53445d174c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139149
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:33:02 +00:00
Paul Berry 92b1057f3f Fix hint deprecated_member_use in analyzer 
Change-Id: I90031ca5044626b731ef57cc0f6ad57012850ae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138982
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 15:20:59 +00:00
Janice Collins ace1d9b921 Do not repeatedly analyze a full library per part when dartfixing. 
Migration performance improves 10x on web_ui with this CL.
Also fixes a heisenbug in the linter code where identical uniqueNames
for LintCodes could wind up in objects that compare differently.

Bug: https://github.com/dart-lang/sdk/issues/40915
Change-Id: Iddddfd7659f4bc724ddf21ebae41750a0ee51e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-10 21:16:11 +00:00
Keerti Parthasarathy 7f649e9ebc Remove a missed usage of .analysis_options. 
Change-Id: I552fa197aa13b1987b6b348295a37d1e61ba7775
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-10 20:30:01 +00:00
Konstantin Shcheglov 9a0c09ecb2 Track definitely unassigned variables. 
Change-Id: Id610a133912605f9af63222f25408942420cbf1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138881
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-10 18:35:40 +00:00