Konstantin Shcheglov
085e3d8464
Remove deprecated 'enableSuperMixins' from ErrorVerifier.
...
Change-Id: Ib4d74cf8f9d36d4e2917a171e8ea2dfceff7a603
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-14 19:02:01 +00:00
Johnni Winther
383a8ea857
[cfe] Initial support for external fields.
...
Change-Id: Iccee87f40df395c928dc1a9dc81ddad8813a5000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147906
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-05-14 18:34:06 +00:00
Konstantin Shcheglov
e388956b81
Use TypeSystem.isNullable() for MISSING_RETURN.
...
Change-Id: I90d79b4d605eb0ad5537f323e0f019a5730c1095
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-14 00:03:13 +00:00
Konstantin Shcheglov
ea4e4367bc
Fix MISSING_RETURN after function expression return type inference.
...
Bug: https://buganizer.corp.google.com/issues/156495751
Change-Id: I0b994d9023cf9282048b2ec9462190f579ce620d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148001
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-13 21:46:42 +00:00
Kevin Moore
0acc564104
Fix a number of URIs referring to dartlang.org
...
Change-Id: Ie1373e93092023caf5e0bcfd6bb88bfb422d5daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
2020-05-13 18:24:12 +00:00
Konstantin Shcheglov
6e5cf35ee6
Use single flag in ElementDisplayStringBuilder, make it required.
...
Change-Id: I4e6d8b16ff24fd0fdf40efe6b2f4a44d6c6596f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-13 16:59:51 +00:00
Konstantin Shcheglov
251933ca62
Implement futureValueType() operation.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I34cca0aa0ee8ca8237a5bfb3c123bc732a279c4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147824
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-13 15:36:16 +00:00
Konstantin Shcheglov
9d0d7a675c
The formal spec has a typo around async functions and void.
...
R=brianwilkerson@google.com
Change-Id: Idd87f69a6eb406f911d11c923ee13eb1cef6c55b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-13 15:28:33 +00:00
Konstantin Shcheglov
f5b1e83a93
Add debug information to a potential reason for linking crash.
...
Change-Id: I069b9872becbd0c246d354a2c60a4e1166b5dd18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-13 15:28:11 +00:00
Konstantin Shcheglov
0861470197
Update ReturnTypeVerifier to be what the spec says.
...
See also https://github.com/dart-lang/language/issues/960
Change-Id: I5cfc672e7902fba15ec940afb07f324cd21da686
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-12 23:54:06 +00:00
Sam Rawlins
b9e10e3870
analyzer: Remove unused imports
...
These were previously undetected due to https://github.com/dart-lang/sdk/issues/38784
Change-Id: I546f698d992142f5e1d1260fba1cfd4a5308a0d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-05-12 23:45:24 +00:00
Paul Berry
275b922ee8
Revert recent parser fixes
...
Commit 1f9b5c1996 causes tests to fail
in angular when rolled into internal sources; the other two commits
need to be reverted as well to avoid merge conflicts.
This reverts commit 1f9b5c1996 .
This reverts commit c40b24da48 .
This reverts commit 96df1f9e6c .
Change-Id: Ic4e55181ef60e825ce4409a9a9528ecbf19c39c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-05-12 22:02:09 +00:00
Konstantin Shcheglov
8963497d55
Ensure that URIs end with '/', fixes empty 'packageUri'.
...
Bug: https://github.com/dart-lang/pub/issues/2482
Change-Id: Ibaf94b44532b44c9a87c05cb8c6eaa523fbbb6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-12 19:30:51 +00:00
Konstantin Shcheglov
5ab1687ee7
Create updated ParameterElement(s) using replace().
...
Change-Id: I1038f119e9678eb6bb24fa4b10513a28a701d782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-12 17:04:09 +00:00
Danny Tuppeny
1a328bed36
Restore default values in hover element descriptions
...
Bug: https://github.com/dart-lang/sdk/issues/41844
Change-Id: Ibb6197cba25adb6507a7cd35aff97b134a7e910f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147549
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-05-12 08:24:09 +00:00
Konstantin Shcheglov
2ebd8e22a0
Add DartType.isDartCoreIterable
...
R=brianwilkerson@google.com
Change-Id: Ia21b8f66bc19467b1b4e84c0cd9d59d6553a58a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-11 22:06:20 +00:00
Konstantin Shcheglov
4ead8ad652
Resolve operands of '==='.
...
Change-Id: Ib6fddcb62dfeb840276e188b77119e661c7ce5cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-11 17:22:58 +00:00
Konstantin Shcheglov
29c340fb94
Perform return type inference using BodyInferenceContext.
...
Change-Id: I713a01add6da45aa03d6e15d1374297182d39116
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-11 17:20:57 +00:00
Konstantin Shcheglov
4e520824f5
Deprecated DartType.isObject
...
R=brianwilkerson@google.com
Change-Id: If588b23668764b07c99e327281bfeb11c8e31367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-11 16:14:37 +00:00
Konstantin Shcheglov
1120d64149
Simplify InterfaceType.isDartXyz implementations.
...
R=brianwilkerson@google.com
Change-Id: I152d49f274b78c54630e8e8a288f8cc82d6080af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-11 16:14:17 +00:00
Jens Johansen
96df1f9e6c
[parser] Add ErrorToken for ignored (unmatched) end parenthesis, brackets etc
...
Change-Id: Idb57295700988d71321743af9782134b02562311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146240
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-05-11 14:46:47 +00:00
Konstantin Shcheglov
81780821e8
Extract FunctionExpressionResolver.
...
R=brianwilkerson@google.com
Change-Id: I363f0bfe91328c2729fe268d2dcb79f61d51b91c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147338
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-09 18:19:09 +00:00
Konstantin Shcheglov
b8b9f89b69
Extract ReturnTypeVerifier.
...
Change-Id: I1dc7333faf40f227b8be0b8fbfc4b2bd7e8e84eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-08 20:31:27 +00:00
Konstantin Shcheglov
da02189198
Split computing interface for class and mixin.
...
Change-Id: I1d936dd7aee83f4436183f2e20433cfed7ebc747
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147330
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-08 16:08:39 +00:00
Sam Rawlins
478a8f2a16
analyzer: Do not report non-EOL doc comments in codes.dart
...
This codifies Brian's comment on a recent CL [1].
[1] https://dart-review.googlesource.com/c/sdk/+/145571/2/pkg/analyzer/lib/src/error/codes.dart#5496
Change-Id: Ie9def6fe9979e57b77ee951d38c701d6300fad26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-05-08 08:10:49 +00:00
Konstantin Shcheglov
7161036eb7
Fix avoid_unused_constructor_parameters in analyzer.
...
Bug: https://github.com/dart-lang/sdk/issues/41797
Change-Id: I6fb201b549a599b12d022abd6108d3418966c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-05-08 04:44:58 +00:00
Sam Rawlins
d0d0952546
analyzer: Report unused public members of private and unnamed extensions
...
Fixes #41592
Change-Id: I95b79724bfcfc5d48b8f6cca61c6a3a681de3662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144353
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-07 15:34:48 +00:00
guidezpl
094fcd78a1
Add test_driver directory to @visibleForTesting whitelist
...
Bug: https://github.com/dart-lang/sdk/issues/41151
Change-Id: I2d620ef296c3f9fc1d6e56fec645a4530416a622
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140867
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-05-07 06:45:37 +00:00
Konstantin Shcheglov
b598f417dd
Use separate Conflict subclasses in inheritance manager.
...
R=brianwilkerson@google.com
Change-Id: I45377fed1cc28a7d0301fdc2d7b7897ccf2b3e84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-07 01:23:32 +00:00
Konstantin Shcheglov
0fd787e02c
Don't create extra InheritanceManager3 instances.
...
Change-Id: If09b6031bd67da506e622814bb4e86323e0cd30f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-07 00:48:22 +00:00
Konstantin Shcheglov
8bfd2e4090
Fix InheritanceManager3.getOverridden() backward compatibility.
...
TBR
R=brianwilkerson@google.com
Change-Id: I23584737fe809052bdb14effde7dcfaeba8fd30c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146985
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-05-06 22:47:36 +00:00
Konstantin Shcheglov
e6a3125492
Fix for crash when reporting ABSTRACT_SUPER_MEMBER_REFERENCE for PropertyAccess in mixin.
...
Change-Id: I3270ac34b837fc5940e6f4938627bb7479eff851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-06 19:27:58 +00:00
Konstantin Shcheglov
f6d0f462fb
Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for redirecting factory constructors.
...
Change-Id: Ia218070ae332aae8e071e76b2b2bcbc06983e191
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146698
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-06 18:09:44 +00:00
Brian Wilkerson
4da5b40fb6
Remove unnecessary braces in a string interpolation
...
Change-Id: I16d86df473e054a5f17b6c72f155467618ef0307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146823
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-05-06 16:59:45 +00:00
Konstantin Shcheglov
9b3f9db65a
Switch InheritanceManager3 to computing ClassElement interfaces.
...
Change-Id: Id9148d1bf3fc369eeabe2b1acc7507c20986a3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-06 03:09:03 +00:00
Konstantin Shcheglov
91ca5a3e00
Ignore uninitialized fields in FFI Struct.
...
Change-Id: I61b2a7e1059befd99469a617b1eed0e2220041d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-05 22:45:16 +00:00
Keerti Parthasarathy
1e2ebe8506
Add support for part of
...
Change-Id: I8002a6449f95422700b522a9cbae0a8c55ee460d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-05-05 19:57:47 +00:00
Paul Berry
b71d09542c
Migration: extend compound assignment diagnostics to ++ and --.
...
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Iab5097359d8de7aa9411f51ee0ec6212c3adb678
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145920
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-05-04 23:02:17 +00:00
pq
767e78cb4d
add lint reporting for offsets
...
Change-Id: I56898228f19039aeb6f241080cd3324027763b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-05-04 20:32:17 +00:00
Keerti Parthasarathy
01820c20a5
Fix checking path for windows
...
Change-Id: I7ad6bb40be07dc2cf9d609c7c379dc7ec6725da1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-05-04 19:56:54 +00:00
Konstantin Shcheglov
3a7633a191
Remove unnecessary null checks in BinaryExpressionResolver.
...
Change-Id: Iedc37b7f5f68828fc7c4a9765649b5ba5d44f0a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146067
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-03 18:00:27 +00:00
Konstantin Shcheglov
c3ce873556
Inline intermediate method for user defined element resolution for binary expressions.
...
Also rename corresponding element/type resolving methods.
R=brianwilkerson@google.com
Change-Id: Ic66ab0716ba98e23aabd713e8cd66c47f048807d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146065
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-05-03 00:40:56 +00:00
Konstantin Shcheglov
908f630813
Issue 41724. Resolve operator== using NonNull(leftType).
...
Bug: https://github.com/dart-lang/sdk/issues/41724
Change-Id: Ie16e6853c5cd5254663bf2d87ef044b8e56734c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-02 19:40:06 +00:00
Sam Rawlins
018dab4568
Analyzer: Report a constructor which redirects to a constructor of an abstract class
...
Fixes https://github.com/dart-lang/sdk/issues/37552 and
fixes https://github.com/dart-lang/sdk/issues/34370
Change-Id: I75e68157cf7e6e9824353c307a8e9f6669f8ea82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145571
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-05-02 03:53:55 +00:00
Keerti Parthasarathy
eca696c026
Use third_party analysis options file for third_party code.
...
Change-Id: Ia88180cd1a5ba186796bd7081721cd0da756ad50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-05-01 23:09:25 +00:00
Konstantin Shcheglov
798ea59564
Remove invalid assert from ErrorVerifier.enclosingClass=.
...
Change-Id: Ic811d3576a041fba88675ff9eec2cf059745c5d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145760
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-01 17:21:43 +00:00
Konstantin Shcheglov
eaf46c9ccf
Remove unused _isInConstInstanceCreation.
...
Change-Id: Id989fd41a3249fc35147b5be43c935bc5a2ce340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 23:46:36 +00:00
Konstantin Shcheglov
087d3166a2
In getLibraryLinkedSignature() access just file.
...
We don't need to configure the analysis context with file specific
analysis options, we are not going to resolve this file.
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Ie0efafc39a35622f12f4110097ff9e804ef87cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 23:45:46 +00:00
Konstantin Shcheglov
0b8b1515dd
Apply new AnalysisOptions for the library context.
...
Now we find different options for files more often, and it was affecting
completion performance if we reset the library context every time.
I had to change some shared analyzer objects to be updatable.
Change-Id: If4eee82df62d5115b12fce5865ff3be12aac8c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 20:21:22 +00:00
Konstantin Shcheglov
cf3a034210
Implement promotion via initialization in flow analysis.
...
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 16:26:27 +00:00