Commit Graph

8489 Commits

Author SHA1 Message Date
Parker Lougheed cad7b26b47 [pkg/analyzer] Update pedantic to 1.9.0
Change-Id: I1161ed0c4681ddc8d2bd494586a9442a2ce1c4e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-06-02 21:41:03 +00:00
Sam Rawlins 598c65165b Analyzer: Mark used extension operators as such
Fixes https://github.com/dart-lang/sdk/issues/42122

Change-Id: I3cc57715471a6369c60d21e2a691e8cc0d90f809
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149663
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-06-02 16:37:22 +00:00
Paul Berry 930cae0f13 Revert "Remove DartSdk.useSummary."
This reverts commit a2c3ecabce.

Reason for revert: Breaking change to de facto API

Original change's description:
> Remove DartSdk.useSummary.
> 
> R=​brianwilkerson@google.com
> 
> Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9998bedb74ea940371f18ac7dce42b2f5dcc3b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149687
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-06-02 15:20:32 +00:00
Sam Rawlins 695470eb70 Analyzer: skip using bazel-bin
bazel-bin or blaze-bin may result in the wrong directory from being
used. The shortcut does not provide much benefit, and has a risk of
being wrong.

Bug: b/154627287
Change-Id: Ib629492a6c3a3c82519e3382c5bacec74d9272a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-06-01 22:49:48 +00:00
Konstantin Shcheglov fe52ae462c Instantiate Never as Null* in legacy libraries.
Change-Id: Ibe7302a539e7debd0cab468119a4dba0a4517163
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 19:44:58 +00:00
Konstantin Shcheglov fe6fc7803d Remove AnalysisDriver.useSummary2
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I789794c80484143288be8ef3d14ff78b8976e494
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149607
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 16:48:26 +00:00
Konstantin Shcheglov 24c50fb8b2 Issue 35710. Test switch exhaustiveness, improve for null.
Bug: https://github.com/dart-lang/sdk/issues/35710
Change-Id: I6f17db1a9b2c01ec4b97538e224146fd3cec9002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149606
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-31 18:58:53 +00:00
Konstantin Shcheglov 20e6f150e5 Fix crash when inferring types with FunctionExpressionInvocation and out of order dependencies.
This fixes language/lazy/static_test

R=brianwilkerson@google.com

Change-Id: I52c25903de8096af58b4fac9654eace7ee358aba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-31 01:56:22 +00:00
Konstantin Shcheglov a2c3ecabce Remove DartSdk.useSummary.
R=brianwilkerson@google.com

Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-30 19:07:32 +00:00
Konstantin Shcheglov 439e99483f Remove DartSdk.getLinkedBundle().
R=brianwilkerson@google.com

Change-Id: I2335ad03856b73e6d864d939a90839ef85dcab78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149487
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-30 03:16:51 +00:00
Konstantin Shcheglov 89782c96d9 Implement changes to return type verification.
https://github.com/dart-lang/sdk/issues/41803
https://dart-review.googlesource.com/c/sdk/+/149163
https://github.com/dart-lang/language/pull/989

Change-Id: I13caf53a3e96c7b266dd3b3bf511002addcf83b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149373
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-29 23:09:37 +00:00
Konstantin Shcheglov a2e85dcda9 Rename HintCode.DEAD_CODE visitor to LegacyDeadCodeVerifier, report other dead code.
Finishing https://dart-review.googlesource.com/c/sdk/+/149240

R=brianwilkerson@google.com

Change-Id: I801f9140587d16969d639889fa14efde3b09dd4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149388
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-29 17:40:46 +00:00
Konstantin Shcheglov 6a551f8d54 Use allowed_experiments.json when building SDK summary (reland).
Landed: https://dart-review.googlesource.com/c/sdk/+/149052
Reverted: https://dart-review.googlesource.com/c/sdk/+/149201
Change-Id: Ief9430c58254fe8cbdcedc8d3678c61d4c086f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-29 16:31:35 +00:00
Joshua Litt 20faaa5d94 [dart2js] Move dart2js unit tests to pkg/compiler/test.
Change-Id: Ib18f554c1076f27a3f7c0df5a36410da41a1f467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148784
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-05-28 18:51:11 +00:00
Paul Berry 2e261f9386 Migration: add locations to trace entries that refer to elements.
Bug: https://github.com/dart-lang/sdk/issues/41402
Change-Id: I0dc59ae9d64c6e8ab470b2ddcb5fd42557ba5704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148742
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-05-27 21:52:14 +00:00
Konstantin Shcheglov a538c7fcc7 Non-nullify context type for FunctionExpression inference.
Bug: https://github.com/dart-lang/sdk/issues/42007
Change-Id: Id75956759c66aa6090ba52e07deb120ce44fd8d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 20:22:20 +00:00
Konstantin Shcheglov 00fa48fbb1 MockSdk does need to create summary.
Change-Id: Id62bc99394e9afd6306ba6a12118d7bcd045a598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 19:39:10 +00:00
Konstantin Shcheglov 860d3c0697 Report UNUSED_LABEL when null safety, fix for crash.
Bug: https://github.com/dart-lang/sdk/issues/42077
Change-Id: I85325ae1f2d25f680182d07ef50ddb56633b89f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 19:36:30 +00:00
Konstantin Shcheglov b6af46dc30 Revert "Use allowed_experiments.json when building SDK summary."
This reverts commit 97d9412996.

Reason for revert: This causes some, probably temporary, issues internally. Reverting for a day or two.

Original change's description:
> Use allowed_experiments.json when building SDK summary.
> 
> Change-Id: I3fd73d9890d62cc7b3c19e061069979a6b65c9b7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149052
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I9c8142bfc5728dd773830b653bb31d28b5e81628
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 16:26:12 +00:00
Konstantin Shcheglov 97d9412996 Use allowed_experiments.json when building SDK summary.
Change-Id: I3fd73d9890d62cc7b3c19e061069979a6b65c9b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149052
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 15:28:19 +00:00
Parker Lougheed 6489a0c68d Fix error when modifying import on Windows
If there is an exception when checking if a resource exists, it is similar to it not existing. Open to feedback here though, perhaps the issue should be handled more specifically to Windows path requirements.

Bug: https://github.com/dart-lang/sdk/issues/37403
Change-Id: Ic5d4ed0cb22619897c3ccaf46feaadd297b55472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 05:50:13 +00:00
pq 253022eb1b remove non-node-processing lint support
See: https://github.com/dart-lang/linter/issues/2105

Change-Id: I8895c567813d7757e659f8e0d2c700268eae4a6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149050
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2020-05-27 00:40:02 +00:00
Konstantin Shcheglov 279024d823 Deprecate InstanceCreationExpression.staticElement
Change-Id: I3c2de8ce22944963418d543b887720db15badd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148981
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 22:56:42 +00:00
Konstantin Shcheglov 0b3ece9287 Expose FeatureSetProvider from AnalysisDriver for dartdoc.
R=brianwilkerson@google.com

Change-Id: I790737f7538e1104d27b71d0b789e09f22e49e0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149046
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-26 22:13:35 +00:00
Konstantin Shcheglov fc1a782168 Remove support for '--package-root'.
Bug: https://github.com/dart-lang/sdk/issues/41197
Change-Id: Ia10946b4db2204cc11e78a1d114578ba79904e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-26 21:33:32 +00:00
Konstantin Shcheglov 571f564eda Rewrite TypeName to ConstructorName in one place, consolidate error reporting.
Change-Id: I5ea1369d65c5eb47e920f68806d28f34931d372e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-26 21:32:22 +00:00
Parker Lougheed d936b4f88c [pkg/analyzer] Address prefer_collection_literals lints
Change-Id: I2ec7ae41e35f3c42a8cd2c3723cbe58266099f99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 19:09:00 +00:00
Parker Lougheed 66e2339142 [pkg/analyzer] Address prefer_final_fields lint
Change-Id: I737502b4bbef575ef6d9e0a16c12f43365a5e093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 19:00:56 +00:00
Parker Lougheed 2e89bcfc7d Fix prefer_conditional_assignment lint suggestions
This is a step towards moving towards the 1.9.0 version of pedantic which includes this lint.

Change-Id: I59a8d8d7a2c377a007cc08fdf7eef8c60203466d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 17:46:08 +00:00
Konstantin Shcheglov 32ab4205e3 Extract resolution of 'new Class.constructor<typeArguments>()'.
Change-Id: Ib2ffb7bc0b5411a087949f797d153eed1710f9e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-25 21:07:49 +00:00
Konstantin Shcheglov c0b4f14360 Use NNBD aware subtype matching rules for inference.
Change-Id: I12133e6e9195817af96d93ce8f39b635d187751a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-24 19:06:38 +00:00
Konstantin Shcheglov 396b5fb7a9 Report issues with loading summaries using LibraryCycleLinkException.
...so that we can include additional data as a "file".
The exception text has smaller size limit than we need.

Change-Id: I56ff7f7a85658419aa360bd6ab48b55fd180bfe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148794
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-21 16:40:01 +00:00
Konstantin Shcheglov d24a834181 Subtype constraint generation.
Implements part of https://github.com/dart-lang/language/pull/957

Change-Id: Ia9174c6be6710ae43619f7b5c07d8feb190ca6a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148225
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-21 00:38:24 +00:00
Konstantin Shcheglov c93537c50f Use FindNode and FindElement in search tests.
Change-Id: I29d7ad856e050b09337817df02610aebb6f40303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148790
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-21 00:29:10 +00:00
Konstantin Shcheglov dbc41af864 Extract ElementNameComponents and use in indexing, tests, and search.
Change-Id: Ib84f5d593bffc8a4e7587d1bded22459bf234e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 22:46:54 +00:00
Konstantin Shcheglov e6bdfb70c5 Fix analyzer tests of Windows.
TBR

Change-Id: I92921d41a711c19ff846a649193252effe0a310b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148787
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 22:44:14 +00:00
Konstantin Shcheglov 819e82ee1d Fix subtype 'T <: Object' when T has implicit Object? bound.
We were not reporting a compile-time error by a wrong reason.
https://github.com/dart-lang/sdk/issues/40089

Change-Id: Ic0caf01a49e5dc4badefb5a534a7dbaac2108213
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 21:45:24 +00:00
Konstantin Shcheglov 10e14c0377 Add context information to exceptions during computing fixes.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Idfd6aaa1f593cef496ebf0763ff038c1ddae6d80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148783
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 20:44:11 +00:00
Konstantin Shcheglov 2231b8c580 Use AllowedExperiments in analyzer.
Bug: https://github.com/dart-lang/sdk/issues/41741
Change-Id: Iba0face7198f4ecc17c86d2fcb0630912db7ba60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148648
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 20:42:31 +00:00
Konstantin Shcheglov 1821f0ec32 Issue 41997. Fix for indexing, searching, renaming members of unnamed extensions.
Bug: https://github.com/dart-lang/sdk/issues/41997
Change-Id: I963a9ceae03a0d1ed3d04936c4042980a08fa56f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 18:12:30 +00:00
Konstantin Shcheglov 5dd096ac99 Fix NPE in PropertyAccessorMember.correspondingGetter/Setter.
Change-Id: I9b1dc720b39c5c58b3da6e27543264362f4d2eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 06:43:11 +00:00
Konstantin Shcheglov daa8d68a29 Handle the case when source cannot be found for uri
Change-Id: Ia34d6162f59fa83ae9ed8f6e841088e5b779065a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148236
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2020-05-19 22:35:11 +00:00
Konstantin Shcheglov df695b84d1 Rename element model modifier setters to isXyz.
Change-Id: Icdcedff8d5af0777851200bacf54428a229d359e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-19 04:02:09 +00:00
Konstantin Shcheglov 0324ce28bc Use hasLegalReturnType flag instead of a type check.
Change-Id: If2caa49aad6e3300e0ffe5de23095d2e824fb3ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-18 20:49:06 +00:00
Konstantin Shcheglov 3ebcc10acd Issue 41938. Report INSTANCE_MEMBER_ACCESS_FROM_STATIC for extension members.
Bug: https://github.com/dart-lang/sdk/issues/41938
Change-Id: I95364cb460eacf8076de9a12f4975eb7b1963916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-18 19:36:17 +00:00
Konstantin Shcheglov b591ea11bc Add more data to debugging crash during linking.
Change-Id: I076cbec33d4e2c1e3e5d72c72c5a4657d2b94d1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-18 19:30:57 +00:00
Konstantin Shcheglov 08bad91aa3 Fix for crash 'C?.foo'.
Change-Id: I9e03b056c9df6c476de7fa29f412c1704d6c3185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148183
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-18 02:43:47 +00:00
Konstantin Shcheglov 529f614eb3 Remove UnknownInferredTypeElement.
Change-Id: Iae13ed84dec9a041bd3ed3d470e867628f776da0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148233
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-15 21:37:42 +00:00
Konstantin Shcheglov 80bd1d5970 Change the unknown type presentation to '_'.
...to align with the changes to the inference spec.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I31132f1df53924970a987d936bc3a90e9c824f90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148232
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-15 20:03:14 +00:00
Konstantin Shcheglov 9c9b17d2f7 Remove deprecated 'typeSystem' parameter from InheritanceManager3.
Change-Id: I1a33fe5b9f7298aeb786f4421ee0e6913b066e76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-14 19:12:49 +00:00