819f0a92a5
Remove unnecessary override in ReplacementVisitor.
...
R=brianwilkerson@google.com
Change-Id: Iba88984097212242e1373e80af61a340e22d4a1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153500
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-08 00:25:00 +00:00
eada9fa426
Issue 42605. Do LEGACY_ERASURE when checking inferred mixin type arguments.
...
Bug: https://github.com/dart-lang/sdk/issues/42605
Change-Id: I58d27352e770ce63fabc0da2c07920dbadb8af11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-08 00:09:24 +00:00
ec30a30ac2
Remove the type parameter from NullabilityEliminator.perform().
...
R=brianwilkerson@google.com
Change-Id: Iebf32f926aec6d904940d531a8c56318f33b8074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153483
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-08 00:06:00 +00:00
fea5f5866e
Add DartTypeVisitor and DartType.accept(DartTypeVisitor) to API.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/40478
Change-Id: I8453011f4a39323bda86244a749509b4b347b4b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-07 20:13:10 +00:00
3b25d6ff69
Add DynamicType, NeverType, and VoidType to API.
...
R=brianwilkerson@google.com
Change-Id: Icf917d999878b3c4d7b1d9425eb8a3c79921ba6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-07 00:22:40 +00:00
11632ff4d4
Add buildSdkSummary() to analyzer API.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/build/issues/2745#issuecomment-654441549
Change-Id: I144dd99be5e5a210e27f3b5b5b54951659479511
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-06 23:03:09 +00:00
bda4994482
Analyzer: Finish using ///-style comments.
...
This ignores the Lint on a few files where it is undesired.
Change-Id: I5e4244607da0ef60678cebb89a433e44cb1e753f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-07-06 00:54:10 +00:00
69aba23371
Move TypeSystemImpl to src/dart/element/type_system.dart
...
R=brianwilkerson@google.com
Change-Id: I0d9acad041c1038f6f2be6c09855488287ba5e97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-05 16:44:59 +00:00
d1c9b09042
Set uri for implicit dart:core import.
...
R=brianwilkerson@google.com
Change-Id: Ie354df1cd541480f4deb3a4d29c7068990072f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 22:54:02 +00:00
eb7d35ea18
Add overrideKnownFeaturesAsync() for DartDoc testing.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I66c03b06e5ac57dbd288242f7bb873d982fe2a30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 17:20:22 +00:00
326f7b4a8f
Remove DartSdk.useSummary.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/149495
Reverted: https://dart-review.googlesource.com/c/sdk/+/149687
Change-Id: Ibd3f1af1aef83adc35f77cfbda66e07c5ae99922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 15:56:41 +00:00
9cfdc02e58
Stop depending on exports from generated/resolver.dart
...
We cannot remove them completely just yet, there are users in google3.
But this CL will allow experimenting internally to track these users
and update them similarly.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ic588b2873f9d5202783c8991f58e86bab28bd47e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 15:55:41 +00:00
4301899ed5
Track more Cider operation performance.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I95f2a36434556256dd5d55395cfc1bfca056763b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153068
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-02 23:33:59 +00:00
cffeac78f9
Mark recently published codes as being published
...
Change-Id: I9d4ce65e1f95ccf7fbcdb3007bed81e5b4b0ac0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-07-02 19:22:09 +00:00
8cc3d415e7
Integrate suggested changes from the PR to publish the docs
...
Please look this over carefully; all of your changes have been integrated,
but not all of the changes are yours. While itegrating your suggestions I
found a few more occurrances of 'is not' and 'are not' that I converted.
I also found a couple of other things that needed to be updated.
Change-Id: Iddaaa22d7e584506bc3c16606166771fd5a75caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152942
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2020-07-01 15:58:11 +00:00
fc1999de15
[dartdev] Implement --enable-experiments for dart run and dart pub run.
...
Related to https://github.com/dart-lang/sdk/issues/42339 .
Change-Id: I3fdeee33dcad0ca031f483e2e3692be300392958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152960
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-06-30 23:22:42 +00:00
c0a7ee9b65
Issue 42007. Don't report UNNECESSARY_CAST when casting from a star to question type.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/42007
Change-Id: I1c7f353a4e5a18c028d2a1c746ec76c916fcaaa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-30 17:59:44 +00:00
c4503f0074
Use OperationPerformance to track performance in CompletionPerformance.
...
R=brianwilkerson@google.com
Change-Id: I50158512020be87b3c51363ed2e503c3df3cfaae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-30 17:44:54 +00:00
22da8934ac
Migration: properly handle extension override syntax.
...
There were two problems:
- EdgeBuilder wasn't handling the extension override syntax at all,
causing a crash.
- FixBuilder wasn't overriding the behavior of
ExtensionElement.extendedType, causing a star type to be used as a
context for the target expression; this prevented the fix builder
from realizing when it needed to insert `!` after the target
expression.
Fixes #42455 .
Bug: https://github.com/dart-lang/sdk/issues/42455
Change-Id: I5a9f66f83db73a796e72708022faefd527667e32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-06-30 16:00:47 +00:00
46a2fa6b99
Unify two error codes for diagnostics
...
Change-Id: I5714cec5e47b67e1a4be2f2895fa9cc96e869c45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152732
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-29 18:58:03 +00:00
12f1d68ee3
Move OperationPerformance out of Cider to use it wider.
...
Change-Id: I9e1669c650b23d02e645ef3b19bfd9e15c7f54ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152735
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2020-06-29 18:42:44 +00:00
6e9aa86d6f
Stop using AnalysisOptions.signature and multiple paths in SdkDescription.
...
Basically reduce it to a single path.
R=brianwilkerson@google.com
Change-Id: Ia532a5c7f6ae1464b77c5e9d23b3aaa7e85a6bf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152710
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-29 17:50:14 +00:00
e77e270cc2
Make all parameters of ExperimentalFeature constructor named required.
...
Change-Id: Ib0af7526923653992c13002c808197cc16ffa98b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152619
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-29 17:49:33 +00:00
d074bb1596
Improve the range selected by const_constructor_with_field_initialized_by_non_const
...
Instead of highlighting the entire constructor, which might be long, we
now highlight just the keyword `const`.
Change-Id: Ie520db0a2fcaf05db79d9e49e08f06a5212fef7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152727
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-28 14:51:31 +00:00
30fe39b92d
Do not report a missing implicit default super constructor when subclassing an non-subclassable class
...
Change-Id: I015ebb07ae341bcee615e032be460b3e59e149c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152726
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-28 14:51:24 +00:00
f91547d6dd
Separate signatures for linked elements from signatures for resolution.
...
So, lints and error filters don't affect cache keys for summaries, and
we can reuse them more often across analysis contexts.
This makes `dart flutter_tools/bin/flutter_tools.dart analyze --flutter-repo`
about 35% faster, from 153 seconds to 113 seconds.
Change-Id: I606acce7ef712450783c75d24bc52fd5877b3f1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152725
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-27 19:14:41 +00:00
6bf946bbfc
analyzer: Always declare return types.
...
Change-Id: I23d89bb572310a1a8deef8e173630d9bb59c9a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152708
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 23:54:28 +00:00
4b93c8aabd
Remove unused AnalysisDriver flag 'disableChangesAndCacheAllResults'.
...
R=brianwilkerson@google.com
Change-Id: Ic9a98493496cf875434d0d6c2246721d4985c8c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152707
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-26 21:16:38 +00:00
cf53aea310
Consolidate to a single implementation of refineBinaryExpressionType.
...
Previously, we had one implementation in TypeSystemImpl that did some
of the work, and then deferred to the superclass implementation in
TypeSystem to do the rest of the work. But the separation between the
two didn't add any value, since all instances of TypeSystem are also
instances of TypeSystemImpl. So we move all the logic into
TypeSystemImpl for clarity.
Change-Id: I2901ab854a1507d65545ab05e3662913f219ad56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152704
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-06-26 19:42:25 +00:00
648b5e9c68
Use ///-style doc comments in analyzer/lib
...
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I573cb81dca6462c571bd6bf7bf309a46fd628967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152610
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 17:58:50 +00:00
baa5717f78
Use ///-style doc comments in analyzer/lib/src/generated
...
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I0cee47b71702a210c5ace9455ce9aaf914355d05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152683
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 17:31:58 +00:00
a89b7a4ef7
Use ///-style doc comments in analyzer/lib/src/dart
...
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I5c4d112228ab2ee23f59743e005a5fde1ae2fff4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152681
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 16:48:18 +00:00
13a24f4de1
Issue 42474. Add LibraryElement.languageVersion
...
Bug: https://github.com/dart-lang/sdk/issues/42474
Change-Id: I316f34b14f01daa517182c1cb7b7c3fb038f0be2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-25 23:54:03 +00:00
d022d4c9e1
Migrator: Fix if-null promotion with GLB
...
Fixes https://github.com/dart-lang/sdk/issues/42375
EdgeBuilder wishes to do its own GLB type-joining, as does FlowAnalysis.
When FlowAnalysis pushes a promotion in ifNullExpression_rightBegin,
and then in write, and then pops those two promotions to join them in
ifNullExpression_end, EdgeBuilder is not given a chance to make its
own GLB node. Instead promotion never happens: the DecoratedType which
is the variable's type is promoted to non-nullable, for the left side.
The DecoratedType for the right side expression is not considered
non-nullable, so the FlowAnalysis.join will always fail to promote.
TypeOperations.adjustPromotedTypes solves this. It is a no-op in all
implementations except in EdgeBuilder.
Additionally FlowAnalysis.write's promotion fails for the same reason:
the only type of interest is the declared type made non-nullable, and
no matter what, the writtenType is not a subtype of this.
TypeOperations.forcePromotion solves this. It is a no-op in all
implementations except EdgeBuilder.
Change-Id: Iba6b9a69583af8fe1aa23124c7d66047acfff495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152104
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-25 21:09:12 +00:00
616ed353a2
Rename / deprecate FileResolver methods.
...
R=keertip@google.com
Change-Id: I684465db327f5f448a95f57a18cf65e172c09b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152603
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-25 20:59:32 +00:00
52d16dfbba
Resolve only relevant portion of the file for Cider completion.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Icf23a79f25baf309f88b737ac061a10a655d2f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-25 01:02:41 +00:00
2ec47ad273
Use ElementKind.ENUM for enums.
...
There was a crash internally, caused by the fact that when we have
duplicate name for class and enum, during linking we put them into
different Reference bucket - @class and @enum, and also inside
the class, the reference to its name is the class.
But when we resolve, we check equality of elements using not
references, but locations. So, we need to make sure that their
kinds are also different, so go into different bucket, and so
not equal.
When they are InterfaceType and equal, we would try to match
type arguments against the wrong number of type parameters and crash.
Change-Id: Iee3f8691adac65d4b0395ceec7fc7250f96afa88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-25 00:20:31 +00:00
ff83b0fec9
Add support for navigating from the URI in import and export configurations to the referenced file
...
Change-Id: Ic6234d9a24dcb52228067b20d69277e47ff89a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-24 22:46:33 +00:00
a1078d23c0
Remove the return type for inferring FunctionExpression formal parameters.
...
Change-Id: I5d1ae6b5f563ccbebf01c224d2dec439f0d6986e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-24 16:15:51 +00:00
77b0817f35
Deduplicate computing getter/setter types in override inference.
...
Change-Id: If800970fca69d0a85d3a23fd3dc4abb5b9b6bb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152209
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-24 16:15:42 +00:00
05167f3b63
Clean up isUnnecessaryCast() and many of its tests.
...
Change-Id: I74c509aa43fa7e8850b6e2026c570606a8cb18e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-24 05:16:01 +00:00
59b2bc0cdd
Clean up matching type parameters in FunctionExpressionResolver.
...
R=brianwilkerson@google.com
Change-Id: I4ad140fc76e65e7af4cd2e849e2d9e9aac68e9ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152205
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-23 22:42:45 +00:00
16a64f0bde
Check for PackageBuildPackageUriResolver in SourceFactory.packageMap
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/2558
Change-Id: I3270918320a9a15ca3175101da0337145179f6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152203
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-23 21:48:13 +00:00
6b630c3719
Enabled allowed experiments for the whole package, including bin/ and test/.
...
Change-Id: I617b80f0ea6a182d6e48eeb731c89cd5659cb567
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-23 18:30:23 +00:00
1d64ba0429
Merge 4 diagnostics for the purpose of documentation
...
Change-Id: I7e7a50ad924af9d200333d2d1640e3f8cd97a88f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151873
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-23 17:46:02 +00:00
ab73158758
Fix the windows bot and update MockSdk
...
Fixing the test that's causing the Windows bot to fail required updating
the MockSdk, which cause a lot of other changes. I would have done this
in two separate CLs if I'd known how big this was going to get, but I'm
hoping it isn't too big.
Change-Id: Idee56bab5e73a78ab7857e81177090493aa08b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151874
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-22 14:34:25 +00:00
197308560a
Add documentation for more diagnostics
...
Change-Id: Ib63182c67dfa0bef475871aa2104811c3a44dac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151882
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-19 20:46:32 +00:00
67173ade40
Record performance for analysis operations.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Ib85680d37f36c9a34f61b8d215a68ed2bd71f8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-19 20:15:35 +00:00
69843a8f04
Record performance with CiderOperationPerformance hierarchy.
...
This does not include breakdown for resolution yet.
I wonder if this more general information could replace specialized
CiderCompletionPerformance fields 'resolution', 'suggestions', etc.
WDYT?
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I4685dc2a8de8028ce84cc2640943f45c8cf047e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151811
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2020-06-19 17:33:03 +00:00
9239061138
Analyzer: Improve message of implicit_this_reference_in_initializer
...
Fixes https://github.com/dart-lang/sdk/issues/37293
Change-Id: I4b621171dcaf618e97c62acd110ce7c911e6c9e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151425
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-19 13:40:43 +00:00
Konstantin Shcheglov