f43912dfce
fix code completion in string literals
...
BUG=dartbug.com/22297
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907453005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:07:29 +00:00
bd8778a87b
Quick Assist to add explicit types to formal parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//908503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:03:39 +00:00
20b64a97a4
fix completion in for statement
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//862803008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:58:11 +00:00
84350e186c
fix named param default value code completion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:50:57 +00:00
dc95fd3689
use propogated type for completions
...
BUG=dartbug.com/21457
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:43:15 +00:00
fa0dc53f6f
fix code completion in conditional expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:33:07 +00:00
81ebd5fd77
Fix for extracting local variable in if-else-if statements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//879463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:36:56 +00:00
e5a34c3c12
fix completions in indexed expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:42:43 +00:00
2425d0c57c
const rename and cleanup
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:50:42 +00:00
8233434126
move relevance computation from client to server
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//901253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:36:19 +00:00
dbd0fa9d68
fix exception and improve keyword completion
...
BUG=dartbug.com/22231
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:18:42 +00:00
ef89b4c21a
tests for earlier CL
...
BUG=dartbug.com/21768
R=paulberry@google.com
Review URL: https://codereview.chromium.org//882273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:50:24 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
4229cb1c6f
use CompletionTarget for replacement offset/length
...
add code completion replacementLength and replacementOffset assertions
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//886463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
36ce6423a6
Fix for two semantic highlighting problems.
...
1. We need to dispose the existing semantic highlighting manager before setting a new input.
So, we would not apply old highlighting to the new file.
2. We need to clear "input" fields to correctly determine full file path.
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//882203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 19:55:25 +00:00
c5af5132fc
Issue 22191. Grab the document lock before positionsLock to prevent deadlock.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191
Review URL: https://codereview.chromium.org//885653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 18:33:16 +00:00
ea333d8459
Fix mixin resolution order when multiple mixins present.
...
BUG=dartbug.com/22069
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
a016a7b56e
Fix for 'Convert Method to Getter' when multiple files are changed.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:12:23 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
a9bc5e512d
Issue 22150. Quick fix to add a getter, in addition to create a field.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22150
Review URL: https://codereview.chromium.org//875193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43155 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:29:37 +00:00
2b8c66ea79
Rename ChangeNotice resolved Dart/Html unit fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
f32f6699bf
Fix for file:// package: references to the same element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//877693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43143 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:30:45 +00:00
26d43c80fc
Library dependency service tests.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//868873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43142 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 18:28:12 +00:00
30f1b97888
Handle generic parameters correctly in invocation completions.
...
When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters. This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//829173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43040 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 15:16:50 +00:00
cbd16a7336
add local parameter info to completion suggestions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//850003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42894 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:26:45 +00:00
a38a503d86
Replace @ReflectiveTestCase() with @reflectiveTest.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//849863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
0974f8b1ea
insert parameters when completing imported functions and inherited methods
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//811933007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42808 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 14:10:47 +00:00
cebcc398f6
Add support for completion of case labels.
...
This change addresses completions like the following:
switch (...) {
foo: case 1:
...
bar: case 2:
continue ^;
baz: case 3:
...
}
Completion at the point marked "^" will show "foo", "bar", and "baz"
as possible completions.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//806473007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42799 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:11:46 +00:00
14a97cafed
suggest fields rather than synthetic getters
...
and return dynamic returnType rather than null
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//791553007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 19:02:47 +00:00
531c591460
Completion support for loop labels.
...
Break and continue statements inside loops now have their targets
properly completed. Continue statements inside switch statements will
be addressed in a future CL.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//812593008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42781 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:37:46 +00:00
214a2380ca
Fix for NPE in the index store.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//823223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42777 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:38:52 +00:00
2005b07aea
Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int
...
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//845553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:30:59 +00:00
05ac43c3ea
Issue 22027. When parameters has function type alias type, use its name.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22027
Review URL: https://codereview.chromium.org//836413006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42720 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 22:10:36 +00:00
46df250c5a
suggest fields rather than synthetic getters
...
BUG=dartbug.com/21679
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42712 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:35:52 +00:00
dd306dc9eb
Enable enum and deferred import support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//829133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42704 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 17:51:49 +00:00
4fe7a9dd3e
Remove Angular support from the analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42697 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 16:04:17 +00:00
8393c92e89
exclude suggestions from other contexts
...
BUG=dartbug.com/21853
R=paulberry@google.com
Review URL: https://codereview.chromium.org//839713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42668 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 17:16:37 +00:00
94993d5cc1
Include required parameter names when completing a method call.
...
When a method such as "void m(int i, int j)" is completed, instead of
simply inserting "m()", we insert "m(i, j)", we highlight "i", and we
set up linked position groups for "i" and "j" so that the user can
press tab to move from one parameter to the next.
Optional parameters (both named and positional) are not handled by
this logic--the user must still enter them manually.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//837793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42667 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:57:39 +00:00
138572182c
Getter elements should not have parameters.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//831263007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42617 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 23:22:20 +00:00
9f64a926e6
Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21959
Review URL: https://codereview.chromium.org//832343004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42615 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 23:12:27 +00:00
712cd7cc87
Check if assists are requested on a invalid offset.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//823103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42609 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:58:20 +00:00
dca42cafab
Check if the method / accessor being inlined is synthetic.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//835093005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42606 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:36:39 +00:00
bc9c340ec5
fix local setter suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//831273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42599 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 17:26:51 +00:00
d645d2dce2
fix top level getter suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//832343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42597 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 15:55:15 +00:00
78a3bfe9c2
refactor/cleanup dart completion cache
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//816233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42556 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-22 22:09:46 +00:00
6d7155de63
Introduce CompletionTarget to take the place of the Node being completed.
...
Instead of locating the node containing the cursor offset using a
NodeLocator, identify the edge in the parse tree which will be
displaced or modified by the completion proposal. This reduces the
number of cases that need to be handled in the _OpTypeAstVisitor, and
avoids the need for the _OpTypeAstVisitor to consider character
offsets in nearly all cases.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//820773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42543 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 15:47:25 +00:00
d06e291c52
update completion cache key to include part directives
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//812233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42542 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 05:17:58 +00:00
e95dcac840
support part file completions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//815683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42541 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 05:15:50 +00:00
97f90d4acc
Fix for extracting from interpolated string.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907
Review URL: https://codereview.chromium.org//820763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42528 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 22:11:13 +00:00
049adb2777
refactor optype to be computed once per refactoring request
...
and hide optype computation internals
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//807743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42412 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:15:38 +00:00
danrubel@google.com