Commit Graph

1474 Commits

Author SHA1 Message Date
danrubel@google.com d22c027e0a add suggestions in format parameter list
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 15:13:57 +00:00
danrubel@google.com b7aeaab3f7 make deprecated elements have low suggestion relevance
BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 01:08:32 +00:00
scheglov@google.com 97bc20ffc5 Suggest names for PropertyAccess.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//646103006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41409 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 22:07:27 +00:00
scheglov@google.com bdd50e1230 Issue 21458. Support for 'Add type' Quick Assist in for-each loops.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Review URL: https://codereview.chromium.org//680133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41403 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 20:59:29 +00:00
danrubel@google.com 67071bd861 Refactor CompletionSuggestionKind
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 16:09:56 +00:00
danrubel@google.com e4b90d4cee add class type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41388 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 02:48:31 +00:00
danrubel@google.com 98d9096892 add functional type alias suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//682953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41376 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 22:03:16 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version).
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:42:46 +00:00
danrubel@google.com 2e5f738ad9 add type static constants suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41369 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:03:36 +00:00
danrubel@google.com 1a68218c36 suggest imported functions in argument list
BUG=dartbug.com/21446
R=scheglov@google.com

Review URL: https://codereview.chromium.org//683133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41368 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 19:03:37 +00:00
danrubel@google.com b41bc7b57e add property accessor suggestions
BUG=dartbug.com/21380
R=paulberry@google.com

Review URL: https://codereview.chromium.org//666863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41344 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 22:56:26 +00:00
scheglov@google.com a625b09fa8 Index EnumDeclaration definitions as top-level elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//685493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41341 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 21:56:55 +00:00
scheglov@google.com 2d38012c14 'Create Local Varaible' quick fix.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//677583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41280 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 14:55:38 +00:00
scheglov@google.com 227c5524d8 Issue 21375. Fix for FunctionTypeAliasElement-based FunctionType source.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21375

Review URL: https://codereview.chromium.org//672013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41254 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 04:24:59 +00:00
scheglov@google.com 3074fefa82 Issue 21372. "Convert into block body" and "Convert into expression body" for factory constructors.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21372

Review URL: https://codereview.chromium.org//664403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41230 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 15:32:55 +00:00
danrubel@google.com 946d40e8ac improve element parameter string returned by local suggestion computer
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//664523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41178 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:37:37 +00:00
danrubel@google.com 8da06376d3 update keyword suggestion priorities
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41177 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:35:41 +00:00
danrubel@google.com 582b276b6f filter invalid method invocation suggestions
and filter _ from local suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41159 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 21:25:46 +00:00
danrubel@google.com 8d47e699d9 filter void methods when suggesting expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//658053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41153 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 16:46:45 +00:00
danrubel@google.com 7c9dc9695b add imported inherited member suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41137 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:55:30 +00:00
danrubel@google.com 8465275f69 include locally inherited members in suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//657593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41114 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 03:25:20 +00:00
danrubel@google.com be3cc6897b exclude operators from "." suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//655733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41100 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 15:35:46 +00:00
danrubel@google.com 1766795d5f improve method invocation and string interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41091 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-14 06:07:58 +00:00
danrubel@google.com db9357f408 (TBR) fix the build
BUG=

Review URL: https://codereview.chromium.org//643923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41040 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 13:12:52 +00:00
danrubel@google.com eb0e7f5c0c suppress suggestions in string literals
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41039 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 12:52:20 +00:00
danrubel@google.com dd6b2426df add if statement condition suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//642973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41034 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 02:52:30 +00:00
scheglov@google.com 8f4ce65d53 Ignore case when sort members.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//646753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41033 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 23:48:19 +00:00
danrubel@google.com b45a2aa7ff include imported elements in interpolation suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//646773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41032 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:49:23 +00:00
danrubel@google.com e0b32d20f2 improve suggestions in for statement
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//645733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41031 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 22:17:53 +00:00
danrubel@google.com 56027f1dcb fix suggestions in class body and more common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//645573004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41027 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 21:00:15 +00:00
scheglov@google.com 68831585dd Fix for renaming import without an import prefix.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41021 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 16:25:07 +00:00
danrubel@google.com 029ed4968e binary expression suggestion fix
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//639183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41019 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-09 16:07:32 +00:00
danrubel@google.com 64db597677 import directive suggestion fix
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//639133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40999 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:46:22 +00:00
danrubel@google.com 5bdaa8ddcf combinator suggestion fix and more common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//644473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40998 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:38:42 +00:00
scheglov@google.com 9bcd836cf8 Search for function to import even when reported as UNDEFINED_METHOD.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//636293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40996 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 19:35:45 +00:00
danrubel@google.com b95d052249 more common code completion tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//636153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40995 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 17:56:31 +00:00
danrubel@google.com e4200b55d8 add suggestions for variable declaration assignment RHS
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//637703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40991 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 13:15:35 +00:00
danrubel@google.com e08c24ea56 show only type names in is expression RHS
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//635043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40977 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 20:24:40 +00:00
danrubel@google.com 6319b75048 cascade target fix and common test
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//633153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40970 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 18:54:34 +00:00
scheglov@google.com 53fe3d983f Issue 21233. Improve inlining strings into string interpolations.
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21233

Review URL: https://codereview.chromium.org//633823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40963 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 17:21:40 +00:00
danrubel@google.com 932218aea1 local cascade suggestion fix and move towards common tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//632323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40959 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 16:21:01 +00:00
danrubel@google.com 19e54e4f2b add named constructor, cascade selector suggestions and more tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//634653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40954 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 12:43:45 +00:00
scheglov@google.com e9e0694e2f Remove references to Engine classes from protocol.dart
R=brianwilkerson@google.com, paulberry@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//628293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40948 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 00:24:48 +00:00
danrubel@google.com 9cc5893d3d filter undesired suggestions from prefix expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//626303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40908 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-04 04:32:37 +00:00
danrubel@google.com a46a5b166d suggest re-exported elements of imported libraries
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//629633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40907 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-04 03:14:28 +00:00
scheglov@google.com 11644f7288 Fix for the prefix/suffix diff computing.
We need to exclude a common part of a prefix/suffix.
Also, I decided not to improve diff calculation, at least in the short term.
So, I'm removing diff.dart and the TODO comment.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//626883003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40903 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 17:31:55 +00:00
danrubel@google.com ef2982539d refactor library prefix suggestion generation
so the imported_computer is responsible for all suggestions
based upon import directives.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//620293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40900 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 16:02:36 +00:00
danrubel@google.com 206acf2715 cleanup/organize/improve completion tests
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//628473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40890 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 04:36:11 +00:00
danrubel@google.com 6f46e0296c improve completion test failure message by adding node info
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//620013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40885 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-02 16:30:30 +00:00
scheglov@google.com a863eecbfd Use simple prefix/suffix diff in members sorter.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//615313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40880 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-02 14:52:14 +00:00