dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
scheglov@google.com 28c4a74388 Tweaks for Element encoding and decoding. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1067363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45016 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 16:09:07 +00:00
danrubel@google.com a22a7c47ff do not suggest local functions 
BUG=dartbug.com/23131
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1076773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45014 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 15:58:59 +00:00
scheglov@google.com 976eeb8df4 Use file/offset/kind triplet as elements id. 
It saves about 20 MB for each ToDo MVC sample.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1075773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45011 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 15:21:12 +00:00
danrubel@google.com 0a1f0d3fc9 refactor optype to better filter invocation/prefixed suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1072623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45001 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 12:16:28 +00:00
danrubel@google.com de06a0607e fix NSMError in completion 
BUG=dartbug.com/23114
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1069813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44979 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-08 18:42:25 +00:00
danrubel@google.com a34401414c improve parser recovery for import statements 
BUG=dartbug.com/23108
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1068263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44978 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-08 18:26:00 +00:00
danrubel@google.com faf29a0686 improve parser recovery for import directives 
BUG=dartbug.com/23108
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1062343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44968 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-08 13:37:50 +00:00
danrubel@google.com 509dd4988a suggest loadLibrary is import is deferred 
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1065063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44953 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 22:20:04 +00:00
danrubel@google.com 2a7093fa25 suggest deferred/as keywords 
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1067143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44952 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 22:17:20 +00:00
danrubel@google.com ec456501b5 do not suggest elements from internal sdk libs 
BUG=dartbug.com/23104
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1064743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44939 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 16:52:43 +00:00
scheglov@google.com 4d9b8090a0 Tweaks for 'Encapsulate Field' assist. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1066913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 15:33:53 +00:00
danrubel@google.com 1e83a73221 rename completion source files to match content 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1068483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44921 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 17:46:39 +00:00
danrubel@google.com 259dac94cc rename completion computer to contributor 
* this will be followed by a separate CL that renames related files

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060713005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44918 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 17:25:09 +00:00
scheglov@google.com a9bbd436f5 Issue 13239. Add the 'Encapsulate Field' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13239

Review URL: https://codereview.chromium.org//1062823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44912 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 15:44:33 +00:00
danrubel@google.com 9eede4128e suggest dynamic and void when defining new compilation unit members 
BUG=dartbug.com/23063
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1048303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44895 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:18:39 +00:00
danrubel@google.com 9f492ecbe6 fix keyword completion in class body 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1057403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:12:56 +00:00
scheglov@google.com 8a1f8b158b Issue 23091. Fix for adding import prefix before string-interpolated identifier. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23091

Review URL: https://codereview.chromium.org//1059133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44893 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:58:59 +00:00
scheglov@google.com cadcd05f73 Issue 22988. Improve checking for conflicts between parameters and local elements during extracting methods. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22988

Review URL: https://codereview.chromium.org//1053323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44891 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:04:26 +00:00
danrubel@google.com 4e903a637e do not suggest completions for empty dot target 
BUG=dartbug.com/23095
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1056163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44887 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:38:50 +00:00
danrubel@google.com 8bf9e95e6e replace request.node with request.target 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1054363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44886 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:34:20 +00:00
scheglov@google.com 17ea180d2c Issue 23081. Fix for inlining into IndexExpression index. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23081

Review URL: https://codereview.chromium.org//1052243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44863 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 17:19:08 +00:00
danrubel@google.com 2329562cc0 replace request.node with request.target.containingNode in more situations 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44852 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 00:41:20 +00:00
brianwilkerson@google.com 83c9fe01a6 Fix a null-pointer reference and minor clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44844 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 20:57:33 +00:00
danrubel@google.com caff47a011 add type completions after "on" in a try block 
BUG=dartbug.com/23028
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44839 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 19:29:57 +00:00
scheglov@google.com 8bf13093b1 Fix removing type annotations for const/final variables. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1051733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44836 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 18:08:28 +00:00
danrubel@google.com cb0be1b4cf improve parser recovery when top level function is missing parameters 
BUG=dartbug.com/23044
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1044383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44822 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 20:49:19 +00:00
danrubel@google.com 39598962a0 fix NSM error when completing imported inherited private fields 
BUG=dartbug.com/23036
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44805 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 16:00:31 +00:00
scheglov@google.com 1dc26d9f06 Issue 23018. Fix for inlining multiline strings with leading whitespaces. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23018

Review URL: https://codereview.chromium.org//1042033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44771 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-28 02:31:07 +00:00
danrubel@google.com 8f4ac8f16b improve parser recovery for incomplete prefixed identifier in method/function parameter list 
BUG=dartbug.com/22526
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1033333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44760 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 20:05:18 +00:00
danrubel@google.com 2c188c493f remove invalid completions in method declaration param list 
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44758 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 19:42:37 +00:00
danrubel@google.com 6312e784a9 only suggest types when completing from a library prefix in parameter list 
BUG=dartbug.com/22526
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1035283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44756 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 19:39:28 +00:00
scheglov@google.com cdff0e1509 Test that the target node is a SimpleIdentifier. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1040733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44741 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-27 15:48:39 +00:00
danrubel@google.com 9b7edbfc8b fix exceptions when completing other edge cases 
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1022703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44697 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 20:20:00 +00:00
danrubel@google.com 18758d3d22 fix exception when completing between arglist and body 
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44687 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 17:27:44 +00:00
danrubel@google.com ac87c46ebd exclude identifier being completed from list of suggestions 
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027693007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44683 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 12:46:08 +00:00
scheglov@google.com a640643eeb Quick Fixes for unused catch clause/stack. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1020853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44636 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-23 17:10:14 +00:00
scheglov@google.com 85db3fbe62 Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1020243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44635 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-23 16:41:20 +00:00
danrubel@google.com 03cac10578 improve parser recovery of type argument list 
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1025903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-22 18:33:23 +00:00
scheglov@google.com cd1b09f5c3 Simplify rules for extracting getters. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1026503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44607 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-20 18:54:56 +00:00
scheglov@google.com 9f92f24c59 Issue 22851. Append comment tokens after sorted directives. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22851

Review URL: https://codereview.chromium.org//1019993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44591 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-19 20:54:40 +00:00
scheglov@google.com 39c3a6c255 Issue 22886. Quick fixes create getter' and 'create field' for hints. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22886

Review URL: https://codereview.chromium.org//1024573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44585 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-19 18:16:04 +00:00
scheglov@google.com 7eae9c4902 Fix for NPE in the field creation Quick Fix. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1013303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44542 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-17 20:29:47 +00:00
scheglov@google.com 4cdce46316 Issue 22757. Update self references on package rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1010803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44524 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 21:28:57 +00:00
scheglov@google.com ca64df1d44 Casted variable declarations for 'if (v is! Type)' should be declared after IfStatement. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1012913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44517 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 19:26:33 +00:00
scheglov@google.com a28e99b719 Issue 22757. Create pubspec.yaml file change on project rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1015513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44515 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 18:59:16 +00:00
scheglov@google.com b44673fef0 Quick Fix for adding field formal parameters of not initialized final fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1018433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44514 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 18:18:19 +00:00
scheglov@google.com b34d061d1f Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22834

Review URL: https://codereview.chromium.org//1014503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44509 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:26:58 +00:00
scheglov@google.com a9975332ac Issue 22833. Quick Assist to convert for-each into for-index. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22833

Review URL: https://codereview.chromium.org//1012623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44507 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:06:18 +00:00
scheglov@google.com dbf1e4cbe0 Quick Assist for creating a constructor for selected final fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1009833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44504 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 15:00:28 +00:00
scheglov@google.com 28764d3a93 Quick Fix for creating a missing part file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1013543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-15 23:39:50 +00:00