773c3cf9d1
improve import uri completions - fixes #24000
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1325583002 .
2015-08-31 15:21:34 -04:00
c0fe214c47
show all available import completion suggestions - fixes #23955
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1317023002 .
2015-08-26 17:37:01 -04:00
bd95b13b90
improve keyword suggestions - fixes #24016
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1303233008 .
2015-08-26 17:34:57 -04:00
f61faa2fbd
exclude instance suggestions in static context - fixes #22932
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1319753002 .
2015-08-26 14:00:03 -04:00
271bc1f776
Convert completion API to be future based
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1318543002 .
2015-08-25 11:01:13 -07:00
4bd6b4b048
Fix display of parameter lists in servers Element structure (issue 24194)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1313113002 .
2015-08-25 09:23:26 -07:00
aea1e572a1
Sort top-level constants before other top-level variables.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//1306083003 .
2015-08-21 12:19:48 -07:00
0aaa3bd0a4
reformat and 2 new tests for #23501
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1290743003 .
2015-08-17 11:20:20 -04:00
e2f6739b44
tests for keyword/identifier replacementOffset - asserts fixes #23906 and fixes #23947
...
requires these CLs:
https://codereview.chromium.org/1281793004/
https://codereview.chromium.org/1287603003/
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1278033006 .
2015-08-15 15:18:03 -04:00
9af696a4f7
suggest prefixed constructors - fixes #23210
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1291283002 .
2015-08-14 20:33:12 -04:00
f3f52d4b59
Fix regression in import fixups introduced by .packages support.
...
With the introduction of support for ".packages" files, analysis
server now uses a slightly different code path for translating the
Source objects from imported package files into "package:" URI's.
Previously it used PackageUriResolver.resolveAbsolute(); now it uses
ResourceUriResolver.resolveAbsolute(), and then translates the
resulting file: URI to a package: URI uring the .packages file.
The old code path used Source.fullName (the file path) to locate the
file in the filesystem; the new code path uses Source.uri. This
causes problems because when figuring out the correct import statement
to insert, the analysis server creates a bogus Source object whose uri
field is null. As a result, import fixups were getting relative paths
like "../../../../.pub-cache/..." rather than package imports, which
is clearly wrong.
As a short term non-invasive fix, we set Source.uri in the bogus
Source object, so that the new codepath is able to find the path of
the imported file.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1281313002 .
2015-08-10 12:14:26 -07:00
07d94ad596
fix completion after dot-keyword - fixes #23882
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1273773005 .
2015-08-10 11:11:51 -04:00
3bbf03ba7b
suggest "in" in for statement
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1285573003 .
2015-08-10 10:43:27 -04:00
f79d02ddd0
remove complex keyword suggestions - fixes #23978
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1280313002 .
2015-08-10 10:09:18 -04:00
8ac02a9a24
suggest constructor named param
...
fixes #24004
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1283443004 .
2015-08-07 13:09:47 -05:00
a05ee55f03
suggest import uris when import is only text in file
...
prevent keyword suggestion in import uri without semicolon
fixes #24002
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1276273003 .
2015-08-07 12:25:25 -05:00
3b8b7ee7a2
suggest "deferred as" rather than "deferred"
...
suggest show and hide in import declaration
fixes #23967
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1276843007 .
2015-08-06 16:02:58 -07:00
65941839b7
Remove also duplicate imports.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1277983002 .
2015-08-06 12:42:30 -07:00
908708d655
More fixes for failures on the Windows bot
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
a6ea45883d
add location to suggestions from local file
...
fixes #23905
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1267203002 .
2015-08-04 22:12:01 -07:00
bf05b75f43
update suggestion element return type to have type param
...
cleanup loadLibrary suggestion to have correct element
dartbug.com/23905
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1260593005 .
2015-08-04 22:08:55 -07:00
d11b644cc5
Issue 23963. Improve to/from block/expression body with void expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23963
Review URL: https://codereview.chromium.org//1267333003 .
2015-08-04 16:16:17 -07:00
fbb7aedee5
WEB-17598. Name new libraries according to the Dart Style Guide.
...
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-17598
https://github.com/dart-lang/sdk/issues/23972
Review URL: https://codereview.chromium.org//1253103007 .
2015-08-04 14:47:30 -07:00
60ab26dc30
Simplify directive's optimizer edit.
...
There was also a bug in computing common range.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1272013002 .
2015-08-04 13:14:27 -07:00
fde3b1b335
better completions in switch statements
...
Closes #23527
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1255953004 .
2015-08-03 14:06:30 -07:00
e8e6cf823a
fix completion replacement offset/length for invalid token in switch statement
...
Closes #23947
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1271723002 .
2015-08-03 14:02:40 -07:00
9d5154a1fd
include exported library namespace in prefixed import suggestions
...
Closes #23946
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1263093003 .
2015-08-03 13:52:44 -07:00
64ff591f56
Organize directives implementation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1266393002 .
2015-08-03 13:49:57 -07:00
e5b4713f03
'Import library' and 'Create class' Quick Fixes for unresolved class-like name in list literals.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1269043003 .
2015-08-03 13:03:28 -07:00
23f96f1916
Renames to move closer to the new API
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1240433008 .
2015-07-17 12:20:02 -07:00
27f600058e
Improve propagation in binary expressions
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1226823003 .
2015-07-08 08:02:05 -07:00
b62e8fbca9
New Quick Assist - 'Convert to field formal parameter'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1216463004 .
2015-07-07 14:57:43 -07:00
0bb5179b84
Quick Assist for converting field formal parameters into normal parameters and initializers.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1217593006 .
2015-07-06 11:19:30 -07:00
bee94603a0
Warning fix.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1209633002 .
2015-06-24 09:35:30 -07:00
8b9578ef26
add for() keyword suggestion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1179283007 .
2015-06-20 15:01:20 -04:00
ce311218e9
suggest keywords in if expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1147213008 .
2015-06-12 09:50:10 +02:00
9c9108d51a
no keyword suggestions in library identifier or property accessor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1151493004 .
2015-06-12 09:39:40 +02:00
4224b9c049
fix ENUM_CONSTANT suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1157283004
2015-06-04 18:01:06 -04:00
b35d54a8b7
Decide if unit without directives is a part or a library.
...
1. When there is a library containing it while we are parsing a part.
2. When a part was parsed, but then we found a library containing it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1167733004
2015-06-02 16:01:01 -07:00
a567814119
Replace 'Element.node' with 'Element.computeNode()'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1164823003
2015-06-02 13:25:04 -07:00
8e439849b3
Issue 23573. Catch exception during indexing.
...
R=paulberry@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23573
Review URL: https://codereview.chromium.org//1168473003
2015-06-02 09:40:20 -07:00
40e925078f
Bug fixes for the new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1144393006
2015-06-01 16:42:36 -07:00
aad76fdcbf
Issue 23568. Fix for NPE in index when unresolved field formal parameter.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568
Review URL: https://codereview.chromium.org//1162853004
2015-06-01 15:08:33 -07:00
b9cdbace93
Issue 23545. Replace unaccessible type parameters with 'dynamic'.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545
Review URL: https://codereview.chromium.org//1147213005
2015-06-01 14:50:39 -07:00
a3a40c9ef6
Issue 11200. Quick Fix for adding required/positional parameters.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200
Review URL: https://codereview.chromium.org//1159273004
2015-06-01 14:48:50 -07:00
be9cd1c165
Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551
Review URL: https://codereview.chromium.org//1151183003
2015-06-01 14:19:33 -07:00
f1d4ef9164
Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'.
...
This fixes the corresponding 'Extract Method' issue.
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409
Review URL: https://codereview.chromium.org//1161343002
2015-06-01 12:40:30 -07:00
c1c0354014
Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239
Review URL: https://codereview.chromium.org//1161333002
2015-06-01 12:26:39 -07:00
5b44136f2a
Issue 23389. Report error in the renamed element be invisible after rename.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389
Review URL: https://codereview.chromium.org//1153253004
2015-06-01 10:40:59 -07:00
0e39092fd0
add enum suggestions
...
and update LocalDeclarationVisitor to visit enum declarations
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1157113004
2015-06-01 12:10:46 -04:00
danrubel