e03c395a8c
extract TypeMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504223005 .
2015-12-09 07:38:20 -05:00
b05ae45575
Extract Local refactoring: provide a linked edit group for the name.
...
This will support in-place rename after extract in IDEA.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1502183007 .
2015-12-08 15:27:05 -08:00
dcacf6145b
extract LibraryMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507303002 .
2015-12-08 15:10:32 -05:00
c66a5d3fb5
suggest async* and sync* - fixes 24554
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509193003 .
2015-12-08 15:07:35 -05:00
72cf3cbe91
Remove unnecessary 'noSuchMethod' declarations.
...
Also format these file.
I don't like how the new formatter changed the code :-(
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1507813004 .
2015-12-08 11:39:37 -08:00
4c28eb6f67
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-08 10:16:29 -08:00
088b50f8a9
extract StaticMemberContributor from PrefixedElementContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1505703003 .
2015-12-07 17:15:14 -05:00
20909182b0
add suggestion for partial named parameter - fixes #24758
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504233002 .
2015-12-07 17:13:06 -05:00
ea3ba0e31f
Remove deprecated code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1502213002 .
2015-12-07 10:24:36 -08:00
89168a1956
add completions in assert stmt - fixes #24888
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509523002 .
2015-12-07 12:51:02 -05:00
55a8740ba1
extract named constructor suggestions from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507633002 .
2015-12-07 11:58:39 -05:00
de3a1b22c8
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-07 07:04:07 -08:00
9dd5b25d50
extract field formal contributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507513002 .
2015-12-07 08:05:00 -05:00
372cb6be58
fix combinator contributor
...
gracefully degrade given partially element information
better reporting of exceptions during testing
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1506623002 .
2015-12-06 15:34:19 -05:00
4f654473ff
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-06 08:41:24 -08:00
a5e4c81b7f
move combinator contributor to new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1503463002 .
2015-12-04 15:48:21 -05:00
dd9ad7e015
Skip assignments and argument lists.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1496363002 .
2015-12-04 11:43:39 -08:00
cd03a05caf
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-04 09:06:41 -08:00
9f033a9d94
convert uri contributor to use new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1498733005 .
2015-12-04 07:49:31 -05:00
7b5a756b0f
extract ReplacementRange for use in tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1499003002 .
2015-12-03 20:59:29 -05:00
767b57bafd
Extract Local refactoring: skip method names in invocations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1498523005 .
2015-12-03 15:19:36 -08:00
4379efb6b4
rework ArgListContributor to use new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1500793003 .
2015-12-03 18:00:50 -05:00
7d3c4743db
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-03 14:22:24 -08:00
6fd2fba704
hookup new CompletionContributorFactory
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1500723002 .
2015-12-03 13:34:35 -05:00
c2b70c9054
improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1497773002 .
2015-12-03 10:34:00 -05:00
5f49df1644
Issue 25095. Add 'Change X to Y type annotation' Quick Fix.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25095
Review URL: https://codereview.chromium.org/1492053004 .
2015-12-02 18:50:41 -08:00
43f027fc05
Analysis request getReachableSources ( #24893 ).
...
Implements a new request to get reachable sources.
This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").
More context here: https://github.com/dart-lang/sdk/issues/24893
R=brianwilkerson@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org/1491013002 .
2015-12-02 13:26:35 -08:00
600fc17de1
Clean-up the registration of plugins
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1487953002 .
2015-12-02 13:25:28 -08:00
bf54a3bef6
Don't attempt to create a file for non-Dart imports.
...
This should help to fix the following exception:
Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
Bad state: No element
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1492843003 .
2015-12-02 09:28:58 -08:00
cfc8ee30b7
Fix for exception in FixProcessor._addFix_illegalAsyncReturnType.
...
This fixes the following reported exception.
Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
The null object does not have a getter 'offset'.
NoSuchMethodError: method not found: 'offset'
Receiver: null
Arguments: []
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1487683006 .
2015-12-01 14:37:11 -08:00
6fb4f45d6b
- move completion contributor extension into new DartCompletionPlugin
...
- change DartCompletionContributorFactor to return single contributor rather than list of contributors
- remove server field from completion request
- update comments per prior review
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1484853002 .
2015-11-30 13:53:22 -05:00
6859412fac
Issue 24865. Quick Fix 'Create Method' should create named parameters.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24865
Review URL: https://codereview.chromium.org/1475743003 .
2015-11-24 14:55:39 -08:00
67e4b7d081
Convert all 'wrong' test to 'BAD'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1469333003 .
2015-11-24 14:02:01 -08:00
d176336e59
remove redundant CompletionRequestImpl class
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1469393003 .
2015-11-24 16:17:51 -05:00
0168336439
create new Dart specific completion contributor extension point
...
and modify DartCompletionManager to use it
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1470373002 .
2015-11-24 16:12:55 -05:00
c0c11daa15
Disable merging of 'if' statements when there are other staments in the outer one.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1473513003 .
2015-11-24 13:06:20 -08:00
b9ad8a15e4
hook new DartCompletionContributor API into existing framework
...
and convert KeywordContributor to use new DartCompletionContributor API
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1471173003 .
2015-11-24 12:03:44 -05:00
594183e0db
Rework contribution sorter to use futures
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1470863003 .
2015-11-23 21:35:52 -05:00
0ae251793f
Make index provisional API.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1471073002 .
2015-11-23 12:54:55 -08:00
2cbd3d3803
rename file to prevent bots from running it as a test
...
Review URL: https://codereview.chromium.org/1468143002 .
2015-11-23 13:16:57 -05:00
38cec67d03
step toward new completion API
...
- separate new CompletionContributor and DartCompletionContributor APIs
- revise new APIs and implementations to be Futures based
- revise InheritedContributor to use new Futures based contributor API
- remove unused classes
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1467023002 .
2015-11-23 12:50:12 -05:00
1e05c35650
Issue 25021. Fix for adding new required parameters when optional exist.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25021
Review URL: https://codereview.chromium.org/1468913004 .
2015-11-23 09:21:11 -08:00
6ce9b7faeb
(TBR) fix completion test
...
Review URL: https://codereview.chromium.org/1469963002 .
2015-11-23 12:09:52 -05:00
53e9cce24d
Quick assist for converting block documentation comments into line ones.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1470753002 .
2015-11-22 19:57:03 -08:00
bb1914e175
Make FixContributor asynchronous.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1461313004 .
2015-11-20 14:57:00 -08:00
b2728c15a6
Revert "Fix test failures on the bots"
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1468623002 .
2015-11-20 14:04:11 -08:00
ae1bee3859
Make AssistContributor asynchronous.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1461343002 .
2015-11-20 12:18:26 -08:00
6b45d6544c
Fix test failures on the bots
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1467623002 .
2015-11-20 11:48:35 -08:00
2b59830f49
Convert into block documentation comment assist.
...
I found out that I don't like the /// style.
So, I'm going to convert the Angular2 analysis plugins to the block style.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1466623002 .
2015-11-20 08:11:28 -08:00
eee07a4815
update completion sorter to new API
...
first step updating to the new completion API
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1447503002 .
2015-11-16 23:01:43 -08:00
danrubel