31b1288f06
Fix for test - don't depend on the order of errors.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1434063002 .
2015-11-11 14:03:54 -08:00
128250a9ea
Compute covering offsets/lengths.
...
Drop support for binary expressions fragments.
Reduce number of reported problems, provide best guess results instead.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1431673003 .
2015-11-02 18:22:12 -08:00
765c7fd0f1
Mark HintCode.CAN_BE_NULL_AFTER_NULL_AWARE as fixable.
...
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org/1428903002 .
2015-10-30 08:02:29 -07:00
851dc4ea97
Quick Fix for CAN_BE_NULL_AFTER_NULL_AWARE.
...
Also fix for false positive :-(
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1423993005 .
2015-10-29 13:47:17 -07:00
52fb3b3bab
Introducing a lint server plugin.
...
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/ ). Also soon to be future home for fixes and completions.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1410553005 .
2015-10-26 12:11:38 -07:00
cbea0dedf9
Issue 24714. Check other libraries that define unresolved class.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24714
Review URL: https://codereview.chromium.org/1413973007 .
2015-10-26 11:32:59 -07:00
68dc36a3e7
OptionsValidator plugin extension and linter service.
...
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.
You'll notice that the warning code I added is NOT in `errors.dart`. I did that in anticipation of plugin-specifc warnings living elsewhere. If that's not the right angle, happy to un-do!
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1418333002 .
2015-10-26 08:50:55 -07:00
5bd191ee12
fix import uri completion exception - fixes #24709
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1418123004 .
2015-10-23 14:55:20 -04:00
f18a0209fb
Fix for 'Assign to Local Variable' in closures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1415253002 .
2015-10-21 13:20:22 -07:00
5f71b2e7cd
Check that AnalysisContext is not null.
...
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1418513002 .
2015-10-19 13:27:50 -07:00
ea947094ae
Fix for suggesting methods as a *name* of a local variable declaration.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1417603002 .
2015-10-19 12:29:22 -07:00
948b21a8cf
(TBR) update test to run with new task model
...
Review URL: https://codereview.chromium.org/1413963002 .
2015-10-19 12:04:51 -04:00
3b198ed6ae
Disable completion of formal parameter names as *types*.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1414653002 .
2015-10-18 13:28:12 -07:00
af4fbdd952
Index library/part file references from import/export/part containing files.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1407863004 .
2015-10-18 10:24:53 -07:00
ce6614f2dc
Disable completion in comment text.
...
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1410893002 .
2015-10-16 10:38:47 -07:00
586a1f359a
Fix for renaming (an invalid) ClassElement invocation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1385403007 .
2015-10-12 12:21:12 -07:00
2bbb40d0e2
Warn about conflict before renamed class member and enclosing class name.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398213004 .
2015-10-12 12:10:12 -07:00
307438d582
Return 'null' rename refactoring in case of a null element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1397403002 .
2015-10-12 10:44:31 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
8f4c63c92b
Restructure the public API for server
...
R=danrubel@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
abfa9bf46a
Move getCamelWords() to the strings.dart file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1394933003 .
2015-10-08 21:31:27 -07:00
63d8b70fce
Add 'Add != null' quick fix.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518
Review URL: https://codereview.chromium.org/1393953002 .
2015-10-07 10:18:23 -07:00
d14a963546
only send final completion notification
...
This shaves 1 ms off the average completion notification response time
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1389473002 .
2015-10-06 14:21:29 -04:00
7bbd8c66a5
Move completion APIs to private location
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
147581cf34
Remove the 'name' and 'length' getters from IndexableObject.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1378843003 .
2015-10-05 07:27:50 -07:00
e6053aa135
Rollback https://codereview.chromium.org/1380223003
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1390463002 .
2015-10-04 17:07:10 -07:00
1af7b154af
Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694
Review URL: https://codereview.chromium.org/1380223003 .
2015-10-04 16:16:45 -07:00
0b01edac17
More tests for 'Organize Directives'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1380893003 .
2015-10-02 13:11:34 -07:00
c06ad0db30
Issue 24420. Don't allow renaming in pub packages.
...
There are no ideal solution for this.
But all our users want it somehow.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24420
Review URL: https://codereview.chromium.org/1380253003 .
2015-10-02 13:09:55 -07:00
04e21a2a7c
Completions with exact prefix should be prioritized - fixes #23099
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1369033002 .
2015-10-02 15:12:23 -04:00
6e441f62e8
only suggest rethrow inside catch block - fixes #24214
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1360123003 .
2015-10-02 15:10:14 -04:00
8eef458f9c
add completion after export - fixes #24400
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1368173004 .
2015-10-02 13:00:06 -04:00
a24ae72e74
suggest argument name completions for annotations - fixes #24296 and fixes #24259
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1362353003 .
2015-10-02 12:54:22 -04:00
db4e79b74d
Issue 24459. Fix for 'Create Method' QF in different unit.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24459
Review URL: https://codereview.chromium.org//1375043004 .
2015-09-29 21:29:07 -07:00
5bc38481a7
Report a fatal error on attempt to rename an element declared in SDK.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1377623002 .
2015-09-28 14:00:13 -07:00
6cd9e0da71
Do not suggest static fields in constructor initializer - fixes #24256
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1365403002 .
2015-09-26 11:59:15 +02:00
6bab7d9cbc
Use Element.nameLength where possible.
...
...or don't use it when there is a better alternative.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1372673003 .
2015-09-25 15:03:46 -07:00
4f8649f1b3
Issue 24442. Fix for renaming library names with spaces.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24442
Review URL: https://codereview.chromium.org//1370793003 .
2015-09-25 13:55:13 -07:00
805f6ec3ba
Record HAS_ANCESTOR relations into index.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1371463002 .
2015-09-24 16:21:09 -07:00
6899986bfe
Use TypeSystem in the 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1364803003 .
2015-09-23 10:28:50 -07:00
4aa6466ccb
Use IndexContributor(s) in LocalIndex.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
531f1d1e5b
Extract Dart specific node management into DartUnitIndexObjectManager.
...
We want to be able to index not just CompilationUnitElement(s), but also
for example results of Angular resolution, which while are based on resolved
CompilationUnit(s), are not ready together with it, so should live in separate
split index nodes.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1359023002 .
2015-09-22 12:26:41 -07:00
f67bc2f546
Replace NameElement with IndexableName.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1347943006 .
2015-09-21 12:02:34 -07:00
d6051a53a0
refactor ContributionSorter to use new API
...
move CompletionTarget to public API
modify DartCompletionRequest to return completion target
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1347283005 .
2015-09-18 16:03:22 -04:00
42593f4094
(TBD) Disable broken test
...
Review URL: https://codereview.chromium.org//1358493002 .
2015-09-18 09:17:01 -07:00
f4b1879180
Add a completion for inherited methods
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1338173002 .
2015-09-18 08:59:56 -07:00
cf88943a10
Issue 24338. Don't propose creating a local class for prefixed identifiers.
...
Importing with prefix would take more time than I'd like to spend now.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1336323003 .
2015-09-14 08:17:18 -07:00
42d1d4532d
Reformat code to minimize churn
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
f0cbf430e0
Issue 24298. Fix for 'async' function body conversion.
...
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298
Review URL: https://codereview.chromium.org//1324323004 .
2015-09-04 21:39:28 -07:00
07184f6cdd
rename ImportUriContributor to UriContributor
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1329463002 .
2015-09-01 11:11:36 -04:00
Konstantin Shcheglov