dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
scheglov@google.com da0cecb331 Issue 22845. Rename should prevent the use of invalid identifiers. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22845

Review URL: https://codereview.chromium.org//1011613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44495 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-15 19:55:57 +00:00
danrubel@google.com 0a63518267 include library prefix completions given trailing local method invocation 
BUG=dartbug.com/22790
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1008973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44491 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-14 03:09:29 +00:00
danrubel@google.com 31339e3a62 Completion should not show overridden inherited methods 
and centralize checking for duplicate suggestions

BUG=dartbug.com/22396
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1004343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44490 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-14 03:07:12 +00:00
danrubel@google.com 5903f0c31c include unimported sdk lib types as low priority suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1000223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44473 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 19:15:46 +00:00
danrubel@google.com 676e027663 remove duplicate completion suggestions 
BUG=dartbug.com/22684
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1001143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44444 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 21:40:55 +00:00
danrubel@google.com e867811d28 include constructor arguments in completion suggestions 
BUG=dartbug.com/22364
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1006593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44438 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 18:46:06 +00:00
danrubel@google.com 47128e2603 completions in map literals 
BUG=dartbug.com/22784
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1002713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44432 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 15:24:57 +00:00
danrubel@google.com 8a04710a47 add completion in type argument list 
BUG=dartbug.com/22584
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1005483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44431 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 15:20:08 +00:00
danrubel@google.com fcc0559acd completions for function return type 
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//999923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44415 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 21:19:57 +00:00
danrubel@google.com fc4de72889 completion for method return type after comment 
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//996263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44409 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 17:44:25 +00:00
danrubel@google.com 6c1a40377c fix completion target handling of comments 
The intent is to normalize the completion target returned given different comment arrangements.
This is a precursor to the fix for code completions given preceeding comments.

BUG=dartbug.com/22686
R=paulberry@google.com

Review URL: https://codereview.chromium.org//985183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44408 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-11 17:38:53 +00:00
scheglov@google.com 51870ff901 Quick Fix for using similarly named field/getter/setter instead of undefined. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//991133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44357 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-10 03:09:00 +00:00
scheglov@google.com 7a8603736d Quick Fix for returning Future from 'async' functions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//987173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44348 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-09 21:35:31 +00:00
scheglov@google.com 60d4a29500 Fix for subscribing for notifications for files in packages. 
Unfortunately this fix makes the server about 20% slower.

This is mostly because of the check in scheduleNotificationOperations(),
as required to fix dartbug.com/22210. I think it is much cheaper to send
duplicate notifications, like outline or navigation, than to check if
they should not be sent.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//987663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44305 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-06 22:55:20 +00:00
danrubel@google.com b9baf4be94 add completions after final keyword 
BUG=dartbug.com/22683
R=scheglov@google.com

Review URL: https://codereview.chromium.org//978923006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44277 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-06 02:02:28 +00:00
danrubel@google.com 45118de875 remove type suggestion when interpolation completion 
BUG=dartbug.com/21518
R=scheglov@google.com

Review URL: https://codereview.chromium.org//982983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44276 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-06 01:58:42 +00:00
danrubel@google.com f8b6da83c6 When target requires a function, propose a function reference, not an invocation 
BUG=dartbug.com/22360
R=scheglov@google.com

Review URL: https://codereview.chromium.org//977223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44271 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-05 21:25:58 +00:00
danrubel@google.com b820aef91c fix constructor suggestion element names 
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//962243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44183 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 17:03:24 +00:00
scheglov@google.com 75fc8fd45c Some clean-ups for Index / SearchEngine. 
1. Remove the TODO, it is better to keep searchTopLevelDeclarations() returning Future,
   for consistency and possible future changes.

2. Rename IndexStore.recordTopDeclaration() to recordTopLevelDeclaration().
   Sorry, I missed it initially.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//975753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44182 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:54:56 +00:00
scheglov@google.com b6836ac439 Restore the test for an unknown element search. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//975743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44181 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:53:54 +00:00
danrubel@google.com 7c9de023c2 include library prefix suggestions when suggesting constructors 
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44179 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:51:18 +00:00
scheglov@google.com 1183b3b35a When a closure is extracted as a method, it does not have any return type. 
But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//970063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44177 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:17:33 +00:00
scheglov@google.com d69f9043cd Don't allow to extract a closure as a getter. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//971203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44176 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:15:47 +00:00
danrubel@google.com 7e9557cb39 add arguments to constructor completions 
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44174 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 15:58:50 +00:00
brianwilkerson@google.com cd58e290c4 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 22:43:12 +00:00
scheglov@google.com 253658afa8 Optimize top-level element declarations search. 
No limits on the number of returned matches yet.
With this CL it takes about 20 ms for one-character regexp, vs. 200+ ms before.

The Editor UI is still not quite fast, we need to set some limits there too.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//971833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44145 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 19:56:13 +00:00
scheglov@google.com fde14c072a Issue 22593. Quick fix 'import library' for typedefs. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22593

Review URL: https://codereview.chromium.org//965013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44112 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-28 01:40:34 +00:00
danrubel@google.com d91099d6cb fix invocation completion with trailing stmt 
BUG=dartbug.com/22365
R=scheglov@google.com

Review URL: https://codereview.chromium.org//965753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44100 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-27 18:42:41 +00:00
danrubel@google.com 28979ebefc test for interpolation completions 
BUG=dartbug.com/21637
R=scheglov@google.com

Review URL: https://codereview.chromium.org//966773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44097 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-27 17:52:18 +00:00
scheglov@google.com 98c9558a23 Issue 20827. Import required type in 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827

Review URL: https://codereview.chromium.org//956393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44059 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-26 17:08:13 +00:00
scheglov@google.com ec8ab11a9d Issue 20827. Extract library importing helper and use it fox Quick Fixes. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827

Review URL: https://codereview.chromium.org//961583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44052 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-26 15:57:10 +00:00
scheglov@google.com 08cff379ca Don't propose 'Assign to local variable' when in arguments list. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//943053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44036 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-26 01:34:25 +00:00
scheglov@google.com d7672348a1 Issue 21978. Put function 'main' first when sorting members. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21978

Review URL: https://codereview.chromium.org//961443004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44032 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-25 22:40:26 +00:00
scheglov@google.com b36efe9640 Field references in field format parameter declarations and initializers mean writing. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//949623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43971 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-23 18:45:30 +00:00
scheglov@google.com acec842aee Add 'Convert Method to Getter' proposal only if it is an available refactoring. 
So, that we don't show it for method with parameter or returning null.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//945113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 23:18:21 +00:00
scheglov@google.com 946d56198e Fix for searching constructor references. 
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.

With this change to ConstructorElement we don't need to have these artificial references.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//946023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:10:30 +00:00
scheglov@google.com 0348d0decd Issue 22288. Rename named parameters in hierarchy. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288

Review URL: https://codereview.chromium.org//945693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:08:18 +00:00
danrubel@google.com 45acfc4524 fix code completion invocation on getter 
BUG=dartbug.com/22376
R=scheglov@google.com

Review URL: https://codereview.chromium.org//929323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 22:14:52 +00:00
scheglov@google.com 1e120443b5 Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body. 
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879

Review URL: https://codereview.chromium.org//935123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 23:17:10 +00:00
scheglov@google.com 55a3255070 Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests. 
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//923103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 20:01:45 +00:00
danrubel@google.com a56ac2f521 update code completion suggestion relevance based on common usage 
BUG=
R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//925723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-15 21:17:48 +00:00
scheglov@google.com ef1e368409 Improve code generation for 'bottom' and 'dynamic' arguments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//924783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43780 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-13 21:02:34 +00:00
scheglov@google.com 0b922f3d22 Quick Fix for an undefined class in is/as expressions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 01:31:53 +00:00
paulberry@google.com acaed71dba Clean up analyzer and analysis server hints. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43667 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 20:40:26 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 19:14:01 +00:00
scheglov@google.com 07d2c82919 Issue 22316. Don't propose to create invalid local variable. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316

Review URL: https://codereview.chromium.org//895773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 16:45:43 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions 
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-07 00:56:15 +00:00
scheglov@google.com 8cee600323 Don't propose fixes to update SDK sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//902273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:21:48 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:13:37 +00:00
scheglov@google.com 2593c00b36 Quick Fix for adding 'async' to fix invalid 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//894373005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 21:10:11 +00:00