Commit Graph

733 Commits

Author SHA1 Message Date
Brian Wilkerson 40e925078f Bug fixes for the new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1144393006
2015-06-01 16:42:36 -07:00
danrubel 0e39092fd0 add enum suggestions
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
2015-06-01 12:10:46 -04:00
danrubel ecf44e960d remove keyword suggestions in constructor names and prefixed expressions
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1158413003
2015-05-29 13:28:34 -04:00
danrubel@google.com ee3263c22c reduce rethrow keyword relevance
so that return is prioritized over rethrow

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1135243006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45809 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 02:35:23 +00:00
brianwilkerson@google.com 0bf3812043 Fix exception in code completion (issue 23439)
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1138963005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45805 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 00:00:59 +00:00
danrubel@google.com a0099fc922 suggest async for closures
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1135613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45711 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:30:35 +00:00
danrubel@google.com 4e3e55276a suggest keywords for more expressions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1141443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45708 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:17:44 +00:00
danrubel@google.com d2164273da check for package lib exist before making package suggestions
BUG=dartbug.com/23428
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1128833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45706 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 18:48:15 +00:00
danrubel@google.com 4d0cce227d Sort the containing method first in completions following super
BUG=dartbug.com/22850
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1121773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45539 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 21:11:11 +00:00
danrubel@google.com b05fb8ba98 suggest only superclass elements for "super."
BUG=dartbug.com/23208
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1127643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 19:09:51 +00:00
danrubel@google.com 0ae83bf868 (TBR) fix the build
BUG=dartbug.com/23073

Review URL: https://codereview.chromium.org//1126703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45512 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 21:49:54 +00:00
danrubel@google.com be90dce1de fix file uri suggestions on Windows
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1120113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45500 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:16:46 +00:00
danrubel@google.com 2c96ad2af5 update relevance for named param suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1120023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45499 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:13:41 +00:00
danrubel@google.com 6368514b6d improve import suggestion
BUG=dartbug.com/19941
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1113063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45497 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:02:23 +00:00
danrubel@google.com 2527d6b840 (TBR) fix the build
BUG=

Review URL: https://codereview.chromium.org//1118313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45468 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 15:50:21 +00:00
danrubel@google.com e2d3e3b09f suggest part file uris
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45467 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 02:29:27 +00:00
danrubel@google.com e6e1182a6d add import file uri suggestions
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1117963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45464 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:37:07 +00:00
danrubel@google.com 85e1841e35 suggest keywords for switch statement and expressions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:35:35 +00:00
danrubel@google.com af475ead16 restructure internal request to implement CompletionRequest API,
move performance tracking out of internal completion request,
and add resourceProvider to request

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1115843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45455 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 05:09:03 +00:00
danrubel@google.com a7fa3c85c2 suggest async/await
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1103643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45415 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 21:39:57 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 12:51:52 +00:00
danrubel@google.com 1330c1f1ee provide importUri for packages and include those suggestions
BUG=dartbug.com/23175
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45377 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 16:24:57 +00:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
danrubel@google.com 8f7079de3d fix NSM in suggestions with importUri
BUG=dartbug.com/23302
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1088973008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45359 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:15:16 +00:00
danrubel@google.com b0886e8c98 include importUri in out of scope suggestions
BUG=dartbug.com/23175
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1095113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45349 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 14:31:46 +00:00
danrubel@google.com 25c6bbaa14 suggest types in var declaration when partial type name supplied
BUG=dartbug.com/23225
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1097973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45287 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:29:28 +00:00
danrubel@google.com 58dd0377b3 fix NSM when computing field formal parameter in non-constructor arg list
BUG=dartbug.com/23268
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45286 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:15:01 +00:00
danrubel@google.com 1a605b53d5 suggest this keyword in constructor param list
BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1084233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45285 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:13:40 +00:00
danrubel@google.com 118f05d804 suggest "this." local fields in constructor param
BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1082233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45213 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 16:06:26 +00:00
danrubel@google.com 29d83d3cb5 improve keyword suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1084613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45113 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 17:44:19 +00:00
danrubel@google.com 9efad0a88f add suggestions for named param
BUG=dartbug.com/22403
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1078943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45047 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 01:23:23 +00:00
danrubel@google.com a22a7c47ff do not suggest local functions
BUG=dartbug.com/23131
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1076773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45014 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 15:58:59 +00:00
danrubel@google.com 0a1f0d3fc9 refactor optype to better filter invocation/prefixed suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1072623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45001 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 12:16:28 +00:00
danrubel@google.com de06a0607e fix NSMError in completion
BUG=dartbug.com/23114
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1069813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44979 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 18:42:25 +00:00
danrubel@google.com a34401414c improve parser recovery for import statements
BUG=dartbug.com/23108
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1068263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44978 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 18:26:00 +00:00
danrubel@google.com faf29a0686 improve parser recovery for import directives
BUG=dartbug.com/23108
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1062343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44968 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 13:37:50 +00:00
danrubel@google.com 509dd4988a suggest loadLibrary is import is deferred
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1065063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44953 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 22:20:04 +00:00
danrubel@google.com 2a7093fa25 suggest deferred/as keywords
BUG=dartbug.com/23108
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1067143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44952 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 22:17:20 +00:00
danrubel@google.com ec456501b5 do not suggest elements from internal sdk libs
BUG=dartbug.com/23104
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1064743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44939 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 16:52:43 +00:00
danrubel@google.com 1e83a73221 rename completion source files to match content
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1068483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44921 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 17:46:39 +00:00
danrubel@google.com 259dac94cc rename completion computer to contributor
* this will be followed by a separate CL that renames related files

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060713005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44918 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 17:25:09 +00:00
danrubel@google.com 9eede4128e suggest dynamic and void when defining new compilation unit members
BUG=dartbug.com/23063
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1048303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44895 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 22:18:39 +00:00
danrubel@google.com 9f492ecbe6 fix keyword completion in class body
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1057403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44894 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 22:12:56 +00:00
danrubel@google.com 4e903a637e do not suggest completions for empty dot target
BUG=dartbug.com/23095
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1056163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44887 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 20:38:50 +00:00
danrubel@google.com 8bf9e95e6e replace request.node with request.target
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1054363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44886 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 20:34:20 +00:00
danrubel@google.com 2329562cc0 replace request.node with request.target.containingNode in more situations
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44852 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-02 00:41:20 +00:00
danrubel@google.com caff47a011 add type completions after "on" in a try block
BUG=dartbug.com/23028
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44839 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-01 19:29:57 +00:00
danrubel@google.com cb0be1b4cf improve parser recovery when top level function is missing parameters
BUG=dartbug.com/23044
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1044383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44822 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-31 20:49:19 +00:00
danrubel@google.com 39598962a0 fix NSM error when completing imported inherited private fields
BUG=dartbug.com/23036
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44805 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-31 16:00:31 +00:00
danrubel@google.com 8f4ac8f16b improve parser recovery for incomplete prefixed identifier in method/function parameter list
BUG=dartbug.com/22526
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1033333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44760 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 20:05:18 +00:00