Commit Graph

733 Commits

Author SHA1 Message Date
danrubel@google.com 2c188c493f remove invalid completions in method declaration param list
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44758 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 19:42:37 +00:00
danrubel@google.com 6312e784a9 only suggest types when completing from a library prefix in parameter list
BUG=dartbug.com/22526
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1035283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44756 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 19:39:28 +00:00
danrubel@google.com 9b7edbfc8b fix exceptions when completing other edge cases
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1022703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44697 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 20:20:00 +00:00
danrubel@google.com 18758d3d22 fix exception when completing between arglist and body
BUG=dartbug.com/22885
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44687 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:27:44 +00:00
danrubel@google.com ac87c46ebd exclude identifier being completed from list of suggestions
BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027693007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44683 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 12:46:08 +00:00
danrubel@google.com 03cac10578 improve parser recovery of type argument list
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1025903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-22 18:33:23 +00:00
danrubel@google.com 0a63518267 include library prefix completions given trailing local method invocation
BUG=dartbug.com/22790
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1008973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44491 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:09:29 +00:00
danrubel@google.com 31339e3a62 Completion should not show overridden inherited methods
and centralize checking for duplicate suggestions

BUG=dartbug.com/22396
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1004343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44490 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:07:12 +00:00
danrubel@google.com 5903f0c31c include unimported sdk lib types as low priority suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1000223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44473 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 19:15:46 +00:00
danrubel@google.com 676e027663 remove duplicate completion suggestions
BUG=dartbug.com/22684
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1001143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44444 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:40:55 +00:00
danrubel@google.com e867811d28 include constructor arguments in completion suggestions
BUG=dartbug.com/22364
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1006593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44438 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 18:46:06 +00:00
danrubel@google.com 47128e2603 completions in map literals
BUG=dartbug.com/22784
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1002713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44432 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:24:57 +00:00
danrubel@google.com 8a04710a47 add completion in type argument list
BUG=dartbug.com/22584
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1005483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44431 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:20:08 +00:00
danrubel@google.com fcc0559acd completions for function return type
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//999923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44415 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 21:19:57 +00:00
danrubel@google.com fc4de72889 completion for method return type after comment
BUG=dartbug.com/22686
R=scheglov@google.com

Review URL: https://codereview.chromium.org//996263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44409 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 17:44:25 +00:00
danrubel@google.com 6c1a40377c fix completion target handling of comments
The intent is to normalize the completion target returned given different comment arrangements.
This is a precursor to the fix for code completions given preceeding comments.

BUG=dartbug.com/22686
R=paulberry@google.com

Review URL: https://codereview.chromium.org//985183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44408 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 17:38:53 +00:00
scheglov@google.com 60d4a29500 Fix for subscribing for notifications for files in packages.
Unfortunately this fix makes the server about 20% slower.

This is mostly because of the check in scheduleNotificationOperations(),
as required to fix dartbug.com/22210. I think it is much cheaper to send
duplicate notifications, like outline or navigation, than to check if
they should not be sent.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//987663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44305 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 22:55:20 +00:00
danrubel@google.com b9baf4be94 add completions after final keyword
BUG=dartbug.com/22683
R=scheglov@google.com

Review URL: https://codereview.chromium.org//978923006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44277 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 02:02:28 +00:00
danrubel@google.com 45118de875 remove type suggestion when interpolation completion
BUG=dartbug.com/21518
R=scheglov@google.com

Review URL: https://codereview.chromium.org//982983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44276 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 01:58:42 +00:00
danrubel@google.com f8b6da83c6 When target requires a function, propose a function reference, not an invocation
BUG=dartbug.com/22360
R=scheglov@google.com

Review URL: https://codereview.chromium.org//977223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44271 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-05 21:25:58 +00:00
danrubel@google.com b820aef91c fix constructor suggestion element names
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//962243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44183 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 17:03:24 +00:00
danrubel@google.com 7c9de023c2 include library prefix suggestions when suggesting constructors
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44179 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:51:18 +00:00
danrubel@google.com 7e9557cb39 add arguments to constructor completions
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44174 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 15:58:50 +00:00
brianwilkerson@google.com cd58e290c4 Reformat
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
danrubel@google.com d91099d6cb fix invocation completion with trailing stmt
BUG=dartbug.com/22365
R=scheglov@google.com

Review URL: https://codereview.chromium.org//965753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44100 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 18:42:41 +00:00
danrubel@google.com 28979ebefc test for interpolation completions
BUG=dartbug.com/21637
R=scheglov@google.com

Review URL: https://codereview.chromium.org//966773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44097 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 17:52:18 +00:00
danrubel@google.com 45acfc4524 fix code completion invocation on getter
BUG=dartbug.com/22376
R=scheglov@google.com

Review URL: https://codereview.chromium.org//929323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
scheglov@google.com 1e120443b5 Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879

Review URL: https://codereview.chromium.org//935123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 23:17:10 +00:00
danrubel@google.com a56ac2f521 update code completion suggestion relevance based on common usage
BUG=
R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//925723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-15 21:17:48 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:56:15 +00:00
danrubel@google.com f43912dfce fix code completion in string literals
BUG=dartbug.com/22297
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907453005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:07:29 +00:00
danrubel@google.com 20b64a97a4 fix completion in for statement
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//862803008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:58:11 +00:00
danrubel@google.com 84350e186c fix named param default value code completion
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:50:57 +00:00
danrubel@google.com dc95fd3689 use propogated type for completions
BUG=dartbug.com/21457
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:43:15 +00:00
danrubel@google.com fa0dc53f6f fix code completion in conditional expressions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:33:07 +00:00
danrubel@google.com e5a34c3c12 fix completions in indexed expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:42:43 +00:00
danrubel@google.com 2425d0c57c const rename and cleanup
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:50:42 +00:00
danrubel@google.com 8233434126 move relevance computation from client to server
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//901253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:36:19 +00:00
danrubel@google.com dbd0fa9d68 fix exception and improve keyword completion
BUG=dartbug.com/22231
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:18:42 +00:00
danrubel@google.com ef89b4c21a tests for earlier CL
BUG=dartbug.com/21768
R=paulberry@google.com

Review URL: https://codereview.chromium.org//882273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:50:24 +00:00
brianwilkerson@google.com cb6c16922f Fix for issue 22052
R=scheglov@google.com

Review URL: https://codereview.chromium.org//881403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
danrubel@google.com 4229cb1c6f use CompletionTarget for replacement offset/length
add code completion replacementLength and replacementOffset assertions

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//886463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
paulberry@google.com ea333d8459 Fix mixin resolution order when multiple mixins present.
BUG=dartbug.com/22069
R=scheglov@google.com

Review URL: https://codereview.chromium.org//879093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
scheglov@google.com 2b8c66ea79 Rename ChangeNotice resolved Dart/Html unit fields.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
paulberry@google.com 30f1b97888 Handle generic parameters correctly in invocation completions.
When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters.  This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//829173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43040 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 15:16:50 +00:00
danrubel@google.com cbd16a7336 add local parameter info to completion suggestions
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//850003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42894 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:26:45 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
danrubel@google.com 0974f8b1ea insert parameters when completing imported functions and inherited methods
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//811933007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42808 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 14:10:47 +00:00
paulberry@google.com cebcc398f6 Add support for completion of case labels.
This change addresses completions like the following:

  switch (...) {
    foo: case 1:
      ...
    bar: case 2:
      continue ^;
    baz: case 3:
      ...
  }

Completion at the point marked "^" will show "foo", "bar", and "baz"
as possible completions.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//806473007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42799 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 03:11:46 +00:00
danrubel@google.com 14a97cafed suggest fields rather than synthetic getters
and return dynamic returnType rather than null

BUG=dartbug.com/21679
R=paulberry@google.com

Review URL: https://codereview.chromium.org//791553007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 19:02:47 +00:00