Commit Graph

733 Commits

Author SHA1 Message Date
Brian Wilkerson b2728c15a6 Revert "Fix test failures on the bots"
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1468623002 .
2015-11-20 14:04:11 -08:00
Brian Wilkerson 6b45d6544c Fix test failures on the bots
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1467623002 .
2015-11-20 11:48:35 -08:00
danrubel eee07a4815 update completion sorter to new API
first step updating to the new completion API

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1447503002 .
2015-11-16 23:01:43 -08:00
danrubel 5bd191ee12 fix import uri completion exception - fixes #24709
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1418123004 .
2015-10-23 14:55:20 -04:00
Konstantin Shcheglov ea947094ae Fix for suggesting methods as a *name* of a local variable declaration.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1417603002 .
2015-10-19 12:29:22 -07:00
danrubel 948b21a8cf (TBR) update test to run with new task model
Review URL: https://codereview.chromium.org/1413963002 .
2015-10-19 12:04:51 -04:00
Konstantin Shcheglov 3b198ed6ae Disable completion of formal parameter names as *types*.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1414653002 .
2015-10-18 13:28:12 -07:00
Konstantin Shcheglov ce6614f2dc Disable completion in comment text.
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1410893002 .
2015-10-16 10:38:47 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
danrubel d14a963546 only send final completion notification
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
2015-10-06 14:21:29 -04:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
Konstantin Shcheglov e6053aa135 Rollback https://codereview.chromium.org/1380223003
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1390463002 .
2015-10-04 17:07:10 -07:00
Konstantin Shcheglov 1af7b154af Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694

Review URL: https://codereview.chromium.org/1380223003 .
2015-10-04 16:16:45 -07:00
danrubel 04e21a2a7c Completions with exact prefix should be prioritized - fixes #23099
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1369033002 .
2015-10-02 15:12:23 -04:00
danrubel 6e441f62e8 only suggest rethrow inside catch block - fixes #24214
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1360123003 .
2015-10-02 15:10:14 -04:00
danrubel 8eef458f9c add completion after export - fixes #24400
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1368173004 .
2015-10-02 13:00:06 -04:00
danrubel a24ae72e74 suggest argument name completions for annotations - fixes #24296 and fixes #24259
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1362353003 .
2015-10-02 12:54:22 -04:00
danrubel 6cd9e0da71 Do not suggest static fields in constructor initializer - fixes #24256
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1365403002 .
2015-09-26 11:59:15 +02:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
danrubel d6051a53a0 refactor ContributionSorter to use new API
move CompletionTarget to public API
modify DartCompletionRequest to return completion target

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1347283005 .
2015-09-18 16:03:22 -04:00
Brian Wilkerson 42593f4094 (TBD) Disable broken test
Review URL: https://codereview.chromium.org//1358493002 .
2015-09-18 09:17:01 -07:00
Brian Wilkerson f4b1879180 Add a completion for inherited methods
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1338173002 .
2015-09-18 08:59:56 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
danrubel 07184f6cdd rename ImportUriContributor to UriContributor
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1329463002 .
2015-09-01 11:11:36 -04:00
danrubel 773c3cf9d1 improve import uri completions - fixes #24000
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1325583002 .
2015-08-31 15:21:34 -04:00
Dan Rubel c0fe214c47 show all available import completion suggestions - fixes #23955
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1317023002 .
2015-08-26 17:37:01 -04:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
2015-08-26 17:34:57 -04:00
Dan Rubel f61faa2fbd exclude instance suggestions in static context - fixes #22932
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1319753002 .
2015-08-26 14:00:03 -04:00
Brian Wilkerson 271bc1f776 Convert completion API to be future based
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1318543002 .
2015-08-25 11:01:13 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
2015-08-25 09:23:26 -07:00
Dan Rubel 0aaa3bd0a4 reformat and 2 new tests for #23501
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1290743003 .
2015-08-17 11:20:20 -04:00
danrubel e2f6739b44 tests for keyword/identifier replacementOffset - asserts fixes #23906 and fixes #23947
requires these CLs:
https://codereview.chromium.org/1281793004/
https://codereview.chromium.org/1287603003/

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278033006 .
2015-08-15 15:18:03 -04:00
danrubel 9af696a4f7 suggest prefixed constructors - fixes #23210
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1291283002 .
2015-08-14 20:33:12 -04:00
danrubel 07d94ad596 fix completion after dot-keyword - fixes #23882
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1273773005 .
2015-08-10 11:11:51 -04:00
danrubel 3bbf03ba7b suggest "in" in for statement
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1285573003 .
2015-08-10 10:43:27 -04:00
danrubel f79d02ddd0 remove complex keyword suggestions - fixes #23978
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1280313002 .
2015-08-10 10:09:18 -04:00
danrubel 8ac02a9a24 suggest constructor named param
fixes #24004

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1283443004 .
2015-08-07 13:09:47 -05:00
danrubel a05ee55f03 suggest import uris when import is only text in file
prevent keyword suggestion in import uri without semicolon

fixes #24002

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276273003 .
2015-08-07 12:25:25 -05:00
danrubel 3b8b7ee7a2 suggest "deferred as" rather than "deferred"
suggest show and hide in import declaration

fixes #23967

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1276843007 .
2015-08-06 16:02:58 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
danrubel a6ea45883d add location to suggestions from local file
fixes #23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1267203002 .
2015-08-04 22:12:01 -07:00
danrubel bf05b75f43 update suggestion element return type to have type param
cleanup loadLibrary suggestion to have correct element

dartbug.com/23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1260593005 .
2015-08-04 22:08:55 -07:00
danrubel fde3b1b335 better completions in switch statements
Closes #23527

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1255953004 .
2015-08-03 14:06:30 -07:00
danrubel e8e6cf823a fix completion replacement offset/length for invalid token in switch statement
Closes #23947

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1271723002 .
2015-08-03 14:02:40 -07:00
danrubel 9d5154a1fd include exported library namespace in prefixed import suggestions
Closes #23946

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1263093003 .
2015-08-03 13:52:44 -07:00
Brian Wilkerson 23f96f1916 Renames to move closer to the new API
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1240433008 .
2015-07-17 12:20:02 -07:00
Dan Rubel 8b9578ef26 add for() keyword suggestion
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1179283007.
2015-06-20 15:01:20 -04:00
danrubel ce311218e9 suggest keywords in if expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1147213008.
2015-06-12 09:50:10 +02:00
danrubel 9c9108d51a no keyword suggestions in library identifier or property accessor
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1151493004.
2015-06-12 09:39:40 +02:00
Dan Rubel 4224b9c049 fix ENUM_CONSTANT suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1157283004
2015-06-04 18:01:06 -04:00