Commit Graph

733 Commits

Author SHA1 Message Date
Dan Rubel 0de484bb8b convert ImportedReferenceContributor to new API
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1526303003 .
2015-12-16 21:17:27 -05:00
Dan Rubel 3bf298760f extract InheritedReferenceContributor from imported reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1533613004 .
2015-12-16 16:20:53 -05:00
Dan Rubel f13460e235 rename InheritedContributor to OverrideContributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523163004 .
2015-12-16 12:15:34 -05:00
danrubel 62f8832770 cleanup LocalLibraryContributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1527613008 .
2015-12-15 13:03:41 -05:00
Brian Wilkerson 56fe38f0ab Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
danrubel 6464160147 move LocalDeclarationVisitor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1529653003 .
2015-12-14 20:36:57 -05:00
danrubel 5ff1ebe935 extract LocalLibraryContributor from imported reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1525753003 .
2015-12-14 20:31:50 -05:00
danrubel 8a99902b94 suppress all dart contributor suggestions in comments
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1522003003 .
2015-12-14 18:50:18 -05:00
danrubel 5c3fcf81c0 fix CombinatorContributor to only suggest public members
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1525713002 .
2015-12-14 14:21:01 -05:00
danrubel d8494d2f50 move LocalReferenceContributor to new API
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1528633002 .
2015-12-14 13:57:51 -05:00
danrubel 7db8d0267d extract LocalConstructorContributor from local reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1521753002 .
2015-12-12 10:01:22 -05:00
danrubel 3a5a2d17ee extract LabelContributor from local reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514263004 .
2015-12-11 17:46:41 -05:00
Dan Rubel 7ad6c0f1f9 extract LibraryPrefixContributor from imported reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1517693004 .
2015-12-10 22:42:53 -05:00
Dan Rubel 59c3ed6ded simplify contributors by resolving declarations in scope
once rather than requiring each contributor to do so.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1520613003 .
2015-12-10 17:41:03 -05:00
Dan Rubel 37d52a5d1c do not suggest completions for cascade on library prefix - fixes #25215
add CompletionRequest dotTarget
add CompletionTarget offset and isCascade

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1516883002 .
2015-12-10 11:57:26 -05:00
Dan Rubel 29a44c7b4c remove argument list suggestions - fixes #25197
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514613003 .
2015-12-09 16:06:53 -05:00
Dan Rubel d54fb071a9 do not suggest import uri reaching out of lib
related to https://github.com/dart-lang/sdk/issues/22358

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509373005 .
2015-12-09 14:38:49 -05:00
Dan Rubel 824a012d8f do not suggest static methods from superclass - fixes #24258
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509723004 .
2015-12-09 14:37:03 -05:00
Dan Rubel 830a37afae suggest after import prefix in part files - fixes #25023
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514603002 .
2015-12-09 14:35:30 -05:00
Dan Rubel e9a77de7dd suggest yield and yeild* - fixes #24346
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1511553005 .
2015-12-09 12:03:12 -05:00
danrubel e03c395a8c extract TypeMemberContributor from prefixed element contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1504223005 .
2015-12-09 07:38:20 -05:00
danrubel dcacf6145b extract LibraryMemberContributor from prefixed element contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1507303002 .
2015-12-08 15:10:32 -05:00
danrubel c66a5d3fb5 suggest async* and sync* - fixes 24554
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509193003 .
2015-12-08 15:07:35 -05:00
Paul Berry 4c28eb6f67 Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-08 10:16:29 -08:00
danrubel 088b50f8a9 extract StaticMemberContributor from PrefixedElementContributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1505703003 .
2015-12-07 17:15:14 -05:00
danrubel 20909182b0 add suggestion for partial named parameter - fixes #24758
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1504233002 .
2015-12-07 17:13:06 -05:00
Brian Wilkerson ea3ba0e31f Remove deprecated code
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
2015-12-07 10:24:36 -08:00
danrubel 89168a1956 add completions in assert stmt - fixes #24888
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509523002 .
2015-12-07 12:51:02 -05:00
danrubel 55a8740ba1 extract named constructor suggestions from prefixed element contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1507633002 .
2015-12-07 11:58:39 -05:00
Paul Berry de3a1b22c8 Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-07 07:04:07 -08:00
danrubel 9dd5b25d50 extract field formal contributor from prefixed element contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1507513002 .
2015-12-07 08:05:00 -05:00
danrubel 372cb6be58 fix combinator contributor
gracefully degrade given partially element information
better reporting of exceptions during testing

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1506623002 .
2015-12-06 15:34:19 -05:00
Paul Berry 4f654473ff Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-06 08:41:24 -08:00
Dan Rubel a5e4c81b7f move combinator contributor to new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503463002 .
2015-12-04 15:48:21 -05:00
Paul Berry cd03a05caf Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-04 09:06:41 -08:00
danrubel 9f033a9d94 convert uri contributor to use new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1498733005 .
2015-12-04 07:49:31 -05:00
danrubel 7b5a756b0f extract ReplacementRange for use in tests
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1499003002 .
2015-12-03 20:59:29 -05:00
danrubel 4379efb6b4 rework ArgListContributor to use new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1500793003 .
2015-12-03 18:00:50 -05:00
Paul Berry 7d3c4743db Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-03 14:22:24 -08:00
danrubel 6fd2fba704 hookup new CompletionContributorFactory
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1500723002 .
2015-12-03 13:34:35 -05:00
danrubel c2b70c9054 improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1497773002 .
2015-12-03 10:34:00 -05:00
Brian Wilkerson 600fc17de1 Clean-up the registration of plugins
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1487953002 .
2015-12-02 13:25:28 -08:00
danrubel 6fb4f45d6b - move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather than list of contributors
- remove server field from completion request
- update comments per prior review

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1484853002 .
2015-11-30 13:53:22 -05:00
danrubel d176336e59 remove redundant CompletionRequestImpl class
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1469393003 .
2015-11-24 16:17:51 -05:00
danrubel 0168336439 create new Dart specific completion contributor extension point
and modify DartCompletionManager to use it

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470373002 .
2015-11-24 16:12:55 -05:00
danrubel b9ad8a15e4 hook new DartCompletionContributor API into existing framework
and convert KeywordContributor to use new DartCompletionContributor API

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1471173003 .
2015-11-24 12:03:44 -05:00
danrubel 594183e0db Rework contribution sorter to use futures
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470863003 .
2015-11-23 21:35:52 -05:00
danrubel 2cbd3d3803 rename file to prevent bots from running it as a test
Review URL: https://codereview.chromium.org/1468143002 .
2015-11-23 13:16:57 -05:00
danrubel 38cec67d03 step toward new completion API
- separate new CompletionContributor and DartCompletionContributor APIs
- revise new APIs and implementations to be Futures based
- revise InheritedContributor to use new Futures based contributor API
- remove unused classes

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1467023002 .
2015-11-23 12:50:12 -05:00
danrubel 6ce9b7faeb (TBR) fix completion test
Review URL: https://codereview.chromium.org/1469963002 .
2015-11-23 12:09:52 -05:00