dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Danny Tuppeny 0c62908b40 Fix FixesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I010b2365ffc2a3ab2a9daa6cec71067ce32a2f76
Reviewed-on: https://dart-review.googlesource.com/43663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:37:47 +00:00
Danny Tuppeny e9527bed5e Fix plugin tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Iffbd616eec6afcc7613d829c47d8c278a268ab1b
Reviewed-on: https://dart-review.googlesource.com/43662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:35:42 +00:00
Danny Tuppeny 49d68924b5 Fix OrganizeDirectivesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie033ae9fcf4088d4fb39f46c2a7a6dc7afab68b3
Reviewed-on: https://dart-review.googlesource.com/43664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:27:58 +00:00
Danny Tuppeny 40d7fe87f1 Fix GetErrorsTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I0636fb61ffdec435e5f84a6c85ae102151a5a609
Reviewed-on: https://dart-review.googlesource.com/43680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:27:37 +00:00
Danny Tuppeny b9b8b9080e Fix ExecutionDomainTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I149c32c4b2130518921c592be56c71d451010a36
Reviewed-on: https://dart-review.googlesource.com/42947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:14:37 +00:00
Dmitry Stefantsov df8deddfa5 [vm] Skip functions in source reports if their token pos is unknown 
Change-Id: I2f953ee5745dd7193a77098d0e83d5ac247f5886
Reviewed-on: https://dart-review.googlesource.com/43720
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-26 14:35:56 +00:00
Peter von der Ahé 982fc59531 Annotate local variable instead of local function 
Change-Id: Ieac8446f24c5244cf5614242567ebcd3f033c23b
Reviewed-on: https://dart-review.googlesource.com/41260
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-26 13:09:03 +00:00
William Hesse 77cd4a9d2d Update HTML worker test status on Chrome with CSP (content security protocol) 
BUG: dartbug.com/32261
Change-Id: I08949cddbfe7bc39e98c132ecc6e64e7cb3561b8
TBR: eernst@google.com
Reviewed-on: https://dart-review.googlesource.com/43669
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-02-26 12:30:38 +00:00
Lasse R.H. Nielsen 8d38d94ddb Add static list methods. 
Change-Id: I40574d695826a3ed038c7c756ce980fae001325d
Reviewed-on: https://dart-review.googlesource.com/43040
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-26 11:34:43 +00:00
Peter von der Ahé 790a34b9f0 Provide lengths in more cases 
Change-Id: I76f629528329dbd1de90a8a415d03aa0f1975113
Reviewed-on: https://dart-review.googlesource.com/43520
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-02-26 10:27:54 +00:00
Johnni Winther 011cd01875 Handle local initializers in constant constructors 
Change-Id: Ifcbaf4b19f4411cd499db35242523eea215c77c4
Reviewed-on: https://dart-review.googlesource.com/40820
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-26 10:04:58 +00:00
Johnni Winther 7c2d96490d Support forwarding bounds in function type variables 
Change-Id: Ifeab9ad06f512d9b6a5db02fc89d45250c25c054
Reviewed-on: https://dart-review.googlesource.com/40821
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-26 09:45:56 +00:00
Johnni Winther 216c0ae8c2 Don't override .constructor property 
- on named mixin applications with --fast-startup.

Change-Id: Ia58e1b8e9a06d2c8d2ce14b3435b3c76aeef6fbc
Reviewed-on: https://dart-review.googlesource.com/40743
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-02-26 09:39:43 +00:00
Paul Berry 3a4c889968 Add a test case demonstrating #32290. 
Change-Id: Ic8513a5ee1fb9de0d3e71a06f85d5bfb60024d1f
Reviewed-on: https://dart-review.googlesource.com/43481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-26 08:57:53 +00:00
Terry Lucas 53d020339e Updated status files. 
TBR=vsm@google.com

Change-Id: I9c2e7060e4e2058eabb49f55ce7b34e301b9be82
Reviewed-on: https://dart-review.googlesource.com/43623
Reviewed-by: Terry Lucas <terry@google.com>
 2018-02-25 23:30:27 +00:00
Terry Lucas ba5c32ce06 Updated status files for bot run. 
TBR=vsm@google.com

Change-Id: I5170832aa59f7430de2d00917d76050d6e341124
Reviewed-on: https://dart-review.googlesource.com/43622
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-25 21:22:13 +00:00
Terry Lucas fbf0113aa6 Fixed tests to successfully run with the DDC. 
TBR=vsm@google.com

Change-Id: I38c1ec16cb27dc3a46bb62ae129d9daa9cc4e9be
Reviewed-on: https://dart-review.googlesource.com/43621
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-25 18:43:33 +00:00
Mike Fairhurst 69474f23c2 Fix the 'pub' command in plugins on Windows -- '.bat' required. 
Change-Id: Ibcf212902454dd8d9eb442e9633a193163d5bcae
Reviewed-on: https://dart-review.googlesource.com/43620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-25 03:33:23 +00:00
Brian Wilkerson 716daa3b0d Add assists to convert between literal string styles 
Change-Id: I691ff29d0bdc5a01cef6736f403025d1eee912d0
Reviewed-on: https://dart-review.googlesource.com/43580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 21:45:32 +00:00
Konstantin Shcheglov 9567305bd6 Set selection position for Flutter move widget up/down assists. 
This requires also changes to Dart plugin for IntelliJ, because currently
we use exit position only when there are linked edits. I attempted to
implement it myself, it mostly works, but there are race condition
complications.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Iff1a79ebb0cb7e0eabfe59e45d8dde7559c60a0f
Reviewed-on: https://dart-review.googlesource.com/43600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 17:14:30 +00:00
Sigmund Cherem 5021d24e4b Add an '--use-old-frontend' flag (noop right now) 
Change-Id: I4a75f9a6742c87d86206c96cf667e6e81064b926
Reviewed-on: https://dart-review.googlesource.com/43498
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-02-24 01:03:17 +00:00
Emily Fortuna 99d2f1a1ac Fix typecheck error for TypeVariableType contexts. 
Change-Id: I53ac4e728ac440a2cea727016b3475a730c5b59d
Reviewed-on: https://dart-review.googlesource.com/43496
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2018-02-24 00:41:37 +00:00
Mike Fairhurst 75bed68ca2 Handle null unit check for angular plugin in completion 
Change-Id: I0dfba8ad20023ddf0248684bc4436e5057ca5f36
Reviewed-on: https://dart-review.googlesource.com/43492
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-23 23:40:47 +00:00
Ben Konyi b3056d8083 Reland "[VM / Hot Reload] Fixed IsolateReload tests which were importing"" 
This reverts commit 2538adf41a.

Change-Id: I8904241911a7308dd00f6eb3034b05162be44f38
Reviewed-on: https://dart-review.googlesource.com/43494
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-02-23 23:22:18 +00:00
Sigmund Cherem 735ff83d82 Make the dart2js-d8-kernel try bot no longer experimental 
It has been running as expected this week. It has been red, but normally because
of actual breakages that will be prevented once this is on by default.

R=efortuna@google.com
CC=​athom@google.com,whesse@google.com

Change-Id: I85a406d30b9c65274104e4a1b33f9af6a18b3616
Reviewed-on: https://dart-review.googlesource.com/43493
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-23 22:39:19 +00:00
Sigmund Cherem 5b467f1fc2 Fix status of dart2js +FE +strong mode tests 
TBR=sra@google.com,danrubel@google.com

Change-Id: I3e6a469df051a164c19cc3984fb8d5b79fa29e58
Reviewed-on: https://dart-review.googlesource.com/43491
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-02-23 22:22:46 +00:00
Adam Barth ec97188f7a [fuchsia] Rename fidl namespace to f1dl 
This change prepares for the migrationt to FIDL2.

Change-Id: Ia9acbc3e7c77d6c3bec226543ab9a21f6531ed45
Reviewed-on: https://dart-review.googlesource.com/43495
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-02-23 22:22:30 +00:00
Ben Konyi 418d867250 [ VM ] Updated IsolateReload tests to not directly use TestCase::GetReloadErrorOrRootLibrary as it accesses zone allocated memory. 
Change-Id: Id6fb04e549dc3c0ed9db470a4e49b750b5a51124
Reviewed-on: https://dart-review.googlesource.com/43488
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-02-23 22:15:17 +00:00
Alexander Markov bee3158185 [Gardening] Update status for passing tests in dartkp mode 
This is the follow-up for the change
https://github.com/dart-lang/sdk/commit/7ea40d281c1b012517c009a9afcf37ef80a7f4b6

Change-Id: I242aa47361987c5cd619749b8d02929a7acfb80b
Reviewed-on: https://dart-review.googlesource.com/43490
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-02-23 21:50:26 +00:00
Dan Rubel a8be36f42a Report error on dynamic with type arguments 
Change-Id: Ie95e1c1b0b23cb3a3b6d4b7b7561edc2765fdebb
Reviewed-on: https://dart-review.googlesource.com/43560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-23 21:49:07 +00:00
Sigmund Cherem 4315d7b3ee Make strong bots green again 
TBR=sra@google.com
CC=brianwilkerson@google.com

Change-Id: Ief148445e5cd91eca964dee9927790ada585a260
Reviewed-on: https://dart-review.googlesource.com/43487
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-02-23 21:23:46 +00:00
Alexander Markov de69b1bfe1 [vm] Add test case for issue #32299 
Issue: https://github.com/dart-lang/sdk/issues/32299
Change-Id: I4cac3bb6a6c40458a489adfe371f6b97507f6794
Reviewed-on: https://dart-review.googlesource.com/43486
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-23 20:58:36 +00:00
Devon Carew aac3b7a3c1 Address two analyzer warnings. 
Change-Id: Idec60e040785b8967c024557f15dc28839287a94
Reviewed-on: https://dart-review.googlesource.com/43540
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-02-23 19:42:58 +00:00
Konstantin Shcheglov 316af55593 Suggest enum constants for imported enums. 
So, you can complete `Column(crossAxisAlignment: ^)` and get all of
the CrossAxisAlignment right away for selection. Or you can start
typing `center` and by the time when you typed first letters, you get
several completion suggestions. There are several enums with `center`,
but because we give compatible types higher relevance, the correct
one is always the first.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I6c2082668c6b25bf23e070915b5df03081ff0d5c
Reviewed-on: https://dart-review.googlesource.com/43485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-23 19:26:36 +00:00
Dan Rubel d2a16738be Error when type is omitted from function type parameter 
Change-Id: Ia124235b348bd1dcec7162c7968976b2adec0a1f
Reviewed-on: https://dart-review.googlesource.com/42680
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-23 19:03:06 +00:00
Peter von der Ahé 09777d2179 Move Arguments to Forest 
Change-Id: Ic3617a1aaa63729722bdf506dd4f1b8977046623
Reviewed-on: https://dart-review.googlesource.com/43041
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-23 18:51:46 +00:00
Alexander Markov 111ea256ad [vm/kernel/aot] Generate list of precompiler entry points during build 
This CL adds auto-generation of entry points JSON file for standalone VM
during build (in runtime_kernel target, as it is only used for
kernel-based transformation).

pkg/vm/tool/precompiler2 script is changed to automatically pass
auto-generated entry points to gen_kernel.

New option --entry-points is added to pkg/vm/bin/gen_kernel.dart in order to
specify custom entry points files.

Checked-in entry_points.json is still used for testing and in gen_kernel
if --entry-points is not specified.

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I39c4461e48763f40d7565656dc33e23fc5d9c2cb
Reviewed-on: https://dart-review.googlesource.com/42521
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-23 18:30:46 +00:00
Terry Lucas 0105febbee Enable tests that now pass 
TBR=brianwilkerson@google.com

Change-Id: I65b3a9aafda51ea7dfc859353f408dc17f93e254
Reviewed-on: https://dart-review.googlesource.com/43484
Reviewed-by: Terry Lucas <terry@google.com>
 2018-02-23 18:20:27 +00:00
Peter von der Ahé 595b599001 Prefer tokens over int offsets 
Change-Id: I057721c8b84484b434247276aead319885c90447
Reviewed-on: https://dart-review.googlesource.com/41800
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-02-23 18:08:04 +00:00
Alexander Markov 68fd91b5bb [vm] Fix field initialization during isolate reload in kernel mode 
Closes https://github.com/dart-lang/sdk/issues/32273

Change-Id: Ief0dfaa735e29619a1541b890069f4618906440d
Reviewed-on: https://dart-review.googlesource.com/43260
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-02-23 17:44:24 +00:00
Kevin Millikin 7ea40d281c Do not expect named parameters to be sorted 
The code for checking overrides seemed to assume that named parameters
were sorted, but they are not.

Fixes https://github.com/dart-lang/sdk/issues/32283

Change-Id: I2775201ecfa79f9968e554a166d2fee79f011063
Reviewed-on: https://dart-review.googlesource.com/43460
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-02-23 17:26:26 +00:00
Brian Wilkerson a3bc0284c2 Correctly convert file paths to URIs on Windows (issue 32278) 
Change-Id: I386038f828154b35e8f7a212d351a054d28e3b1f
Reviewed-on: https://dart-review.googlesource.com/43483
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-23 17:23:54 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and 
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-23 14:29:45 +00:00
Dan Rubel a8bf40399f Update fasta parser to report error on static constructor 
This refactors how modifiers are passed to listener so that the
OutlineBuilder can report a static constructor error.

* Remove handleModifier/s calls from parseMethod
* Pass name and modifiers in beginMethod event
* Update listeners to process method modifiers in beginMethod event
    * AstBuilder
    * NodeListener
    * OutlineBuilder
* Address comment in https://dart-review.googlesource.com/c/sdk/+/42800

Change-Id: Iabd4a18613c1814eb5a157df4acf60dd9060d5eb
Reviewed-on: https://dart-review.googlesource.com/43120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-23 13:18:46 +00:00
Peter von der Ahé fc5e9938e6 Tweak output from package:testing 
* Ensure that chain paths have a trailing slash.
* Don't use ANSI escapes when terminal doesn't support them.

Both changes combined should change the logged output on build bots from running pkg/dev_compiler/test/sourcemap/sourcemaps_ddk_suite.dart from:

<ESC>[2K[ 00:00 |   0.0% | +    0 | -    0 ]: sourcemaps_ddk//breakpoint_on_class_all_in_one_line.unformatte setup<ESC>[1A

To:

[ 00:00 |   0.0% | +    0 | -    0 ]: sourcemaps_ddk/breakpoint_on_class_all_in_one_line.unformatte setup

Change-Id: I0f79e7cefb4e5bcba3002aa49f624cc0a2f7032c
Reviewed-on: https://dart-review.googlesource.com/43402
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-23 12:50:04 +00:00
Peter von der Ahé 4304a50ef6 Move all literals to tree factory 
Change-Id: I34e3b5a03d60031fe80892cc5c8153ca47f1f298
Reviewed-on: https://dart-review.googlesource.com/41780
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-02-23 11:41:14 +00:00
William Hesse 9119148f9c Update checked-in SDK version to 2.0.0-dev.30.0 
This updates the checked-in dartfmt to use dart_style 1.0.10.

Change-Id: I2c8ec63bd6634e3cb1b220078ccbca4a1e85d7c6
Reviewed-on: https://dart-review.googlesource.com/43344
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-02-23 10:34:43 +00:00
Maksim Ryzhikov a218445ead Fix Doc typo in the example 
Closes #32287
https://github.com/dart-lang/sdk/pull/32287

GitOrigin-RevId: 6ea54882bd45566454ab44adbfa96ca11aa4ec3d
Change-Id: Ieba69f244e5ddef77e2074f666bec04825e47bc5
Reviewed-on: https://dart-review.googlesource.com/43360
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-23 10:20:50 +00:00
Dmitry Stefantsov e95e199fd5 Update status for a failing test for dart2js on safari 
Bug: http://dartbug.com/32286
Change-Id: Iea76641e46a557e7180099a344549719afe61698
Reviewed-on: https://dart-review.googlesource.com/43343
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-23 09:56:21 +00:00
William Hesse caede1d2ef Update status for dartk on standalone test that times out or passes 
standalone_2/io/secure_builtin_roots_test was always timing out, now it passes
on MacOS.

R=dmitryas@google.com

Change-Id: I852bc00907b17080a3581af87be7f13a852c5e4d
Reviewed-on: https://dart-review.googlesource.com/43342
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-02-23 09:27:46 +00:00