dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lasse Reichstein Holst Nielsen eaf49211ce Document deprecation of @proxy. 
Fixes #32251

Bug: http://dartbug.com/32251
Change-Id: I080f95eb99ed5c3dc058ac84fd9194ff72f59b0a
Reviewed-on: https://dart-review.googlesource.com/42760
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-23 09:26:23 +00:00
Jens Johansen dc7b26ec37 Update status files after ac7f580005 try #2 
Change-Id: I038f3bc6d636a109effbb848c52e53ce2e03780d
Reviewed-on: https://dart-review.googlesource.com/43341
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-23 08:07:16 +00:00
Jens Johansen 8d2fdfc36a Update status files after ac7f580005 
Change-Id: Ia0ebef9e65b3cae7d3d6d9e0b1794aa7110d5e3d
Reviewed-on: https://dart-review.googlesource.com/43340
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-23 07:37:05 +00:00
Jens Johansen ac7f580005 Support Kernel Instantiation node in VMs constant evaluator 
Fixes #32268.

Bug: 32268
Change-Id: I7d2ebc28d19aca623460cd1dacc86b64893810ac
Reviewed-on: https://dart-review.googlesource.com/42949
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-23 07:02:45 +00:00
Konstantin Shcheglov cc3e062578 Set higher relevance for exact type and subtype completions. 
Exact type get the largest relevance boost, subtypes a smaller boost,
and the rest has default relevance for its element kind.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: Ibb38caedc314e9cf476de2116aeb61bcec8c8a08
Reviewed-on: https://dart-review.googlesource.com/43263
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-23 06:05:13 +00:00
Leaf Petersen fdaaa874a0 Draft feature specification for mixin inference 
Change-Id: I0c1aa6877cc4b33adcd0be15800d93667d149545
Reviewed-on: https://dart-review.googlesource.com/38940
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-02-23 05:56:03 +00:00
Ryan Macnak 6664e3c02a [vm, dbc] Implement lazily-linked natives for DBC and enable AppJIT. 
Because DBC still uses code patching to implement breakpoints, running a program from DBC AppJIT may trigger a crash attempting to set a breakpoint.

Change-Id: I5d761aacec6629be946d7d2510ec3f1e3f03f4a4
Reviewed-on: https://dart-review.googlesource.com/42584
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-02-23 02:20:12 +00:00
Kevin Moore 922c0b5664 Fix Doc comment issues with Map and mirrors 
Change-Id: I86c8d849c8137854b3a2dfa966cf86c9475f9f72
Reviewed-on: https://dart-review.googlesource.com/43201
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-02-23 01:59:44 +00:00
Ryan Macnak ebdc8abaae [vm, service] Avoid double TLS creating timeline events for API functions. 
Add timeline events for Dart_CompileAll and Dart_ParseAll.

Change-Id: I184319aadfe18a6e51cb44c2ab77fb95f452f6de
Reviewed-on: https://dart-review.googlesource.com/43242
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-02-23 01:31:38 +00:00
Alexander Markov 3b005afc1c [kernel/vm/aot/tfa] Treat incoming arguments as dynamic in opaque calls 
This CL changes incoming argument types of raw (opaque, untracked) calls
in type flow analysis (TFA) from static parameter types to 'dynamic'.
Currently, raw calls are used to approximate calls from native code to
entry points and calls through tear-offs. Using static parameter types
is not correct for raw calls as incoming argument types should not include
the effect of strong mode argument type checks inside the body of a
method. This change has almost no impact on the results of analysis
because intersection with static parameter types is already performed when
applying a summary.

To fill out the remaining gap, static types of fields are now taken
into account in TFA: type of an incoming value is intersected with a static
field type in _FieldValue.setValue().

Also, this CL includes a fix for handling cyclic type parameters in TFA
(this problem appears on language_2/cyclic_type_variable_test test as
soon as TFA starts looking at static types of fields).

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: Ib79f1399e6c086445a61acc22a24a5e37bf481e6
Reviewed-on: https://dart-review.googlesource.com/42820
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-23 01:23:42 +00:00
Régis Crelier b761571bf3 [VM runtime] Remove reference to old Bigint class from intrinsics (that will be 
reused to support new Bigint implementation) by introducing a global constant.
Add asserts and comments in old Bigint implementation.

Change-Id: Id647ffb6ae6557457ccf52fde4f0e6eb3d06c0b5
Reviewed-on: https://dart-review.googlesource.com/43280
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-02-23 01:23:33 +00:00
Stephen Adams 24b7429b02 Install JS-interop properties on JavaScriptObject 
Fixes #26838

Change-Id: Id4a16431e94a50fd0e962301ef23eb4a31a8d5cf
Reviewed-on: https://dart-review.googlesource.com/42585
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-02-23 00:31:52 +00:00
Ben Konyi 2538adf41a Revert "[VM / Hot Reload] Fixed IsolateReload tests which were importing" 
This reverts commit fdce9a8266835fba252150fae8f88f4dee06b698.

Change-Id: Ifca4a1254c9045cb5c5e8b5c1dfcd606b858b8aa
Reviewed-on: https://dart-review.googlesource.com/43262
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-02-22 23:45:25 +00:00
Alexander Aprelev ffad1d2287 Update dartkp status files. 
This is follow-up to ec7029daf6.

Change-Id: I8aee1bc0002290ca5f6d91b87149b67ebb4943c2
Reviewed-on: https://dart-review.googlesource.com/43241
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Chandra <sivachandra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-22 23:35:47 +00:00
Ben Konyi 8eab1cf6f4 [VM / Hot Reload] Fixed IsolateReload tests which were importing 'test:isolate_reload_helper' 
Change-Id: I0c78c41b43a9976bc8c3811314c1efff09ee90cc
Reviewed-on: https://dart-review.googlesource.com/43240
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-22 23:14:29 +00:00
Ryan Macnak 6ae272becf [vm] Make --compile_all retain the compiled code. 
Change-Id: I5595c5855d638b5ed144e3591348ddb9080f9e81
Reviewed-on: https://dart-review.googlesource.com/42886
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-02-22 22:56:01 +00:00
Alexander Markov 2dedc4f9bd [vm/kernel/aot] Add unreachable metadata to members and call sites 
This CL adds metadata to mark unreachable (unused) members (both
functions and fields) and unreachable calls into kernel binaries
using the information inferred by global type flow analysis.

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I86c75cd4c7798a23f1de52141d0e9d605b62bf19
Reviewed-on: https://dart-review.googlesource.com/42462
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-02-22 22:44:31 +00:00
Alexander Markov f69cf3b3dc [vm/kernel/aot] Improve efficiency of set operations in TFA 
This CL revises implementation of concrete types and set types in
global type flow analysis. For concrete types, unique comparable
class identifiers are assigned. SetType, instead of storing elements
in a Set, stores them in a List ordered by class identifiers.
This makes comparison, union and intersection of set types linear of
number of elements.

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I85a2aa7e550fd5708352bdca515bf5cb5dc221d1
Reviewed-on: https://dart-review.googlesource.com/42120
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-02-22 22:24:01 +00:00
Stephen Adams 9598a1d1fa Add HAbs instruction 
This change is to recover 6% lost on Intl.NumberFormat.format.reused
when JSNumber was make Dart2 clean.

Use invoke_dynamic_specializer to replace call with HAbs instruction.

Inject receiver check to condition receiver to a non-null number to
improve. This part makes x.abs() one of the operations 'trusted' by
'--trust-primitives'.

Add one-shot accelerators for abs and get:sign.

Change-Id: Ia423c4b398114abe1d4a784febbe664710f0a242
Reviewed-on: https://dart-review.googlesource.com/42890
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-02-22 22:21:41 +00:00
Mike Fairhurst ea37af3e71 Change dynamic to void to be compliant with #32161 
Change-Id: Ic986525d61bc36fb5ad25cacb2c9233b75c38bf7
Reviewed-on: https://dart-review.googlesource.com/42322
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-02-22 21:46:41 +00:00
Brian Wilkerson a81a2c120f Guard against exception in fix processor when URI is invalid (issue 32276) 
Change-Id: I5902ab5f260941f0da3a751a03783999737319f1
Reviewed-on: https://dart-review.googlesource.com/43202
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 21:41:11 +00:00
Emily Fortuna 1b9b488b26 Update status files for dart2js. 
Change-Id: I788f979a83f912e9429e0b48a64578524f3b381c
Reviewed-on: https://dart-review.googlesource.com/43180
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2018-02-22 21:27:41 +00:00
Vyacheslav Egorov e9ca5ea55f [vm/kernel] Unbreak debug build broken by 8881ec77ec 
Change-Id: I34d30b53f39616c3181bdaee107928c2a93aada2
Reviewed-on: https://dart-review.googlesource.com/43220
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-22 20:49:31 +00:00
Alexander Aprelev ec7029daf6 Workaround deferred library limitation. 
Introduce no-op LoadLibrary, CheckLibraryIsLoaded into kernel_binary_flowgraph.cc

Bug: https://github.com/dart-lang/sdk/issues/32245
Change-Id: If93a4d717844dcb8a5d45d0237660ec764a6f738
Reviewed-on: https://dart-review.googlesource.com/42461
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-02-22 20:34:39 +00:00
Brian Wilkerson cbacb35d51 Fix selection range from override contributor and contribute when there is a leading annotation 
Change-Id: If43dd85531d1c9cdcba0f750b299990c10991538
Reviewed-on: https://dart-review.googlesource.com/43140
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 20:22:29 +00:00
Mike Fairhurst 7fdab0de2c Fix issue autocompleting members on dynamic values in ng plugin. 
See angular issue #499 for a stack trace. When autocompleting a member
on dynamic, the member contributor checks to find a member definition
higher up in the tree that should lead to specific members to suggest.

However, in the angular plugin, the ASTs passed in are often fragments.
Account for the case where a node has no parent earlier than expected.

Change-Id: Ib30d9f1aef77241224f604c5994489aa9448b0c2
Reviewed-on: https://dart-review.googlesource.com/42884
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 19:19:47 +00:00
Konstantin Shcheglov 9b71ba7f17 Copy 'className' field into the API structure. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie95f4b59dfa15fc085694317883b0c2fd81c1fbb
Reviewed-on: https://dart-review.googlesource.com/43160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:40:37 +00:00
Konstantin Shcheglov 0ce1a92d98 Suggest constructors for implicit creation in previewDart2. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I43270f47fb43402d1a9e0f7d9814494ffd83bb5e
Reviewed-on: https://dart-review.googlesource.com/43080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:03:12 +00:00
Mike Fairhurst d0be238ca3 Add missing void annotation: refs #32161 
Change-Id: Iea314e7a23513eef1823dbfe8690494f45af9185
Reviewed-on: https://dart-review.googlesource.com/42323
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-22 18:01:32 +00:00
Mike Fairhurst 532ec84418 Add missing void annotation: refs #32161 
Change-Id: Ifee22c00bd9384faef8ee48c1d7fd92879609ce4
Reviewed-on: https://dart-review.googlesource.com/42321
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-02-22 17:55:07 +00:00
Danny Tuppeny c840168ef2 Fix CombinatorContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I198378b707df36852d4d7a90f98e4542b95c218c
Reviewed-on: https://dart-review.googlesource.com/42944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:53:26 +00:00
Danny Tuppeny 5da95d7c9f Fix AssistProcessorTest on Windows 
Note: This fixes one of the tests but the other still fails. I believe
that's because of https://github.com/dart-lang/sdk/issues/32278 and
should pass once that issue is fixed.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6469b75de39e6476353da303c9c72cfba2da922e
Reviewed-on: https://dart-review.googlesource.com/43006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:37:11 +00:00
Danny Tuppeny 89240070b0 Fix AnalysisNotificationAnalyzedFilesTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I9d8c333f0c5070d932645d34986dc931b0038b61
Reviewed-on: https://dart-review.googlesource.com/43022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:33:06 +00:00
Mike Fairhurst 13ccc0d49e Reland https://dart-review.googlesource.com/c/sdk/+/42540 
In CLI no batch, support analyzing multiple files in multiple contexts

Support `dartanalyzer pkg/a/foo pkg/b/foo` and use a different context
for each.

Requires knowing the source being analyzed while creating a context,
which gets a bit hacky with build mode, but seems to work as is.
Suggestions on a cleaner integration there are welcome!

Change-Id: I2648fdb80c0a36a05580ef7267350ffb847c43e9
Reviewed-on: https://dart-review.googlesource.com/42582
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:29:06 +00:00
Danny Tuppeny 6074dcfdae Fix LibraryPrefixContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I7073e516109570ca80b1890368351e22b9ed844f
Reviewed-on: https://dart-review.googlesource.com/43004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:10:38 +00:00
Danny Tuppeny 82a1702cc8 Fix OverrideContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I68f0691007820e5efbabca58b6436d0c68d81487
Reviewed-on: https://dart-review.googlesource.com/43005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:05:43 +00:00
Danny Tuppeny ddf36c26c9 Fix GetTypeHierarchyTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57a1ebf7481e17d8cdd7be8d69c3ac84d0fcc185
Reviewed-on: https://dart-review.googlesource.com/43000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:02:33 +00:00
Danny Tuppeny f94a0f54e6 Fix CommonUsageSorterTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie90a0b8823816d8b64f261e561183c35fb1737c8
Reviewed-on: https://dart-review.googlesource.com/43001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:56:03 +00:00
Danny Tuppeny 812b635ea3 Fix CompletionManagerTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6b521604141b4584c4ed17470e7ea25b060af841
Reviewed-on: https://dart-review.googlesource.com/43003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:51:53 +00:00
Danny Tuppeny 6437794e32 Fix LocalLibraryContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie57904d6eac2eabe8538400b4e56b2c414aebb35
Reviewed-on: https://dart-review.googlesource.com/42921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:39:43 +00:00
Danny Tuppeny 7d1f930949 Fix DiagnosticDomainTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I3b32087af3690ea7faa6715fdb6e5889b798b263
Reviewed-on: https://dart-review.googlesource.com/42948
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:25:03 +00:00
Danny Tuppeny e7d57c8535 Fix RenameClassMemberTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57804f6c168cccdbfee62f8fa6b60b40f260015b
Reviewed-on: https://dart-review.googlesource.com/42946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:17:33 +00:00
Danny Tuppeny 04830ac262 Fix RenameUnitMemberTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I98f2c5025615adf52919ea87d637a47ee50fe760
Reviewed-on: https://dart-review.googlesource.com/42942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:11:53 +00:00
Danny Tuppeny 9e96a89628 Fix NamedConstructorContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I47d47bf7275f4e78d6e077d5f2c1e0ec4246c150
Reviewed-on: https://dart-review.googlesource.com/42943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 16:06:03 +00:00
Danny Tuppeny 0796ea4ee5 Fix RefactoringLocationTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ieead4b1d434740078a6383cafb426ddc4bbe002b
Reviewed-on: https://dart-review.googlesource.com/42941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:51:33 +00:00
Danny Tuppeny 1c44401f2e Fix LocalReferenceContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I75a3b5200f6ef06c3c14233d45c897ae8bdd655c
Reviewed-on: https://dart-review.googlesource.com/42923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:46:23 +00:00
Danny Tuppeny 427506d1f0 Fix LibraryMemberContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I53c12fc79d0d5bf9331eb42714d7a6c29a5325af
Reviewed-on: https://dart-review.googlesource.com/42940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:36:43 +00:00
Danny Tuppeny 6a82f29e32 Fix ArgListContributorTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I04faca9575387faeca1cf6b505f05c15a1b0e670
Reviewed-on: https://dart-review.googlesource.com/42920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:29:36 +00:00
Paul Berry 619727ab6f Fix warning in resource_provider_mixin.dart 
The warning was: "Element 'File' from SDK library 'io.dart' is
implicitly hidden by 'file_system.dart'."

Change-Id: Iddd41025c780d41385d1c357fa800d6a31b4aa18
Reviewed-on: https://dart-review.googlesource.com/42980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-22 15:25:24 +00:00
Jens Johansen e8026c1e76 [fasta] Fix crash on dynamic<argument> 
Change-Id: Ibebb7bc5b95979cef9254305430b55ce8cb3cb34
Reviewed-on: https://dart-review.googlesource.com/42744
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-02-22 14:06:03 +00:00