dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Janice Collins 7df5055b06 Upgrade dartdoc to 0.17.0. 
https://github.com/dart-lang/dartdoc/releases/tag/v0.17.0

No other packages need to change versions.

Change-Id: I980f22738d470261198c56367bd77c28e799b892
Reviewed-on: https://dart-review.googlesource.com/44021
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-02-27 21:53:46 +00:00
Vyacheslav Egorov 9e7279bce9 [vm/compiler] Fix illegal code motion where LoadField is hoisted past CheckNull. 
Canonicalizer should not remove Redefinitions that have no uses before LICM
happens. Even though Redefinition itself has no uses it might be still
dominating uses of the original value - is we expect RenameUsesDominatedByRedefinitions
that is run before LICM to normalize the graph by routing those uses
through Redefinition.

Fixes https://github.com/dart-lang/sdk/issues/32322

Bug: 32322
Change-Id: Ice310aaf8ab62cd6d3ec575876c12e8634a91dce
Reviewed-on: https://dart-review.googlesource.com/44040
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-02-27 20:45:59 +00:00
Paul Berry 6e94dd93bd Skip mixin inference code when analyzer is running in non-strong mode 
This should fix broken analyzer buildbots.

Change-Id: Ibb3893bf58bc5c4c759499e8344a44722cbe0ca5
Reviewed-on: https://dart-review.googlesource.com/44020
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 20:24:48 +00:00
Kevin Millikin 13067387a4 Fix mixin inference for classes read from .dill files 
When classes are loaded from a VM-specific .dill file, mixin
applications have been translated into normal classes.  In that case
the mixin class will be found as the only implemented type.

Change-Id: I6543f1e0bad72d351efb0a768f2c9c8967b8a196
Reviewed-on: https://dart-review.googlesource.com/43965
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-02-27 20:09:58 +00:00
Alexander Markov a681867054 [vm/kernel/aot] Prepare to enable type flow analysis in Flutter 
* Introduce --tfa option in gen_kernel and 'useGlobalTypeFlowAnalysis'
  parameter in compileToKernel(), which is used in Flutter's frontend
  server.

* Split entry_points_extra.json into 2 parts: common to all embedders
  and specific to a standalone VM (entry_points_extra_standalone.json).

* Extract generation of entry points JSON files into a separate .gni
  file, introduce action to generate entry points JSON using
  gen_snapshot instead of dart_bootstrap (required for Flutter), and
  action to copy checked-in extra entry points file.

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: Ie0af9d7128d7fc0e3a9d623fd3c1589e87c83f5c
Reviewed-on: https://dart-review.googlesource.com/43884
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-27 19:59:19 +00:00
Paul Berry 2101ccfaea Fix mistake in multitest numbering 
Change-Id: I4e02078db84458602253f0402a3f559febfb05a1
Reviewed-on: https://dart-review.googlesource.com/43943
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-27 19:31:09 +00:00
Emily Fortuna e9b3ce9619 Make the actual signature function use our entity-based signature code. 
Change-Id: I99b4dd4a7b9d549fcec60e4cc341512402c19ced
Reviewed-on: https://dart-review.googlesource.com/43264
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-02-27 18:53:58 +00:00
Dan Rubel 700732786b Remove type argument on dynamic check from parser 
Change-Id: I1c92e311a931f5bf0768352c2b066559a8d7b339
Reviewed-on: https://dart-review.googlesource.com/43920
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 18:12:58 +00:00
Mike Fairhurst 4e11d9f78b Infer void for operator[]= return in task mode so it works in DDC 
Bug:  32241
Change-Id: Ia34a0e1fb558a4ea4a939603c75c8176c1a04fb2
Reviewed-on: https://dart-review.googlesource.com/43889
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-27 17:52:39 +00:00
Paul Berry 593273cf51 Finish implementing mixin type inference in the analyzer. 
Fixes #32146.

Change-Id: Ia46b6a54757901681858e682bdd6f809c194999c
Reviewed-on: https://dart-review.googlesource.com/43944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-27 17:49:59 +00:00
Konstantin Shcheglov 4cf5b7df12 Boost relevance for compatible types in '==' and switch/case. 
Probably less Flutter specific, but still useful.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I979e1a0640494a4a6cbedcec90781bc165c94f31
Reviewed-on: https://dart-review.googlesource.com/44000
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 17:36:40 +00:00
Dan Rubel 6f710ee546 Update AstBuilder to report scanner errors 
Change-Id: I7b33a86378a7c816ccdfb1a7e0869ccd5c3b8f7c
Reviewed-on: https://dart-review.googlesource.com/43900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-27 17:20:58 +00:00
Danny Tuppeny 7ca10a7adf Fix file completion for absolute paths on Windows + related tests 
Bug: https://github.com/dart-lang/sdk/issues/32226
Bug: https://github.com/dart-lang/sdk/issues/32277
Change-Id: Ie78423dc4a99efd25976b49ec7642362ed61a3c6
Reviewed-on: https://dart-review.googlesource.com/43961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2018-02-27 17:20:49 +00:00
Brian Wilkerson 73eb8a37e0 Make ContextRoot part of the API to support the angular plugin, fix some bugs 
Change-Id: I3f23d1712473c4e5522c441ac31e013516ae5f4d
Reviewed-on: https://dart-review.googlesource.com/43880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 15:37:19 +00:00
Aske Simon Christensen 9d3e18e14d Do not treat context messages as errors in tests. 
Re-enable co19 tests in legacy mode, reverting
f9be43d0f6

Closes https://github.com/dart-lang/sdk/issues/32337

Change-Id: I87922f6d8d727737f51fa6506dd775decd68915e
Reviewed-on: https://dart-review.googlesource.com/43966
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-02-27 15:20:19 +00:00
Martin Kustermann e269f7e7a0 [gardening] Mark tests which incorrectly use non-canonicalized TypeArguments 
Issue https://github.com/dart-lang/sdk/issues/32340

Change-Id: Ia446b683d64041a406f41027be432e3a28607242
Reviewed-on: https://dart-review.googlesource.com/43967
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-02-27 14:33:34 +00:00
Jens Johansen 7b4ad246b7 [kernel] Fix crash in mixin resolution on invalid override 
Change-Id: I602fe4aaed1520ead002933a41ca75527e93e4af
Reviewed-on: https://dart-review.googlesource.com/42746
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-27 14:14:08 +00:00
Johnni Winther 6931a7a288 Use [localFunctionNeedsSignature] to determine when to add JSignatureMethod 
Closes #32078

Change-Id: Ib1c9c08b1fdf33e3d94c02595135cf430357fed6
Reviewed-on: https://dart-review.googlesource.com/43742
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-27 12:33:53 +00:00
Dmitry Stefantsov 35a2aab4da Fix status files after e7830a9f 
Change-Id: I45241ef42a3ed1e9963753ba57459b55c8bd85fa
Reviewed-on: https://dart-review.googlesource.com/43964
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-02-27 12:04:09 +00:00
William Hesse 28b318abd4 Update status for non-strong dartk on args mismatch compile-time warning/error 
The test kernel/unsorted/invocation_errors_test is mistakenly reported as
an error in non-strong mode

R: askesc@google.com
Bug: https://github.com/dart-lang/sdk/issues/32337
Change-Id: Ic0bcf74a87570d72b386c3a4e04d3a13f2a10394
Reviewed-on: https://dart-review.googlesource.com/43963
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-27 11:57:33 +00:00
Martin Kustermann 105b426cf6 [VM] Exclude runtime/bin:precompiler_entry_points_json from being generated for ia32/dbc 
Change-Id: Ibd0b478e32a518804e5015ea3468ce8fca745933
Reviewed-on: https://dart-review.googlesource.com/43962
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-02-27 10:57:47 +00:00
Dmitry Stefantsov e7830a9f7b Add a flag to Procedures indicating that it's a redirecting factory 
Fixes #32282

Bug: http://dartbug.com/32282
Change-Id: Iee8535b053ced415e3047e990a0940d859faa86a
Reviewed-on: https://dart-review.googlesource.com/43440
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-27 10:42:07 +00:00
Jens Johansen df92e14975 [kernel/vm] Initial obfuscate support for kernel pipeline 
Change-Id: I72ca9f690ad46578b963f06af24c3b85d960cac5
Reviewed-on: https://dart-review.googlesource.com/42240
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-27 10:11:17 +00:00
Johnni Winther 85cf0961ee Include type arguments passed through generic calls in rti emission 
Change-Id: Id757caaebb0bd802e8afa978c9a4bc5b4d6273fe
Reviewed-on: https://dart-review.googlesource.com/43670
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-27 10:01:14 +00:00
Johnni Winther 9a0307043d Test internal data in rti_emission_test. 
Change-Id: I09e43bbe0470d0928478d15a629232d5ffef902f
Reviewed-on: https://dart-review.googlesource.com/43667
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-02-27 09:51:24 +00:00
Paul Berry 0d42430ed8 Change the implicit tear-off of call methods to be null-aware. 
We want the implicit tear-off of a `call` method to succeed even if
the value is `null`, so we need the implicit tear-off to be equivalent
to `?.call`.

Change-Id: I5134858b84e501081a52d59b78b101597bdfcc4a
Reviewed-on: https://dart-review.googlesource.com/43480
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-27 09:44:27 +00:00
Kevin Millikin a92221a450 Remove $runtime != none sections from DDC status files 
These sections are no longer necessary (and neither is $runtime==none)
after test.py was changed to run tests with compile-time errors on
browser runtimes and to not expect a runtime error from a test that
has no runtime.

The status OK doesn't work for tests that have (only) a runtime error
expectation, because removing the runtime error and leaving just OK is
not okay.

Change-Id: I97998e0d75dfd1c5e01f2f80368416dcf0303114
Reviewed-on: https://dart-review.googlesource.com/43661
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-02-27 08:53:42 +00:00
Kevin Millikin caae5ee054 Fix a Kernel representation bug (typo) 
Clearing this flag would clear some other unrelated flag instead.

Change-Id: Ief0a8a9d02cca34bf6f101404ded291fe6dfe41c
Reviewed-on: https://dart-review.googlesource.com/43960
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-02-27 08:46:47 +00:00
Vyacheslav Egorov 59c3f0f0c3 Revert "Strip out platform dill files and the kernel service dill file from" 
This reverts commit 92b5bf86a1.

Reason for revert: this breaks Flutter engine build because is_product is not defined.

Original change's description:
> Strip out platform dill files and the kernel service dill file from
> a product build.
> They only need to run a self contained '.dill' file as their application.
> 
> Change-Id: I9a2566b9e552a7aef4ebf52c2ecb664088ad030c
> Reviewed-on: https://dart-review.googlesource.com/43497
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>
> Reviewed-by: Siva Chandra <sivachandra@google.com>

TBR=zra@google.com,sivachandra@google.com,asiva@google.com

Change-Id: Id55a3f749290813aba479cc705c6065b75a0ac9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/43980
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-02-27 08:45:39 +00:00
asiva b656c6cb1e Fix bot 
Change-Id: I226ed09a482aace743e04c637b2c5a9dcc215090
Reviewed-on: https://dart-review.googlesource.com/43942
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-27 06:56:30 +00:00
asiva 29b0a84220 Fix status file. 
Change-Id: I44e4ae7cc9095a097d4d10f9f6a4b9ea74e8b6bf
Reviewed-on: https://dart-review.googlesource.com/43941
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-27 06:05:36 +00:00
asiva fb2d58945d Adjust a non strong run status file (maybe this directory should also be skipped for non strong runs of dartk and dartkp) 
TBR=rmacnak

Change-Id: I4bb17256bf77637d5da7dbcd63e79dc9427e7e73
Reviewed-on: https://dart-review.googlesource.com/43940
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-27 05:47:23 +00:00
Sigmund Cherem e33f4f7c2e Fail if mirrors are really used. 
Some legacy libraries may import dart:mirrors, but not use it. This CL turns them
into a runtime error temporarily to give some time for the library
maintainers to remove the import to dart:mirrors in the future.

Change-Id: I876133908d2a61300256915aab54730bdff51649
Reviewed-on: https://dart-review.googlesource.com/43640
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-02-27 04:57:27 +00:00
asiva 4e863bc273 Skip 'lib' test directory when running tests in dartk or dartkp mode 
as these tests are not strong mode clean and only support Dart1 semantics.
These tests have been migrated to lib_2 and made strong mode clean.

TBR=zra

Change-Id: If465157e2595ab5ed5e9b1653ff873d6ac1dc990
Reviewed-on: https://dart-review.googlesource.com/43890
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-27 01:35:14 +00:00
Konstantin Shcheglov 75858ec680 Add optional 'parameters' field to ElementDeclaration. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6b8e4417e7a7bc32537fdcbaa8fd04caf18da052
Reviewed-on: https://dart-review.googlesource.com/43885
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-27 01:27:37 +00:00
asiva f9be43d0f6 Skip co19 tests in dartk and dartkp modes as these tests are not 
strong mode clean.

Change-Id: Iec1397a704faff2708a35ed5707c24275816d07a
Reviewed-on: https://dart-review.googlesource.com/43887
Reviewed-by: Siva Chandra <sivachandra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-02-27 00:33:38 +00:00
asiva 92b5bf86a1 Strip out platform dill files and the kernel service dill file from 
a product build.
They only need to run a self contained '.dill' file as their application.

Change-Id: I9a2566b9e552a7aef4ebf52c2ecb664088ad030c
Reviewed-on: https://dart-review.googlesource.com/43497
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Siva Chandra <sivachandra@google.com>
 2018-02-26 23:58:07 +00:00
Konstantin Shcheglov 199206a735 Implement support for 'pattern' and 'maxResults' in getEElementDeclarations(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I38a53c44016d01e2012b2e20173e0ae07cc658e2
Reviewed-on: https://dart-review.googlesource.com/43883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-26 22:48:20 +00:00
Jaime Wren 0f4835c14c Additional analyzer test for implicit new and const, where the constructor is implicit. 
Change-Id: I3c6749e3652c19617695e6b10520fee9c3c23f39
Reviewed-on: https://dart-review.googlesource.com/43881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-02-26 22:41:07 +00:00
Brian Wilkerson de88ea0994 No hint when no return from Future<void> and async method 
Change-Id: Ic925509b1b262d54712f8e9d4bdd7e8df211ed5e
Reviewed-on: https://dart-review.googlesource.com/43882
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 22:14:47 +00:00
Régis Crelier ac146f2332 [Kernel] Annotate status file with number of newly filed issue. 
Change-Id: I2a209dd8f4183e57fb8a2a36f6ff26041cc27032
Reviewed-on: https://dart-review.googlesource.com/43862
Reviewed-by: Régis Crelier <regis@google.com>
 2018-02-26 20:51:16 +00:00
Konstantin Shcheglov 586c183904 Add code range to ElementDeclaration. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6e7afe3b8ea8191d737c717b753d55d2a7945a81
Reviewed-on: https://dart-review.googlesource.com/43840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-26 20:37:44 +00:00
Dan Rubel 76cd43ab02 Update fasta parser listeners to generate additional errors 
This updates the AstBuilder and OutlineBuilder
to generate the following errors:

* ConstConstructorWithBody
* ConstMethod
* ConstructorWithReturnType
* FieldInitializerOutsideConstructor

In order to get the necessary state in OutlineBuilder so that I could
report these errors, I extracted SourceLibraryBuilder.addConstructor
from addProcedure.

In addition, I updated AstBuilder to use handleRecoverableError
rather than parser.reportRecoverableError.

Change-Id: I8b5517ec2ab44ff13a65628c594f803138cad6f5
Reviewed-on: https://dart-review.googlesource.com/43800
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-26 19:48:25 +00:00
Konstantin Shcheglov c3330ba080 Add 'pattern' and 'maxResults' to getElementDeclarations() request. 
R=brianwilkerson@google.com

Change-Id: I2094fa106cbdd7bc4eff9015d94b34517b3d50a5
Reviewed-on: https://dart-review.googlesource.com/42180
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 18:46:27 +00:00
Vyacheslav Egorov f2f7ad2fdd [gardening] Update dartk windows status 
Change-Id: I9619198e9d16bc3688ab24165fad06d1d0461d0a
Reviewed-on: https://dart-review.googlesource.com/43820
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-26 17:41:09 +00:00
Vyacheslav Egorov 0b5c52456a [testing] Make dartkp configuration work on Windows 
Change-Id: I4a09994a1b79a7d857a854e3dcc1fe24068ffdec
Reviewed-on: https://dart-review.googlesource.com/43671
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-02-26 17:31:48 +00:00
Aske Simon Christensen 69775fbf8c Allow constructors called 'get' or 'set'. 
Closes https://github.com/dart-lang/sdk/issues/32196

Change-Id: I61ea62b5c3d96634b1830383217ba6ef2aef8b7b
Reviewed-on: https://dart-review.googlesource.com/43741
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-02-26 17:30:17 +00:00
Vyacheslav Egorov 37f56d6c8e [vm/simdbc] Fix SIMDBC64 build: do not try to generate entry points JSON. 
Change-Id: I74d416e345d4dd9c3b73d4fb523ebcf02ca8b629
Reviewed-on: https://dart-review.googlesource.com/43780
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-02-26 17:08:47 +00:00
Aske Simon Christensen bb088347f0 Separate severity for context messages 
Change-Id: I8c0f9f0eae141e38e1f57afce4a30b6f95e8e412
Reviewed-on: https://dart-review.googlesource.com/43721
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-02-26 16:24:13 +00:00
Danny Tuppeny af527dd769 Fix some CompletionDomainHandlerTest tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: If6d0568d0de2268157c916267a0120c5b4295951
Reviewed-on: https://dart-review.googlesource.com/43666
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-26 15:53:37 +00:00