a3b2c5addb
Update status for analysis server tests on Windows
...
Various tests are currently flaky so marked with Pass, Slow/RuntimeError.
Bug: https://github.com/dart-lang/sdk/issues/32355
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: I86755a5eeb72ad92eaa22f950306e745c14e67fc
Reviewed-on: https://dart-review.googlesource.com/44260
Reviewed-by: William Hesse <whesse@google.com >
2018-03-01 13:52:32 +00:00
ded230959d
Fix Homebrew undent warning
...
Update the generated `dart.rb` formula file to fix:
```
Warning: Calling <<-EOS.undent is deprecated!
Use <<~EOS instead.
/usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats'
Please report this to the dart-lang/dart tap!
```
being reported by `brew`.
Fixes https://github.com/dart-lang/homebrew-dart/issues/48
Credit for original patch to @fsouza:
https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4
Closes #32346
https://github.com/dart-lang/sdk/pull/32346
GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71
Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e
Reviewed-on: https://dart-review.googlesource.com/44100
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-03-01 13:50:38 +00:00
1e814d92b1
[gardening] Mark null_nosuchmethod_test as crashing
...
Change-Id: I440d873f78b8aacf9e6c845d12f2966e12071235
Reviewed-on: https://dart-review.googlesource.com/44460
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-03-01 13:47:59 +00:00
90098c6c49
In front_end, treat ? and _ type contexts as equivalent.
...
We do this by requiring that the context argument to inferExpression
is non-null (since `_` is represented by `null`). Instead of passing
`null` as a type context, we pass `const UnknownType()`, which
represents `?`.
See #32291 .
Change-Id: I9a0d0f3bcd74e6226004c85f63cf8be49934388a
Reviewed-on: https://dart-review.googlesource.com/43761
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-03-01 13:20:28 +00:00
926ef7d742
[infra] Remove dart2js jsshell builder from the test matrix
...
Change-Id: I850f0d1d75e030da71593e56292fe986e15cc846
Reviewed-on: https://dart-review.googlesource.com/44461
Reviewed-by: William Hesse <whesse@google.com >
2018-03-01 11:56:39 +00:00
cebe85fb59
Add "Slow" to status for io test on simarch-kernel-release configs.
...
R: jensj@google.com
Change-Id: I24a59462d84e7e9a4487b16cbe11f27f6467e778
Reviewed-on: https://dart-review.googlesource.com/44428
Reviewed-by: Jens Johansen <jensj@google.com >
2018-03-01 11:54:09 +00:00
9c6ac3d3ea
Mark more tests crashing on dartk+dart_precompiled.
...
Change-Id: I6b923c520c2252b3fdf251315c4977a5a0dcbeb4
Reviewed-on: https://dart-review.googlesource.com/44429
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2018-03-01 11:15:16 +00:00
990fbea399
[infra] Update analyzer builders in the test matrix
...
Change-Id: I6a1b9533700646c0ab9b264063e31d6fd671dee7
Reviewed-on: https://dart-review.googlesource.com/44241
Reviewed-by: Paul Berry <paulberry@google.com >
2018-03-01 09:58:24 +00:00
9a024a2a5e
[fasta] Add reproduction of flutter incremental compilation crash
...
Add a (currently crashing) test which is a reproduction of
https://github.com/flutter/flutter/issues/14850
Also redo incremental_load_from_dill_test slightly so it uses an actual
test package (mostly so the new test can be marked as failing).
Change-Id: If439d4a9cb58ee10affa4a9742464ce10e930d93
Reviewed-on: https://dart-review.googlesource.com/43723
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-03-01 09:49:46 +00:00
aba70e747f
Update status files due to failing ASSERT in CompileAllFunctions
...
Bug: http://dartbug.com/32373
Change-Id: Id686f3c71918ca4eb12185eb5c4f8b8691441561
Reviewed-on: https://dart-review.googlesource.com/44425
Reviewed-by: Jens Johansen <jensj@google.com >
2018-03-01 09:47:44 +00:00
0d9b1e0fed
Make Member a FileUriNode.
...
Change-Id: I163d3e7315dbd28fb034230eb2064fe631ea74b4
Reviewed-on: https://dart-review.googlesource.com/44202
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2018-03-01 09:39:36 +00:00
f91ab5b64e
Fix test failures on Windows
...
Windows doesn't have curl, but PowerShell does have Invoke-WebRequest (aliased to curl).
Also Fix set_general_subscriptions_test path issue.
Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: I7567e2e01fc2158443b86569894ab0b17b3c5096
Reviewed-on: https://dart-review.googlesource.com/44240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2018-03-01 07:46:36 +00:00
b1a5325171
Suppress "extends" check when inferring mixins.
...
This should be safe since the purpose of the inference is to find an
exact match for each type parameter; if an exact match is found but it
doesn't satisfy the "extends" constraint, that will be detected and
reported later. If an exact match isn't found, the type bound will be
filled in my instantiate-to-bounds.
Addresses the analyzer portion of issue #32353 .
Change-Id: Ic9f71eefac2fa3f6f126957b9d1652ca1d990b89
Reviewed-on: https://dart-review.googlesource.com/44220
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-01 05:55:26 +00:00
39c2fc00e8
Optimize forwarding calls in string/num/bool
...
This generates string.length instead of string[dartx.length]. Will
do same kernel side if this looks good.
Change-Id: I1fed3ca3febfa441ba36a0be34d06ab9e2e103c8
Reviewed-on: https://dart-review.googlesource.com/44280
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2018-03-01 03:55:16 +00:00
ea7c7988e3
Don't inline source maps into the SDK
...
Change-Id: Ia4e8673cf0c023353b27a3c0a947b09e04ec09c0
Reviewed-on: https://dart-review.googlesource.com/44320
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2018-03-01 03:21:37 +00:00
558a931409
[vm] Move some string utils from runtime/vm to runtime/platform.
...
Change-Id: I552086445a7e07792f9da85afa5edf23b6c450d5
Reviewed-on: https://dart-review.googlesource.com/44402
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-03-01 02:07:46 +00:00
b8e4af7588
Increase dart_internal's lower SDK bound.
...
(This is mainly needed to allow using it with bleeding edge SDKs.)
Change-Id: Ie90d4dd51c03b1f48b42066041e9f5b743d791cb
Reviewed-on: https://dart-review.googlesource.com/44401
Reviewed-by: Natalie Weizenbaum <nweiz@google.com >
2018-03-01 00:40:53 +00:00
6238a55450
Get ready to publish dart_internal.
...
We need to use it in the observable package, which is externally
available, so it needs to be able to access it from pub.
Change-Id: I85a1488decb5ef4acd062e2fb3556e7d589e2c8c
Reviewed-on: https://dart-review.googlesource.com/44385
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2018-02-28 23:53:14 +00:00
d45d5a72d2
Pass --preview-dart-2 to dart_bootstrap and dart_precompiled in dartkp config.
...
Change-Id: I728d085b6433d7ad35fb389ce61b4959311a9b4a
Reviewed-on: https://dart-review.googlesource.com/44383
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Chandra <sivachandra@google.com >
2018-02-28 23:49:05 +00:00
21c9372d8d
Add dart2js-old-frontend option to test.py
...
Change-Id: I4e762bd5e50b2ff8a91b29e8067e47351ace94f7
Reviewed-on: https://dart-review.googlesource.com/44380
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-02-28 23:21:24 +00:00
3a5be046bb
Update FlutterOutline API to provide widgets instrumentation.
...
So, this is alternative approach - the plan is to instrument in Analysis
Server, then generate the entry point and instrumented code in Flutter
plugin, and run flutter_tester also from the plugin.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I6b2bb0fea6494df6b9f6b3e69e7548d03af7e94b
Reviewed-on: https://dart-review.googlesource.com/44382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-28 23:02:53 +00:00
6be6c3751d
[infra] Roll boringssl forward
...
Last roll was >1yr ago.
Change-Id: I9b641b9cff4b8b53887fe0ad1615bb9085ae9717
Reviewed-on: https://dart-review.googlesource.com/44381
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-02-28 22:16:13 +00:00
471f9a0a63
[vm/aot] Ensure that types and type arguments are handled correctly in tree-shaking
...
Move the code deciding whether instance needs to be handled specially
into AddConstObject, instead of having it spread around - this ensures
uniform handling.
Fixes https://github.com/flutter/flutter/issues/14891
Bug: 14891
Change-Id: I92b6383f37f6b6cf2e917013d17e8ae7ee977150
Reviewed-on: https://dart-review.googlesource.com/44300
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-02-28 21:23:33 +00:00
7ddeb32ec7
Update fasta parser to report error on "=" in for-in loop
...
In addition, this CL
* Inlines parseVariablesDeclarationOrExpressionOpt
* Adds for statement missing parenthesis recovery
* Removes TypeContinuation.VariablesDeclarationOrExpression
and inline the functionality
Change-Id: Ied57eb35848026ab856f21c66283bc8883a9d5e1
Reviewed-on: https://dart-review.googlesource.com/44360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-02-28 21:22:34 +00:00
215aa21172
Boost completion relevance for more cases.
...
R=brianwilkerson@google.com
Change-Id: Ib5fe69d3a0d20e29f36575e692a7418b6744ca83
Reviewed-on: https://dart-review.googlesource.com/44281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-28 19:32:56 +00:00
20f2a4b523
[vm/aot] Add regression test for issue #32322 .
...
This regression test was accidentally omitted from the
CL that fixed the issue itself.
Bug: 32322
Change-Id: I6011752827c4f46ab0602f17e0508a53578993b4
Reviewed-on: https://dart-review.googlesource.com/44301
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2018-02-28 18:37:56 +00:00
b5966dbddc
[vm] Don't use popcount intrinsic on both x86s.
...
Bug: https://github.com/dart-lang/sdk/issues/32314
Change-Id: I5589a22de5777af664c83f221758ba5b35d8678a
Reviewed-on: https://dart-review.googlesource.com/43886
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-02-28 17:48:16 +00:00
d002e2f6f3
Update status for 3 analysis server unit tests on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: Ide2a8e5051e42b529c5b302978f28246ce087cf4
R: athom@google.com
Reviewed-on: https://dart-review.googlesource.com/44203
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
2018-02-28 15:51:17 +00:00
74445c9eaf
Mark dartkp+dart_precompiled language_2/tearoff_dynamic_test as crashing.
...
Change-Id: I4bfa3306a52710ca550459a66274273c92286255
Reviewed-on: https://dart-review.googlesource.com/44141
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2018-02-28 14:34:33 +00:00
6eeac05d48
Unskip analysis server tests on windows
...
All path issues have been fixed and pass locally.
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I782bd0a661a10f78cb672e79a000f637aa9e46a6
Reviewed-on: https://dart-review.googlesource.com/44063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2018-02-28 14:18:55 +00:00
a96855a40f
Move exceptions to status file
...
Change-Id: Iee0e98e5e1e9884f798db3e130d4fca6c8ac6477
Reviewed-on: https://dart-review.googlesource.com/44064
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-02-28 14:13:55 +00:00
32efcbfde3
[test.py] Make test.py quickly skip tests that it isn't going to run
...
The current behavior is to - for instance - create all multitests in a
suite (e.g. language_2) up front, despite having a test-selector that
restricts it a lot.
This CL skips tests faster (i.e. before creating multitests).
Example:
Now:
$ time tools/test.py -m release -a x64 -c dartk --strong language_2/lalala
Test configuration: dartk_vm_release_x64_strong
real 0m0.598s
user 0m0.760s
sys 0m0.116s
Before:
$ time tools/test.py -m release -a x64 -c dartk --strong language_2/lalala
Test configuration: dartk_vm_release_x64_strong
real 0m1.796s
user 0m2.156s
sys 0m0.344s
Change-Id: Ib3c254d4e18c8ed4e6c66f7e25f384ce6b652f02
Reviewed-on: https://dart-review.googlesource.com/44061
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-02-28 13:29:34 +00:00
bd5f041b88
Remove unnecessary abstract check
...
Change-Id: Iadb3ff9f6f5d576b0d290d136fc7400ad7dcb48b
Reviewed-on: https://dart-review.googlesource.com/43921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-02-28 12:43:44 +00:00
9ee735b659
Add missing methods to List and Map implementations.
...
Optimize FollowedBy when the operands have efficient length.
Change-Id: I0af59240d70b929358c06b8d57a85df2deee6aaf
Reviewed-on: https://dart-review.googlesource.com/43665
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-02-28 12:26:53 +00:00
4a11a27b53
Revert "[VM runtime] Switch intrinsics from old to new Bigint implementation."
...
This reverts commit 9ba8c08953https://dart-review.googlesource.com/44025
> Reviewed-by: Alexander Markov <alexmarkov@google.com >
> Commit-Queue: Régis Crelier <regis@google.com >
TBR=alexmarkov@google.com ,regis@google.com
Change-Id: I926cc72e1ed89d8631e33ebcc8198853c05a08dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/44065
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2018-02-28 11:27:45 +00:00
b2d7397a0c
Add testing chain to validate messages.yaml
...
Change-Id: I34bf0a4bbbd9dab1133a69c844033035b7edb8db
Reviewed-on: https://dart-review.googlesource.com/43969
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-02-28 11:02:23 +00:00
063a244a7f
Fix analyzer bot failures in non-strong mode.
...
Change-Id: I614f2b5869e8b2ac022cc401df08d4dda4efd513
Reviewed-on: https://dart-review.googlesource.com/44101
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-28 09:22:13 +00:00
8bce74bc05
Remove dart:html import of dart:isolate
...
dart:isolate was used for the `Future<Isolate>` return type of
spawnDomUri, which is an unimplemented experimental method. This method
now returns `Future`.
This change helps dart4web disable support for dart:isolate (#30538 )
Change-Id: Ida87c2a27ac33d1b9a14feb7dd6d306a546a0aaf
Reviewed-on: https://dart-review.googlesource.com/43860
Reviewed-by: Terry Lucas <terry@google.com >
2018-02-28 07:25:00 +00:00
efc8ec1560
Update status of kernel/unsorted/types_test for dartkp non-strong.
...
Change-Id: Ibd22612ccbf4fa855f3a6bc068da64f4bb911fe6
Reviewed-on: https://dart-review.googlesource.com/44123
Reviewed-by: Siva Chandra <sivachandra@google.com >
2018-02-28 05:49:00 +00:00
01bdda69ef
Yet another status file update.
...
Update status files after 4f5ad1918chttps://dart-review.googlesource.com/44122
Reviewed-by: Siva Chandra <sivachandra@google.com >
2018-02-28 04:51:57 +00:00
579911393d
More status file updates.
...
Update status files after 4f5ad1918chttps://dart-review.googlesource.com/44121
Reviewed-by: Siva Chandra <sivachandra@google.com >
2018-02-28 04:43:18 +00:00
27d28702a6
Update status files after 4f5ad1918c
...
Change-Id: I96c56728521a507fe9870fa3f53060d594fa8a78
Reviewed-on: https://dart-review.googlesource.com/44023
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Chandra <sivachandra@google.com >
2018-02-28 02:06:36 +00:00
9ba8c08953
[VM runtime] Switch intrinsics from old to new Bigint implementation.
...
Change-Id: I43dfbdf76267bb96d1b1ce4aeb695d02bb18b7f8
Reviewed-on: https://dart-review.googlesource.com/44025
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2018-02-28 01:37:06 +00:00
aee7d5773d
API doc updates
...
* Update the API doc index page
* Update dart:io API description
Change-Id: I3e3574fc8d188e0d2fb5033c523f314590c4214c
Reviewed-on: https://dart-review.googlesource.com/43891
Reviewed-by: Kathy Walrath <kathyw@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
2018-02-28 01:23:46 +00:00
1aaebedd70
Reland https://dart-review.googlesource.com/c/sdk/+/43497
...
(Strip out platform dill files and the kernel service dill file from a
product build)
After fixing the issue of using 'is_product' which is not present in the
flutter build environment.
Change-Id: I49dd68e63b1f6d7ac0981b28bf2b08618551ae2e
Reviewed-on: https://dart-review.googlesource.com/44024
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-02-28 01:15:47 +00:00
b766ec170c
[VM runtime] Optimize new Bigint implementation for digit pair processing on 64-bit platforms.
...
Added Montgomery reduction in new Bigint implementation to support faster crypto (modPow).
Change-Id: Ic6872c9809485db27d0175c1d1f348232250b682
Reviewed-on: https://dart-review.googlesource.com/43300
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2018-02-28 00:52:57 +00:00
88c972de64
Address comments https://dart-review.googlesource.com/c/sdk/+/43800
...
Update AstBuilder to report interpolation in import conditional
Change-Id: Ie3c4971f6c5e99ecc018c5cedf934e37640778b2
Reviewed-on: https://dart-review.googlesource.com/44081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-02-28 00:37:56 +00:00
699f7bc1b1
Bring in the latest pub
...
Closes #32030
Bug: 32030
Change-Id: I349bfff94ebd2700f9950ed151da08c0becc9500
Reviewed-on: https://dart-review.googlesource.com/44022
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Natalie Weizenbaum <nweiz@google.com >
2018-02-27 23:49:46 +00:00
b3847560e4
Update AstBuilder to report interpolation in import conditional
...
Change-Id: If87831a138c14ef913f46b99b044c774d828ea08
Reviewed-on: https://dart-review.googlesource.com/44080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-02-27 23:29:07 +00:00
4f5ad1918c
Make strong mode the default under --preview-dart-2.
...
Change-Id: Ic1637d65a34f6b0310439293f7d83cb351f2c89c
Reviewed-on: https://dart-review.googlesource.com/43200
Commit-Queue: Siva Chandra <sivachandra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-02-27 22:16:07 +00:00
Danny Tuppeny