dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sigmund Cherem 932a99a731 Prepare pkg.status to enable dart2js CFE by default 
TBR=sra@google.com

Change-Id: I041af103a50c534ba278a61c1eefb689e5f58d6f
Reviewed-on: https://dart-review.googlesource.com/45366
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-07 01:30:21 +00:00
Jenny Messerly dab7da78cd fix implicit casts in DDC 
There are a few bug fixes here as well. Most notably, `.name.name`
instead of `.name` in DDK's analysis of virtual accessors. DDC/K's
handling of spread arguments in JS interop was also fairly broken
(it was generating a RestParameter instead of Spread). There's
also a lot of cleanup in js_ast as well, to make it a bit more
type safe.

Change-Id: Ia5333179e6dd0a62f20ce64a2b2b8bedf2ed7c49
Reviewed-on: https://dart-review.googlesource.com/44700
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-07 01:26:21 +00:00
Jenny Messerly 1b9b3453de fix DDC ES6 module export names, part of #32272 
We use renamable variables for Dart libraries, this ensures we still
export it with the correct name.

Change-Id: I96dc161e33d265c0ffbd07f8d642629504dffe62
Reviewed-on: https://dart-review.googlesource.com/42892
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-07 01:03:01 +00:00
Brian Wilkerson 69f8d4ef0d Fix parsing of super expressions (issue 32393) 
Change-Id: I887288254eb1be33c111b6dedd16c2acd3eb3dd1
Reviewed-on: https://dart-review.googlesource.com/45440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-03-07 00:43:21 +00:00
William Hesse 2ace7c9e9a Update dart2js-minified status for co19 no-such-method test 
Change-Id: Ie8b36afe78f256b7bdde11aec3079f0407c8bf01
Reviewed-on: https://dart-review.googlesource.com/45480
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-07 00:04:01 +00:00
William Hesse a1cacec5fc Update status after co19 roll 
The only change in co19-runtime.status that isn't just combining two
sections and normalizing is the movement of

Language/Classes/definition_t24: MissingCompileTimeError # Issue co19 #129, sdk issue #31624

from the vm section to a section with vm, dart_precompiled, and flutter, and
the removal of two sections only containing a single Generative_Constructors
test each.

The file is also normalized.

Bug: dartbug.com/32434
Change-Id: Ic62817b3ebdfd27e3cd58abc21f8bd61e7a18664
Reviewed-on: https://dart-review.googlesource.com/45380
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-06 18:08:45 +00:00
Konstantin Shcheglov 6b44182344 Only widgets in libraries can be rendered. 
Technically we could eventually implement rendering widgets in parts,
but this is probably rare situation, and IntelliJ plugin does not
handle this case yet.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I734eb5f5b26c386780a776f652366bd4d21125f9
Reviewed-on: https://dart-review.googlesource.com/45361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-06 18:02:39 +00:00
Martin Kustermann 8d6b050e28 [VM] Guard against duplicate entries in the static [Redirection::list_] 
The ARM simulator has assertions that there are no duplicates in the
[Redirection::list_] but the code does not guarantee this, since
multiple threads can add the same add [Redirection] entries for the same
native concurrently.

This CL guards the modification of [list_] with a [Mutex] and ensures
there's no duplicates.

This issue caused flakiness on the debug-simarm configuration.

Change-Id: Ia84a08e6e6f851a6047bae047ffb990044fb4a4b
Reviewed-on: https://dart-review.googlesource.com/45281
Reviewed-by: Erik Corry <erikcorry@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-03-06 16:42:21 +00:00
Konstantin Shcheglov be87175fee Implement Flutter Outline rendering API. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I7cbb4c0be7656ba1e684e8864348e6f1af54efae
Reviewed-on: https://dart-review.googlesource.com/45140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-06 16:33:34 +00:00
Lasse R.H. Nielsen 619434d38d Remember that C() is a compile-time constant expression. 
Actually make default value expression not constant.

Change-Id: Id9082716a6606618b91545f427726925849fb61c
Reviewed-on: https://dart-review.googlesource.com/45323
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-03-06 16:07:23 +00:00
Peter von der Ahé 18fe31ab11 Remove useOptimizedMixins from dart2js 
Change-Id: I677e96cf0d27c6c9e1f1eede57e9c248d6514769
Reviewed-on: https://dart-review.googlesource.com/45280
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-06 15:15:57 +00:00
Peter von der Ahé 9f56e28372 Mixin Applications with a Vengeance 
Change-Id: I213f99234f29abd7e2ec03dc8451ed6dd16f3d03
Reviewed-on: https://dart-review.googlesource.com/45021
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-06 15:15:57 +00:00
William Hesse 3f71dc5dd2 Add preview_dart_2 to supported set of status file variables 
R: paulberry@google.com
Change-Id: I9d77800f7db42207c5e730706b02b38080e85299
Reviewed-on: https://dart-review.googlesource.com/45322
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-03-06 14:46:44 +00:00
Lasse R.H. Nielsen bda78a0f41 Deprecated old upper-case constants. 
Change-Id: Ia923f953069bd41dbd5f0f3dc48aa55bad46aabd
Reviewed-on: https://dart-review.googlesource.com/45220
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-03-06 14:17:01 +00:00
Paul Berry b5b8080b2c Disable the conflicting generics check when using the old task model. 
This is necessary since the old task model doesn't implement mixin
type inference properly.

Works around bug #32421.

Change-Id: I6d7873d658d9d0fd8ea6aa5d2452bf9e92947032
Reviewed-on: https://dart-review.googlesource.com/45200
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-03-06 14:14:54 +00:00
Lasse R.H. Nielsen 9986b6de25 Fix bugs in implicit-creation tests. Add one more test. 
Change-Id: Id5328ba0568d7eba78c2b9145ee2db3476dc5bd5
Reviewed-on: https://dart-review.googlesource.com/44961
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-06 13:47:51 +00:00
Lasse R.H. Nielsen d22ac9f071 Faster first/last on VM implementation of (Linked)HashSet. 
See issue #31470

The performance numbers from the example in that issue improved as follows:

Before:
Set.first  2669 ms
Set.last  15509 ms
HashSet.first  2845 ms
HashSet.last  22053 ms

After:
Set.first  1244 ms
Set.last  1422 ms
HashSet.first  1075 ms
HashSet.last  4552 ms

Bug: http://dartbug.com/31470
Change-Id: I8afc91ad8835ac18bcc37737570c7f4be0bb6e8a
Reviewed-on: https://dart-review.googlesource.com/44782
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Corry <erikcorry@google.com>
 2018-03-06 12:50:21 +00:00
Sergey G. Grekhov f8f97bf105 *.status files and DEPS updated to include latest fixes for co19 tests 
Closes #32385
https://github.com/dart-lang/sdk/pull/32385

GitOrigin-RevId: 5c72b85b68c732de7f6aaec40bc13cc786f4af3d
Change-Id: I7dd33d1d2aed2ddf61465aa1a7696a3d5284e3f5
Reviewed-on: https://dart-review.googlesource.com/44760
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-06 12:24:43 +00:00
Erik Corry 235e62264e [VM] Reland Support some 32bit instructions in 64bit assemblers. 
These instructions will soon be used for for smaller (32 bit) Smis.
Also fix broken ubfiz instruction in ARM64 assembler.

This reland fixes the disassembler test that used Stop
instructions which disassemble differently on Mac
because constants have higher addresses.

Originally reviewed at
https://dart-review.googlesource.com/c/sdk/+/43668

Fix assembler test on Mac

R=kustermann@google.com

Change-Id: I61f8626184af495f18a74b5fef07bad02b6615e9
Reviewed-on: https://dart-review.googlesource.com/45240
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Erik Corry <erikcorry@google.com>
 2018-03-06 10:50:21 +00:00
Jens Johansen 17d5c44d40 [fasta] Invalidate part file when init from dill 
This CL adds a test that invalidates a part file after initializing from
a dill file. It futher more fixes the found issue so the part file (and
subsequent entire library it is a part of) is invalidated. Previously
invalidating a part file had no effect.

Change-Id: I0e76998d0ce2247b58c4a0e6cd691062b3069a2b
Reviewed-on: https://dart-review.googlesource.com/45181
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-06 10:19:01 +00:00
Johnni Winther d3c3ac48a3 Remove implicit 'implements Function' for strong mode 
Change-Id: Ie3e3e11a727f7fbe3c8d7af17c84dedfbdfcdf3a
Reviewed-on: https://dart-review.googlesource.com/44422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-06 09:18:48 +00:00
Johnni Winther 6baae53a5b Check functionTypeIndex in rti_emission_test 
Change-Id: Icffa0174cc0cfeedca98b11fe9ea95ee9ac24626
Reviewed-on: https://dart-review.googlesource.com/44140
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-06 07:58:46 +00:00
Jens Johansen e047586a0e Fix bad merge after 2181119d87 
Change-Id: I1e8131ae2ad8f5ac2e86a6590d303f69161d092a
Reviewed-on: https://dart-review.googlesource.com/45180
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-03-06 07:52:30 +00:00
Jens Johansen 2181119d87 Test and fix invalidating file exporting main 
In the incremental compiler, invalidating a file that exports other
libraries (among them one containing main) will fail to have a main set
in the resulting dill file.

This CL fixes the issue and introduces a test.

Change-Id: Ib7fe5ca46a44017eba6c5fcd39c358fe1b857a26
Reviewed-on: https://dart-review.googlesource.com/45000
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-03-06 07:24:12 +00:00
Mike Fairhurst 080e7e6073 Fix status files: file is excluded and so dartanalyzer errs on test. 
Change-Id: Id134bd81d02a8166ee2756f0323db8f650ccde84
Reviewed-on: https://dart-review.googlesource.com/45160
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-03-06 01:40:26 +00:00
Leaf Petersen c8ee601268 Add feature specification draft for Dart 2.0 subtyping 
This is a draft of a feature specification for the Dart 2.0 subtyping
relation.

See https://github.com/dart-lang/sdk/blob/2_0_subtyping/docs/language/informal/subtyping.md
to preview the markdown during review.

Bug:
Change-Id: Ib67fdb22b68a45e8dc1c1831326c82e735c89404
Reviewed-on: https://dart-review.googlesource.com/30927
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-06 00:02:38 +00:00
Sigmund Cherem 73944a3a5c Stop running corelib_2 in dart2js legacy 
TBR=sra@google.com

Change-Id: Ica678ba6531c8c09deacb3cbe875180a4ed5ecba
Reviewed-on: https://dart-review.googlesource.com/45121
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-05 23:57:10 +00:00
Mike Fairhurst 748cfdff7e Refactor to efficiently find analysis roots correctly fix #31343 & #31344. 
Move logic out into a ContextCache since we're not interested in caching
at least two if not three things (the options, the options path, and
optionally the builder).

Move some convenience methods around accessing contexts into a mixin.

Regarding some semantic decisions for finding analysis roots:
* treat the analysis_options.yaml file as the analysis root if it exists
* if it doesn't exist, assume the directory passed in is the root
* if custom options are provided, assume they "overwrite" the others
  _in-place_.

Tests to confirm this logic via excludes configurations with & without
the yaml file specified, passing in the root in some cases and
subdirectories in others.

Also change to use PathFinder for handling wildcards in excludes.

Bug: 31343,31344
Change-Id: I400fe30a1ec379f9040f812fc0bd9481d42a13cf
Reviewed-on: https://dart-review.googlesource.com/41570
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-05 23:51:00 +00:00
Sigmund Cherem c2a8632665 Cleanup language_2 .status 
We no longer have any sections with !$fasta. I saved around status lines that appear accurate at the dart2js global level.

TBR=sra@google.com

Change-Id: Ia2b212df87e196181d2631950f7d970edc9d6371
Reviewed-on: https://dart-review.googlesource.com/45123
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-05 23:26:00 +00:00
Konstantin Shcheglov 6189b9a360 Change Flutter Outline API to provide full instrumented code instead of edits. 
This solves potential consistency problem between Analysis Server and IDE.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I1403af1c90d7fec2ff18ffdb862f2209b19e548e
Reviewed-on: https://dart-review.googlesource.com/45124
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-05 22:46:19 +00:00
Sigmund Cherem 2448814e83 Also exclude 'Ok' as a valid status to ignore when checking for runtime errors 
in Runtime.none

R=rnystrom@google.com,whesse@google.com

Change-Id: I10c9c686d92ab646eebc7bc03a8abdedda66aa92
Reviewed-on: https://dart-review.googlesource.com/45122
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-05 22:19:40 +00:00
Sigmund Cherem b1778e5c34 Stop running language_2 tests on legacy mode 
TBR=sra@google.com

Change-Id: Iad324b54ab922b549cf07c090cb95d55f7d768c6
Reviewed-on: https://dart-review.googlesource.com/45120
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-05 20:15:00 +00:00
Leaf Petersen 4066804e5f Remove hint suppression now that MapEntry has landed 
Change-Id: I35d9c7105c2a5278b5b9558af9fe0570839fc51f
Reviewed-on: https://dart-review.googlesource.com/44882
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-05 18:45:51 +00:00
Stephen Adams f5e4f88c71 Skip assertions in InlineWeeder unless enabled 
Change-Id: I889a7aee208b68cbadb8bda01d5c1176e7dfe581
Reviewed-on: https://dart-review.googlesource.com/44920
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-03-05 18:15:20 +00:00
Régis Crelier ce715c3157 [Kernel] Annotate status file with newly filed issues. 
Change-Id: I6ea898f794dda65a705c6dcc19d70c1ec0567193
Reviewed-on: https://dart-review.googlesource.com/45100
Reviewed-by: Régis Crelier <regis@google.com>
 2018-03-05 18:02:32 +00:00
Alexander Aprelev a4c69b7729 Pass platform sdk as uri to frontend server. 
This fixes frontend_server.dart.snapshot creation on Windows.

Change-Id: I8dca91ed37ad7c83e951b6fa6c7a34070a35b666
Reviewed-on: https://dart-review.googlesource.com/45060
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-03-05 17:52:00 +00:00
Brian Wilkerson 1d159e7c23 Rename annotation testing methods in Element 
Change-Id: I0f60b9abd3de350e62d89eac0d690a1db40316b7
Reviewed-on: https://dart-review.googlesource.com/45080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-05 17:23:48 +00:00
Alexander Aprelev 4688be6320 Pass sdkRoot as file path to frontend server. 
This fixes test breakage on Windows.

Change-Id: I54dba0ec6955dee9d2417d81faa42dfc6b7e2da8
Reviewed-on: https://dart-review.googlesource.com/45040
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-03-05 16:32:29 +00:00
Erik Corry 3ac86d759e Revert "[VM] Support some 32bit instructions in 64bit assemblers." 
This reverts commit a5f173f165.

Reason for revert: Some test failures.

Original change's description:
> [VM] Support some 32bit instructions in 64bit assemblers.
> 
> These instructions will soon be used for for smaller (32 bit) Smis.
> 
> Also fix broken ubfiz instruction in ARM64 assembler.
> 
> R=​kustermann@google.com
> 
> Change-Id: I9068a1c4281047dbd7c1c447fc32ac0e92c89e9d
> Reviewed-on: https://dart-review.googlesource.com/43668
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

TBR=vegorov@google.com,kustermann@google.com,erikcorry@google.com

Change-Id: I0991712936d903f2cb1f3851c919ed6171a96711
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/44981
Reviewed-by: Erik Corry <erikcorry@google.com>
Commit-Queue: Erik Corry <erikcorry@google.com>
 2018-03-05 15:29:56 +00:00
Alexander Thomas d0eb2d63e8 [infra] Add front-end builder to test matrix 
#32123

Change-Id: I996ed57edc78f46aac6fa65a45e07500ad3758a0
Reviewed-on: https://dart-review.googlesource.com/44160
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-05 14:53:03 +00:00
Erik Corry a5f173f165 [VM] Support some 32bit instructions in 64bit assemblers. 
These instructions will soon be used for for smaller (32 bit) Smis.

Also fix broken ubfiz instruction in ARM64 assembler.

R=kustermann@google.com

Change-Id: I9068a1c4281047dbd7c1c447fc32ac0e92c89e9d
Reviewed-on: https://dart-review.googlesource.com/43668
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-03-05 14:45:23 +00:00
Jens Johansen d1203a382f [fasta] Use platform as outline in incremental test; assert non-empty mixin bodies 
Change-Id: I6dba18b8202b24ee3a87df5f18b1989bc62ef465
Reviewed-on: https://dart-review.googlesource.com/44431
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-03-05 14:30:07 +00:00
Brian Wilkerson 5fd560f96b Add getters to replace ParameterKind 
Change-Id: I0886c8d032e963857b8054e894ed3343a235b5c2
Reviewed-on: https://dart-review.googlesource.com/44921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-05 14:22:52 +00:00
Brian Wilkerson 0b332de3a8 Refactor where AST re-writing is happening to not interact poorly with inference (issue 32342) 
Change-Id: Ia8c0d17cedb78709dce421658eb46ff6a80d56c5
Reviewed-on: https://dart-review.googlesource.com/44384
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-05 14:22:02 +00:00
William Hesse a528f09443 Update status for dartkp test null_nosuchmethod_test 
BUG=dartbug.com/32377
R=jensj@google.com

Change-Id: If9921a23c211081101c3aadd85ca8acb2ef96f97
Reviewed-on: https://dart-review.googlesource.com/44960
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-03-05 13:54:27 +00:00
William Hesse e59018e714 Revert "Do not return this on RandomAccessFile.close" 
This reverts commit 44aa9a17fd.

Reason for revert: The dartdoc API documentation generator cannot handle Future<void> yet.  This is filed as a P0 issue, and the change should be relanded when it is fixed: https://github.com/dart-lang/dartdoc/issues/1625

Original change's description:
> Do not return this on RandomAccessFile.close
> 
> Bug: 32015
> Change-Id: I98508bdad569201afeed91f1287f061b5bb39a31
> Reviewed-on: https://dart-review.googlesource.com/44060
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

TBR=lrn@google.com,vegorov@google.com,zra@google.com,sigmund@google.com,lexa.knyazev@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 32015
Change-Id: I658b997cdc62e23cfb4fec8921e19239d534e272
Reviewed-on: https://dart-review.googlesource.com/44980
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-03-05 13:10:41 +00:00
Jens Johansen 14c1834334 [fasta] Add mixin test to incremental compiler test 
This CL adds another incremental compilation test extracted from flutter
that currently fails.

Change-Id: I03c7cf48933b3a6608e93ec34e5c27941b7d1ecb
Reviewed-on: https://dart-review.googlesource.com/44940
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-03-05 12:32:03 +00:00
Paul Berry 2993476129 Report an error if a class inconsistently implements a generic interface. 
This is not allowed in Dart 2.0.

Change-Id: I6861ce298e5d5a5cf3f26a010990868b5ba9bda2
Reviewed-on: https://dart-review.googlesource.com/39601
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-05 12:13:12 +00:00
Jens Johansen e5295eb6d1 [fasta] Small changes to the incremental compiler 
Fixes based on remarks in https://dart-review.googlesource.com/44720.

Change-Id: I455f8e62508c888873ae776af2d0a19e4ca49123
Reviewed-on: https://dart-review.googlesource.com/44941
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-03-05 11:58:23 +00:00
Peter von der Ahé b2fa7c4497 Always create problems to ensure lines are removed from status files 
Also, don't require example and analyzer code on internal errors and contexts.

Change-Id: I310772c869c8dba57a7f8a050364f2cfe05cf4e3
Reviewed-on: https://dart-review.googlesource.com/44785
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-03-05 11:29:41 +00:00