dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vyacheslav Egorov d8e96a8700 [vm/cleanup] Remove vm/cc/Sleep test. 
This test was skipped for ages and it does not seem to be very useful.

Closes https://github.com/dart-lang/sdk/issues/5133.

Change-Id: I9035956069fc7d42e710c3c49f98811db10f7d36
Reviewed-on: https://dart-review.googlesource.com/46062
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-03-12 17:15:28 +00:00
Vyacheslav Egorov f0455493de [vm/kernel] Do not skip type checks on closure functions. 
Fixes https://github.com/dart-lang/sdk/issues/32502

Bug: 32502
Change-Id: I3e4e9d6dd884f9660380994b24b7a263777f1a18
Reviewed-on: https://dart-review.googlesource.com/46066
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-03-12 17:13:20 +00:00
Devon Carew 9d053e2f43 Bring in the latest version of package:html. 
Change-Id: I9de7d0c936b31f1365fc6cd9099a87fa42798aaf
Reviewed-on: https://dart-review.googlesource.com/46001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-03-12 14:45:29 +00:00
Samir Jindel 290c576264 Remove inherited setters for mixed-in fields and copy their covariance-bits. 
Currently the transformed expectations are not checked.
This will be implemented shortly.

Mixin code from kmillikin@ (https://dart-review.googlesource.com/c/sdk/+/46060).
Test from jensjoha@.

Change-Id: If8abe4950b80bbec993833700bfeeb8be15f9585
Reviewed-on: https://dart-review.googlesource.com/46061
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-03-12 14:25:01 +00:00
Peter von der Ahé 52b66e17fe Make fasta command line work on Windows 
Change-Id: I2c3f5fea5948074c9dee138c387065edbe08b644
Reviewed-on: https://dart-review.googlesource.com/45509
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-03-12 14:00:39 +00:00
Dmitry Stefantsov cb2e4b183e [fasta] Rename some methods in Forest API 
Change-Id: Ic12bee4d3ff139135b1738bfb52485b26884c68b
Reviewed-on: https://dart-review.googlesource.com/45720
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-12 13:24:08 +00:00
Dmitry Stefantsov 2fcdfc1f23 Rename bug32353{,_2}_test.dart to issue32353{,_2}_test.dart 
Change-Id: Id00f2713dda2fcb62d43d5f7f2034b8f09bb12c1
Reviewed-on: https://dart-review.googlesource.com/46020
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-03-12 10:50:17 +00:00
Lasse Reichstein Holst Nielsen 414a3318ea Add jsonDecode, jsonEncode, base64Decode, base64Encode, base64UrlEncode functions. 
Change-Id: Ic65ada3b107cc8e6c3459459c4bea389feef2168
Reviewed-on: https://dart-review.googlesource.com/23664
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-03-12 09:16:27 +00:00
Dmitry Stefantsov 6cef6625ef [kernel] Record supertypes after the query intervals in CHA are built 
Fixes #32353.

Bug: http://dartbug.com/32353
Change-Id: I80199222ad5e44b954ed424f82752381653c63d3
Reviewed-on: https://dart-review.googlesource.com/45681
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-12 08:57:17 +00:00
Dmitry Stefantsov f820555d19 Add test of type checks on redirecting initializer arguments 
Bug: http://dartbug.com/32343
Change-Id: I863e370a3148f7a7da7a4c4599e005b381ceffa7
Reviewed-on: https://dart-review.googlesource.com/44465
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-03-12 08:49:37 +00:00
Dmitry Stefantsov c31e628c4c Check types of arguments passed to redirecting initializers 
Fixes #32343

Bug: http://dartbug.com/32343
Change-Id: I3f04d5a11e17541b7318c3721657c28928e7a634
Reviewed-on: https://dart-review.googlesource.com/44463
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-12 08:49:37 +00:00
Vyacheslav Egorov 009b6673ce [vm/kernel] Make 'unsupported tag' errors more verbose 
This simplifies figuring out what went wrong from just
debugging output in some cases.

Change-Id: Ie7a775c57fb691d6bd3ca1c70a04fb6cbe9e0875
Reviewed-on: https://dart-review.googlesource.com/43060
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-03-11 20:57:08 +00:00
Stephen Adams 70d715f115 Substitute return type too 
TBR=johnniwinther@google.com

Change-Id: I82cc6d6e7af8fb42956fbe538d770de66a449bd3
Reviewed-on: https://dart-review.googlesource.com/45924
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-03-10 03:44:28 +00:00
Jenny Messerly 40738b8884 fix #32481, generate signatures for mock members induced by nSM 
This bug prevented various DDC features from working correctly at
runtime, such as tearoffs, dynamic call checking, generic methods, and
parameter type checks.

Change-Id: I02cd27abbcb1d5f42b9d4ac504c7dd8bc80c866a
Reviewed-on: https://dart-review.googlesource.com/45960
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-10 01:11:23 +00:00
Mike Fairhurst b6460f34f6 Upgrade analyzer_plugin for republish with recent bugfix 
Change-Id: Ib431ae65936be23ccf05a160e8e607d40ab7d5ff
Reviewed-on: https://dart-review.googlesource.com/45962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-10 00:40:13 +00:00
Ryan Macnak 439badf2c0 Revert "[build] Declare dependency of the version strings on the current Git commit." 
This reverts commit c080951d45.

Reason for revert: Breaks Debian source package

Original change's description:
> [build] Declare dependency of the version strings on the current Git commit.
> 
> Bug: https://github.com/flutter/flutter/issues/15348
> Change-Id: Ifef1b55c6efe0f030ee83e4c43a774c7cd049fac
> Reviewed-on: https://dart-review.googlesource.com/45921
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>

TBR=aam@google.com,rmacnak@google.com,zra@google.com,phosek@google.com

Change-Id: I16ff18213bd1592c21bd9ae99b6e97fbdfc1824c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/flutter/flutter/issues/15348
Reviewed-on: https://dart-review.googlesource.com/45980
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-03-10 00:39:50 +00:00
Brian Wilkerson 7a0b6f8f4a Fix the analyzer bots 
Change-Id: I707211ea0698c4b684e13caccb099e3fdcc66409
Reviewed-on: https://dart-review.googlesource.com/45940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-10 00:20:08 +00:00
Ryan Macnak c080951d45 [build] Declare dependency of the version strings on the current Git commit. 
Bug: https://github.com/flutter/flutter/issues/15348
Change-Id: Ifef1b55c6efe0f030ee83e4c43a774c7cd049fac
Reviewed-on: https://dart-review.googlesource.com/45921
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-03-09 23:24:08 +00:00
Konstantin Shcheglov 693390a776 Index and search implicit references to optional positional parameters. 
R=brianwilkerson@google.com

Change-Id: Icf5f48118aeccbc137f125f9e730c9fe84200063
Reviewed-on: https://dart-review.googlesource.com/45922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 23:23:49 +00:00
Devon Carew 80a571d546 Take the --preview-dart-2 defaults from the context and options classes, not the cli tool defaults. 
Also, allow --no-preview-dart-2 from dartanalyzer.

Change-Id: Ic304a29e640bbddb50892c28712a131a2b306930
Reviewed-on: https://dart-review.googlesource.com/45881
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 22:30:24 +00:00
Brian Wilkerson 8d47a6e86f Add a fix for lints that recommend using final (issue 32473) 
Change-Id: I9ba38998e99c6102c0b69a2a3f8427416d087f2e
Reviewed-on: https://dart-review.googlesource.com/45900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 22:09:18 +00:00
Vijay Menon 0b48112d3e Fix nsm forwarding bug 
DDC was generating forwarders to static methods in interfaces.  (DDK was fine.)

Change-Id: Ic8ac2b7543d115cb06f215ffc7ebd0a4e7895b70
Reviewed-on: https://dart-review.googlesource.com/45860
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-03-09 21:50:28 +00:00
Konstantin Shcheglov 977f4c706f Issue 32397. Fix for top-level inference and implicit creation. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32397
Change-Id: Idec5867cfd0ac3e6c0f650afb7f282e66aea91ce
Reviewed-on: https://dart-review.googlesource.com/45880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 21:20:00 +00:00
Stephen Adams b8093e3323 Generate signature of instantiated generic function from uninstantiated function 
Change-Id: I8c02404e5a17f577d831f3a3b58ff075ad73e878
Reviewed-on: https://dart-review.googlesource.com/45755
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-09 21:05:38 +00:00
Brian Wilkerson 528d9d2e1f Do not hint when only a responsive asset exists (issue 32250) 
Change-Id: I8dc5402bb6d4e20682b49fa653349f03da934afe
Reviewed-on: https://dart-review.googlesource.com/45841
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 20:26:29 +00:00
Brian Wilkerson 5eb6d980b5 Do not hint when using a deprecated parameter in the defining function (issue 32468) 
Change-Id: I71de5c121add7bca7faa0875573e27f17f672e44
Reviewed-on: https://dart-review.googlesource.com/45840
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 19:09:08 +00:00
Alexander Markov aff70cafc1 [vm] Fix reading of Object::extractor_parameter_types() from a snapshot 
Before this fix, Object::extractor_parameter_types() and Object::extractor_parameter_names()
were initialized in Object::FinalizeVMIsolate(), which was called after
reading VM snapshot. So VM snapshot reader was registering nulls in place
of these VM objects in Deserializer::AddVMIsolateBaseObjects().
As a result, all references to Object::extractor_parameter_names()
were replaced with nulls while reading a snapshot.

The fix is to move initialization of those objects to Object::InitOnce().

Change-Id: I5f68853d9de23c94eb901080d9677100a6856c0c
Reviewed-on: https://dart-review.googlesource.com/45747
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-03-09 17:55:39 +00:00
Erik Corry 23fccf2e59 [VM] ARM64 unboxed 64 bit fix signed/unsigned const shift 
R=vegorov@google.com
TBR=vegorov@google.com

Change-Id: I3f67bbce487a1d2133080a1c441814ba0dd47ead
Reviewed-on: https://dart-review.googlesource.com/45706
Reviewed-by: Erik Corry <erikcorry@google.com>
 2018-03-09 14:18:55 +00:00
Dmitry Stefantsov e66733dd60 Simplify test case bug32353_test and decouple it from dart:io 
Bug: http://dartbug.com/32353
Change-Id: I941e15ed9f7dcc10c1ea1a0b3ff3acdee92487de
Reviewed-on: https://dart-review.googlesource.com/45503
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-03-09 13:45:58 +00:00
Jonas Termansen e067f7fdfa The dart-dfe target is no longer being benchmarked. 
Change-Id: I9188362c0f62e4df50a0b8262d03a183c615eedb
Reviewed-on: https://dart-review.googlesource.com/45703
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2018-03-09 13:31:08 +00:00
Dmitry Stefantsov 7ce30c5289 Fix status files after 26e689de05 
Change-Id: I2b992642194af7c56c0145a9aaa37b53984c07b2
Reviewed-on: https://dart-review.googlesource.com/45705
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-09 12:56:23 +00:00
Zach Anderson 978840a42f [infra] Use a jessie sysroot for sanitizer builds 
Change-Id: Ia91c6c10acebf2e94485dfbcbb5c4b38d772bc7d
Reviewed-on: https://dart-review.googlesource.com/45820
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-09 11:52:25 +00:00
Johnni Winther ad62702e93 Update status 
Change-Id: I6b231d18741045619315985e85ed04cf01181232
Reviewed-on: https://dart-review.googlesource.com/45701
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-03-09 09:39:35 +00:00
Vyacheslav Egorov 11c77930e0 [infra] Turn on C++14 in the compiler config 
Change-Id: I1b059deee64cf653be14e4a908050f1ff9c53781
Reviewed-on: https://dart-review.googlesource.com/45682
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-03-09 09:13:08 +00:00
Erik Corry 30a87ce3fa [VM] ARM64: Add unboxed 64 bit integers 
R=rmacnak@google.com

Change-Id: I9b18ef5385d3fbf615b82713f1af3f6a2facfb3d
Reviewed-on: https://dart-review.googlesource.com/45421
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-03-09 09:09:18 +00:00
Zach Anderson d2b7787186 [infra] Use downloaded sysroots by default 
Change-Id: I6bd6e369775182acb4aa5933360282af47024018
Reviewed-on: https://dart-review.googlesource.com/45762
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-03-09 09:02:05 +00:00
Zach Anderson 76b8e397ed Revert "Reland "[VM runtime] Switch intrinsics from old to new Bigint implementation."" 
This reverts commit be62fff82f.

Reason for revert: See https://github.com/dart-lang/sdk/issues/32465

Original change's description:
> Reland "[VM runtime] Switch intrinsics from old to new Bigint implementation."
> 
> The change was reverted (thanks Slava) because gen_snapshot was failing to
> find the core lib class _BigIntImpl on flutter.
> The PR https://github.com/flutter/engine/pull/4735 fixed that issue on flutter.
> 
> Change-Id: Id6863d79f7fdb17f0076b63b0168394d5e95ec8d
> Reviewed-on: https://dart-review.googlesource.com/44660
> Reviewed-by: Alexander Markov <alexmarkov@google.com>

TBR=alexmarkov@google.com,regis@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I412f5143442ca6ad43784b037c01fcf9bb42c348
Reviewed-on: https://dart-review.googlesource.com/45800
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-03-09 08:59:58 +00:00
Johnni Winther 26e689de05 More work on signatures 
Change-Id: Ifd8c20f1947149d60cca7c69e40ad85533519746
Reviewed-on: https://dart-review.googlesource.com/45700
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-03-09 08:30:28 +00:00
Sigmund Cherem 5f51db3efb More status preparations to make the CQ clean 
TBR=sra@google.com

Change-Id: I8275ada3611cfd4099342f963d76d94d7a267aac
Reviewed-on: https://dart-review.googlesource.com/45751
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-09 06:47:28 +00:00
Zach Anderson 2cb80620bd Revert "[vm/simarm] Fix VRECPS/VRSQRTSQS instruction implementation." 
This reverts commit 3da9c349d4.

Reason for revert: Broke the build on vm-kernel-precomp-linux-release-simarm

Original change's description:
> [vm/simarm] Fix VRECPS/VRSQRTSQS instruction implementation.
> 
> This instruction handles 0.0 and infinity operands
> specially because otherwise it produces NaN where it
> should produce appropriate infinity or zero.
> 
> Fixes https://github.com/dart-lang/sdk/issues/24399
> Fixes https://github.com/dart-lang/sdk/issues/26675
> 
> Change-Id: I0741d0daa8b92b4dcd780b1453c9ec449552b1fd
> Reviewed-on: https://dart-review.googlesource.com/45382
> Reviewed-by: Zach Anderson <zra@google.com>

TBR=whesse@google.com,vegorov@google.com,alexmarkov@google.com,zra@google.com

Change-Id: I413be56fdce8afa0e2faa6ed2b16ef0f68b795b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/45683
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-03-09 06:09:40 +00:00
Emily Fortuna feac6cfc20 Deal with Function type parameter contexts in closure conversion. 
They don't have a context, so just set context as "null" for the TypeVaribleTypeWithContext.

Change-Id: I50944c787d4bd88dd55b402d137da1ca99a55566
Reviewed-on: https://dart-review.googlesource.com/45748
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2018-03-09 02:31:17 +00:00
Jenny Messerly 76a672e8ea mark lib_2/html/fileapi_entry_test flaky on ddc+mac 
Change-Id: Ie501f972829f85f3fb3e1a0072d874bf4a2652a3
Reviewed-on: https://dart-review.googlesource.com/45753
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-03-09 02:03:34 +00:00
Alexander Markov 97bbe2f20b [vm] Avoid using objects in VM isolate heap for de-duplication 
Parameter types in application isolate could be modified during
execution, so it is incorrect to de-duplicate them with
read-only objects from VM isolate.

Fixes crash in pkg/front_end/tool/incremental_perf.dart
benchmark running from appjit snapshot. This crash appears after
https://dart-review.googlesource.com/c/sdk/+/45747 is applied.

Change-Id: I42a2007d02e04e0720c7e5d15224fcb6994bc515
Reviewed-on: https://dart-review.googlesource.com/45752
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-03-09 01:53:17 +00:00
Konstantin Shcheglov e1909cb52a Update Outline protocol - change offset/length, add codeOffset/codeLength. 
R=brianwilkerson@google.com

Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 01:52:57 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants 
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 01:02:49 +00:00
Jenny Messerly 5c94ec7b43 avoid generating unused constructors in dart:html 
Change-Id: I9de5d3ce68e7b4ae1873fbfa3eb96383b6b34460
Reviewed-on: https://dart-review.googlesource.com/13640
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-09 00:46:47 +00:00
Alexander Markov 7aa3e54acf [vm] Fix computation of hashCode of a closure with null receiver 
As tests/language_2/tearoff_dynamic_test.dart shows, it is perfectly
valid to take a tear-off of an instance method from null, and then call
hashCode from such tear-off.

The implementation of hashCode for closures, Closure::ComputeHash()
was calling Instance::Cast(receiver) which asserts for null.
This code is revised to allow null receiver.

Change-Id: I85cc7abf25aab99590b53403904e8bac25328308
Reviewed-on: https://dart-review.googlesource.com/45749
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-03-09 00:26:31 +00:00
Stephen Adams b93c74092a Make isInterceptedCall a field 
Change-Id: I88a16189d8a6a30fa52be61bc3d015a703368baa
Reviewed-on: https://dart-review.googlesource.com/45583
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-03-08 23:50:57 +00:00
Sigmund Cherem c956cc152f Prepare co19 for d8-hostchecked-dart2js-with-cfe. 
TBR=sra@google.com

Change-Id: I5c021a4a4043570a07ee931a83250a163227377f
Reviewed-on: https://dart-review.googlesource.com/45750
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-08 23:48:37 +00:00
Leaf Petersen 4c881188b2 Disable the .whereType method until generic methods are turned on. 
The whereType method silently does the wrong thing without methods,
so make it throw until we turn them on everywhere.

Change-Id: Id934c8bdb4f682dbc3560d78fbca580e37297e2d
Reviewed-on: https://dart-review.googlesource.com/45744
Reviewed-by: Nate Bosch <nbosch@google.com>
 2018-03-08 23:14:22 +00:00