flutter/shorebird
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore(shorebird_cli): raise minLinkPercentage to 75% (#1876)

Browse Source
This commit is contained in:
Eric Seidel
2024-04-08 10:11:13 -07:00
committed by GitHub
parent dc17d08cec
commit 4622f24afb
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
+8 -3
View File
@@ -104,9 +104,14 @@ If this option is not provided, the version number will be determined from the p
final HashFunction _hashFn;
final IosArchiveDiffer _archiveDiffer;
// Link percentage that is considered the minimum for acceptable perfromance.
// This was selected arbitrarily and may need to be adjusted.
static const double minLinkPercentage = 50;
// Link percentage that is considered the minimum before a user might notice.
// Our early testing has shown that about:
// - 1/3rd of patches link at 99%
// - 1/3rd of patches link between 20% and 99%
// - 1/3rd of patches link below 20%
// Most lowering is likely due to:
// https://github.com/shorebirdtech/shorebird/issues/1825
static const double minLinkPercentage = 75;
static String lowLinkPercentageWarning(double linkPercentage) {
return '''