From 4622f24afbd8eedb086138f207ff71482e0b9118 Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Mon, 8 Apr 2024 10:11:13 -0700 Subject: [PATCH] chore(shorebird_cli): raise `minLinkPercentage` to 75% (#1876) --- .../lib/src/commands/patch/patch_ios_command.dart | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart b/packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart index c1f27adb..b7620ca1 100644 --- a/packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart +++ b/packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart @@ -104,9 +104,14 @@ If this option is not provided, the version number will be determined from the p final HashFunction _hashFn; final IosArchiveDiffer _archiveDiffer; - // Link percentage that is considered the minimum for acceptable perfromance. - // This was selected arbitrarily and may need to be adjusted. - static const double minLinkPercentage = 50; + // Link percentage that is considered the minimum before a user might notice. + // Our early testing has shown that about: + // - 1/3rd of patches link at 99% + // - 1/3rd of patches link between 20% and 99% + // - 1/3rd of patches link below 20% + // Most lowering is likely due to: + // https://github.com/shorebirdtech/shorebird/issues/1825 + static const double minLinkPercentage = 75; static String lowLinkPercentageWarning(double linkPercentage) { return '''