dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Berry 38eed58f61 Fix hints in nullability migration code 
Change-Id: I22ef26cd928832a9d9ab2e8f4552519b914eef98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100080
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-22 14:00:59 +00:00
Paul Berry d50232a3f5 Plumb new FeatureSet class into AstBuilder. 
And change clients of parser and AstBuilder (within the SDK) to use
it.

Long term, it would be better to store the FeatureSet object directly
in the AstBuilder and remove the existing flags `enableNonNullable`,
`enableSpreadCollections`, `enableControlFlowCollections`, and
`enableControlFlowCollections`.  However there are analyzer clients
that currently use these flags.  So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags.  Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.

Change-Id: I6d37177c40b1a1216956e95f473252aa218d10b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100000
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-22 13:38:59 +00:00
Paul Berry 780f1b6c3e Remove unused imports 
Change-Id: Ia34e9d49e1baffe96a7da72a663f6751de31fc36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100041
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-22 13:29:19 +00:00
Brian Wilkerson c3f822eae6 Attempt to fix failures on the windows bot 
Change-Id: I668e62e5b866b83bba24a8406ffcaca4450eeb46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-21 19:42:17 +00:00
Brian Wilkerson 47a8ff60e1 Convert more analyzer unit tests 
Change-Id: Ie457491e24bc8820d24c533342b0d74edb922370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-21 15:29:17 +00:00
Paul Berry 76f177a492 Use a non-null index for all features, even expired ones. 
This ensures that the FeatureSet object can track the presence or
absence of expired features.

Change-Id: Ie6e213993792b8c3d6cf84ef01c464c16c274b85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-20 13:53:45 +00:00
Nicholas Shahan f5224b53e4 [dart_internal] Bump SDK constraint upper-bound to <2.4.0 
Change-Id: Iaad5890187b02562ae97ccc5195b0576cb58e564
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99860
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-04-20 00:58:51 +00:00
Ryan Macnak 3d1ca4ae39 Revert "[vm, interpreter] Invoke field as a bytecode." 
This reverts commit c85631330d.

Reason for revert: precompilation build failure

Original change's description:
> [vm, interpreter] Invoke field as a bytecode.
> 
> Simplify invocation.
> 
> Change-Id: I2d605d5f2f17e0e98499a19b9d9b6059682100b5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99884
> Reviewed-by: Régis Crelier <regis@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>

TBR=rmacnak@google.com,alexmarkov@google.com,regis@google.com

Change-Id: If417cb83e55e392895cdbdd263757f3e877f5ee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99961
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-04-19 23:38:24 +00:00
Ryan Macnak c85631330d [vm, interpreter] Invoke field as a bytecode. 
Simplify invocation.

Change-Id: I2d605d5f2f17e0e98499a19b9d9b6059682100b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99884
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-04-19 23:05:07 +00:00
Paul Berry 680744d169 Fix version number strings to always include a patch number. 
The version parser we use (Version.parse from package:pub_sumver)
doesn't support `major.minor` formatter version strings.

Change-Id: Ie6bf59d0f59d24d036c037d079494eb980e73212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99886
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-19 22:44:31 +00:00
Zichang Guo cb4db33010 [vm/debugger] fix order of type arguments in debugger 
Debugger will build array of type param(BuildParameters()) in an order that type param starts with type params of ancestor function and ends up with child function. But function with multiple type arguments is supposed to keep the same order instead of inserting reversely.

Bug: https://github.com/dart-lang/sdk/issues/35581
Change-Id: I861d8cf08ed90738dcaf18551eb1e5abd67067a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99721
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-04-19 21:53:21 +00:00
Stephen Adams 1ecedb2341 Fix JsLinkedHashMap memory leak 
Change-Id: I768de1f8e52c890dfbf8ca214e9e82051b4070fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99885
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-04-19 19:45:31 +00:00
Brian Wilkerson af0fa108da Add support for required named parameters 
Change-Id: Iebfd8da18c6f2158ed39043ab116e2670a7329c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99717
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-19 19:25:01 +00:00
danrubel a2e06eafff allow built-in keywords as identifier in for-in loop 
Fix https://github.com/dart-lang/sdk/issues/36678

Change-Id: I2af3a21e96c5654b12c199fc71d87f088e9d739d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99904
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-19 19:07:11 +00:00
Paul Berry 63658b113c Proposed new API for tracking feature opt in/out 
Change-Id: I777094da1301b525cd92cab1f9bf49d2f70a911b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99784
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-19 18:20:41 +00:00
Alexander Markov 8924c18003 [vm/tests] Revert changes in pkg/vm unit tests after constant-update-2018 was disabled 
Pkg/vm tests were adjusted after constant evaluation was enabled in the front-end.
As constant evaluation was reverted (4b7d256a06),
we also need to revert corresponding changes in pkg/vm unit tests.

Revert "[vm/bytecode] Update expectations for bytecode generator unit test"

This reverts commit 734c50cbf2.

Revert "[vm/aot/tfa] Update TFA tests after front-end starts evaluating constants"

This reverts commit 25cb45c02f.

Change-Id: I2fcc30571bec2dd904925724ddb7105567c7ecda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99782
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-19 18:12:21 +00:00
Hillel Coren aaa829695f Fix typo in CHANGELOG.md 
The word 'know' is missing from 'If you the expression' in CHANGELOG.md.

Closes #36676
https://github.com/dart-lang/sdk/pull/36676

GitOrigin-RevId: e406ea211f0421f5208d728e0d6261d12782adcc
Change-Id: Ifa335b2858f978837955eca23f47de589934b007
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99881
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2019-04-19 17:39:30 +00:00
Zichang Guo 78340fdf82 [vm] Support ListInterfaces for android 
Support ListInterfaces() for android. If android api level during build time
is greater than or equal to 24, it will use getifaddrs() from android ndk.
Since it didn't support until 24. Otherwise, use system call to query the
network interfaces.

Bug: https://github.com/dart-lang/sdk/issues/36449
Change-Id: I615b31b804b751382b775ad9c6af4411b123d5ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98949
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-04-19 16:38:44 +00:00
Konstantin Shcheglov 9e87c16677 Record TopLevelInferenceErrorKind.dependencyCycle in summary2. 
R=brianwilkerson@google.com

Change-Id: I1869f31dd6163827026e8e9d54e8682cb9ab2405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-19 15:45:34 +00:00
danrubel 3ae2ef7763 parse "late" modifier 
This updates the parser to recognize the "late" modifier and produce
errors when it is used improperly, but not yet notify the listeners.
Listeners will be updated in a subsequent CL.

Change-Id: Id15dfb1e3763872256e2ec93c83cf58adda096d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99786
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-19 01:25:26 +00:00
Ryan Macnak b352b5ffb7 [vm, jit] The hottest Smi ops are + < == not + - ==. 
Bug: https://github.com/dart-lang/sdk/issues/36409
Change-Id: Id1a6a65b26c95fb3f56bf844943aa09cc4f13a2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99728
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-04-18 22:50:45 +00:00
Bob Nystrom 3f477a6218 Consolidated CHANGELOG entry for 2.3.0. 
I added an intro to the UI as code stuff and then merged all of the
changes from the previous dev releases.

Change-Id: I0726268adcf5838a24dfee1cacd13e730b004090
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99736
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-04-18 21:27:51 +00:00
Ben Konyi cf4444b803 Revert "[ VM / Service ] Temporarily disable VM service auth codes by default" 
This reverts commit 98fc8ac7ff.

Change-Id: I4f9c1da8f216039017d954931d141fd267d71508
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99761
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-04-18 21:21:18 +00:00
Konstantin Shcheglov f8491950fe Create List<TypeParameterElement>, not Impl. 
Otherwise this Impl type gets propagated via toList(), and we get
a cast failure when attempt to assign TypeParameterMember element to
it. I'd like that we did not use TypeParameterMember at all, but
for now we do.

R=brianwilkerson@google.com

Change-Id: I03e1392fbd52d5a0fc7c257265d17d1cbd391edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99718
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-18 20:15:26 +00:00
Konstantin Shcheglov fa7485f28e Build types for not simply bounded elements using dynamic type arguments. 
R=brianwilkerson@google.com

Change-Id: Ia3c2d5193212a8cf58caad2323185e1ac9e31c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99716
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 20:14:49 +00:00
Ryan Macnak 9d376de55a [vm] Remove code collection. 
Code collection interacts badly with
 - warming up compiled code
 - retaining pre-compiled code
 - code coverage
 - hot reload (deopting to an old version of a function)

Change-Id: Id269a6c3281e577d4f600f0c158af9e62f6b49ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99722
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-04-18 20:12:09 +00:00
danrubel 0c0e49cd11 update keyword list to include "late" modifier 
Change-Id: I10d815d78d8198749680af1b56eff8eb31a6f895
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-18 19:59:29 +00:00
Aart Bik 3cf3e4edde [dart/vm] Reduce trip count of osr test 
Rationale:
Test was borderline timeout. The reduced tripcount
still triggers OSR consistently, but runs a lot faster.

https://github.com/dart-lang/sdk/issues/36421
https://github.com/dart-lang/sdk/issues/36218
https://github.com/dart-lang/sdk/issues/36214

Change-Id: I60917bb6bdd51dee6bd11d1fe5beede4753c2147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99783
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-04-18 19:52:20 +00:00
Ryan Macnak 503e20946c [vm] Start logging if shutdown takes too long. 
Change-Id: I2280df660cfeefe600ed7d0323769efc84ba54e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99738
Reviewed-by: Chinmay Garde <chinmaygarde@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-04-18 19:24:08 +00:00
Paul Berry 2b9f968d2f Convert engine.dart to triple-slash comment style 
Change-Id: I5808862e2d9a8e0944f713d925cf9b526bc5cccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99780
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 18:45:08 +00:00
Alexander Markov 73b917c014 [vm/compiler] Do not generate unnecessary field length guards 
GuardFieldLengthInstr::EmitNativeCode aborts background compilation
if we're not tracking list length for a field
(guarded_list_length() == Field::kNoFixedLength).
I'm seeing a lot of aborted background compilations on a Flutter app with
the reason "GuardFieldLengthInstr: field state changed while compiling".

This CL avoids generating these useless (and harmful) GuardFieldLengthInstr
if not tracking list length for a field.

Change-Id: I2a083c5df35e89893c9e787bebe4e3e7d8177c83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99737
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-04-18 18:31:49 +00:00
Konstantin Shcheglov 20fde9a6a8 Don't overwrite inherited types of fields with types of initializers. 
R=brianwilkerson@google.com

Change-Id: I0a92cc38e6f4bb8fe8f2102bf62f27c61ade1823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99715
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-18 18:03:59 +00:00
Konstantin Shcheglov e6e2a196a3 Issue 36667. Check for unresolved URI in getLibraryByUri(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36667
Change-Id: If35719b350c2f26edbb7cbe42f51af896aa41fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99713
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 18:02:38 +00:00
Konstantin Shcheglov 6ac38a926c The synthetic default constructor should have reference. 
We use ElementImpl.reference to store references to elements.
So, all elements must have one, even synthetic.

R=brianwilkerson@google.com

Change-Id: I29932449d97816108a6c1fca6db3fe7162baa1ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 17:44:10 +00:00
Konstantin Shcheglov 92729e0cd3 Remove UndefinedTypeImpl. 
And corresponding DartType.isUndefined as well.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I85debe627e989b5a5671becf5d9dd16413562236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99729
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-18 17:42:28 +00:00
Devon Carew cf77b82f52 [analyzer] handle youtube and animation dartdoc directives 
Change-Id: I5bcad74803da2466c8a50160823c586f57e00ec1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99711
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-04-18 17:18:28 +00:00
danrubel 6384f629c0 new conflicting-modifiers error code 
This adds a new "conflicting modifiers" error code for new NNBD
modifier errors and replaces the existing "const and var" error
code with the new error code.

Change-Id: I1997bbb7f66e62d2de3c5042b6ea85861f2e00d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-18 16:44:08 +00:00
danrubel f3703c1bce change "late" from built-in to keyword 
Change-Id: I851bc1a6db305c6fa7f5be001af1632d6d69aa2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99739
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-18 16:42:28 +00:00
Paul Berry af9c01432c Remove unused import 
Change-Id: I41a322c6eb208127256d752be23a92e59a01387f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99710
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2019-04-18 14:10:48 +00:00
Konstantin Shcheglov 7b6b8f8c43 Restore 'parameters' and 'typeParameters' for ParameterElementImpl. 
This partially reverts https://dart-review.googlesource.com/c/sdk/+/5000
which was done during moving toward integration with Kernel, which
we don't do anymore.

With summary2 the FunctionType of a function type parameter is purely
synthetic, without its original element. However parameters in
function typed parameters still exist as nodes, so they must have
elements.

R=brianwilkerson@google.com

Change-Id: I6689b05459f3989a20839346013c80a86ac8dc7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 14:10:18 +00:00
Paul Berry bc58bf598e Add summary serialization support for nullability suffixes. 
Resynthesis support will be added in a future CL.

Change-Id: I652da0c1ba60d8e41179e952294b4a4b45961347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99702
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-18 12:11:08 +00:00
Martin Kustermann 8093f73424 [vm/dbc] Add UNREACHABLE() stubs to simulator_dbc.cc in 32-bit mode to make 32-build work 
Issue https://github.com/dart-lang/sdk/issues/36665

Change-Id: I3690bac0ad213ea1757a78a14e513ccd8967f92b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99741
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-04-18 10:33:28 +00:00
Konstantin Shcheglov 336fc9001c Fix for getting type of a DefaultFormalParameter during building types. 
R=brianwilkerson@google.com

Change-Id: Idce49baa00c9b100efd5622ecfc64ef8f85bcb78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 05:08:08 +00:00
danrubel e93c6b7ce1 Add AST representation of the late keyword 
Change-Id: I0475065506488a0313c0aa6bc7f30d16f95d1405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99730
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-18 01:56:18 +00:00
Vijay Menon 43eebea5a3 [kernel_worker] retry on failure 
Workaround for https://github.com/dart-lang/sdk/issues/36644

See similar for dartdevc: https://dart-review.googlesource.com/c/sdk/+/99442

Change-Id: Id02549a7bd8110b4691a724fa8930ede477464f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99735
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2019-04-17 23:36:01 +00:00
Sam Rawlins 284a299543 Fix mustCallSuper for mixins; fixes #36492 
This re-lands most of https://dart-review.googlesource.com/c/sdk/+/98443.
This change does not include the "inherited interfaces" bit of that CL,
which some developers have objected to; we'll discuss.

Bug: https://github.com/dart-lang/sdk/issues/36492
Change-Id: Ibaa8ab87c749eae6359b739204c6f286b6818aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-04-17 22:59:11 +00:00
Konstantin Shcheglov 5a824581b7 Read directive annotations before returning offset. 
AST is read lazily.

R=brianwilkerson@google.com

Change-Id: Ibba09fd28d0cf6c0b5d59b0bf437b09adf16c78f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-17 21:47:28 +00:00
Konstantin Shcheglov 703ccc974b Support for TypeParameter metadata. 
R=brianwilkerson@google.com

Change-Id: Id0d0b9018538986787832c8001c6aa43c6bec380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99733
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-17 21:47:13 +00:00
Konstantin Shcheglov 242ed77040 Fix for FormalParameter without name. 
R=brianwilkerson@google.com

Change-Id: I9dd957a9a55aef444f1e82a094dbf600a57074b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99732
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-17 21:46:46 +00:00
Konstantin Shcheglov 92dd37081d Write / read Annotation element. 
R=brianwilkerson@google.com

Change-Id: Ia1cf2fd7d397186094827245a3cf33a5892690aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99731
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-17 21:46:11 +00:00