dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[kernel_worker] retry on failure

Browse Source 
Workaround for https://github.com/dart-lang/sdk/issues/36644

See similar for dartdevc: https://dart-review.googlesource.com/c/sdk/+/99442

Change-Id: Id02549a7bd8110b4691a724fa8930ede477464f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99735
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
This commit is contained in:
Vijay Menon
2019-04-17 23:36:01 +00:00
committed by commit-bot@chromium.org
parent 284a299543
commit 43eebea5a3
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
utils/bazel/kernel_worker.dart
+18 -5
View File
@@ -53,11 +53,24 @@ class KernelWorker extends AsyncWorkerLoop {
} else {
previousState = null;
}
var result = await computeKernel(request.arguments,
isWorker: true,
outputBuffer: outputBuffer,
inputs: request.inputs,
previousState: previousStateToPass);
ComputeKernelResult result;
// TODO(vsm): See https://github.com/dart-lang/sdk/issues/36644.
// If the CFE is crashing with previous state, then clear compilation
// state and try again.
try {
result = await computeKernel(request.arguments,
isWorker: true,
outputBuffer: outputBuffer,
inputs: request.inputs,
previousState: previousStateToPass);
} catch (_) {
outputBuffer.clear();
result = await computeKernel(request.arguments,
isWorker: true,
outputBuffer: outputBuffer,
inputs: request.inputs,
previousState: null);
}
previousState = result.previousState;
if (!result.succeeded) {
response.exitCode = 15;