6761015e30
Fixes for unresolved and invalid URIs.
...
R=brianwilkerson@google.com
Change-Id: Ief66dea3203187da90367984dc33f535748938d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-16 14:10:56 +00:00
890d12fa47
Do not append ! to type names in tests that exercise NullabilitySuffix.none.
...
Appending `!` is confusing because it suggests a non-nullable version
of the type. But the absence of a `?` or `*` suffix doesn't mean the
type is non-nullable. For type parameters, the type might or might
permit null depending on how it is instantiated.
Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-16 13:29:32 +00:00
2f77be6dc7
Fix overzealous rename.
...
In 79974bb026https://dart-review.googlesource.com/c/sdk/+/99480
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-16 13:22:42 +00:00
58ff41ad33
Add test for static tear-off
...
- to document the change (for the better) with CFE constant
Change-Id: I9b6673497fe07ccd4f92fc4c22df0ae3205f72a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99152
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-04-16 07:06:12 +00:00
e0bb1c8a58
[dartdevc] switch DDC tests to use Kernel files
...
This switches the "dartdevk" test configuration to use Kernel IL files
directly, rather than automatically converting Analyzer summaries.
Change-Id: Ifeeff98f298050b206c17678a85ee87909d41f46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99370
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Auto-Submit: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2019-04-16 00:55:42 +00:00
32f5223119
Search all directories when attempting to analyze manifest files
...
Change-Id: I3a900362d8d36d27e5c22f600db7bc54059c7717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-16 00:45:32 +00:00
5319d76b5a
Run ddc worker tests
...
Change-Id: I3555fe64bacd03a728d63a035457ca1e3398edb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98699
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2019-04-16 00:38:24 +00:00
a63bf3c846
[vm] Don't call the debug step check stub or bytecode in PRODUCT mode.
...
Change-Id: I2c91c69f4271bb3eed11d7ba81bd453bdb31bf38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99287
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-04-15 23:40:56 +00:00
f8c1cc7c24
Update the output for the generated Outline.java to compile. Outline.java has a special fromJson() method special cased in codegen_java_types.dart that was not updated when fields were added to the protocol.
...
Change-Id: Ib78f8a81ea3b48d6ae821d89617d3c1b66e69fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99375
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-04-15 23:05:56 +00:00
144bfdfce6
[vm] Use a separate kind tag for static field initializers.
...
This is preparation for handling implicit static getters as a bytecode.
Change-Id: Ic9fd186161d900c3b4c0bb773726b0cd0f35451e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99105
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-04-15 22:54:36 +00:00
92c14cb7ef
[fuchsia] Mark subprocess images as executable
...
Currently, the VMO returned by `fdio_get_vmo_clone` is executable,
despite being documented as being read-only. We wish to correct
the implementation, but doing so would break anything that relies
on the implicit executability of that VMO.
To enable Fuchsia to make this transition, we should explicitly call
zx_vmo_replace_as_executable on the VMO holding the binary image we
wish to launch as a subprocess.
Change-Id: I040ed2409120a58a30e88ef34a01fe73434a7ea0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99369
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
Auto-Submit: Drew Fisher <zarvox@google.com >
2019-04-15 22:32:46 +00:00
f0ae4de9a7
[ VM / Service ] Fixed GetCpuProfileTimeline which was attempting to parse 64-bit values as if they were 32 bits.
...
Change-Id: Ie4aa0727d28a977f00b8e6470fdf1d8811a13a62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99365
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2019-04-15 22:10:56 +00:00
bd4576174e
Remove the nullability variants of dynamic, bottom, and void.
...
Dynamic and void are always nullable. Bottom is never nullable.
Change-Id: I198dd6ccc84684ed05c578a5f80b1770d3f14b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99276
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-15 22:04:21 +00:00
a82a35af71
Rework _checkForDeadNullCoalesce using isNonNullable.
...
Change-Id: If55565d272af1be44e3326c3ec34889b3258323b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99367
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 22:04:21 +00:00
fa5440a568
Fix a typo in the comments
...
Change-Id: Ie67ca958622aef487322ad32d32d807f39cfe6f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99381
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-15 21:58:36 +00:00
77d096ca94
Add AST representation of the required keyword
...
Change-Id: I7eededadfa7bf5648cbaadbbccb0ef65af9a839f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99371
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 21:56:16 +00:00
f315727b79
Add basic resolution semantics for null-assertion operator
...
Change-Id: I69d0c577938a8991b98c44577556722bf54a1df8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99285
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 21:46:07 +00:00
067293b7fc
Update the copyright year to 2019 before pushing DAS 1.26.0 version to the Dart plugin
...
Change-Id: I8a2e5de067d5ee5a1bd564e5738e990bf289e325
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99372
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-04-15 21:41:29 +00:00
3937751b94
Switch AST summaries tests from the hardcoded SDK to MockSdk.
...
We have implemented enough to link MockSdk.
R=brianwilkerson@google.com
Change-Id: I6593a6a65773c5727a2bcd1d0b937b35bf8598ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99368
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-15 20:44:22 +00:00
369c9653c6
Store 'definingType' for next to raw Element references.
...
R=brianwilkerson@google.com
Change-Id: Ieb21f9af030b65afb59491f50a5659c564dfc419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99366
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-15 20:37:06 +00:00
b9eb7c312c
Add nullability testing methods to TypeSystem
...
Change-Id: I6451468eafedddb75a7012f328d730836694bdd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99380
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 20:32:05 +00:00
55ff0abde5
Rework building types for type annotations and declarations.
...
It is possible that a TypeName is a typedef, for which we have not
built types for its return type and parameter types. So, we cannot
rely on the order of nodes in NodesToBuildType. We have to build types
recursively.
R=brianwilkerson@google.com
Change-Id: Idb865ed1723456ccaea49802ea5e869e544461d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 20:06:13 +00:00
76e62d83e3
[vm/precompiler,const eval] Properly handle constant closures with delayed type args.
...
The precompiler fails to traverse the delayed type arguments of a constant
closure for addition to the snapshot. The canonical bit of these type arguments
is therefore cleared in Precompiler::DropTypeArguments before the snapshot is
written.
The vm constant evaluator fails to canonicalize the delayed type arguments of a
constant closure.
This fixes issue 36500.
Change-Id: I3e336e5c8233e5b5233828a913ee66f7b1d4daef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99364
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-04-15 19:54:50 +00:00
0b6c61dbd3
tests for issue 36055
...
Change-Id: I1ccd5deb6cff6e046895220ffdd03842ec5c20d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-15 19:28:45 +00:00
ae05bc6ec5
Add support for the type Never
...
Change-Id: I174ab85c0010a900b4d84068a90ac27e76b0e80c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99363
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 19:24:25 +00:00
92b4f78148
Fix warnings discovered during Apr 15 analyzer/front_end roll.
...
Change-Id: I6b78c732137738e5d5d35bd31f474f4210061edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99343
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-04-15 17:06:04 +00:00
79974bb026
Rename Nullability enum to avoid confusion with spec.
...
The spec uses the terminology "nullable", "non-nullable", etc. to
refer to properties of types that differ subtly from their structure.
For example "Null" is considered nullable, even though it lacks a
trailing "?". Since we were using the Nullability enum to denote a
purely structural property of types (whether they end in "?", "*", or
neither), this led to confusion.
So to avoid confusion, we rename the Nullability enum, and its
enumerated values, to clarify that it refers specifically to the
nullability suffixes and not to the property of being
nullable/non-nullable.
Change-Id: Ia34a500a3d2d724d30c66a410140ae11d6512f50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99275
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-15 16:50:14 +00:00
e42a8032fb
[cfe] Remove uninferred initializers from outlines
...
When performing top-level type inference based on overrides for fields
that have initializers, we never perform type inference for the
initializers. Since type inference is the thing that rewrites shadow
AST nodes with their Kernel translation, we are left with
untransformed shadow nodes that cannot be serialized.
Instead, remove these initializers. Fixes
https://github.com/dart-lang/sdk/issues/36498
Change-Id: I044fadd897e9f2d0e37f5ce0e5adaadb0e42a992
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99120
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-15 16:17:35 +00:00
4b42f87971
Remove unused import
...
Change-Id: I48175f0eecbd53fbe0c02b70c0a5f4d27ba88764
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99155
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-04-15 15:45:24 +00:00
193458abaa
Return the keyword from childEntities for import and export directives
...
Change-Id: I92d04bb856d7798d141f871766ec417745dd5f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 15:36:45 +00:00
d3e00fd35e
Update .expect files in pkg/front_end after e9ca6a53
...
TBR=askesc@google.com
Change-Id: I65e263c7ee627f94bc314346a322953f9e954899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99174
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-04-15 14:40:24 +00:00
b997b59c09
Include manifest in the list of files to analyze
...
Change-Id: I9b1c52ce085303e84b8882b0ccdc51c9555ce55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2019-04-15 14:15:15 +00:00
ec0447db5d
Add support for using ExpectedError and convert a couple of tests over to use it
...
Change-Id: I04a89cc922e0046dee4d7e9f964f272cfc60a055
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-15 02:17:44 +00:00
ea8d6e6fa9
Rename some error checking methods
...
Change-Id: I5a750c16a8c49d724f964efa5184a3d82abce8ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-14 15:10:33 +00:00
3e6fd64a8a
Dependencies based type inference with AST summaries.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I1513d54f6d6dbab70fa58af8d9c68a186c2a1ee3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99273
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-14 04:54:33 +00:00
c18c1f4bfb
[fuchsia] Use Unmap() instead of zx_vmar_unmap()
...
Cleanup from last CL.
Change-Id: I08547b78641867de301d6657c7bc096e7480ad55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99243
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2019-04-13 21:05:53 +00:00
0aa5547de1
Add missed tests and fix bug
...
Change-Id: I7696207525a009860f813ddcb94528edbf12ac4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99244
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-13 20:39:13 +00:00
22a843a23d
Fix precedence of postfix "!" operator
...
Change-Id: I00446e15cd7e19285b35742a1936c36b1faf4774
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99282
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-13 16:20:22 +00:00
f3dbfee467
Fix the error message template for EXPERIMENT_NOT_ENABLED.
...
Given an experiment named foo, it doesn't make sense to ask the user
to enable experiment --foo, since that's not the syntax for enabling
an experiment (the syntax is --enable-experiment=foo). Changed to
'foo'.
Change-Id: I055461fb389a4338578fc7f260e252b8e3fe9a13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99286
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-13 16:19:23 +00:00
2e7bd1359d
parse dart language version comment
...
This updates the parser to recognize a language version comment
of the form
// @dart = <major>.<minor>
as specified in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/language-versioning/language-versioning.md#individual-library-language-version-override
Change-Id: I884620ac7da86025f5b408bcba8dd1f77e4c523c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99261
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-13 13:09:22 +00:00
e89850f95d
Move STRICT_RAW_TYPE on constructors to INFERENCE_FAILURE_ON_INSTANCE_CREATION
...
Bug: https://github.com/dart-lang/sdk/issues/33749 https://github.com/dart-lang/sdk/issues/36445
Change-Id: Ic34f0e07b1cc5cbbc265ab2c32cabc61d7901c0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-04-12 23:51:21 +00:00
381f94522c
[fuchsia] Fix vmo leak
...
Change-Id: I0e3f1a869ba974a8c665d0741a2597e0bbd2a860
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99288
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2019-04-12 23:29:22 +00:00
61bb30822b
Revert "[VM-debugger] resolve column breakpoint tokenposition into a single value"
...
This reverts commit 2d1440b848https://github.com/dart-lang/sdk/issues/35137
>
> Change-Id: Ibbd273fcd85d49b441f2de7f3720e7889a6c1c22
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97341
> Reviewed-by: Siva Annamalai <asiva@google.com >
> Commit-Queue: Zichang Guo <zichangguo@google.com >
TBR=rmacnak@google.com ,asiva@google.com ,zichangguo@google.com
Change-Id: I4ea9bcfb82f1cac49312766d420c57959e500270
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/35137
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99272
Reviewed-by: Zichang Guo <zichangguo@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2019-04-12 22:00:42 +00:00
0314d86af4
Add errors when a nullable type is used as a supertype
...
Change-Id: I82471ba67dd74db6425bb2081bd761eb2b490333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99284
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-12 21:13:21 +00:00
9cc008e49c
[vm/bytecode] Add bytecode instructions for double operations
...
Change-Id: Ib1e8ca3b9bbf62f8282524fc5599eee5cae38389
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99089
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-04-12 20:17:01 +00:00
734c50cbf2
[vm/bytecode] Update expectations for bytecode generator unit test
...
This update is needed after constant-update-2018 is enabled in
e9ca6a5335https://github.com/dart-lang/sdk/issues/36601
Change-Id: I25f33e504f4df09a0d936fd11c7fa9c6236e4c78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99265
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-04-12 20:15:40 +00:00
3714658d0f
[vm] Fix Win32 build broken by 2a237327b2
...
Add missing <functional> include for std::function
Change-Id: I2010c7c3952b619d27bb881be38732e85993f50c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99171
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2019-04-12 20:09:01 +00:00
1ca57fc729
Update cfe_constant_evaluation_test and remove old constant-expression tests now that constant-update-2018 is on by default
...
Fixes https://github.com/dart-lang/sdk/issues/36597
Change-Id: Iaaadbacb71fdaddb5486bf0cf85188a30d088e50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99280
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-04-12 19:46:50 +00:00
2d1440b848
[VM-debugger] resolve column breakpoint tokenposition into a single value
...
The token positions of column breakpointlocation was the token position range of requested line.
With column number given, the token position should be resolved into a single value. Therefore,
FindInnermostClosure() can identify the closure precisely.
BUG= https://github.com/dart-lang/sdk/issues/35137
Change-Id: Ibbd273fcd85d49b441f2de7f3720e7889a6c1c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97341
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2019-04-12 19:41:45 +00:00
0d65bb9ab3
[VM] Adjust the expected results for get_source_report_test.dart
...
Since evaluation of constant expressions now happens in the front end
the test coverage results are consistent irrespective of whether 'Force
compilation' is specified for coverage data or not in this test.
Adjusted the expectations accordingly.
This should fix https://github.com/dart-lang/sdk/issues/36600
Change-Id: I5392b255c6102d90b431f62e5fd92408fd706ace
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99268
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-04-12 19:40:15 +00:00
Konstantin Shcheglov