Commit Graph

500 Commits

Author SHA1 Message Date
rnystrom@google.com bf31c85b6f Pass absolute path to git.
BUG=

Review URL: https://codereview.chromium.org//11364141

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14670 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 01:01:13 +00:00
rnystrom@google.com 9c0ace0797 Revert "Pass absolute path to git (redux)."
This reverts commit 9d638b8a9a48c7bae854685f9413d2c40a4911a1.

BUG=

Review URL: https://codereview.chromium.org//11361158

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14661 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:25:31 +00:00
rnystrom@google.com 930a3f1d7e Pass absolute path to git (redux).
Review URL: https://codereview.chromium.org//11312133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14659 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:20:18 +00:00
rnystrom@google.com 0caf122ecd Revert "Pass absolute path to 'git clone'."
This reverts commit db4155692da9cda80ef558886eeea35e963fe1c6.

BUG=

Review URL: https://codereview.chromium.org//11360133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14655 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:12:20 +00:00
rnystrom@google.com 8bea0cc487 Pass absolute path to 'git clone'.
Review URL: https://codereview.chromium.org//11390003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14654 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:03:53 +00:00
rnystrom@google.com f50263acb9 Revert "Try setting the working directory explicitly."
This reverts commit 71ae3f9bcae7ff111a3f360384ec148f1c2079b2.

BUG=

Review URL: https://codereview.chromium.org//11383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14652 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 21:00:43 +00:00
rnystrom@google.com c5fb8014cb Try setting the working directory explicitly.
This shouldn't be necessary but I want to see if this makes the
Windows buildbots happy.

BUG=

Review URL: https://codereview.chromium.org//11377036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14650 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 20:49:40 +00:00
ager@google.com b61bebe636 Allow Directory.create to create all missing path components.
Unified Directory.create/list/delete to take a named 'recursive'
argument.

Fixed bug in Path implementation on Windows.

R=sgjesse@google.com
BUG=dartbug.com/6024

Review URL: https://codereview.chromium.org//11364097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14572 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 15:00:54 +00:00
rnystrom@google.com 5704507534 Show better error messages in network failures.
We had decent messages for a couple of failure modes. This tries
to catch some more.

Review URL: https://codereview.chromium.org//11369066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14543 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 20:42:39 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
rnystrom@google.com c561c7f4c8 Configure git explicitly when committing.
Review URL: https://codereview.chromium.org//11343059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14314 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 23:31:16 +00:00
rnystrom@google.com 30f4763934 Revert "Explicitly configure git committer."
This reverts commit de38db47e7f5eca54ad1e338fec317cf67701448.

Review URL: https://codereview.chromium.org//11339058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14313 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:19:21 +00:00
rnystrom@google.com 36ced3963a Explicitly configure git committer.
Review URL: https://codereview.chromium.org//11276042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14312 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:09:41 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
floitsch@google.com 7041a6bbf1 Make methods in Stopwatch getters and rename to be more consistent.
Includes:
- Stopwatch.frequency.
- Stopwatch.elapsedInMs() -> Stopwatch.elapsedMilliseconds
- Stopwatch.elapsedInUs() -> Stopwatch.elapsedMicroseconds
- Stopwatch.elapsed() -> Stopwatch.elapsedTicks

Review URL: https://codereview.chromium.org//11265024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14140 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 14:25:23 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com e7c5e69beb Make String.charCodes a getter.
Review URL: https://codereview.chromium.org//11263040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14078 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 14:25:43 +00:00
rnystrom@google.com 8d84a68bac Remove wrong type annotation.
Review URL: https://codereview.chromium.org//11276019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14054 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 00:39:16 +00:00
rnystrom@google.com ab8d8d99e3 Explicitly create a git config in the test repos.
Review URL: https://codereview.chromium.org//11266027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14052 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 00:24:38 +00:00
rnystrom@google.com f573519f13 Include an explicit author when committing.
Review URL: https://codereview.chromium.org//11275019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14049 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 23:41:08 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com 0e47b363ae Make hasNext a getter instead of a method.
Review URL: https://codereview.chromium.org//11230011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
rnystrom@google.com 4c04a099d5 Apply patch from other client.
BUG=

Review URL: https://codereview.chromium.org//11235067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13984 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 20:25:58 +00:00
floitsch@google.com 27cadf2b66 isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.
Review URL: https://codereview.chromium.org//11227042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
ager@google.com 0f11f4baa0 Skip git pub tests as they do not work on Windows buildbots.
They work locally on my machine.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//11227053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13966 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 14:04:25 +00:00
ager@google.com 57d5cd2278 Remove second sleep in pub and enable pub tests on Windows.
After the inherit fix I cannot reproduce the other 7zip
problem either so I'm removing the sleep call. All tests
pass on my machine.

Bob, could you test this with all of your migthty pub
power and see if you can make it break?

R=sgjesse@google.com,rnystrom@google.com
BUG=dartbug.com/5910

Review URL: https://codereview.chromium.org//11225056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13964 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:56:54 +00:00
regis@google.com 8c3cfbb381 Second round of cleanups for new optional parameter semantics.
Review URL: https://codereview.chromium.org//11194025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13759 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 20:58:19 +00:00
nweiz@google.com 11a3d6b769 Reverting 13708
TBR

Review URL: https://codereview.chromium.org//11192019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13710 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 22:39:50 +00:00
nweiz@google.com ac3242b205 Add a Pub test that runs against the real Dart SDK.
BUG=5906

Review URL: https://codereview.chromium.org//11187011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13708 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 22:31:44 +00:00
regis@google.com adb534674c Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
Review URL: https://codereview.chromium.org//11090016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
rnystrom@google.com 1bb574612e Download to a temp dir and rename on success.
This prevents ghost packages ending up in your pub cache if a
download fails. Also added some more output during installation so
you can see what's happening.

BUG=

Review URL: https://codereview.chromium.org//11151026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13666 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 20:59:56 +00:00
rnystrom@google.com fc169ee8b2 "Reverting 13451"
Review URL: https://codereview.chromium.org//11066091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13452 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:32:21 +00:00
rnystrom@google.com 87f5622b44 Print out the working directory when git fails.
Also (sigh) re-enabling Windows again.

Review URL: https://codereview.chromium.org//11087039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13451 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:26:43 +00:00
rnystrom@google.com e9ff2669b8 "Reverting 13440"
Review URL: https://codereview.chromium.org//11099019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13441 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 21:02:26 +00:00
rnystrom@google.com 8fe2700fd8 Try enabling Git on Windows again.
Review URL: https://codereview.chromium.org//11098025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13440 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:55:46 +00:00
rnystrom@google.com 7707b979c4 "Reverting 13434"
Review URL: https://codereview.chromium.org//11028097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13436 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:01:58 +00:00
rnystrom@google.com 68fdad3715 Enable Git on Windows, again.
Now with slightly better error reporting so I can try to see what's going on.

Review URL: https://codereview.chromium.org//11066084

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13434 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:56:40 +00:00
rnystrom@google.com 182ae3e26c Update pub to use new import syntax.
Review URL: https://codereview.chromium.org//11093012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13391 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:25:43 +00:00
rnystrom@google.com 1ac8be8aa3 Better pub integration test error reporting.
Always includes the stderr when a test failures. Shows errors in stdout, stderr
and the exit code all at once. Displays differences in expected output better.

Review URL: https://codereview.chromium.org//11091015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13390 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:11:52 +00:00
rnystrom@google.com 9de6ef8dee "Reverting 13373"
Review URL: https://codereview.chromium.org//11091010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13374 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 21:02:31 +00:00
rnystrom@google.com d6bef3ac7a Enable pub git tests on Windows.
Review URL: https://codereview.chromium.org//11091008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13373 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 20:51:45 +00:00
rnystrom@google.com 57a43b6fd5 Spit pub tests into smaller suites.
Windows is slow and our large tests suites time out.

Review URL: https://codereview.chromium.org//11035066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13315 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 20:01:50 +00:00
rnystrom@google.com 3baa35cb36 Don't warn on the absence of "lib" in the root package.
Review URL: https://codereview.chromium.org//11043026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13193 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 20:04:19 +00:00
rnystrom@google.com 9486bb1c4e Revert "Tentatively enable pub hosted tests on Windows."
This reverts commit c078ff25b48d5904eea0358f322fc87799fc90ed.

Review URL: https://codereview.chromium.org//11031028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13125 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 16:29:24 +00:00
rnystrom@google.com da067c50b1 Tentatively enable pub hosted tests on Windows.
Review URL: https://codereview.chromium.org//11031020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13123 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 16:16:58 +00:00
ager@google.com 7977b42215 Update all occurrences of raw strings.
R=hausner@google.com,kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//10977027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12893 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 06:01:23 +00:00
rnystrom@google.com def86f3256 Convert raw strings in pub (and apidoc) to new syntax.
Review URL: https://codereview.chromium.org//10981031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12890 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 01:23:18 +00:00
sra@google.com ec120ee230 Update peg parser tests to r'' strings
Review URL: https://codereview.chromium.org//10991031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12889 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 01:02:21 +00:00