nweiz@google.com
3b8e03576e
Validate that an uploaded package has a LICENSE file.
...
BUG=7045
Review URL: https://codereview.chromium.org//11474047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15879 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:24:44 +00:00
nweiz@google.com
55ad513b3b
Work around issue 7218 in Pub.
...
Review URL: https://codereview.chromium.org//11470030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15878 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:21:15 +00:00
rnystrom@google.com
30d0a0356d
Fix type annotation and comment.
...
Review URL: https://codereview.chromium.org//11464040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15875 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:46:07 +00:00
rnystrom@google.com
015bb89346
Make sure to drain stderr in tests so that spawned process doesn't hang.
...
Review URL: https://codereview.chromium.org//11474046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15874 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:18:06 +00:00
rnystrom@google.com
2b9281fe14
Add in basic logging system.
...
Review URL: https://codereview.chromium.org//11470023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15870 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 22:13:47 +00:00
nweiz@google.com
97f425b7de
Add a validator that checks package names.
...
BUG=7045
Review URL: https://codereview.chromium.org//11444018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15857 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:30:51 +00:00
nweiz@google.com
e15d4788ce
Require a description field in pubspecs.
...
BUG=7045
Review URL: https://codereview.chromium.org//11466020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15856 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:27:03 +00:00
rnystrom@google.com
cf5ab6030e
Revert "By default use current code page on Windows for decoding string"
...
This reverts commit c247cd299958d0ee713dcfef8aaf44d230a3a7e0.
Revert "Fix memory leaks in system string patch"
This reverts commit 5e533a0c383518fc1851fbdc01a796f7d6b077f8.
Review URL: https://codereview.chromium.org//11446067
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15854 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 18:49:52 +00:00
rnystrom@google.com
e3bc775e68
Revert "Add logging system to pub and sprinkle some logging in."
...
This reverts commit 60468a1a0854389bb3f460cf2368f22013f1af31.
BUG=
Review URL: https://codereview.chromium.org//11472016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15830 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:48:12 +00:00
rnystrom@google.com
578c415134
Add logging system to pub and sprinkle some logging in.
...
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.
This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:
print() -> log.message()
printError() -> log.error()
That ensures all messages will correctly get added to the log's
transcript.
Review URL: https://codereview.chromium.org//11437019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:29:23 +00:00
nweiz@google.com
83fa5c203c
Stop working around issue 7044.
...
Review URL: https://codereview.chromium.org//11478004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15826 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:11:35 +00:00
nweiz@google.com
29318c2f5c
Revert "Stop working around issue 6984."
...
Review URL: https://codereview.chromium.org//11464015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:09:19 +00:00
nweiz@google.com
01dd8fcb4e
Stop working around issue 6984.
...
Review URL: https://codereview.chromium.org//11464006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 20:50:21 +00:00
rnystrom@google.com
39dc1b5323
Better error messages for dependency conflicts.
...
BUG=
Review URL: https://codereview.chromium.org//11445034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15768 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 02:04:30 +00:00
nweiz@google.com
0e9b2ef0bd
Add validation infrastructure for "pub lish".
...
This also adds a simple validator.
BUG=7045
Review URL: https://codereview.chromium.org//11434118
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15765 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 00:25:41 +00:00
nweiz@google.com
4ba4e92937
Handle OAuth2 AuthorizationExceptions in pub.
...
BUG=6950
Review URL: https://codereview.chromium.org//11416352
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15747 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 19:47:32 +00:00
rnystrom@google.com
2b3c4cd639
Make directory renaming more resilient on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//11348332
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15608 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 22:39:45 +00:00
rnystrom@google.com
0c0d8d9dc7
Get curl uploads working on Mac.
...
Review URL: https://codereview.chromium.org//11411273
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15592 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 18:21:41 +00:00
nweiz@google.com
6a6c381b91
Use pkg/http pervasively in pub.
...
Review URL: https://codereview.chromium.org//11280246
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15559 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 01:15:23 +00:00
nweiz@google.com
f7f4e8c458
Give all async exceptions in pub some sort of stack trace.
...
Review URL: https://codereview.chromium.org//11421159
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15547 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 22:45:51 +00:00
nweiz@google.com
806e8a5432
Mark pub oauth2 and curl_client tests as skip on Windows.
...
Review URL: https://codereview.chromium.org//11308262
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15488 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:52:00 +00:00
nweiz@google.com
ff3ab9a439
Mark the pub oauth2_test as failing on Windows.
...
Review URL: https://codereview.chromium.org//11418227
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15483 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:39:07 +00:00
rnystrom@google.com
e7382431ba
Get archive creation working on Windows.
...
Review URL: https://codereview.chromium.org//11348288
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15482 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:20:28 +00:00
nweiz@google.com
2df3fd15b2
The macos pub tests are working again.
...
BUG=
Review URL: https://codereview.chromium.org//11421136
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15479 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 23:34:34 +00:00
nweiz@google.com
558ffd19bf
Work around issue 6984.
...
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.
Review URL: https://codereview.chromium.org//11348285
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:43:10 +00:00
nweiz@google.com
a964e37605
Don't require users to copy-paste authorization codes when authorizing pub.
...
BUG=6951
Review URL: https://codereview.chromium.org//11348268
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15468 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:45:06 +00:00
nweiz@google.com
3b5ab2e81e
Add support for pub command aliases.
...
BUG=6949
Review URL: https://codereview.chromium.org//11416222
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15434 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:57:30 +00:00
nweiz@google.com
c2d351b552
Mark pub Windows tests as failing.
...
Review URL: https://codereview.chromium.org//11348266
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15432 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:46:55 +00:00
rnystrom@google.com
d2213763e0
Make pub git tests fast on windows again.
...
BUG=
Review URL: https://codereview.chromium.org//11428037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15424 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 23:21:04 +00:00
nweiz@google.com
8161b23167
Fix or mark "pub lish" build failures.
...
Review URL: https://codereview.chromium.org//11411201
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15423 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 23:10:47 +00:00
nweiz@google.com
e67b17723c
Add an initial "pub lish" command.
...
BUG=6177
Review URL: https://codereview.chromium.org//11308212
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15422 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 22:48:59 +00:00
rnystrom@google.com
8ce4fd1895
Mark the pub tests as slow/timeout on Windows.
...
Review URL: https://codereview.chromium.org//11421085
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15361 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 00:57:36 +00:00
rnystrom@google.com
d824a21ef4
Git tests on Windows are fast now.
...
Review URL: https://codereview.chromium.org//11414170
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15348 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 22:03:36 +00:00
erikcorry@google.com
359736e97a
Fix Unicode issues in dart2js and dart2dart.
...
R=floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//11418115
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15254 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 12:51:14 +00:00
erikcorry@google.com
84da84c22d
Revert "Add some support for the code-point code-unit distinction."
...
This reverts commit r15150
R=karlklose@google.com
BUG=
Review URL: https://codereview.chromium.org//11411092
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15152 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 15:23:41 +00:00
erikcorry@google.com
547cbf9da6
Add some support for the code-point code-unit distinction.
...
Adds String.fromCodeUnits and String.codeUnitAt, and modifies
String.fromCodePoints and String.codePointAt to actually use code points.
Fixes String.charCodes to use code points and adds String.codeUnits.
Reenables some tests, and adds new ones for non-BMP characters.
Fixes issues 6418, 6501 and 1357.
R=floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//11368138
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15150 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 14:51:25 +00:00
nweiz@google.com
500db0fb88
Enable CurlClient tests on Windows by bundling curl.exe.
...
BUG=6777
Review URL: https://codereview.chromium.org//11414044
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15117 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 22:55:30 +00:00
nweiz@google.com
f4e557d746
Move CurlClient to Pub so that it can access resources.
...
This CL also enables tests for the client on Linux and OS X.
Review URL: https://codereview.chromium.org//11299028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15047 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-17 01:15:45 +00:00
rnystrom@google.com
90325c70ca
Remove support for old package layouts.
...
Review URL: https://codereview.chromium.org//11280018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14990 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 00:23:58 +00:00
rnystrom@google.com
24b6b08b04
Don't require "branches" directory in git repo.
...
The pub tests just validate that it looks "like" a git repo.
It seems like some git repos (ones from git later than 1.8?)
don't have this directory so let's just not worry about it.
Review URL: https://codereview.chromium.org//11416024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14988 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 23:52:05 +00:00
rnystrom@google.com
7cc5243981
Validate that the homepage is using an approved scheme.
...
Also cleaned up the pubspec tests a bit.
Review URL: https://codereview.chromium.org//11412017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14984 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 22:53:16 +00:00
rnystrom@google.com
4fc4f5eb9f
Undo bogus change to use old dart:io API.
...
Review URL: https://codereview.chromium.org//11410102
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14928 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 23:29:46 +00:00
rnystrom@google.com
26e59cf859
Fix error reporting on invalid command line args.
...
It would crash in a few cases if you didn't pass in a valid command
Also fixed a few unrelated warnings since a warning we learned to
ignore was masking the original issue. :(
Review URL: https://codereview.chromium.org//11363249
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14927 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 23:22:35 +00:00
rnystrom@google.com
10c9d938ab
Place "packages" directories inside "tool".
...
Review URL: https://codereview.chromium.org//11362233
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14868 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 22:06:35 +00:00
ajohnsen@google.com
ab69873a42
Make RegExp constructor non-const.
...
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.
BUG=
Review URL: https://codereview.chromium.org//11369210
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ajohnsen@google.com
ec9fee9858
"Reverting 14829-14832"
...
BUG=
Review URL: https://codereview.chromium.org//11312203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
ajohnsen@google.com
8dc3edd7ce
Make RegExp's constructor non-const.
...
BUG=
Review URL: https://codereview.chromium.org//11410033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
rnystrom@google.com
46adf67738
Allow an empty "dependencies" key in a pubspec.
...
Review URL: https://codereview.chromium.org//11361201
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14773 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-10 01:00:58 +00:00
gram@google.com
58a016634c
Update utils to new library syntax.
...
This doesn't include adding partofs; that will have to be done later.
Review URL: https://codereview.chromium.org//11358145
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14693 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 17:42:40 +00:00
rnystrom@google.com
c8d4f7dd50
Mark pub windows git tests as potentially timing out.
...
Review URL: https://codereview.chromium.org//11361163
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14672 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 01:44:08 +00:00