Commit Graph

25510 Commits

Author SHA1 Message Date
jmesserly@google.com 9fa9329f90 add custom_element package
code is from https://github.com/dart-lang/web-ui/blob/polymer/lib/custom_element.dart

Includes a test for the polyfill. It also includes a static analysis test to catch the common errors of forgetting to add an Element API. Because we had analysis errors in "observe" and "mdv" packages too, I added tests for them too, and fixed the issues.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20886002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25591 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 23:00:21 +00:00
cbracken@google.com 6a728556d1 Rename int{x,32,64} to Int{X,32,64} in line with naming guidelines.
BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//21085005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25584 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 21:19:59 +00:00
cbracken@google.com 79bd97594e Don't throw exception for non-integer args to fixnum int32,int64 op ==
Original bug
https://code.google.com/p/dart/issues/detail?id=12073

BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//20803006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25577 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 17:56:29 +00:00
gram@google.com f6f52a8416 Fix issue in DeepMatcher where == throws.
See issue https://code.google.com/p/dart/issues/detail?id=12053

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25575 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 17:22:37 +00:00
ricow@google.com 2bc1e6202d Mark pkg/watcher/test/no_subscription_test as flaky on windows.
Filed: http://www.dartbug.com/12107

R=kustermann@google.com

Review URL: https://codereview.chromium.org//21053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25559 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 13:15:19 +00:00
tmandel@google.com b465115231 Fixed YAML output for a list of maps
R=alanknight@google.com, efortuna@google.com

Review URL: https://codereview.chromium.org//20162006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25539 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 21:00:25 +00:00
jmesserly@google.com 0bd2127aac [pkg:observe] Add support for explicit change notification, even on dirty-checked objects.
This is to fix warnings in Polymer.dart's TodoMVC example. Even though the objects extend ObservableMixin, they still have some computed fields that they notify manually. This seems like a scenario we should support, WDYT?

Also fixed a TODO about sending an unmodifiable list to the stream.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20631002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25531 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:15:31 +00:00
janicejl@google.com 7c432437fd Moved deleting directory to whenComplete
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20777002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25528 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:04:24 +00:00
sigmund@google.com 3de7c9695f Fix source spans hashcode implementation
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//20600002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25514 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 00:50:29 +00:00
rnystrom@google.com 1adc8736bc Remove API documentation from path README.
BUG=https://code.google.com/p/dart/issues/detail?id=8072
R=nweiz@google.com

Review URL: https://codereview.chromium.org//20364002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25513 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 00:18:52 +00:00
rnystrom@google.com 27d4c15f99 Handle special characters in path<->uri conversion.
Also cleaned up some docs a bit.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//20130004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25512 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 00:15:40 +00:00
gram@google.com c34f9bfb20 Change throw of String to throw of ArgumentError.
See https://code.google.com/p/dart/issues/detail?id=9913

R=nweiz@google.com

Review URL: https://codereview.chromium.org//20591002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25511 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 00:04:46 +00:00
gram@google.com 56cf8bc524 Add matchers for some more recent error types.
See https://code.google.com/p/dart/issues/detail?id=8510

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20586002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25510 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 23:58:50 +00:00
rnystrom@google.com 6855525908 Ignore all trailing separators in path.extension.
BUG=https://code.google.com/p/dart/issues/detail?id=10235
R=nweiz@google.com

Review URL: https://codereview.chromium.org//20372002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25509 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 23:27:08 +00:00
sigmund@google.com a634d8ffc7 Create package for HTML imports
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//20414002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25505 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 21:57:03 +00:00
janicejl@google.com 67908d7201 Added generic information for return types.
R=alanknight@google.com

Review URL: https://codereview.chromium.org//20162005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25502 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 21:44:27 +00:00
gram@google.com 3600e1b644 TBR Fix build break by not using int for time.
Review URL: https://codereview.chromium.org//20479002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25497 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 20:42:10 +00:00
gram@google.com 053ca05478 Fix issue with extraneous newline in test result output.
See https://code.google.com/p/dart/issues/detail?id=10702

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20428002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25491 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 19:19:32 +00:00
jmesserly@google.com 116e11e9a5 [mdv] fix analyzer failure in select_element.dart
Review URL: https://codereview.chromium.org//20369004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25489 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 18:47:09 +00:00
jmesserly@google.com 1210e466cb [mdv] implement Node.createBinding and Node.createBindings
port of
https://github.com/Polymer/mdv/commit/95c4eca5a89ed3d04af1c6607a61f49d35d05ca6, https://github.com/Polymer/mdv/commit/3a0d2f302d474cd175d7fe49b278f928a019d053

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//20149004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25485 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 18:01:02 +00:00
gram@google.com 470f8ee0eb Add import meta for @deprecated.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25482 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 17:41:59 +00:00
gram@google.com 12af846df4 Added a way to let the outer event loop run periodically so that things like
DOM updates don't get completely starved when doing lots of sync tests.
See issue https://code.google.com/p/dart/issues/detail?id=11450

Also, TestCase._run now always returns a Future, so _nextBatch is a misnomer;
renamed it to _nextTest and removed the loop.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20115007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25480 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 17:17:28 +00:00
gram@google.com 0f4734a082 Replace someElement with anyElement.
See https://code.google.com/p/dart/issues/detail?id=10189

R=seaneagan1@gmail.com, sigmund@google.com

Review URL: https://codereview.chromium.org//20172003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25479 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 17:16:57 +00:00
gram@google.com 1917976321 Remove references to webdriver in pkg.status
R=sigmund@google.com

Review URL: https://codereview.chromium.org//20125006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25455 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:07:57 +00:00
gram@google.com 65fa576868 Modify the instance test to work with dart2js by using looser matching,
and re-enable the test.
See https://code.google.com/p/dart/issues/detail?id=11191

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20101008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25452 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 23:53:27 +00:00
gram@google.com c821dc0cf8 Remove the webdriver package; it has moved to github.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//20134002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25444 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 21:46:04 +00:00
janicejl@google.com 9061a9e69b qualified names added
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20138002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25442 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 21:18:13 +00:00
jmesserly@google.com 93a6deac0c automatically clean up CompoundBinding
rough port of https://github.com/Polymer/mdv/commit/907455b2196f06650c5cdfbdb145e6eda2861750
We already handle most of the cleanup automatically; CompoundBinding was the main outlier.
I'm not completely sold on "close" being public, but it's needed if "bind" is going to start the subscription immediately (like it does now).

R=sigmund@google.com

Review URL: https://codereview.chromium.org//19996008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25438 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:54:09 +00:00
jmesserly@google.com 63a6171bee [mdv] Simplified Mustache Parsing
port of https://github.com/Polymer/mdv/commit/8843b7299d19bb1671780697de483cc3b0456a61

as well as the two follow ups:
https://github.com/Polymer/mdv/commit/f1af6fe683fd06eed2a7a7849f01c227db12cda3
https://github.com/Polymer/mdv/commit/783a48876e86e883ab98f3a7849fcd482e86bb75

R=sigmund@google.com

Review URL: https://codereview.chromium.org//20062002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25437 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:50:21 +00:00
alanknight@google.com 899a8d27a0 Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20072002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25435 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:01:59 +00:00
alanknight@google.com 816b24e8ff Make _shortLocale public
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20071003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25423 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 17:12:54 +00:00
whesse@google.com 23db6345ab Port dart:io Path tests to package:path.
BUG=
R=nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//19231002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25403 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 08:45:18 +00:00
jmesserly@google.com b7a44d0d88 Avoid observing placeholder arrays in TemplateIterator
... and minimize instance removal/addition

port of https://github.com/Polymer/mdv/commit/1bc8afff957fc542ac5925afd8575dce229be835

I also rolled a few other parts of TemplateIterator forward to be based on current code.

The list_diff port is from change_summary.js. It was ported and reviewed in an older MDV CL, but not checked in because ObservableList is smarter about producing diffs.

R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19492018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25392 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 01:11:05 +00:00
jmesserly@google.com 32df041b1e [mdv] fix test expectation
follow up to https://code.google.com/p/dart/source/detail?r=25390

I forgot we had an extra test here that MDV doesn't have.

Review URL: https://codereview.chromium.org//19932007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25391 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 01:00:25 +00:00
jmesserly@google.com 4a51682495 Only need to force removal of conditional attribute bindings
port of https://github.com/Polymer/mdv/commit/853ef6e8d56f994852ade6356febb7037f18b741

R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//20064004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25390 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 00:34:30 +00:00
janicejl@google.com 8544abc81b single library test
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20017003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25386 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 00:03:19 +00:00
sigmund@google.com f49a89abc2 Update shadow_dom package with latest changes.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//19581004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25383 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 23:39:58 +00:00
janicejl@google.com aaf9f61a80 "Reverting 25378"
BUG=

Review URL: https://codereview.chromium.org//19695013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25381 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 23:08:49 +00:00
janicejl@google.com d1ff57f6c2 Single Library Test
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20066002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25378 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 22:54:29 +00:00
kevmoo@j832.com 5285b80b8a pkg/http tweaks
locking down MultipartRequest a bit
Removed superfluous import of dart:io and dart:isolate

R=nweiz@google.com

Review URL: https://codereview.chromium.org//19866007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25376 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 22:47:13 +00:00
jmesserly@google.com b159325f4a Ensure model is passed with <template if>
port of https://github.com/Polymer/mdv/commit/78bd4e2c8e569580863bb80cea90f36ef38f5290 and https://github.com/Polymer/mdv/commit/50d4074d05bd57cd8f76ba7952bf740a7386c1ce

R=sigmund@google.com

Review URL: https://codereview.chromium.org//19744006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25374 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 22:12:19 +00:00
jmesserly@google.com 608d559f7a Ensure getInstanceModel is only called when a new instance will be created
Note that this also allows for the common case of inserting an instance via a DocumentFragment. Only if there is a instanceCache hit, do we insert an array of nodes.
port of https://github.com/Polymer/mdv/commit/694a4114779a9cd8ea3c915d1f5e9ec5ad6bd68c

R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19689009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25373 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 22:06:04 +00:00
jmesserly@google.com 6774f0db6b Custom Syntax's are now enabled via template.bindingDelegate =
port of https://github.com/Polymer/mdv/commit/d4c97a94fe565b07eec174ab27994e67a514ce4b
(except the expression syntax bits -- that's covered in fancy_syntax)
BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19663011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25371 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 21:48:53 +00:00
jmesserly@google.com aea4a202cc fix parsing of semantic template interation w/ shadowdom polyfill
port of https://github.com/Polymer/mdv/commit/05ae24466ea7b2cdd41d879169e95b00a6bf4a8e
BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19482024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25369 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 21:17:34 +00:00
rnystrom@google.com 3b45c1d8a4 Fix documentation of path.toUri().
R=nweiz@google.com

Review URL: https://codereview.chromium.org//20043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25366 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 20:37:57 +00:00
nweiz@google.com 133814b67b Remove calls to [new Future] work around issue 11911.
BUG=11911
R=gram@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//19841002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25365 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 20:26:04 +00:00
jmesserly@google.com fecf49078c [mdv] getTeminatorAt recurses infinitely if template is its own terminator
port of https://github.com/Polymer/mdv/commit/5846863ba6895eaeffee5c4f4618a2f6570c3f99

note that the indicies in that commit are off by 1, it's fixed in a later MDV change and in this port:
https://github.com/Polymer/mdv/commit/83eafb5f2861092fcda56cf28a2570193803fde1, which I have also patched in. Our version was already working but I tweaked the code to more closely resemble the MDV code.

R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//19672018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25363 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 20:20:56 +00:00
rnystrom@google.com 6559ab1bf6 Fix static warnings in pkg/path.
BUG=https://code.google.com/p/dart/issues/detail?id=11856
R=nweiz@google.com

Review URL: https://codereview.chromium.org//19851005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25361 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 20:09:31 +00:00
gram@google.com fb62473ebf Add missing newline after Actual value in fail message.
Remove the BasMatcher class; it made some sense when we had both 'interface'
and 'class' but adds no value now.
Fix a comment in the CustomMatcher documentation.
Fix tests affected by these changes.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//18442002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25356 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 19:48:26 +00:00
janicejl@google.com 1f490d682c "Reverting 25348"
BUG=

Review URL: https://codereview.chromium.org//19818007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25349 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 17:46:13 +00:00