Commit Graph

25510 Commits

Author SHA1 Message Date
jmesserly@google.com be70a7e4d4 Fix packages for latest SDK changes
This is the observe/mdv/custom_element side of the changes.
Polymer changes are at https://chromiumcodereview.appspot.com/22254002

The big change here is we can't use a Stream for the MDV<->custom_element bridge, because Streams aren't re-entrant which makes them not useful for a sync event.

Also fixes createBinding to dispatch to the custom_element so we don't need to hack "bind" in PolymerElement

R=sigmund@google.com

Review URL: https://codereview.chromium.org//22253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25799 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 20:50:55 +00:00
nweiz@google.com 0c7c0765dd Add events in barback to bubble up the dirty bit.
This allows TransformNodes and Phases to notify their AssetCascade that they've
become dirty. This is important for transforms re-running their cascades when
their cross-package imports become dirty.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21446002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25794 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 20:23:06 +00:00
kevmoo@j832.com 541ef31a2b pkg/unittest: get stackTrace from error directly
R=gram@google.com

Review URL: https://codereview.chromium.org//21905005


git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25779 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 18:17:52 +00:00
tmandel@google.com e78e373edf Fixed toMap() for subclasses
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//22232002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25774 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 17:21:46 +00:00
kustermann@google.com 8324943b7d Status file updates after changing testing scripts to use a dependency graph
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//21892004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25768 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 15:30:07 +00:00
fschneider@google.com 39b5f02124 Update status file for flaky test. The failure is not reproducible anymore.
BUG=https://code.google.com/p/dart/issues/detail?id=12177
R=ricow@google.com

Review URL: https://codereview.chromium.org//22199002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25766 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 13:38:44 +00:00
tmandel@google.com 67191d7ce6 Fixed [:foo:]-style markdown links and added lookup within the library
R=efortuna@google.com

Review URL: https://codereview.chromium.org//21999002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25755 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-03 00:06:49 +00:00
janicejl@google.com 3f3eaeb7a3 annotation with parameters.
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21699002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25751 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 22:48:53 +00:00
janicejl@google.com ad42a34d9d Added inherited comments, and where they are inherited from.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//21619003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25748 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 22:19:22 +00:00
rnystrom@google.com b44ec0e706 Re-implement directory polling.
BUG=https://code.google.com/p/dart/issues/detail?id=12107
R=nweiz@google.com

Review URL: https://codereview.chromium.org//21628002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25746 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 22:01:39 +00:00
tmandel@google.com 02ea589b94 Fixed docgen to work on files without the SDK
R=efortuna@google.com

Review URL: https://codereview.chromium.org//21877009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25745 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 21:41:29 +00:00
gram@google.com 98c1a51750 Avoid creating unnecessary port in slave config, and don't print the messages
used by the test harness.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21938002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25737 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 17:30:50 +00:00
gram@google.com 6737bd3dd9 Remove erroneous package dependency.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//21927002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25736 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 17:19:21 +00:00
kustermann@google.com cb18d8ba87 Removed compiler/ directory from repository
R=ricow@google.com

Review URL: https://codereview.chromium.org//20722006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25728 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 08:31:15 +00:00
janicejl@google.com 95ee996390 Returning the closest public superclass rather than returning ""
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//20617005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25727 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 02:50:33 +00:00
janicejl@google.com c97b060fcd added inherited methods and variables with docgen running in under 40s.
superclass ongoing.

attempting super class.

class map

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//21096002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25722 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 20:51:02 +00:00
fschneider@google.com 8c89870852 Mark a Dartium test as flaky until the corresponding issue is resolved.
BUG=dart:12177

Review URL: https://codereview.chromium.org//20654003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25710 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 15:55:36 +00:00
jmesserly@google.com a184061e7f [mdv] fix checked mode issue
Review URL: https://codereview.chromium.org//20907003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25700 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 01:13:53 +00:00
jmesserly@google.com 254878312a Speed up CompoundBindings
port of https://github.com/Polymer/mdv/commit/27b9cc6dfa69745aadb862780ae71b905e74014f

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21451002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25699 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 01:04:18 +00:00
nweiz@google.com 54a2295fd7 Support an additional edge case in barback.
This adds support for the case where a transform loads an input, then that input
is changed before that transform completes. Previously the change would be
ignored; now the transform will be re-run.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//20625005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25695 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:14:41 +00:00
nweiz@google.com f22e9532a6 Move barback to a more event-based model.
The goal of this change is to make it easy to synchronously propagate the dirty
state of an asset node to all of the nodes and transforms that depend on it,
while still asynchronously processing those transforms.

In addition, this refactor ends up addressing two TODOs and one bug:

* If a node has been compiled previously and an unrelated part of its cascade is
  dirtied, it will now be returned immediately rather than waiting for the
  entire cascade to finish processing.

* If a node is consumed as the input of a transform, it will no longer be
  returned by [getAssetById].

* If the contents of a transform's primary input changes such that it's no
  longer a valid primary input for that transform, the transform will be
  removed.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21275003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25693 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 23:51:24 +00:00
gram@google.com 3f0e5d2034 TBR: Disable mirror matcher test for dart2js/csp.
See https://code.google.com/p/dart/issues/detail?id=12151

Review URL: https://codereview.chromium.org//21009003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25678 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 18:58:58 +00:00
jmesserly@google.com e01298dc8c fix analysis error in custom_element
for some reason, dart2js treats this as a warning, dartanalyzer as error, and VM as so serious it won't load the app.

Review URL: https://codereview.chromium.org//21369005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25673 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 17:31:19 +00:00
gram@google.com afe20804eb Re-enable unittest tests disabled due to issues 10935 and 11473.
Because we have split the unittest tests out into individual files, I want 
these tests to be run again with the aim of either understanding and fixing
these issues, or at least reducing the number of tests marked as flakes.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25672 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 17:18:38 +00:00
gram@google.com 3f44e04163 Split unittest tests into separate test files.
For now we replicate the status for all the tests in some cases (e.g.
FireFox flakiness), but after this is committed we can re-enable these 
tests to try to isolate flaky test cases more narrowly.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21220004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25670 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 17:03:07 +00:00
gram@google.com 53fa6910bd Added hasProperty matcher.
See issue https://code.google.com/p/dart/issues/detail?id=11397

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21085010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25667 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 16:03:28 +00:00
ricow@google.com 3f3ee83b09 Fix = to == in status file
Review URL: https://codereview.chromium.org//21114003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25660 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 07:26:12 +00:00
ricow@google.com 039ab166b4 Mark pkg/custom_element/test/custom_element_test as failing on dartium and on the analyzer.
Filed issue 12142

Review URL: https://codereview.chromium.org//21243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25659 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 07:21:40 +00:00
jmesserly@google.com 761dbb63a6 remove bindModel, the same effect can be achieved through createInstance
partial port of https://github.com/Polymer/mdv/commit/86c0d3d8059eebbafab6d919cd805373951873ea

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21093005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25658 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 02:51:50 +00:00
jmesserly@google.com 3d1290bfae attempt to deflake IE9 mutation observer test
R=sigmund@google.com

Review URL: https://codereview.chromium.org//21286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25657 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 01:03:20 +00:00
gram@google.com b51552bb31 Fix a couple of issues in the interactive config that the analyzer found.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//21310003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 00:49:00 +00:00
nweiz@google.com 290b3be3df Fix cancelable_future again.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21004014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25654 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 00:38:09 +00:00
nweiz@google.com 7b86592840 Add a library name for cancelable_future.dart
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21097006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25653 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 00:24:55 +00:00
nweiz@google.com c12a5cad3a Refactor the barback tests somewhat.
This makes each transformer capable of relatively fine-grained pausing
and resuming of processing. They no longer use MockAsset, instead
using [Asset.fromString] to better simulate real-world transformers.

This also adds several new utility functions to
barback/test/utils.dart.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21226004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25652 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 23:57:16 +00:00
jmesserly@google.com 250852e80b [pkg:mutation_observer] fix 12132, ie9 support
R=sigmund@google.com

Review URL: https://codereview.chromium.org//21191006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25650 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 22:49:01 +00:00
jmesserly@google.com 5e389b1b05 mark mutation_observer tests as failing on IE9
filed bug https://code.google.com/p/dart/issues/detail?id=12132

Review URL: https://codereview.chromium.org//21026007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25645 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 21:48:41 +00:00
jmesserly@google.com 7c3ca56e0a skip test that imports dart:html on VM bots
BUG=

Review URL: https://codereview.chromium.org//21261004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25643 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 21:38:13 +00:00
jmesserly@google.com 6121faba73 add mutation observer polyfill package
also enables custom element tests on all supported platforms

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21109007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25637 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 20:48:47 +00:00
cbracken@google.com 25ed5a4234 Clean up exceptions thrown in pkg/fixnum.
* Throw ArgumentError rather than string.
* Don't wrap ArgumentError params in strings.

Original Issue:
https://code.google.com/p/dart/issues/detail?id=9909

BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//21155004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25635 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 20:40:00 +00:00
cbracken@google.com 0bcf5eff82 Int32 constants should be const.
BUG=
R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//21169002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25634 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 20:34:00 +00:00
janicejl@google.com b734eed591 added a warning if no package root is passed in for a single file.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21131009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25629 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 18:42:56 +00:00
rnystrom@google.com e54e94e92a Fix path browser test.
BUG=https://code.google.com/p/dart/issues/detail?id=12121
R=nweiz@google.com

Review URL: https://codereview.chromium.org//21164005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25628 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 18:32:40 +00:00
janicejl@google.com 108ff664b7 Added a flag --append to docgen.
Results of docgen append together if append flag is set.

BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//21184003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25624 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 16:56:57 +00:00
scheglov@google.com 62d6ac752c Fix for NPE when convert error without source.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//21162003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25615 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 14:53:41 +00:00
whesse@google.com 28298880ad Mark two standalone tests as flaky, with bugs filed for them.
package watcher, directory_watcher_test and standalone/vmservice/multiple_isolate_list_test are marked as flaky.

BUG=http://dartbug.com/12107, http://dartbug.com/12124
R=ricow@google.com

Review URL: https://codereview.chromium.org//21241002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25613 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 13:09:32 +00:00
ricow@google.com 947984f6f5 Mark pkg/path/test/browser_test as failing on browsers.
The test is using the io library (which is not available, neither imported)

Filed dartbug.com/12121

R=ager@google.com

Review URL: https://codereview.chromium.org//21128007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25604 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 05:57:19 +00:00
jmesserly@google.com eb6e8d27ff I marked custom_element as failing in IE9, but that also included the analysis test, which was being run even on browser bots(!)
Review URL: https://codereview.chromium.org//21189002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25602 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 01:11:13 +00:00
rnystrom@google.com 3b1d63cd9d First stab at a dev server in pub using barback.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//20204003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25600 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 00:44:56 +00:00
jmesserly@google.com a40fefb346 mark custom_element test as failing on IE9
it depends on Mutation Observers which are not supported
(however, a polyfill package is coming shortly!)

Review URL: https://codereview.chromium.org//21103008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25597 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 00:23:09 +00:00
vsm@google.com 897dc30061 Update mdv test status
I think this was fixed by my recent CL.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//21022010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25595 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 00:01:38 +00:00