b196cd2acb
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 22:35:15 +00:00
25d8456c48
Small improvements for DeclarationsTracker.
...
R=brianwilkerson@google.com
Change-Id: Ic35e7cead9a50b9eb8ae590f9fbf85df0a8f7fc1
Reviewed-on: https://dart-review.googlesource.com/c/91583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-29 22:33:34 +00:00
081160036a
Fix #35306 , improper recursion detection.
...
Bug: 35306
Change-Id: I28f7a298ebf701f9709cb3f49eff07da4cf01fd4
Reviewed-on: https://dart-review.googlesource.com/c/90880
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-01-29 21:28:49 +00:00
6f5556c88a
Prepare to publish analyzer version 0.35.0.
...
Change-Id: Icd0cd786a2b7746046367ca4315748d33381c590
Reviewed-on: https://dart-review.googlesource.com/c/91580
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-01-29 20:27:37 +00:00
011a1239fc
Support for out-of-band worker in AnalysisDriverScheduler.
...
It will be used to perform work of searching for available declarations
and sending corresponding completion libraris notifications.
R=brianwilkerson@google.com
Change-Id: I21b23c4fadf1dc679c16ff00a47149d62707ae51
Reviewed-on: https://dart-review.googlesource.com/c/91581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-29 20:09:47 +00:00
09e6a689c2
parse nested control flow collection entries
...
Change-Id: Id50c0a53a51f076dd75dd5bc13a694663449bc83
Reviewed-on: https://dart-review.googlesource.com/c/91400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
213cfdc85e
Update AstBuilder to generate new for statement structure
...
... if control flow or spread collection entries are enabled.
Change-Id: I8718c1f7a649b7a2a7c9e376a6bf67c1df0542cf
Reviewed-on: https://dart-review.googlesource.com/c/91320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
93a56336a3
Parse simple for control flow collection entires
...
... and address comments in:
https://dart-review.googlesource.com/c/sdk/+/91144
https://dart-review.googlesource.com/c/sdk/+/90901
Change-Id: I7a9288bf28e069832193bd8a196a11f9a407b20d
Reviewed-on: https://dart-review.googlesource.com/c/91300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
d73d3183a2
Fix dead_code hint
...
Change-Id: I30eb074b5346f7c53997e585eda31b374445d807
Reviewed-on: https://dart-review.googlesource.com/c/91500
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 14:58:54 +00:00
f5fd281150
Prevent unsound promoted bounds from being used as arguments
...
Fixes https://github.com/dart-lang/sdk/issues/35100
Change-Id: I65f73f40d0ea970f0631599e01b177412fc32a40
Reviewed-on: https://dart-review.googlesource.com/c/90390
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 14:46:04 +00:00
cf56801308
Garbage-collect compiled libraries
...
If - for instance - a file (say 'main.dart') tries to include a part
(say 'lib.dart') that is not part of that file (i.e. doesn't state
something like 'part of "main.dart"'), and the file ('lib.dart') is not
otherwise used, before this change, the library ('lib.dart') would be
included in the first comile, but on subsequent re-compiles wouldn't
include it because it's not referenced, nor ever cleaned up
(and would thus be re-compiled.)
This change garbage-collects the library as it's not referenced.
Change-Id: I8fa90b3ae6fc3d99af9fec780abe62855e653ddb
Reviewed-on: https://dart-review.googlesource.com/c/90385
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-01-29 14:25:44 +00:00
8fc9eaf06c
Support to run co19_2 on ddk
...
Change-Id: I93b9752655385d0e26cdf97d0f8224a88c198657
Reviewed-on: https://dart-review.googlesource.com/c/90781
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2019-01-29 13:50:02 +00:00
812a6af41a
Anonymous mixin applications are abstract
...
Change-Id: Ib36a0bd243010a5b51bf49bda750d7e432017eae
Reviewed-on: https://dart-review.googlesource.com/c/90703
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2019-01-29 13:29:32 +00:00
977e5b31e2
Support type variables on function types and intersection types
...
Change-Id: Ic4f6f26f1e779e9fc084a06f546584f826a6e720
Reviewed-on: https://dart-review.googlesource.com/c/90382
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
f822d0abb8
Make CoreType test friendly
...
The classes Future and Stream are exported by dart:core.
By attempting to look up FutureOr in dart:core before dart:async,
we support simple a simple test scenario where there's only one
platform library.
Change-Id: I76627f89957b91fbdb52a7772c177a769c37cecb
Reviewed-on: https://dart-review.googlesource.com/c/90381
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
d025ff5367
Copy subtype tests
...
The tests are copied from pkg/kernel/test/type_subtype_test.dart
Change-Id: I1120aa7ae1928fc20982f24fab14925b9ee851c8
Reviewed-on: https://dart-review.googlesource.com/c/90229
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 13:29:32 +00:00
219a2fcf66
Revisit existing constants in the constants transformer.
...
Unevaluated constants are re-evaluated, and evaluated constants are
re-canonicalized.
Change-Id: I241f6b5d734797101ab1168746a849713c104695
Reviewed-on: https://dart-review.googlesource.com/c/91230
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-01-29 10:36:12 +00:00
97cb74cf63
Tweak the subtype rule for Null
...
Change-Id: I3c1f1af40f5930a02355f8d986a27db606998096
Reviewed-on: https://dart-review.googlesource.com/c/90980
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-01-29 10:04:21 +00:00
5fbf15d9c4
Mixins have no static members
...
Change-Id: I93b43ad2d58ab2804ed7deafeadb6346eade9eab
Reviewed-on: https://dart-review.googlesource.com/c/91481
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2019-01-29 09:54:52 +00:00
c5a954794b
Fix PackageBuildWorkspacePackage's contains
...
This implementation did not check whether the path was actually contained
in the package:build workspace. It also made an assumption about how a
resource which is a directory would be treated, which was masked by an
unconditional-and-silenced catch.
The existing test which should have caught this had a hidden exception,
caught by the same unconditional-and-silenced catch. :(
Bug: https://github.com/dart-lang/linter/issues/1393
Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030
Reviewed-on: https://dart-review.googlesource.com/c/91441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-29 02:01:51 +00:00
d84851daf8
[vm/bytecode] Capture receiver if creating a closure
...
When creating a closure, receiver is loaded in order to obtain
instantiator type arguments. That access was not capturing
receiver, if a closure was created inside another closure.
Change-Id: I9ec6d9f2c90643e6deb9c4efde1b070a3255a387
Reviewed-on: https://dart-review.googlesource.com/c/91442
Commit-Queue: Régis Crelier <regis@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2019-01-28 23:41:01 +00:00
1ba59eb13d
Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.
...
As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
and making these two restored problems to warnings.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6266632ade84743b5725c54475fe402902576c00
Reviewed-on: https://dart-review.googlesource.com/c/91420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 22:08:17 +00:00
95b017a888
Implement changeFile() and recompute available libraries and declarations.
...
Some renames in tests.
R=brianwilkerson@google.com
Change-Id: Ia54752c816bbc62f99a200d62658b6f4dfb26480
Reviewed-on: https://dart-review.googlesource.com/c/91381
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-28 18:05:17 +00:00
ec5ba8a252
Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."
...
This reverts commit 6699384dddhttps://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout
Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 17:09:24 +00:00
7daa9f65fc
Start supporting resolution of the code-as-ui constructs
...
Change-Id: I8fba9bfcac2339b113de6bc2954821585e7b8ab4
Reviewed-on: https://dart-review.googlesource.com/c/91240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 15:12:47 +00:00
69af7af70d
Additional tests for interpolation and CONVERT_TO_MULTILINE_STRING.
...
For discussion in https://dart-review.googlesource.com/c/sdk/+/91262
R=brianwilkerson@google.com
Change-Id: Ib25a5da32ade4d4bccef8856867761e153a6d5dc
Reviewed-on: https://dart-review.googlesource.com/c/91263
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 15:08:06 +00:00
5cf4e543b8
Handle mis-included parts differently
...
If, for instance, including something that is not a part of the file
you include it from, previously we would copy things over anyway, and
other libraries wouldn't be able to use it
(for instance including it would fail).
Now, instead, we don't include it, structurally pretending the "part of"
line wasn't there (that is, we don't copy things over and other libraries
are free to include it).
As before, an error is given, but errors doesn't 'cascade' into other
libraries that (before this change) couldn't use the included file.
Change-Id: Ica6225c437ea7dd66f9e8955e638f442b2df8f97
Reviewed-on: https://dart-review.googlesource.com/c/90380
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-01-28 14:20:45 +00:00
f066c05319
Rename klass getter on InstanceConstant to classNode
...
This achieves consistency with similar getters in the API.
This is technically a breaking change, since it changes a published
part of the Kernel API. Since the constants API is relatively new and
so far only used internally in the AOT compiler, the change is
expected to be unproblematic.
Closes https://github.com/dart-lang/sdk/issues/35696
Change-Id: I3ca30922580d226ccbdb6f77496983c21ef2102b
Reviewed-on: https://dart-review.googlesource.com/c/90220
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-01-28 13:31:05 +00:00
42be4083bd
Reproduction of dartbug.com/35715
...
Get an error saying something like
"The argument type 'dart.core::String' can't be assigned to
the parameter type 'dart.core::String'"
Change-Id: I327c613a2070495653e4089475a4f3edf550e9d4
Reviewed-on: https://dart-review.googlesource.com/c/91228
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-01-28 12:15:41 +00:00
e169134203
[Fasta] Fix a typo in a class name
...
Change-Id: Ia2bc80d7a9ba3dc7716f8052e367c7711646a839
Reviewed-on: https://dart-review.googlesource.com/c/91145
Auto-Submit: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-01-28 11:53:41 +00:00
591df5263f
Fix typo in omitPlatform documentation
...
Change-Id: Id490a6b051b0ef74cae709157d4ae537495e9583
Reviewed-on: https://dart-review.googlesource.com/c/90680
Auto-Submit: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-01-28 08:21:36 +00:00
d927333c52
Add all SDK libraries, and context files belonging to the package / potions of it.
...
R=brianwilkerson@google.com
Change-Id: I7e5d6cc12657c92f16d65e89f4b60eacf16c51b6
Reviewed-on: https://dart-review.googlesource.com/c/91260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-27 22:33:04 +00:00
f92b816268
Add 'Convert to multiline string' quick assist.
...
R=brianwilkerson@google.com
Change-Id: Ieaa893e6ceb64ba41d84189267e0087d042fe4e6
Reviewed-on: https://dart-review.googlesource.com/c/91262
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-27 21:38:30 +00:00
6699384ddd
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-26 20:12:55 +00:00
ece54f3c43
[dart2js] Don't inline direct recursion
...
This avoids a bug in handling ir.Let bindings.
Change-Id: I0ccd932248a550a5017dfe565209e8ef62299ff3
Reviewed-on: https://dart-review.googlesource.com/c/91241
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2019-01-26 01:32:10 +00:00
d0f92e8cc5
Remove StrongTypeSystemImpl.
...
It was deprecated in analyzer version 0.34.0, and clients are no
longer using it.
Change-Id: Ib27e9173eb57bcbec700071bd69acbcfaf96e913
Reviewed-on: https://dart-review.googlesource.com/c/91112
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 23:31:44 +00:00
2f3ebf70f6
Update definite assignment for the code-as-ui changes
...
Change-Id: Id425fd6eb76402118738da13275224ae2d1905aa
Reviewed-on: https://dart-review.googlesource.com/c/91168
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 22:28:05 +00:00
fe285e3e60
Update flow analysis for the code-as-ui changes
...
Change-Id: I2bf9ea0beda6bc95556d0e1e75183779433f990f
Reviewed-on: https://dart-review.googlesource.com/c/91169
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 22:27:54 +00:00
c7f6c86128
Fix registration of (un)provided parameters.
...
Change-Id: I5cf1b7543561a728a219a62c8fa6633d4d25846a
Reviewed-on: https://dart-review.googlesource.com/c/91223
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-01-25 21:20:42 +00:00
6fae43b8af
Check exact type for set literals (issue 35742)
...
Change-Id: Icce758b13536171dd20201e52ecae8ecda39a336
Reviewed-on: https://dart-review.googlesource.com/c/91166
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-25 21:09:42 +00:00
eadf9679f3
Fix #35750 by passing a real ContextBuilder to createWorkspace.
...
The PackageBuildWorkspace depends on its ContextBuilder to know if a
[findFile] should return null.
Bug: https://github.com/dart-lang/sdk/issues/35750
Change-Id: Ic562314fa87d1333e8f07efbb06a461be769ea32
Reviewed-on: https://dart-review.googlesource.com/c/91161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-25 21:07:03 +00:00
983b77dda7
Remove unused argument allowNullableDereference
...
Change-Id: I921344bbfe137c376b5b2314a5c82bb2c2bde128
Reviewed-on: https://dart-review.googlesource.com/c/91111
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2019-01-25 19:05:22 +00:00
f8fef94243
Authomatically add dependencies from pubspec.yaml files.
...
In addition to (path, modification) also cache on the content hash.
Implement getLibraries().
R=brianwilkerson@google.com
Change-Id: I263b5479f867aa28d5e43bc0c1bb02702ab6c915
Reviewed-on: https://dart-review.googlesource.com/c/91160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 19:03:51 +00:00
874f9d0bdf
Refactor for statement parsing
...
This CL introduces 2 new parser listener events
in preparation for parsing for control flow structures
in literal lists, sets, and maps.
Change-Id: I230f36cded714a13e4badb401fe5b5906c93a2da
Reviewed-on: https://dart-review.googlesource.com/c/91144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-01-25 18:15:00 +00:00
bb4a880777
Report duplicate set entries with a different error
...
It will take some time until the CFE will take on reporting this error (and
duplicate keys in maps).
For now: detect whether a map is used as the implementation of a set literal,
and if so report the error differently.
Change-Id: I9f657189c79a4532023f615aa91bf63602f27664
Reviewed-on: https://dart-review.googlesource.com/c/91102
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-01-25 17:12:43 +00:00
4f9af4cd03
Add evaluation support for code-as-ui features
...
Change-Id: I604d03218df8af0f405017367b906f944e877762
Reviewed-on: https://dart-review.googlesource.com/c/91110
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 14:20:04 +00:00
0a41a2d292
[ Test ] Remove support for flutter runtime from the test framework
...
Support for the flutter runtime (sky_shell) was added to the Dart
test framework in the hope that one could run the flutter engine
through the Dart test suite. We never got around to running these
tests on the build bots, the sky_shell executable has been deprecated
and there are plans in the flutter engine team to have their own
unit test frame work.
See Issue https://github.com/flutter/flutter/issues/9115 for more
details.
Change-Id: I6ee9e8c919721dccecf4202ab0778939aeb79174
Reviewed-on: https://dart-review.googlesource.com/c/91103
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2019-01-25 04:16:43 +00:00
a851d4c370
[dart/tools] Option to limit column widths in code size tool
...
Rationale:
Ensures that copy-paste into gerrit yields readable code.
https://github.com/dart-lang/sdk/issues/35323
Change-Id: I3df2ed7712216bd67ed092ff62524785ac47ca52
Reviewed-on: https://dart-review.googlesource.com/c/90862
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-01-25 02:28:53 +00:00
56123f08b0
Update parser to support simple if/else control flow in literal lists, sets, and maps
...
Change-Id: I740beea833ed1ad76582ad5232549bd204981808
Reviewed-on: https://dart-review.googlesource.com/c/90901
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-24 22:22:50 +00:00
31dc729452
Fix #35305 , promoting a type that should not be promoted.
...
Bug: 35305
Change-Id: If62e875feed1bed73ec189fa011183fd3e5b4a1b
Reviewed-on: https://dart-review.googlesource.com/c/90881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-01-24 19:10:06 +00:00
Konstantin Shcheglov