dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25510 Commits

Author SHA1 Message Date
Konstantin Shcheglov 1c0422735e Abstract type operations in flow analysis. 
R=paulberry@google.com

Change-Id: I2dad238e7a49317951bd011095645341cf3b2bb4
Reviewed-on: https://dart-review.googlesource.com/c/92026
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-06 15:37:48 +00:00
Paul Berry efcf8b01b1 Move integration tests of migration API to analysis server. 
Change-Id: I7109df482f17be884a31313e18e1b4cf57b1ad4c
Reviewed-on: https://dart-review.googlesource.com/c/92140
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-06 15:37:18 +00:00
Paul Berry 4fb220707e Hardcode SourceFileEdit.fileStamp to -1 in migration prototype. 
SourceFileEdit.fileStamp isn't used anymore, so there's no reason to
have extra plumbing to set it.

Change-Id: I1d1c8e9e74f74d19fd306d44e477573de5a66cd7
Reviewed-on: https://dart-review.googlesource.com/c/92061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-02-06 13:10:48 +00:00
Kevin Millikin 2b8560f4b2 [Fasta] Add spread and control-flow collection flags 
Also stop skipping the corresponding tests.  Add status file entries
for Fasta and VM configurations.

Change-Id: Iecc1e048915df598ba69ac79261cfc836d38f95a
Reviewed-on: https://dart-review.googlesource.com/c/92045
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-06 10:30:18 +00:00
Konstantin Shcheglov 631c550ff9 Extract and migrate ExitDetector and its tests. 
R=brianwilkerson@google.com

Change-Id: I4d3699ffab56d85240809fe50b36c1593e4e19d2
Reviewed-on: https://dart-review.googlesource.com/c/92027
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-06 01:54:55 +00:00
Konstantin Shcheglov c26bf54391 Add InheritanceManager2 APIs to access inherited interface/class maps. 
I'm not particularly attached to the names of new methods.
So, if you have better ideas, please tell me.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/35833
Change-Id: Ibe906c7f779c7606ca3093fd27203fc7c77392b0
Reviewed-on: https://dart-review.googlesource.com/c/91847
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 22:15:05 +00:00
Konstantin Shcheglov 0a2de9238b Extract importLibraryElement() implementation, make it less pessimistic. 
R=brianwilkerson@google.com

Change-Id: I916d4b761c8a9886dc701206c03cfd88c9f047ef
Reviewed-on: https://dart-review.googlesource.com/c/92021
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 21:05:45 +00:00
danrubel ae72248770 Encapsulate dartfix name/description of each fix 
Change-Id: I851607e45c3f97dd47d6611ba20fd493d047aed8
Reviewed-on: https://dart-review.googlesource.com/c/92023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-05 20:43:45 +00:00
Brian Wilkerson ceb7b89df1 Remove a fix that has now been replaced by an assist 
Change-Id: Ifa6ca5b97474ae770c81241e569f6763cdc32a29
Reviewed-on: https://dart-review.googlesource.com/c/92060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 20:37:05 +00:00
Alexander Markov 336969538c [vm/bytecode] Revise representation of types, constants and calls in bytecode 
* Type arguments are moved to global object table (and de-duplicated).
* Finalize non-recursive generic types at bytecode generation time.
* Constants are moved to global object table (and de-duplicated).
* ICData creation is avoided for direct calls.
* Interface calls reference target member instead of selector name.

Size of a dilp files: 17868K => 15896K (-11%).

Change-Id: I0c9bf338137a0fae6ed90ab6b125ed2b24a1a8ad
Reviewed-on: https://dart-review.googlesource.com/c/91108
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-02-05 20:13:45 +00:00
Konstantin Shcheglov b5eb7d463e Extract and migrate ErrorReporter tests. 
R=brianwilkerson@google.com

Change-Id: I5fd12bdd3dc6bacbec61ad9b722a0016cbde2229
Reviewed-on: https://dart-review.googlesource.com/c/92024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-05 19:16:15 +00:00
danrubel db9e3f21c9 remove InconsistentAnalysisException guard code from dartfix 
This updates the dartfix tests to align with how the dartfix API
is implemented and is being used, and removes the now unnecessary
InconsistentAnalysisException guard code.

Change-Id: Id7230ecec4940097fd0f2d3c034f47262ddc94b5
Reviewed-on: https://dart-review.googlesource.com/c/91962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-05 19:01:55 +00:00
Konstantin Shcheglov d236dca9d9 Add 'offset' to 'getSuggestionDetails'. 
We need it to know if names in the syntactic scope will shadow
the requested name if unprefixed import is used.

R=brianwilkerson@google.com

Change-Id: I1fd28add9241b27795160c4705a80e0f8aa6c647
Reviewed-on: https://dart-review.googlesource.com/c/92022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-05 16:49:55 +00:00
Paul Berry 3395550962 Provisional nullability migration API in analysis_server. 
Limitations at this point:

- Only one file can be migrated at a time.  If you try to migrate more
  than one file, you will get an assertion failure.

- The ResolvedUnitResult passed to prepareInput must contain precisely
  the same unit (in terms of `identical`) as the ResoledUnitResult
  passed to processInput.  Otherwise you will get an assertion
  failure.

- There is not yet any way to query diagnostic information about the
  migration (e.g. heuristic decisions that were made).

- Only a very small number of constructs can be successfully migrated
  at this point.

- The implementation is not sensibly organized at this point.  Most of
  it is in the analyzer, and then wrapped in the analysis_server.
  Really it all should go in the analysis_server.

I'll be working to rectify these limitations over the next few days,
which will probably involve a lot of rework under the hood.  But
hopefully the API in provisional_api.dart should remain stable, so
that DartFix code can start being written against it.

Change-Id: Idc3ebab380448a812d5e83338789570e33c55af7
Reviewed-on: https://dart-review.googlesource.com/c/92020
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
 2019-02-05 16:30:35 +00:00
Brian Wilkerson 102f3074d5 Enhance assist to convert invocation of LinkedHashMap to a map literal 
Change-Id: I31c0533ab545734386a5ec8759d7a20abb3b53a0
Reviewed-on: https://dart-review.googlesource.com/c/91980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 15:19:35 +00:00
Mike Fairhurst 3c1ffd23ba remove unneeded override 
Change-Id: Ic930f17a44471b724aaa0389278a899877f6ef69
Reviewed-on: https://dart-review.googlesource.com/c/91963
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-02-05 13:15:15 +00:00
Peter von der Ahé 8d5b5bba41 Allow for non-function types in alias builders. 
Change-Id: I735ee2df97a21a5cef38d18bdb35f83117749be6
Reviewed-on: https://dart-review.googlesource.com/c/92042
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-02-05 10:05:32 +00:00
Peter von der Ahé 824598b17d Rename files related to type aliases 
Change-Id: I5e8ff98efad790c1ebf15dc48b4d92a1b7777338
Reviewed-on: https://dart-review.googlesource.com/c/91825
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-05 10:05:32 +00:00
Peter von der Ahé d7d195283a Add missing type arguments 
Change-Id: I7020eabfe9724d8132820485adbb666ba0e53ba6
Reviewed-on: https://dart-review.googlesource.com/c/92041
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-05 10:05:32 +00:00
Peter von der Ahé 6efbd07145 Rename FunctionTypeAliasBuilder to TypeAliasBuilder 
Change-Id: I33d8ee4e6d78433a3d7219faed0c19eb11d0fb8a
Reviewed-on: https://dart-review.googlesource.com/c/91822
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-05 10:05:32 +00:00
Peter von der Ahé f45d103d67 Finish implementing IsTypeParameterSubtypeOf 
Change-Id: I5e37f87946423b4c1373fb49b2ef482172ce2c87
Reviewed-on: https://dart-review.googlesource.com/c/91821
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-05 10:05:32 +00:00
Peter von der Ahé 52bd3d9159 Complain about use of deprecated members 
Change-Id: I76a66cb143027bed83fe6df3c5f19c8a7879a4ca
Reviewed-on: https://dart-review.googlesource.com/c/91926
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-05 09:09:04 +00:00
Kevin Millikin 0828d2c786 [Fasta] Implement exact types for Set literals 
Set literals have an exact type of Set<T> for some T.  An implicit
downcast to a subtype is a static error.

Change-Id: I922b078b1b9e595243520e73c7130c23fe91f454
Reviewed-on: https://dart-review.googlesource.com/c/91640
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-05 07:43:52 +00:00
Jenny Messerly c6556dc1a3 [package:js] draft proposal to improve JS interop, see #35084 
Change-Id: I77a01469113cdfe6c9c3533cfb398ab97d5cd3b0
Reviewed-on: https://dart-review.googlesource.com/c/89404
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-02-05 01:44:32 +00:00
pq 798123ddb7 add lint associations 
Change-Id: I1ceb6b45f07feff8b5f9d34c071e4a3c7d7c7f4a
Reviewed-on: https://dart-review.googlesource.com/c/91941
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-05 00:41:12 +00:00
Paul Berry 1f638607c2 Rework the ConstraintVariable.or constructor. 
The constructor now records constraints to make sure that the newly
created constraint variable is consistent with the variables that it
is formed from.

Change-Id: I928ff41aaab1b849905b7c8d622049fdd73cdd3e
Reviewed-on: https://dart-review.googlesource.com/c/91948
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-05 00:24:32 +00:00
Brian Wilkerson 35ab1755f4 Support more type propagation for code-as-ui features 
Change-Id: I9f7d93387653cc279dc657e689764d19a6d31858
Reviewed-on: https://dart-review.googlesource.com/c/91766
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 21:55:21 +00:00
Kevin Moore b53dceadaa Update pubspec for dev_compiler and sourcemap_testing 
Useful for tracking pkg usage across the SDK

Change-Id: I16fe0e62922afd76270b03e9423632cd900d4c61
Reviewed-on: https://dart-review.googlesource.com/c/91844
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2019-02-04 20:34:59 +00:00
Konstantin Shcheglov eefc18dc82 Add a hook to AnalysisDriver on the current session to be discarded. 
R=brianwilkerson@google.com, danrubel@google.com

Change-Id: Ie2a84c22d74fd1ba51f5add15fb881fb8b7e6c96
Reviewed-on: https://dart-review.googlesource.com/c/91947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 20:21:19 +00:00
Paul Berry cda43dabda Use findNode.simple in migration test 
Change-Id: Ia61bb5a255f18086c3f42ed68c83910fb7ed4698
Reviewed-on: https://dart-review.googlesource.com/c/91946
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 19:57:19 +00:00
Konstantin Shcheglov 3e5ed47777 Implement 'completion.getSuggestionDetails'. 
R=brianwilkerson@google.com

Change-Id: I7b1fafe7ee2c6442fab0f7a83b3fa4315488e95a
Reviewed-on: https://dart-review.googlesource.com/c/91900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-02-04 18:03:00 +00:00
Paul Berry 38aadd71df Rework DecoratedType substitution. 
Rather than have a special class for substitutions, we simply use a
map from TypeParameterElement to substituted DecoratedType, and we
move the substitution logic into DecoratedType.

This paves the way for a future rework of DecoratedType.

Change-Id: I21145777e5e04a7e24c0c3ff34fdc20fbe8b8feb
Reviewed-on: https://dart-review.googlesource.com/c/91940
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-04 14:59:55 +00:00
pq 087c6e3eb7 Add associatedErrorCodes API to AssistKind 
Background: https://github.com/dart-lang/linter/issues/1375.

Provisional API.  Open for discussion!



Change-Id: I2a1608d748dc0f807b953bd2bc94b24e276c8286
Reviewed-on: https://dart-review.googlesource.com/c/91857
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-02-04 13:54:50 +00:00
Aske Simon Christensen 8a45b5eb57 Move environment handling into the front-end constant evaluator. 
Change-Id: Id01bad9d9dbb7d5f6104a0f633d8303fecfa29db
Reviewed-on: https://dart-review.googlesource.com/c/91227
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-02-04 13:31:30 +00:00
Johnni Winther e4b809f0e6 Add unit testing of (some) invoke dynamic specializers 
Change-Id: I7c3b100da899050a7eb234d53a70d235b3186675
Reviewed-on: https://dart-review.googlesource.com/c/91829
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-04 10:24:03 +00:00
Johnni Winther 0fd1679620 Sort named parameters in native methods by declaration. 
Change-Id: Ic4a7f9ad6cf0d362b6582a59c783cc05cc404a31
Reviewed-on: https://dart-review.googlesource.com/c/91828
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-04 10:02:23 +00:00
Konstantin Shcheglov 8c891ec25e Include type parameters into suggested code completions. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/120659839
Change-Id: I51ec6142b97b079c4db55ef1f2081354ee16dda5
Reviewed-on: https://dart-review.googlesource.com/c/91858
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 05:37:37 +00:00
Konstantin Shcheglov 2efd22271e Use included suggestions only when free standing identifiers are allowed. 
R=brianwilkerson@google.com

Change-Id: I0f401a79e7bcae92646aae13f639c9e57c7852e5
Reviewed-on: https://dart-review.googlesource.com/c/91856
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-04 00:52:47 +00:00
pq 0d075031fa allow custom analysis options in lint driving 
Support for enabling experiments in linter tests.

See: https://github.com/dart-lang/linter/issues/1412


Change-Id: I1f33d8089f1f628a05fef402dc441c73d9309ba2
Reviewed-on: https://dart-review.googlesource.com/c/91854
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-02-03 19:59:07 +00:00
Konstantin Shcheglov f89acfa374 Issue 35621. Part files should use their own transitive signatures. 
Previously we had a bug, when a library linked summary was computed,
and then a part of this library is incorrectly imported as a library,
the implementation of `transitiveSignature` was returning the
signature of the containing library, so we would use the linked library
of the actual library, but the unlinked summary of the part file.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/35621
Change-Id: If225136de4e6576f0499d2318a67c721d80d17ae
Reviewed-on: https://dart-review.googlesource.com/c/91855
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-03 19:05:26 +00:00
Konstantin Shcheglov 133d83eede Protect against override completion outside workspace. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/123774694
Change-Id: I9f5aa93a86c0d1a0c496cd77853314a23a1aedbe
Reviewed-on: https://dart-review.googlesource.com/c/91853
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-03 17:27:16 +00:00
Konstantin Shcheglov 849285276d Extract and migrate ElementLocator tests. 
R=brianwilkerson@google.com

Change-Id: I10914580c96daee9bae8794db477c6413a089c09
Reviewed-on: https://dart-review.googlesource.com/c/91850
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-03 17:26:46 +00:00
Paul Berry d45a6ec893 Split Variables class into two interface classes and create DecoratedType.forElement constructor. 
The two interface classes make it clearer which methods are intended
to be used by ConstraintGatherer vs. ConstraintVariableGatherer, and
refactoring DecoratedType.forElement paves the way for a future CL
that will handle constraints on inferred types.

Change-Id: Ibd2f22ea9d38df7be1c4da0e4eef2006556b7351
Reviewed-on: https://dart-review.googlesource.com/c/91851
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-03 02:35:16 +00:00
Paul Berry b9c89c9fb5 More test cases for the migration prototype. 
Change-Id: If6cd64ae89ebb76a98160dc60d981c7db7ae82a6
Reviewed-on: https://dart-review.googlesource.com/c/91852
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-03 02:31:56 +00:00
Paul Berry a6e7361fa8 Add documentation comments to the migration prototype. 
Change-Id: Ifad776cadfe9a2abc485c6ab251cdee08671d9ef
Reviewed-on: https://dart-review.googlesource.com/c/91848
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-02 23:21:16 +00:00
Paul Berry 67ff7a6ef3 Remove unused import 
Change-Id: Ib75766f76a6b6f57b9490d03fac0006da718f68f
Reviewed-on: https://dart-review.googlesource.com/c/91849
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-02 23:10:55 +00:00
Brian Wilkerson 53ba159aa4 Add assists to convert to list, map and set literals 
Change-Id: If8909859ea9c8752ecf0ea05b89f4a27d373fb39
Reviewed-on: https://dart-review.googlesource.com/c/91846
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-02 22:00:55 +00:00
Paul Berry a9c84ab887 Verify nullability of dynamic in DecoratedType constructor. 
This required some clean-up of how the `always` constraint is handled.

Change-Id: I9c1124bf0d41b58b771eb46ee74a52659e0b5b52
Reviewed-on: https://dart-review.googlesource.com/c/91843
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
 2019-02-02 21:54:56 +00:00
Paul Berry eaeffd2695 Rename ConstraintsTest to match the class it's testing 
Change-Id: I5a9e3d4b098d53efd65201899d1bd6a07be05332
Reviewed-on: https://dart-review.googlesource.com/c/91845
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-02-02 20:36:06 +00:00
Brian Wilkerson af303a277c Add some assists for the code-as-ui features 
Change-Id: Ie01b1875fb35eab1427b2869f9c009a06c048412
Reviewed-on: https://dart-review.googlesource.com/c/91841
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-02-02 17:37:55 +00:00