dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Dan Rubel d2bde00d9d Cleanup skipFormalParameters and remove unused methods 
* Simplify skipFormalParameters
* Replace call to reportUnrecoverableErrorWithToken
* Remove unused import and last uses of expect method
* Improve statement depth overflow recovery

Change-Id: Ibb51e636cea8ebd2c633b68cf2b3706cdbf273f5
Reviewed-on: https://dart-review.googlesource.com/62420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-27 19:26:55 +00:00
Konstantin Shcheglov 56cb7bac02 Fix for applying resolution to static field annotations. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I040f5401a80f77c61df0a52258a83109e4e9ea1a
Reviewed-on: https://dart-review.googlesource.com/62664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-27 19:21:14 +00:00
Paul Berry b9dbe3a0be Fix analyzer/FE integration for is! expressions. 
Change-Id: I2d2e3ccee5f0e5f8c6c3f270cd3a89ea4ada1641
Reviewed-on: https://dart-review.googlesource.com/62662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-27 19:04:34 +00:00
Konstantin Shcheglov 88a88b03dc Fix token used for large negative integers. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I4625f76bb071888392510c1c5c85f1314832ffa3
Reviewed-on: https://dart-review.googlesource.com/62480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-27 14:21:29 +00:00
Dmitry Stefantsov cf2966ea0d [fasta] Generate noSuchMethod forwarders for abstract accessors 
Fixes #32722

Bug: http://dartbug.com/32722
Change-Id: I5a2b29c766a82e06949028dccb69680c685e1ba4
Reviewed-on: https://dart-review.googlesource.com/62151
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-06-27 13:38:07 +00:00
Kevin Millikin df2529d443 Detect when a class has a member that conflicts with a static one 
In Dart 2 classes are not allowed to have an instance method, getter,
or setter that conflicts with a static method, getter, or setter
declared in the class.  Detect this at the start of top-level type
inference when we build an explicit interface for every class.

Change-Id: I39c1887a07fde0c40367d8f243a37f06dfbba353
Reviewed-on: https://dart-review.googlesource.com/60581
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-27 09:30:58 +00:00
Konstantin Shcheglov cad8d4a741 Store instance creation information at arguments offset. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6fcdcd40e8322a0f950cd039bb151ee620e389ec
Reviewed-on: https://dart-review.googlesource.com/62440
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-26 22:33:08 +00:00
Dan Rubel 966541bec9 Improve literal function recovery 
This fixes a crash when parsing literal functions
and improves recovery.

Change-Id: I22e7793d08e772bd186e1fb8fd01e09fa72ea13e
Reviewed-on: https://dart-review.googlesource.com/62380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-26 19:25:42 +00:00
Dan Rubel 386efb1e6a Improve type parameter recovery 
This fixes another crash in the fasta parser
and improves the way it recovers when parsing type parameters
before a map or list literal.

Change-Id: Ic02513b98a31e9ed3f59c8391c260a2a214983ae
Reviewed-on: https://dart-review.googlesource.com/62340
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-26 19:24:28 +00:00
Dmitry Stefantsov 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 
Change-Id: I06ee11f873a00d119b07a4cf7aca50257a315000
Reviewed-on: https://dart-review.googlesource.com/61562
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-06-26 09:23:04 +00:00
Jens Johansen 8e4d5c0a38 Update formated error for nonexisting constructor 
Before:
```
wrong-offset.dart:4:15: Error: Method not found: 'C.wrongOffset'.
  var x = new C.wrongOffset();
              ^^^^^^^^^^^
```

Now:
```
wrong-offset.dart:4:17: Error: Method not found: 'C.wrongOffset'.
  var x = new C.wrongOffset();
                ^^^^^^^^^^^
```

Testcase added.

Closes #33452.

Change-Id: I9910c9e510bbe32562df67ec0fb46060ab674e6c
Reviewed-on: https://dart-review.googlesource.com/62062
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-06-26 08:06:05 +00:00
Paul Berry b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 
Change-Id: I0b860415dbdf3f8fb2e3f21891259f0a6bb322f9
Reviewed-on: https://dart-review.googlesource.com/62124
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-25 20:16:54 +00:00
Mike Fairhurst ca99917fb6 Remove code awaiting void results to unblock #33145 
It's possible that the code relies upon this async gap. However, I
imagine it isn't, and that the await was merely added in these places
because it looks like it would be an asynchronous operation. In any
case, it was not waiting on anything before, and so any reliance upon
any async gaps here would be strange.

Change-Id: I49c3be4dcaaa18361ef60c7f9e31999db3fc090b
Reviewed-on: https://dart-review.googlesource.com/60704
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-25 19:18:44 +00:00
Dan Rubel 19f60bfb52 Improve fasta parser expression recovery 
This improves the parser's ability to distinguish between an expression
and the start of a new statement.

Change-Id: I07871dc0e2e6f81996bfc99a53bd3dede3db21ae
Reviewed-on: https://dart-review.googlesource.com/62180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-25 19:06:26 +00:00
Brian Wilkerson d632980ee0 Add tokens to more judgements 
Change-Id: I9a27702e48b7f4f7600b929834644b233194982c
Reviewed-on: https://dart-review.googlesource.com/62127
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-25 18:57:58 +00:00
Paul Berry 97c81d668a Remove variableSet factory methods. 
It turns out they aren't needed--the required functionality is already
provided by the variableAssign method.

Fixes #33557.

Change-Id: Ieb3cfc237a6d7d6ae61f0afcd9e9bb9ead1c8fbb
Reviewed-on: https://dart-review.googlesource.com/62125
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-25 17:59:49 +00:00
Dan Rubel 98efc7917f Improve parse assert statement recovery 
This fixes a crash when parsing assert statements
and improves recovery when missing a closing ')'.

Change-Id: I1495dad40208918fb93a65234f3fe7e94b2c6aae
Reviewed-on: https://dart-review.googlesource.com/62160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-25 17:53:59 +00:00
Konstantin Shcheglov a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. 
Change-Id: I33d20438a9dd09e41f8db27c37b541a0efc78bd0
Reviewed-on: https://dart-review.googlesource.com/62040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-25 17:42:04 +00:00
Paul Berry de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 
Change-Id: I917a68a7f91820749bb3842304f8ae875182a25b
Reviewed-on: https://dart-review.googlesource.com/62123
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-25 17:21:04 +00:00
Paul Berry 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 
Change-Id: I54982617e02b8ee3004927ded7638c98f1f4d66e
Reviewed-on: https://dart-review.googlesource.com/62122
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-25 16:57:14 +00:00
Brian Wilkerson 1a0fc733d3 Add tokens to more judgements 
Change-Id: I39fca828e117de726907af2eacb2e42e57f33491
Reviewed-on: https://dart-review.googlesource.com/62121
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-25 16:56:24 +00:00
Dan Rubel 81191186d8 Remove unused class 
Change-Id: I5ef6354952f2cc7672aa0527cc8f1dbb28734b46
Reviewed-on: https://dart-review.googlesource.com/62100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-25 16:15:46 +00:00
Martin Kustermann 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 
Closes https://github.com/dart-lang/sdk/issues/33604

Change-Id: I84034499de43ea300b278f2f922bc73c565e8bcc
Reviewed-on: https://dart-review.googlesource.com/61934
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-06-25 12:05:53 +00:00
Kevin Millikin 2f474a55c1 Change infer to return the expression instead of its type 
ExpressionJudgment.infer is the method that will compile from type
inference judgments to abstract syntax.  Change it to have this API.
It currently returns null from all implementations.

Change-Id: Id3bdac43a2783c4fda0aeeeff2963d0ccee4dd20
Reviewed-on: https://dart-review.googlesource.com/61935
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-06-25 11:04:15 +00:00
Jens Johansen f85fbde727 Expression compilation fix 
Previously, when loading from a dill file and not invalidating anything
compilation expression would fail.
This CL introduces a forced invalidation of the entrypoint when loading
for the first time, just as is done when requesting a full component.

Closes #33087.

Bug: 33087
Change-Id: I0d9b84393f3b046a0359e3a94bb1bcb8ab650308
Reviewed-on: https://dart-review.googlesource.com/61920
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-06-25 08:59:49 +00:00
Brian Wilkerson 8b10b1fda9 Add tokens to judgements, part 2 
Change-Id: I2442124d702f1d7728f5d63af041b073cfaa437e
Reviewed-on: https://dart-review.googlesource.com/61985
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-23 15:26:49 +00:00
Paul Berry 8c1591af9e Add a binder mechanism to the Factory API for handling labels. 
Some work needs to be done on both sides to hook up to the API:

- On the front end side, the individual labels need to be plumbed
  through the body builder to the judgment objects (currently the body
  builder discards individual label information).  Follow-up work for
  this will be tracked in
  https://github.com/dart-lang/sdk/issues/33591.

- On the analyzer side, the label information needs to be stored by
  ResolutionStorer and retrieved by ResolutionApplier (currently the
  ResolutionApplier has its own scope resolution mechanism; we don't
  want to keep this because it duplicates resolution logic in the
  front end).  Follw-up work for this will be tracked in
  https://github.com/dart-lang/sdk/issues/33592.

Change-Id: I75afc2be16a277581b0e2ea49b6998e72054a40d
Reviewed-on: https://dart-review.googlesource.com/62000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-23 01:56:39 +00:00
Konstantin Shcheglov ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 
Change-Id: I377edeb65f1b3b650fc7f356f07fd249a2dbdbca
Reviewed-on: https://dart-review.googlesource.com/61984
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-23 00:02:08 +00:00
Konstantin Shcheglov 223b143167 Workaround for issue 33559. 
Not a fix, just a kludge until VM is fixed.
https://github.com/dart-lang/sdk/issues/33559

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I4952f4fddd6ebbd46f8dfa53ea18a8bff269b0f0
Reviewed-on: https://dart-review.googlesource.com/61987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 23:24:07 +00:00
Konstantin Shcheglov c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. 
We don't need changes to NamedFunctionExpressionJudgment, because it is
a wrapper around FunctionExpressionJudgment.

Change-Id: Ia94fb3201c7a960a64af2fdeaa8d8307ba6d82c3
Reviewed-on: https://dart-review.googlesource.com/61980
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 21:25:15 +00:00
Konstantin Shcheglov 1416ed283a Convert ShadowNot to NotJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I280b65bf668bcef07c304bccd92433492e074777
Reviewed-on: https://dart-review.googlesource.com/61964
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-22 20:33:10 +00:00
Konstantin Shcheglov a1a2d90a6c Convert ShadowForStatement to ForJudgment. 
Change-Id: I95e70234be97c4d246ac93caf64958bee1cfbe83
Reviewed-on: https://dart-review.googlesource.com/61911
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-22 20:33:00 +00:00
danrubel fea8cb1473 Revise order of type variable declaration events 
As of this CL, events for type variable declarations occur
in the following order:

* beginTypeVariables
* beginTypeVariable for each type variable in the declaration
* handleTypeVariablesDefined
* endTypeVariable for eah type variable in the declaration
* endTypeVariables

Revising the order of events facilitate removing the hack
in BodyBuilder.beginTypeVariables in a future CL.

This is another slice of https://dart-review.googlesource.com/c/sdk/+/57661
so that it can be landed in a more incremental fashion.

Change-Id: Ief0ad766c12f1ca9d53a8ec8d3c08b41166b2897
Reviewed-on: https://dart-review.googlesource.com/61940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-22 19:47:46 +00:00
Paul Berry 6339976567 Rename lemma to binder 
Change-Id: I90e09158ef4bc6df13684d69543ea32a6cb05255
Reviewed-on: https://dart-review.googlesource.com/61960
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 19:44:20 +00:00
Brian Wilkerson 9d499fffe4 Start adding tokens to judgements 
Change-Id: I938d101aef91f42e85c6263809d0ab617d299521
Reviewed-on: https://dart-review.googlesource.com/61961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-22 19:38:55 +00:00
Konstantin Shcheglov ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 
Change-Id: Ib1edf20c22b448314cc2b1028559d3466ecfe4f8
Reviewed-on: https://dart-review.googlesource.com/61916
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 19:36:17 +00:00
Paul Berry 9b814bdf34 Use the lemma approach for NamedFunctionExpression 
Change-Id: Ib234bd876e9a060d035e90dfc665e3822b3a592b
Reviewed-on: https://dart-review.googlesource.com/61901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 18:17:57 +00:00
Paul Berry 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. 
Addresses comment from https://dart-review.googlesource.com/c/sdk/+/61780.

Change-Id: I1e697030f44184b33cf67263118791592a3c3ba1
Reviewed-on: https://dart-review.googlesource.com/61900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 18:16:08 +00:00
Brian Wilkerson c8a488c1ca Add parameters to Forest method to support labeled statements 
Change-Id: I6b45ba7155b10c7f6f12a203324f0cdc3ccb89f7
Reviewed-on: https://dart-review.googlesource.com/61761
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 15:51:30 +00:00
Brian Wilkerson 3af363cba0 Rename typeContext to inferredType 
Change-Id: Ifde7803944a23f2682a77a5ba5c9a9dfb5ca5978
Reviewed-on: https://dart-review.googlesource.com/61906
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-22 15:43:27 +00:00
Dmitry Stefantsov 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 
Change-Id: Iead84138ca0a74ae15911e6d0978d52c08f40816
Reviewed-on: https://dart-review.googlesource.com/61540
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-22 14:13:25 +00:00
Dmitry Stefantsov 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 
Fixes #33208, #31810, #32416, #32417

Bug: http://dartbug.com/33208
Bug: http://dartbug.com/31810
Bug: http://dartbug.com/32416
Bug: http://dartbug.com/32417
Change-Id: Id178daf35be459fdefe04091bf929b5743d89e81
Reviewed-on: https://dart-review.googlesource.com/41264
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-22 13:41:55 +00:00
Paul Berry 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment 
Change-Id: I411e29c6b3f1d1d88942cfb6775d4b88908bb6a5
Reviewed-on: https://dart-review.googlesource.com/61820
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 13:36:45 +00:00
Paul Berry f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 
Change-Id: Ibc821fc6ec982b4871bb9688f5261d5e901658bb
Reviewed-on: https://dart-review.googlesource.com/61801
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-22 13:10:15 +00:00
Jens Johansen 6888bc2824 Compile time error for web int literals that cannot be represented exactly 
Bug: #33351
Change-Id: I2b99858dfc276dc70c3a36c289030e801145af86
Reviewed-on: https://dart-review.googlesource.com/61180
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-06-22 10:47:54 +00:00
Paul Berry 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 
Change-Id: I8ab44875fb46308dbc71c44b965f9f21aa5e05bc
Reviewed-on: https://dart-review.googlesource.com/61821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 03:14:48 +00:00
Paul Berry 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 
Change-Id: I00955f0c7e2feaff429571b30c68c13cb80782b2
Reviewed-on: https://dart-review.googlesource.com/61823
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 03:07:04 +00:00
Paul Berry 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 
Change-Id: Id61c657b9eaf0e390e9f75c5ab711323a5212bbb
Reviewed-on: https://dart-review.googlesource.com/61825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 03:06:46 +00:00
Paul Berry 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment 
Change-Id: Ibdcacedc163e186a67d9bf3c766417f8cddd16dd
Reviewed-on: https://dart-review.googlesource.com/61781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 00:04:18 +00:00
Paul Berry d0655066a5 Use the lemma approach for other variable declaring constructs. 
This extends the groundwork laid by
1b681a75c3 to the local variables
declared by catch clauses and for-in statements, as well as the
synthetic local variable that Fasta uses to represent a local
function.

Change-Id: I7f6bf9dfb8ad0e06c3332d47287bb7dc7e620a5a
Reviewed-on: https://dart-review.googlesource.com/61780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-22 00:01:53 +00:00